From unknown Mon Aug 18 17:54:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73359: 30.0.91; editorconfig does not work on xml files Resent-From: =?UTF-8?Q?Nguy=E1=BB=85n_?= =?UTF-8?Q?Qu=E1=BB=91c?= Minh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2024 14:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 73359@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17267561189422 (code B ref -1); Thu, 19 Sep 2024 14:29:03 +0000 Received: (at submit) by debbugs.gnu.org; 19 Sep 2024 14:28:38 +0000 Received: from localhost ([127.0.0.1]:33204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srI97-0002Ro-9d for submit@debbugs.gnu.org; Thu, 19 Sep 2024 10:28:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:50726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srBcK-0004XV-Vc for submit@debbugs.gnu.org; Thu, 19 Sep 2024 03:30:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srBc3-0007Jt-Hm for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 03:30:03 -0400 Received: from mail-vs1-xe30.google.com ([2607:f8b0:4864:20::e30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srBc1-00011F-La for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 03:30:03 -0400 Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-49bd45cfe38so178738137.1 for ; Thu, 19 Sep 2024 00:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726731000; x=1727335800; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=m+jlSvxpv7E2Mcz/Uve0cG8Y7eLWGXwd4reOWzRy6WQ=; b=SehzTiIcDfRuEwu4NQq8lLFIYetBg5typLWVR1Q3sbC4xnGwb8qoF5aWYbnBqhtQm+ iVElmMB/Q0XHHSpCsjAYn6KhLh+W2QGpn9QMkj5f5OswEtsqpp3a/zekeurWH3bLGhx2 oVsJgtW/zovj9eT/u+Md9GRST5E57bNR/ME0xgI8zze9WO51hmBNRzhuAUXl0lsEc6i0 L0aul3XOTEYOAhdVmHMeJ52VEYAYQMNH7zOlYz/fnVVRLnmjpo+qBD1T+zBY35uWA3lJ rnMV5r35cLzXhMF9Jp5v+KeBlaiUpOyPCNOF7Xo6wsG9taU+v/iqFLG4pj4KHq9WeV3Z QbXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726731000; x=1727335800; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=m+jlSvxpv7E2Mcz/Uve0cG8Y7eLWGXwd4reOWzRy6WQ=; b=U2uM+DnkRSggHZzLtWEB4h62JxzW4600VikvZ50xdCs4+HnJ+ijSC14EbXjVkHxjQW O8qjFM4Z8HT2gFnV6dZ1qmu0rBuiMsVRHqHGoWuB1Be8SerS7ODudatjf2paPvAd63wE 0udwjsYMNG5BgcTul3zHW8kCjQxDeYiu8+xHkuGSeOD4ifuuO/bUZotXmGL5jmBJZFdw WoJYHweZ4kudcVdyL0ZdB+H+RL0SxwfPOiWOCkDtAYA6amoydh5MbC5DIf+D79zoGYF2 qlxVaGAitoOyaKTUh0uk02pY62K0N8lrByjK+uFR+6tee6vwV1XjGczV1NkeUPOlPcK0 mioQ== X-Gm-Message-State: AOJu0Yzs0x4+g8M8wMkkSGoi+5S+lnbQ3j/eL8Md78LwebaivXscp2t8 W4+jvh5jK5iSJL4t+AY9ZSPrECiOZksheilLwFDj/xvx3iezPosfPfNgRAxHM6wugGk/8PBRvqa i8NqA9lDDqVOv3MjP7M8LB3iirAs5RauE X-Google-Smtp-Source: AGHT+IFp+yzSg22U34IkX+jloQZ6WKIW8KhMV5+58/dRZ/vTfDfJA5NVz5L+oGufacDu6KeEep7y6o5lIdd5vbA95e0= X-Received: by 2002:a05:6102:6c8:b0:497:5e68:887b with SMTP id ada2fe7eead31-49d415151a5mr18885091137.16.1726730999831; Thu, 19 Sep 2024 00:29:59 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Nguy=E1=BB=85n_?= =?UTF-8?Q?Qu=E1=BB=91c?= Minh Date: Thu, 19 Sep 2024 14:29:48 +0700 Message-ID: Content-Type: multipart/alternative; boundary="000000000000de261c062273e354" Received-SPF: pass client-ip=2607:f8b0:4864:20::e30; envelope-from=nqminhuit@gmail.com; helo=mail-vs1-xe30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Thu, 19 Sep 2024 10:28:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000de261c062273e354 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I have encountered an issue when opening an xml file from emacs 30, here is how to reproduce: 1. start emacs with 'emacs -Q -mm' 2. enable editorconfig-mode with 'M-x editorconfig-mode' 3. open an xml file, e.g., pom.xml from a Java project. 4. observe the minibuffer: For information about GNU Emacs and the GNU system, type C-h C-a. funcall-interactively: Text is read-only [10 times] Quit Editorconfig mode enabled Quit pom.xml has auto save data; consider M-x recover-this-file Using vacuous schema Unsupported element in =E2=80=98editorconfig-indentation-alist=E2=80=99: ((nxml-attribute-indent . 2) . 2) Directory-local variables error: (wrong-type-argument listp Unsupported element in =E2=80=98editorconfig-indentation-alist=E2=80=99: ((nxml-attribu= te-indent . 2) . 2)) My '.editorconfig' content: root =3D true [*] charset =3D utf-8 end_of_line =3D lf insert_final_newline =3D true trim_trailing_whitespace =3D true indent_style =3D space indent_size =3D 2 [*.{java,proto}] indent_size =3D 4 Best regards, minh --000000000000de261c062273e354 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I have encountered an issue when opening an xml fil= e from emacs 30, here is how to reproduce:
1. start emacs with 'emac= s -Q -mm'
2. enable editorconfig-mode with 'M-x editorconfig-mod= e'
3. open an xml file, e.g., pom.xml from a Java project.
4. obs= erve the minibuffer:

For information about GNU Emacs and the GNU sys= tem, type C-h C-a.
funcall-interactively: Text is read-only [10 times]Quit
Editorconfig mode enabled
Quit
pom.xml has auto save data; = consider M-x recover-this-file
Using vacuous schema
Unsupported eleme= nt in =E2=80=98editorconfig-indentation-alist=E2=80=99: ((nxml-attribute-in= dent . 2) . 2)
Directory-local variables error: (wrong-type-argument lis= tp Unsupported element in =E2=80=98editorconfig-indentation-alist=E2=80=99:= ((nxml-attribute-indent . 2) . 2))


My '.editorconfig' c= ontent:

root =3D true
[*]
charset =3D utf-8
end_of_line =3D lf=
insert_final_newline =3D true
trim_trailing_whitespace =3D true
i= ndent_style =3D space
indent_size =3D 2
[*.{java,proto}]
indent_si= ze =3D 4

Best regards,
minh
--000000000000de261c062273e354-- From unknown Mon Aug 18 17:54:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73359: 30.0.91; editorconfig does not work on xml files Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2024 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Nguy=E1=BB=85n_?= =?UTF-8?Q?Qu=E1=BB=91c?= Minh , Stefan Monnier Cc: 73359@debbugs.gnu.org Received: via spool by 73359-submit@debbugs.gnu.org id=B73359.172676225531990 (code B ref 73359); Thu, 19 Sep 2024 16:11:02 +0000 Received: (at 73359) by debbugs.gnu.org; 19 Sep 2024 16:10:55 +0000 Received: from localhost ([127.0.0.1]:33346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srJk6-0008Ju-I3 for submit@debbugs.gnu.org; Thu, 19 Sep 2024 12:10:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srJk4-0008Jf-Q3 for 73359@debbugs.gnu.org; Thu, 19 Sep 2024 12:10:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srJjh-0006Zo-3A; Thu, 19 Sep 2024 12:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xALsx9+LYFtL6pz77vHL7G2ixovVEQzAvDDwuZmn+3s=; b=XWMAkM1rtX/TJHxTiPR0 5DcqzvE+KyzvWlspO7GOjmIw3mLee1/7O5uRwVHABWdtnahoyLrtfplpwsqa9zp+0/BUQjfDcsnc9 eS/PneOTzfXirTtwYd9hD8KXzNVgPKxrCI8oc0Q4+psgonIRUONyNhftzM2munwGx6vTyyfNcRKO0 XJzqzXt1wvEJZYpqkSisaLRjSLj5sx1qi5MH9ncmvkSTomf8Yns6xKPQ9iircKjPynDRyBOFWmrJB 9OwtPxPOsKLqPLxm1GPcS5oe9XyWM+ydd7qzdKkMwiLJzQgx/PMqw8n6LlFQCv2Vy/dE7eAtIXZjE 0flKZfjv2GKrOg==; Date: Thu, 19 Sep 2024 19:10:25 +0300 Message-Id: <86msk38w0e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (nqminhuit@gmail.com) References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nguyễn Quốc Minh > > Date: Thu, 19 Sep 2024 14:29:48 +0700 > > 1. start emacs with 'emacs -Q -mm' > 2. enable editorconfig-mode with 'M-x editorconfig-mode' > 3. open an xml file, e.g., pom.xml from a Java project. > 4. observe the minibuffer: > > For information about GNU Emacs and the GNU system, type C-h C-a. > funcall-interactively: Text is read-only [10 times] > Quit > Editorconfig mode enabled > Quit > pom.xml has auto save data; consider M-x recover-this-file > Using vacuous schema > Unsupported element in ‘editorconfig-indentation-alist’: ((nxml-attribute-indent . 2) . 2) > Directory-local variables error: (wrong-type-argument listp Unsupported element in > ‘editorconfig-indentation-alist’: ((nxml-attribute-indent . 2) . 2)) Stefan, this element of editorconfig-indentation-alist: (nxml-mode nxml-child-indent (nxml-attribute-indent . 2)) seems to violate the expected form of the elements, which is (MODE . SETTING). It was added as part of commit 8e143a2f300, whose log says "Sync with upstream", so I suppose this form of the element is supported by upstream, but not by Emacs? I guess we need to replace it with a function or something? Btw, can we clarify the doc string of editorconfig-indentation-alist, where it says "where SETTING should obey the same rules as `editorconfig-indent-size-vars'"? Because if one looks at the doc string of editorconfig-indent-size-vars, the "rules" are either trivial or unclear. If SETTING above should be one or more symbols ("list of variables that need to be set to SIZE") or a function that returns a list of (VAR . VAL) pairs, then why not say that in the doc string of editorconfig-indentation-alist? From unknown Mon Aug 18 17:54:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73359: 30.0.91; editorconfig does not work on xml files Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2024 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 73359@debbugs.gnu.org, =?UTF-8?Q?Nguy=E1=BB=85n_?= =?UTF-8?Q?Qu=E1=BB=91c?= Minh Received: via spool by 73359-submit@debbugs.gnu.org id=B73359.172685876421573 (code B ref 73359); Fri, 20 Sep 2024 19:00:02 +0000 Received: (at 73359) by debbugs.gnu.org; 20 Sep 2024 18:59:24 +0000 Received: from localhost ([127.0.0.1]:36351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sriqh-0005bs-UN for submit@debbugs.gnu.org; Fri, 20 Sep 2024 14:59:24 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sriqg-0005be-4T for 73359@debbugs.gnu.org; Fri, 20 Sep 2024 14:59:22 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 72DF1441B28; Fri, 20 Sep 2024 14:58:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1726858735; bh=kFZ4SLzUc5H+XYBLtnuQyfnYAJdCunxCnP3nbdd0fwY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EROc3leAsUcj6odZCCazzwf8Fog3gffolyIIkqXKizakREHzNqHp6bAFJR/0Y7Hqg RbXVKfBtxEVpTJWjt4DB0GkICrljyzpabmWPWBs69NLetq4ww9akjzxWbeAffgAR/A tSL6T8bJMSIpkQRCqzOLKAilO7WpgbRYuYkeOIUtpGwZACn+H0s/Tjm7Hk8JLKfVdn WAGyqtzWwXd7Zdeshv88GWy66hrDLwpdSpVd/W1RZ6Yw5jIiiTQzVLV7cvNlkTcb5o bnMF9Jvwy9FCp5lrbd0wnzhaOA3X1e6glShykCpY0KJmXZwI+VzwUdioQ3nxxN5bx2 Snfb2JPpjsZEQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A3217441A8D; Fri, 20 Sep 2024 14:58:55 -0400 (EDT) Received: from asado (modemcable031.210-178-173.mc.videotron.ca [173.178.210.31]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7A47E12018B; Fri, 20 Sep 2024 14:58:55 -0400 (EDT) From: Stefan Monnier In-Reply-To: <86msk38w0e.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Sep 2024 19:10:25 +0300") Message-ID: References: <86msk38w0e.fsf@gnu.org> Date: Fri, 20 Sep 2024 14:58:54 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.125 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan, this element of editorconfig-indentation-alist: > > (nxml-mode nxml-child-indent (nxml-attribute-indent . 2)) > > seems to violate the expected form of the elements, which is > (MODE . SETTING). It was added as part of commit 8e143a2f300, whose > log says "Sync with upstream", so I suppose this form of the element > is supported by upstream, but not by Emacs? I guess we need to > replace it with a function or something? Yup. I pushed the patch below to `emacs-30` for it. > Btw, can we clarify the doc string of editorconfig-indentation-alist, > where it says "where SETTING should obey the same rules as > `editorconfig-indent-size-vars'"? Because if one looks at the doc > string of editorconfig-indent-size-vars, the "rules" are either > trivial or unclear. If SETTING above should be one or more symbols > ("list of variables that need to be set to SIZE") or a function that > returns a list of (VAR . VAL) pairs, then why not say that in the doc > string of editorconfig-indentation-alist? I didn't want to do it because it's redundant with the docstring of `editorconfig-indent-size-vars`, but see the patch where I tried to address your request. Stefan diff --git a/lisp/editorconfig.el b/lisp/editorconfig.el index 931781007d9..870f6d32162 100644 --- a/lisp/editorconfig.el +++ b/lisp/editorconfig.el @@ -211,7 +211,7 @@ editorconfig-indentation-alist (mustache-mode mustache-basic-offset) (nasm-mode nasm-basic-offset) (nginx-mode nginx-indent-level) - (nxml-mode nxml-child-indent (nxml-attribute-indent . 2)) + (nxml-mode . editorconfig--get-indentation-nxml-mode) (objc-mode c-basic-offset) (octave-mode octave-block-offset) (perl-mode perl-indent-level) @@ -266,7 +266,9 @@ editorconfig-indentation-alist `editorconfig-indent-size-vars'. Each element should look like (MODE . SETTING) where SETTING -should obey the same rules as `editorconfig-indent-size-vars'." +should obey the same rules as `editorconfig-indent-size-vars', +i.e. either a list of variable names or a function returning a list of (VAR . VAL) +settings." :type '(alist :key-type symbol :value-type (choice function (repeat @@ -341,6 +343,11 @@ editorconfig--get-indentation-latex-mode (LaTeX-indent-level . ,size) (LaTeX-item-indent . ,(- size)))) +(defun editorconfig--get-indentation-nxml-mode (size) + "Vars to set `nxml-mode' indent size to SIZE." + `((nxml-child-indent . ,size) + (nxml-attribute-indent . ,(* 2 size)))) + (defun editorconfig--get-indentation-lisp-mode (size) "Set indent size to SIZE for Lisp mode(s)." (when (cond ((null editorconfig-lisp-use-default-indent) t) From unknown Mon Aug 18 17:54:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Nguy=E1=BB=85n_?= =?UTF-8?Q?Qu=E1=BB=91c?= Minh Subject: bug#73359: closed (Re: bug#73359: 30.0.91; editorconfig does not work on xml files) Message-ID: References: <8634lt47km.fsf@gnu.org> X-Gnu-PR-Message: they-closed 73359 X-Gnu-PR-Package: emacs Reply-To: 73359@debbugs.gnu.org Date: Sat, 21 Sep 2024 10:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1726915022-25405-1" This is a multi-part message in MIME format... ------------=_1726915022-25405-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #73359: 30.0.91; editorconfig does not work on xml files which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 73359@debbugs.gnu.org. --=20 73359: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73359 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1726915022-25405-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 73359-done) by debbugs.gnu.org; 21 Sep 2024 10:36:57 +0000 Received: from localhost ([127.0.0.1]:37402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srxU0-0006bU-M6 for submit@debbugs.gnu.org; Sat, 21 Sep 2024 06:36:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srxTy-0006bF-6j for 73359-done@debbugs.gnu.org; Sat, 21 Sep 2024 06:36:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srxTY-0006BL-BK; Sat, 21 Sep 2024 06:36:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9pL0ruxr3uEMN6NGxwrsWCfnlKMvBwHNVO+hXx24crc=; b=jQugAuos16952MurAUoM HUkAdVomK67kKAsQ/XTvCZ0q+JvbvOTU0tPyiarMkHP1b/mLeej5vOATe+uh/G42lRv/H67GBqt7W qCXGaJB2ggp6rFvAR7ua5e/TMgvvWgvmKjI320fTO8Jlai6OGvXMihJiN+pemM2sGuqEDmOmM5mfb 257CmGfDiyE/AuIu7xz7GlDGZlsGj67mC1KamgGRqQkmva7QMeeHclUWoOVteXsi4ZX2LxklyT1A0 3wc+5QbGE9EVrfvN3XmmbOafjZfA8woZ1Ud6pKdvvG9Lv+8Ok+e0w5FVqHgYUGlPyP0TEPVrcqsGm KMLLNtuL0IefVQ==; Date: Sat, 21 Sep 2024 13:36:25 +0300 Message-Id: <8634lt47km.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Fri, 20 Sep 2024 14:58:54 -0400) Subject: Re: bug#73359: 30.0.91; editorconfig does not work on xml files References: <86msk38w0e.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73359-done Cc: 73359-done@debbugs.gnu.org, nqminhuit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Nguyễn Quốc Minh , > 73359@debbugs.gnu.org > Date: Fri, 20 Sep 2024 14:58:54 -0400 > > > Stefan, this element of editorconfig-indentation-alist: > > > > (nxml-mode nxml-child-indent (nxml-attribute-indent . 2)) > > > > seems to violate the expected form of the elements, which is > > (MODE . SETTING). It was added as part of commit 8e143a2f300, whose > > log says "Sync with upstream", so I suppose this form of the element > > is supported by upstream, but not by Emacs? I guess we need to > > replace it with a function or something? > > Yup. I pushed the patch below to `emacs-30` for it. Thanks, I'm therefore closing this bug. > > Btw, can we clarify the doc string of editorconfig-indentation-alist, > > where it says "where SETTING should obey the same rules as > > `editorconfig-indent-size-vars'"? Because if one looks at the doc > > string of editorconfig-indent-size-vars, the "rules" are either > > trivial or unclear. If SETTING above should be one or more symbols > > ("list of variables that need to be set to SIZE") or a function that > > returns a list of (VAR . VAL) pairs, then why not say that in the doc > > string of editorconfig-indentation-alist? > > I didn't want to do it because it's redundant with the docstring of > `editorconfig-indent-size-vars`, but see the patch where I tried to > address your request. Thanks. ------------=_1726915022-25405-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Sep 2024 14:28:38 +0000 Received: from localhost ([127.0.0.1]:33204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srI97-0002Ro-9d for submit@debbugs.gnu.org; Thu, 19 Sep 2024 10:28:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:50726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srBcK-0004XV-Vc for submit@debbugs.gnu.org; Thu, 19 Sep 2024 03:30:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srBc3-0007Jt-Hm for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 03:30:03 -0400 Received: from mail-vs1-xe30.google.com ([2607:f8b0:4864:20::e30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srBc1-00011F-La for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 03:30:03 -0400 Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-49bd45cfe38so178738137.1 for ; Thu, 19 Sep 2024 00:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726731000; x=1727335800; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=m+jlSvxpv7E2Mcz/Uve0cG8Y7eLWGXwd4reOWzRy6WQ=; b=SehzTiIcDfRuEwu4NQq8lLFIYetBg5typLWVR1Q3sbC4xnGwb8qoF5aWYbnBqhtQm+ iVElmMB/Q0XHHSpCsjAYn6KhLh+W2QGpn9QMkj5f5OswEtsqpp3a/zekeurWH3bLGhx2 oVsJgtW/zovj9eT/u+Md9GRST5E57bNR/ME0xgI8zze9WO51hmBNRzhuAUXl0lsEc6i0 L0aul3XOTEYOAhdVmHMeJ52VEYAYQMNH7zOlYz/fnVVRLnmjpo+qBD1T+zBY35uWA3lJ rnMV5r35cLzXhMF9Jp5v+KeBlaiUpOyPCNOF7Xo6wsG9taU+v/iqFLG4pj4KHq9WeV3Z QbXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726731000; x=1727335800; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=m+jlSvxpv7E2Mcz/Uve0cG8Y7eLWGXwd4reOWzRy6WQ=; b=U2uM+DnkRSggHZzLtWEB4h62JxzW4600VikvZ50xdCs4+HnJ+ijSC14EbXjVkHxjQW O8qjFM4Z8HT2gFnV6dZ1qmu0rBuiMsVRHqHGoWuB1Be8SerS7ODudatjf2paPvAd63wE 0udwjsYMNG5BgcTul3zHW8kCjQxDeYiu8+xHkuGSeOD4ifuuO/bUZotXmGL5jmBJZFdw WoJYHweZ4kudcVdyL0ZdB+H+RL0SxwfPOiWOCkDtAYA6amoydh5MbC5DIf+D79zoGYF2 qlxVaGAitoOyaKTUh0uk02pY62K0N8lrByjK+uFR+6tee6vwV1XjGczV1NkeUPOlPcK0 mioQ== X-Gm-Message-State: AOJu0Yzs0x4+g8M8wMkkSGoi+5S+lnbQ3j/eL8Md78LwebaivXscp2t8 W4+jvh5jK5iSJL4t+AY9ZSPrECiOZksheilLwFDj/xvx3iezPosfPfNgRAxHM6wugGk/8PBRvqa i8NqA9lDDqVOv3MjP7M8LB3iirAs5RauE X-Google-Smtp-Source: AGHT+IFp+yzSg22U34IkX+jloQZ6WKIW8KhMV5+58/dRZ/vTfDfJA5NVz5L+oGufacDu6KeEep7y6o5lIdd5vbA95e0= X-Received: by 2002:a05:6102:6c8:b0:497:5e68:887b with SMTP id ada2fe7eead31-49d415151a5mr18885091137.16.1726730999831; Thu, 19 Sep 2024 00:29:59 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?B?Tmd1eeG7hW4gUXXhu5FjIE1pbmg=?= Date: Thu, 19 Sep 2024 14:29:48 +0700 Message-ID: Subject: 30.0.91; editorconfig does not work on xml files To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000de261c062273e354" Received-SPF: pass client-ip=2607:f8b0:4864:20::e30; envelope-from=nqminhuit@gmail.com; helo=mail-vs1-xe30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 19 Sep 2024 10:28:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000de261c062273e354 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I have encountered an issue when opening an xml file from emacs 30, here is how to reproduce: 1. start emacs with 'emacs -Q -mm' 2. enable editorconfig-mode with 'M-x editorconfig-mode' 3. open an xml file, e.g., pom.xml from a Java project. 4. observe the minibuffer: For information about GNU Emacs and the GNU system, type C-h C-a. funcall-interactively: Text is read-only [10 times] Quit Editorconfig mode enabled Quit pom.xml has auto save data; consider M-x recover-this-file Using vacuous schema Unsupported element in =E2=80=98editorconfig-indentation-alist=E2=80=99: ((nxml-attribute-indent . 2) . 2) Directory-local variables error: (wrong-type-argument listp Unsupported element in =E2=80=98editorconfig-indentation-alist=E2=80=99: ((nxml-attribu= te-indent . 2) . 2)) My '.editorconfig' content: root =3D true [*] charset =3D utf-8 end_of_line =3D lf insert_final_newline =3D true trim_trailing_whitespace =3D true indent_style =3D space indent_size =3D 2 [*.{java,proto}] indent_size =3D 4 Best regards, minh --000000000000de261c062273e354 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I have encountered an issue when opening an xml fil= e from emacs 30, here is how to reproduce:
1. start emacs with 'emac= s -Q -mm'
2. enable editorconfig-mode with 'M-x editorconfig-mod= e'
3. open an xml file, e.g., pom.xml from a Java project.
4. obs= erve the minibuffer:

For information about GNU Emacs and the GNU sys= tem, type C-h C-a.
funcall-interactively: Text is read-only [10 times]Quit
Editorconfig mode enabled
Quit
pom.xml has auto save data; = consider M-x recover-this-file
Using vacuous schema
Unsupported eleme= nt in =E2=80=98editorconfig-indentation-alist=E2=80=99: ((nxml-attribute-in= dent . 2) . 2)
Directory-local variables error: (wrong-type-argument lis= tp Unsupported element in =E2=80=98editorconfig-indentation-alist=E2=80=99:= ((nxml-attribute-indent . 2) . 2))


My '.editorconfig' c= ontent:

root =3D true
[*]
charset =3D utf-8
end_of_line =3D lf=
insert_final_newline =3D true
trim_trailing_whitespace =3D true
i= ndent_style =3D space
indent_size =3D 2
[*.{java,proto}]
indent_si= ze =3D 4

Best regards,
minh
--000000000000de261c062273e354-- ------------=_1726915022-25405-1--