GNU bug report logs - #73357
[PATCH] Make vc-clone interactive

Previous Next

Full log

Message #8 received at 73357 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Aleksandr Vityazev <avityazev <at> disroot.org>
Cc: 73357 <at> debbugs.gnu.org
Subject: Re: bug#73357: [PATCH] Make vc-clone interactive
Date: Thu, 19 Sep 2024 16:36:12 +0300

> Date: Thu, 19 Sep 2024 16:18:16 +0300
> From:  Aleksandr Vityazev via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Cloning is used quite often, so I would like to have an interactive
> command. A patch is attached to the email. WDYT?

Thanks, but making this function a command will take more than just
adding the interactive form.  I think we need at least:

  . mention that in interactive usage the command prompts for the
    argument (why do we have to prompt for REV, btw?)
  . announce the change in NEWS
  . maybe update the user manual
  . maybe make the command fall back to 'checkout' method if 'clone'
    is not supported

> +    (when (file-directory-p directory)
> +      (if (called-interactively-p 'interactive)
> +          (find-file directory)
> +        directory))))

This changes the value returned by the function from what it did
before, no?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.