GNU bug report logs - #73357
[PATCH] Make vc-clone interactive

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Aleksandr Vityazev <avityazev <at> disroot.org>
Subject: bug#73357: closed (Re: bug#73357: [PATCH] Make vc-clone interactive)
Date: Thu, 24 Oct 2024 13:47:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#73357: [PATCH] Make vc-clone interactive

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73357 <at> debbugs.gnu.org.

-- 
73357: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73357
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Aleksandr Vityazev <avityazev <at> disroot.org>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Philip Kaludercic <philipk <at> posteo.net>,
 Eli Zaretskii <eliz <at> gnu.org>, 73357-done <at> debbugs.gnu.org
Subject: Re: bug#73357: [PATCH] Make vc-clone interactive
Date: Thu, 24 Oct 2024 21:45:42 +0800

Hello,

On Thu 24 Oct 2024 at 03:31pm +03, Aleksandr Vityazev wrote:

> I don't have a strong opinion on this. I originally proposed this:
>
> (when (file-directory-p directory)
>   (if (called-interactively-p 'interactive)
>       (find-file directory)
>     directory))
>
> The OPEN-DIR argument was suggested by Philip, and I agreed with him,
> since the option is also good.  I'm fine with both options, I'll do as
> you say.

Sorry, I misread the code, ignore my comment here.

> V5 patches:

Installed, thanks.

I renamed vc-backend-type and vc-heuristic-alist to less generic names.

I also realised that vc-clone now can call vc-guess-url-backend even
when noninteractive, and it always returns DIRECTORY which it didn't
before, so I updated the commit message accordingly.

-- 
Sean Whitton

[Message part 3 (message/rfc822, inline)]

From: Aleksandr Vityazev <avityazev <at> disroot.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make vc-clone interactive
Date: Thu, 19 Sep 2024 16:18:16 +0300

[Message part 4 (text/plain, inline)]

Hi,

Cloning is used quite often, so I would like to have an interactive
command. A patch is attached to the email. WDYT?

[0001-Make-vc-clone-interactive.patch (text/x-patch, attachment)]

[Message part 6 (text/plain, inline)]

-- 
Best regards,
Aleksandr Vityazev

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.