GNU bug report logs - #73357
[PATCH] Make vc-clone interactive

Previous Next

Full log

Message #38 received at 73357 <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> disroot.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Philip Kaludercic <philipk <at> posteo.net>,
 Eli Zaretskii <eliz <at> gnu.org>, 73357 <at> debbugs.gnu.org
Subject: Re: bug#73357: [PATCH] Make vc-clone interactive
Date: Thu, 24 Oct 2024 15:31:59 +0300

[Message part 1 (text/plain, inline)]

On 2024-10-24 19:26, Sean Whitton wrote:

Hello,

> Hello,
>
> On Thu 24 Oct 2024 at 10:43am GMT, Philip Kaludercic wrote:
>
>> Aleksandr Vityazev <avityazev <at> disroot.org> writes:
>>
>> [...]
>>
>>>>> V4 patches:
>>>>
>>>> Thanks.
>>>>
>>>> Dmitry, any comments, or should I install this?
>>>
>>> Just a gentle ping, any news on this bug?
>>
>> FWIW as the vc-clone author, I think we can apply it, but Dmitry is the
>> VC maintainer so he should have the last word.
>
> I'm the new VC maintainer.
>
> Aleksandr, thank you for this.  Some comments on v4:
>
> - The commit message of the first patch doesn't completely follow the
>   guidelines in CONTRIBUTE.  I think M-q will fix it.

fixed
>   - I also find the ... thing hard to read because it's separated by
>     other changes.  Would you mind just writing out the changes twice?

fixed
> - vc-heuristic-alist should probaby have ':version 31.1'

fixed
> - Inserting vc-guess-backend right at the top doesn't seem right.  There
>   is already a section "Code for deducing what fileset and backend to
>   assume".
Moved to suggested section

> - I think that vc-guess-backend should be called vc-guess-url-backend or
>   similar.  'vc-guess-backend' is too generic.

Renamed to vc-guess-url-backend

> - I'm not really convinced by the OPEN-DIR argument.  You specifically
>   say that it's for scripting purposes, but then, the script can just
>   call find-file :)  Is there some reason why it's better as an
>   argument?

I don't have a strong opinion on this. I originally proposed this:

(when (file-directory-p directory)
  (if (called-interactively-p 'interactive)
      (find-file directory)
    directory))

The OPEN-DIR argument was suggested by Philip, and I agreed with him,
since the option is also good.  I'm fine with both options, I'll do as
you say.

V5 patches:

[0001-Move-package-vc-heuristic-alist-and-related-to-vc.patch (text/x-patch, attachment)]

[0002-Make-vc-clone-interactive.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, inline)]

-- 
Best regards,
Aleksandr Vityazev

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.