GNU bug report logs - #73355
29.4; eglot-rename reports success when it shouldn't

Previous Next

Package: emacs;

Reported by: Joost Kremers <joostkremers <at> fastmail.fm>

Date: Thu, 19 Sep 2024 12:02:02 UTC

Severity: normal

Merged with 73358

Found in version 29.4

Full log


Message #22 received at 73355 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Joost Kremers <joostkremers <at> fastmail.fm>
Cc: 73355 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#73355: 29.4; eglot-rename reports success when it shouldn't
Date: Sat, 21 Sep 2024 21:15:42 +0100
[Message part 1 (text/plain, inline)]
On Sat, Sep 21, 2024, 13:13 Joost Kremers <joostkremers <at> fastmail.fm> wrote:.

>
> > It's possible Eglot is just successfully applying 0 edits.
>
> I guess that's one way of looking at it. :-)
>

I'm say this because Eglot has no logic to check if a rename is valid or
not. It just does what the server tells it to. If the intended rename is
invalid, the server can error out (and Eglot will tell you this) out return
0 edits. Either way, the server calls all the shots.

João

>
[Message part 2 (text/html, inline)]

This bug report was last modified 225 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.