GNU bug report logs - #73338
[PATCH 2/2] gnu: impressive: Update to 13.2 and fix build

Previous Next

Package: guix-patches;

Reported by: Aaron Covrig <aaron.covrig.us <at> ieee.org>

Date: Wed, 18 Sep 2024 21:16:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73338 in the body.
You can then email your comments to 73338 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to lars <at> 6xq.net, marius <at> gnu.org, me <at> bonfacemunyoki.com, sharlatanus <at> gmail.com, tanguy <at> bioneland.org, jgart <at> dismail.de, guix-patches <at> gnu.org:
bug#73338; Package guix-patches. (Wed, 18 Sep 2024 21:16:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Aaron Covrig <aaron.covrig.us <at> ieee.org>:
New bug report received and forwarded. Copy sent to lars <at> 6xq.net, marius <at> gnu.org, me <at> bonfacemunyoki.com, sharlatanus <at> gmail.com, tanguy <at> bioneland.org, jgart <at> dismail.de, guix-patches <at> gnu.org. (Wed, 18 Sep 2024 21:16:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: guix-patches <at> gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Subject: [PATCH 2/2] gnu: impressive: Update to 13.2 and fix build
Date: Wed, 18 Sep 2024 17:14:51 -0400

* gnu/packages/pdf.scm (impressive): Update to 13.2
[inputs]: depends on fixed python-pypandoc from prior commit
---
 gnu/packages/pdf.scm | 59 ++++++++++++++++++++++----------------------
 1 file changed, 29 insertions(+), 30 deletions(-)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index e743d51286..8efff540df 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -28,6 +28,7 @@
 ;;; Copyright © 2024 dan <i <at> dan.games>
 ;;; Copyright © 2023 Benjamin Slade <slade <at> lambda-y.net>
 ;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
+;;; Copyright © 2024 Aaron Covrig <aaron.covrig.us <at> ieee.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1171,39 +1172,37 @@ (define-public python-reportlab
 (define-public impressive
   (package
     (name "impressive")
-    (version "0.13.1")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "mirror://sourceforge/impressive/Impressive/"
-                    version "/Impressive-" version ".tar.gz"))
-              (sha256
-               (base32
-                "0d1d2jxfl9vmy4swcdz660xd4wx91w1i3n07k522pccapwxig294"))))
+    ;; (version "0.13.1")
+    (version "0.13.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/impressive/Impressive/"
+                           version "/Impressive-" version ".tar.gz"))
+       (sha256
+        (base32
+         ;; "0d1d2jxfl9vmy4swcdz660xd4wx91w1i3n07k522pccapwxig294"))))
+         "0g15q67f992prkjndrk75hhd601iypfmkafhdx7hijs2byr26c83"))))
     (build-system python-build-system)
     (arguments
      (list
-      #:phases
-      #~(modify-phases %standard-phases
-          (delete 'build)
-          (delete 'configure)
-          (delete 'check)
-          (replace 'install
-            (lambda* (#:key inputs #:allow-other-keys)
-              ;; There's no 'setup.py' so install things manually.
-              (let* ((bin  (string-append #$output "/bin"))
-                     (impressive (string-append bin "/impressive"))
-                     (man1 (string-append #$output "/share/man/man1")))
-                (mkdir-p bin)
-                (copy-file "impressive.py" impressive)
-                (chmod impressive #o755)
-                (wrap-program (string-append bin "/impressive")
-                  `("LIBRARY_PATH" ":" prefix ;for ctypes
-                    (,(string-append #$(this-package-input "sdl")
-                                     "/lib")))
-                  `("PATH" ":" prefix   ;for pdftoppm
-                    (,(search-input-file inputs "bin/xpdf"))))
-                (install-file "impressive.1" man1)))))))
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'build)
+                   (delete 'configure)
+                   (delete 'check)
+                   (replace 'install
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       ;; There's no 'setup.py' so install things manually.
+                       (let* ((bin (string-append #$output "/bin"))
+                              (impressive (string-append bin "/impressive"))
+                              (man1 (string-append #$output "/share/man/man1")))
+                         (mkdir-p bin)
+                         (copy-file "impressive.py" impressive)
+                         (chmod impressive #o755)
+                         (wrap-program (string-append bin "/impressive")
+                           `("PATH" ":" prefix ;for pdftoppm
+                             (,(search-input-file inputs "bin/xpdf"))))
+                         (install-file "impressive.1" man1)))))))
     ;; TODO: Add dependency on pdftk.
     (inputs (list bash-minimal python-pygame python-pillow sdl xpdf))
     (home-page "https://impressive.sourceforge.net")
-- 
2.46.0
Information forwarded to guix-patches <at> gnu.org:
bug#73338; Package guix-patches. (Mon, 23 Sep 2024 23:55:02 GMT) Full text and rfc822 format available.

Message #8 received at 73338 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aarcov <at> gmail.com>
To: 73338 <at> debbugs.gnu.org
Subject: multipart patch split across issues
Date: Mon, 23 Sep 2024 18:38:21 -0400

[Message part 1 (text/plain, inline)]
Looks like I messed up the multipart submission, this patch depends on
https://issues.guix.gnu.org/73339 (python-pypandoc)

[Message part 2 (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#73338; Package guix-patches. (Thu, 24 Oct 2024 21:24:02 GMT) Full text and rfc822 format available.

Message #11 received at 73338 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 73338 <at> debbugs.gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Subject: [PATCH] gnu: impressive: Update to 13.2 and fix build
Date: Thu, 24 Oct 2024 17:21:47 -0400

* gnu/packages/pdf.scm (impressive): Update to 13.2
---
 gnu/packages/pdf.scm | 59 ++++++++++++++++++++++----------------------
 1 file changed, 29 insertions(+), 30 deletions(-)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 72aae8b002..24afadbe80 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -28,6 +28,7 @@
 ;;; Copyright © 2024 dan <i <at> dan.games>
 ;;; Copyright © 2023 Benjamin Slade <slade <at> lambda-y.net>
 ;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
+;;; Copyright © 2024 Aaron Covrig <aaron.covrig.us <at> ieee.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1171,39 +1172,37 @@ (define-public python-reportlab
 (define-public impressive
   (package
     (name "impressive")
-    (version "0.13.1")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "mirror://sourceforge/impressive/Impressive/"
-                    version "/Impressive-" version ".tar.gz"))
-              (sha256
-               (base32
-                "0d1d2jxfl9vmy4swcdz660xd4wx91w1i3n07k522pccapwxig294"))))
+    ;; (version "0.13.1")
+    (version "0.13.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/impressive/Impressive/"
+                           version "/Impressive-" version ".tar.gz"))
+       (sha256
+        (base32
+         ;; "0d1d2jxfl9vmy4swcdz660xd4wx91w1i3n07k522pccapwxig294"))))
+         "0g15q67f992prkjndrk75hhd601iypfmkafhdx7hijs2byr26c83"))))
     (build-system python-build-system)
     (arguments
      (list
-      #:phases
-      #~(modify-phases %standard-phases
-          (delete 'build)
-          (delete 'configure)
-          (delete 'check)
-          (replace 'install
-            (lambda* (#:key inputs #:allow-other-keys)
-              ;; There's no 'setup.py' so install things manually.
-              (let* ((bin  (string-append #$output "/bin"))
-                     (impressive (string-append bin "/impressive"))
-                     (man1 (string-append #$output "/share/man/man1")))
-                (mkdir-p bin)
-                (copy-file "impressive.py" impressive)
-                (chmod impressive #o755)
-                (wrap-program (string-append bin "/impressive")
-                  `("LIBRARY_PATH" ":" prefix ;for ctypes
-                    (,(string-append #$(this-package-input "sdl")
-                                     "/lib")))
-                  `("PATH" ":" prefix   ;for pdftoppm
-                    (,(search-input-file inputs "bin/xpdf"))))
-                (install-file "impressive.1" man1)))))))
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'build)
+                   (delete 'configure)
+                   (delete 'check)
+                   (replace 'install
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       ;; There's no 'setup.py' so install things manually.
+                       (let* ((bin (string-append #$output "/bin"))
+                              (impressive (string-append bin "/impressive"))
+                              (man1 (string-append #$output "/share/man/man1")))
+                         (mkdir-p bin)
+                         (copy-file "impressive.py" impressive)
+                         (chmod impressive #o755)
+                         (wrap-program (string-append bin "/impressive")
+                           `("PATH" ":" prefix ;for pdftoppm
+                             (,(search-input-file inputs "bin/xpdf"))))
+                         (install-file "impressive.1" man1)))))))
     ;; TODO: Add dependency on pdftk.
     (inputs (list bash-minimal python-pygame python-pillow sdl xpdf))
     (home-page "https://impressive.sourceforge.net")

base-commit: 2394a7f5fbf60dd6adc0a870366adb57166b6d8b
-- 
2.46.0
Information forwarded to guix-patches <at> gnu.org:
bug#73338; Package guix-patches. (Thu, 24 Oct 2024 21:31:02 GMT) Full text and rfc822 format available.

Message #14 received at 73338 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 73339 <at> debbugs.gnu.org, 73338 <at> debbugs.gnu.org
Subject: merge 73338 73339
Date: Thu, 24 Oct 2024 17:28:50 -0400

merge 73338 73339
bug closed, send any further explanations to 73338 <at> debbugs.gnu.org and Aaron Covrig <aaron.covrig.us <at> ieee.org> Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 17 Nov 2024 22:07:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 16 Dec 2024 12:24:10 GMT) Full text and rfc822 format available.
This bug report was last modified 186 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.