GNU bug report logs - #73330
31.0.50; Incorrect completions for 'cond' clauses

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73330: closed (31.0.50; Incorrect completions for 'cond' clauses)
Date: Thu, 19 Sep 2024 16:39:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 19 Sep 2024 19:38:12 +0300
with message-id <86frpv8uq3.fsf <at> gnu.org>
and subject line Re: bug#73330: 31.0.50; Incorrect completions for 'cond' clauses
has caused the debbugs.gnu.org bug report #73330,
regarding 31.0.50; Incorrect completions for 'cond' clauses
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73330: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73330
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eshel Yaron <me <at> eshelyaron.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Incorrect completions for 'cond' clauses
Date: Wed, 18 Sep 2024 14:36:18 +0200

Hi,

1. emacs -Q
2. Insert "(cond (current-p
3. Hit M-TAB to complete

We're completing a symbol in the condition of a cond clause, so it is
expected to be completed as a variable, to current-prefix-argument.
However, Emacs mistakenly thinks that we're completing a function name,
and completes to current-bidi-paragraph-direction.


Thanks,

Eshel

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 73330-done <at> debbugs.gnu.org
Subject: Re: bug#73330: 31.0.50; Incorrect completions for 'cond' clauses
Date: Thu, 19 Sep 2024 19:38:12 +0300

> From: Eshel Yaron <me <at> eshelyaron.com>
> Cc: 73330 <at> debbugs.gnu.org
> Date: Thu, 19 Sep 2024 16:33:11 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Does "helps" mean the original scenario is fixed? or are there any
> > leftovers in that scenario?
> 
> Yes, it fixed the original scenario.
> 
> >> but also seems to cause a regression.  With this change I get:
> >> 
> >> 1. emacs -Q
> >> 2. Insert "(cond ((current-p"
> >>                   ^note the additional parenthesis
> >> 3. Hit M-TAB to complete
> >> 
> >> This shows an opposite bug: Emacs should complete function names (and
> >> without the change, it does), but with the change we now get variable
> >> name completion.
> >
> > How about the patch below?
> 
> That works well in both the original scenario and the modified one.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.