GNU bug report logs - #73330
31.0.50; Incorrect completions for 'cond' clauses

Previous Next

Full log

Message #17 received at 73330 <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73330 <at> debbugs.gnu.org
Subject: Re: bug#73330: 31.0.50; Incorrect completions for 'cond' clauses
Date: Thu, 19 Sep 2024 16:33:03 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Eshel Yaron <me <at> eshelyaron.com>
>> Cc: 73330 <at> debbugs.gnu.org
>> Date: Thu, 19 Sep 2024 14:25:13 +0200
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> Date: Wed, 18 Sep 2024 14:36:18 +0200
>> >> From:  Eshel Yaron via "Bug reports for GNU Emacs,
>> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> >> 
>> >> 1. emacs -Q
>> >> 2. Insert "(cond (current-p
>> >> 3. Hit M-TAB to complete
>> >> 
>> >> We're completing a symbol in the condition of a cond clause, so it is
>> >> expected to be completed as a variable, to current-prefix-argument.
>> >> However, Emacs mistakenly thinks that we're completing a function name,
>> >> and completes to current-bidi-paragraph-direction.
>> >
>> > Thanks.  Does the patch below give good results?
>> 
>> It helps
>
> Does "helps" mean the original scenario is fixed? or are there any
> leftovers in that scenario?

Yes, it fixed the original scenario.

>> but also seems to cause a regression.  With this change I get:
>> 
>> 1. emacs -Q
>> 2. Insert "(cond ((current-p"
>>                   ^note the additional parenthesis
>> 3. Hit M-TAB to complete
>> 
>> This shows an opposite bug: Emacs should complete function names (and
>> without the change, it does), but with the change we now get variable
>> name completion.
>
> How about the patch below?

That works well in both the original scenario and the modified one.


Thank!

Eshel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.