From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: bug concatenating CLEANFILES in automake 1.11 Resent-From: Andy Wingo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Fri, 05 Nov 2010 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 7333@debbugs.gnu.org Cc: Ben Denckla X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.128895327813808 (code B ref -1); Fri, 05 Nov 2010 10:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Nov 2010 10:34:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PEJd0-0003af-Ao for submit@debbugs.gnu.org; Fri, 05 Nov 2010 06:34:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PEJcx-0003aa-8o for submit@debbugs.gnu.org; Fri, 05 Nov 2010 06:34:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PEJhI-0008GP-D1 for submit@debbugs.gnu.org; Fri, 05 Nov 2010 06:39:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:38119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PEJhI-0008GK-4K for submit@debbugs.gnu.org; Fri, 05 Nov 2010 06:39:04 -0400 Received: from [140.186.70.92] (port=50742 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PEJhG-0007sc-9e for bug-automake@gnu.org; Fri, 05 Nov 2010 06:39:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PEJhE-0008G0-L5 for bug-automake@gnu.org; Fri, 05 Nov 2010 06:39:01 -0400 Received: from smtp-1.01.com ([38.102.63.180]:44209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PEJhE-0008Fu-HI for bug-automake@gnu.org; Fri, 05 Nov 2010 06:39:00 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp-1.01.com (Postfix) with ESMTP id 89C6DE0570; Fri, 5 Nov 2010 05:38:59 -0500 (CDT) Received: from smtp-1.01.com ([127.0.0.1]) by localhost (smtp-1.01.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m1rXnnQKIcbt; Fri, 5 Nov 2010 05:38:59 -0500 (CDT) Received: from harpy.local (74.Red-80-24-4.staticIP.rima-tde.net [80.24.4.74]) by smtp-1.01.com (Postfix) with ESMTPSA id B08E5E02C6; Fri, 5 Nov 2010 05:38:58 -0500 (CDT) From: Andy Wingo Date: Fri, 05 Nov 2010 11:36:24 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Greets, We have an automake file that, after includes are processed out, looks something like this: # -*- makefile-gmake -*- CLEANFILES = BUILT_SOURCES = CLEANFILES += \ $(addprefix log/, $(addsuffix .log, $(notdir $(TESTS) _timing))) \ $(wildcard scratch/*) \ # CLEANFILES += \ $(BUILT_SOURCES) \ $(OBLONG_pcifiles) \ # CLEANFILES += \ $(man_MANS) \ $(htmlman_DATA) \ pod2htmi.tmp \ pod2htmd.tmp CLEANFILES += if HAVE_FOO GOBJECTS = $(SOURCES:%.scm=%.go) CLEANFILES += $(GOBJECTS) endif SOURCES = SOURCES += plasma.scm BUILT_SOURCES += env CLEANFILES += env In the generated Makefile, there is an extraneous backslash: CLEANFILES = $(addprefix log/, $(addsuffix .log, $(notdir $(TESTS) \ _timing))) $(wildcard scratch/*) $(BUILT_SOURCES) \ $(OBLONG_pcifiles) $(man_MANS) $(htmlman_DATA) pod2htmi.tmp \ pod2htmd.tmp\ $(am__append_3) env ^ it's here Regardless of the taste of that snippet above ;-), that snippet should be sufficient to reproduce this error, with --foreign and the following configure.ac: AC_INIT(foo, 0.1) AM_INIT_AUTOMAKE AC_CONFIG_FILES([Makefile]) AM_CONDITIONAL(HAVE_FOO, 1) AC_OUTPUT Thanks, Andy From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: bug concatenating CLEANFILES in automake 1.11 Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Fri, 05 Nov 2010 11:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: bug-automake@gnu.org Cc: Andy Wingo , Ben Denckla , 7333@debbugs.gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.128895544214708 (code B ref 7333); Fri, 05 Nov 2010 11:11:02 +0000 Received: (at 7333) by debbugs.gnu.org; 5 Nov 2010 11:10:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PEKBt-0003pB-Nv for submit@debbugs.gnu.org; Fri, 05 Nov 2010 07:10:42 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PEKBs-0003p5-Uc for 7333@debbugs.gnu.org; Fri, 05 Nov 2010 07:10:41 -0400 Received: by wwd20 with SMTP id 20so3220317wwd.15 for <7333@debbugs.gnu.org>; Fri, 05 Nov 2010 04:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :message-id; bh=H9TGMVUxSSBTRP6vhyUhoqQQ67IUHZvexy6qfQZJZyw=; b=wjvYMp9MVFiMT61bzsP0qivdlYDi/+pfW0NaYdEzNIx/sWXDBnbHEYGTnxp3jyBaBB Gh8sgG2wh7XHmsJEFXUdmLmDBaGT5/0/ukdN0ErCMbSaD15KQ8g5e6bKAGwjb3uHIVOF RADlX3g2MBJZ5InDQ3wn8CiuSTRtYCe71DsWk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; b=d4cunuTWkbTULyT93RcVfCbjmIWfzT/4qmzycUnC8fPcH2yncJDW5h3HctVcFhmr2k tfZXU1U/D5g2Elh4sAQADBK9NeIutttvLW6aRmQxHsbg4OPSLu8xBlWlBMn82wnrDsvG +N0JpLRw3ztmZIR8QpKjxj/YoQ6yae6PdRTqc= Received: by 10.227.155.15 with SMTP id q15mr1925960wbw.141.1288955709538; Fri, 05 Nov 2010 04:15:09 -0700 (PDT) Received: from bigio.localnet (host178-33-dynamic.56-82-r.retail.telecomitalia.it [82.56.33.178]) by mx.google.com with ESMTPS id h29sm945912wbc.3.2010.11.05.04.15.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 05 Nov 2010 04:15:07 -0700 (PDT) From: Stefano Lattarini Date: Fri, 5 Nov 2010 12:14:36 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_ec+0MWSk7mjph9+" Message-Id: <201011051214.38475.stefano.lattarini@gmail.com> X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --Boundary-00=_ec+0MWSk7mjph9+ Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello Andy, and thanks for the report. I can confirm the bug with latest automake (from git master), with a much-reduced minimal testcase (see attachment). I still haven't looked for an explanation or a fix, though. Regards, Stefano --Boundary-00=_ec+0MWSk7mjph9+ Content-Type: application/x-shellscript; name="foo.test" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="foo.test" #!/bin/sh # Copyright (C) 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2, or (at your option) # any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program. If not, see . # Check for bug in variable concatenation with `+=': an extra backslash # `\' is retained in the final value. . ./defs || Exit 1 set -e cat >>configure.in <<'END' AC_OUTPUT END cat > Makefile.am <<'END' FOO = \ bar FOO += FOO += baz .PHONY: test test: case '$(FOO)' in *\\*) exit 1;; *) exit 0;; esac END $ACLOCAL $AUTOMAKE grep '^ *FOO *=.*\\.' Makefile.in && Exit 1 $AUTOCONF ./configure $MAKE test : --Boundary-00=_ec+0MWSk7mjph9+-- From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. (was: Re: bug#7333: bug concatenating CLEANFILES in automake 1.11) Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 06 Nov 2010 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: automake-patches@gnu.org Cc: Andy Wingo , Ben Denckla , bug-automake@gnu.org, 7333@debbugs.gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.12890632074489 (code B ref 7333); Sat, 06 Nov 2010 17:07:02 +0000 Received: (at 7333) by debbugs.gnu.org; 6 Nov 2010 17:06:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PEmE2-0001AM-Ta for submit@debbugs.gnu.org; Sat, 06 Nov 2010 13:06:47 -0400 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PEmE0-0001AG-TY for 7333@debbugs.gnu.org; Sat, 06 Nov 2010 13:06:45 -0400 Received: by wyb28 with SMTP id 28so4129005wyb.3 for <7333@debbugs.gnu.org>; Sat, 06 Nov 2010 10:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :message-id; bh=D2dQYWjtfEq/1DS2hFEKwEdJiJ34QIPLg+qNd8ETacg=; b=tIal2iXPdV/q4N0OSr9yg9Xn4AXJPyMWNOGd1ErpYe4yWRsAklJUp+BgXsqgtnoT7s 7+6mHH1bQkbKEpct5EwLFw6TgL2tB2jeoi14ZLPcEblpyX5b/o6NRg/zSimz1FKsnCeF 26oRuwMRVkS3S+P6aDh98Z1S0qh6ART3I/Fnc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; b=GVukj8UIiFNQMpeC27QhANvYGDFQIeoemw9y+gkIDmkVWoacwjMTtaHRGJ1rzlQ5Xf LxD7kEHTUFXsfHb7WRwxzTnj+65Mf1W7mDt+Kql1nKcK0H9ysOuyy4O4BVDeI7K2+CvX HfOl/z9uoQp+wLM/gwflL6bjHj93bcTqK416k= Received: by 10.227.145.68 with SMTP id c4mr3389755wbv.42.1289063477773; Sat, 06 Nov 2010 10:11:17 -0700 (PDT) Received: from bigio.localnet (host18-58-dynamic.1-79-r.retail.telecomitalia.it [79.1.58.18]) by mx.google.com with ESMTPS id f14sm2319680wbe.8.2010.11.06.10.11.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 06 Nov 2010 10:11:17 -0700 (PDT) From: Stefano Lattarini Date: Sat, 6 Nov 2010 18:10:44 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201011051214.38475.stefano.lattarini@gmail.com> In-Reply-To: <201011051214.38475.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_VwY1MJP6XMh49LR" Message-Id: <201011061810.46020.stefano.lattarini@gmail.com> X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --Boundary-00=_VwY1MJP6XMh49LR Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Friday 05 November 2010, Stefano Lattarini wrote: > I can confirm the bug with latest automake (from git master), with > a much-reduced minimal testcase (see attachment). > > I still haven't looked for an explanation or a fix, though. I've manged to find a very simple fix for the bug (see attached patch). OK to apply to maint? Regards, Stefano --Boundary-00=_VwY1MJP6XMh49LR Content-Type: text/x-patch; charset="us-ascii"; name="0001-Fix-a-bug-in-variable-concatanation-with.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0001-Fix-a-bug-in-variable-concatanation-with.patch" =46rom b8de299295e081909c6d0a8a1cef957b337e3732 Mon Sep 17 00:00:00 2001 =46rom: Stefano Lattarini Date: Sat, 6 Nov 2010 12:46:52 +0100 Subject: [PATCH] Fix a bug in variable concatanation with `+=3D'. * lib/Automake/VarDef.pm (append): Remove extra backslash-escaped newlines from the end of the variable's content, before appending to it. * tests/pluseq11.test: New test, exposing the bug. * tests/Makefile.am (TESTS): Update. Reported by Andy Wingo. =2D-- ChangeLog | 10 ++++++++ lib/Automake/VarDef.pm | 13 +--------- tests/Makefile.am | 1 + tests/Makefile.in | 1 + tests/pluseq11.test | 54 ++++++++++++++++++++++++++++++++++++++++++++= ++++ 5 files changed, 68 insertions(+), 11 deletions(-) create mode 100755 tests/pluseq11.test diff --git a/ChangeLog b/ChangeLog index 6c17cd3..a928363 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2010-11-06 Stefano Lattarini + + Fix a bug in variable concatanation with `+=3D'. + * lib/Automake/VarDef.pm (append): Remove extra backslash-escaped + newlines from the end of the variable's content, before appending + to it. + * tests/pluseq11.test: New test, exposing the bug. + * tests/Makefile.am (TESTS): Update. + Reported by Andy Wingo. + 2010-11-01 Ralf Wildenhues =20 Fix and document rules to not touch the tree with `make -n'. diff --git a/lib/Automake/VarDef.pm b/lib/Automake/VarDef.pm index d7ba155..568c82a 100644 =2D-- a/lib/Automake/VarDef.pm +++ b/lib/Automake/VarDef.pm @@ -185,17 +185,8 @@ sub append ($$$) # Furthermore keeping `#' would not be portable if the variable is # output on multiple lines. $val =3D~ s/ ?#.*//; =2D =2D if (chomp $val) =2D { =2D # Insert a backslash before a trailing newline. =2D $val .=3D "\\\n"; =2D } =2D elsif ($val) =2D { =2D # Insert a separator. =2D $val .=3D ' '; =2D } + # Insert a separator, if required. + $val .=3D ' ' if $val; $self->{'value'} =3D $val . $value; # Turn ASIS appended variables into PRETTY variables. This is to # cope with `make' implementation that cannot read very long lines. diff --git a/tests/Makefile.am b/tests/Makefile.am index 9c81564..da81c49 100644 =2D-- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -570,6 +570,7 @@ pluseq7.test \ pluseq8.test \ pluseq9.test \ pluseq10.test \ +pluseq11.test \ postproc.test \ ppf77.test \ pr2.test \ diff --git a/tests/Makefile.in b/tests/Makefile.in index b568a09..eb461a9 100644 =2D-- a/tests/Makefile.in +++ b/tests/Makefile.in @@ -837,6 +837,7 @@ pluseq7.test \ pluseq8.test \ pluseq9.test \ pluseq10.test \ +pluseq11.test \ postproc.test \ ppf77.test \ pr2.test \ diff --git a/tests/pluseq11.test b/tests/pluseq11.test new file mode 100755 index 0000000..293270f =2D-- /dev/null +++ b/tests/pluseq11.test @@ -0,0 +1,54 @@ +#!/bin/sh +# Copyright (C) 2010 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check for bug in variable concatenation with `+=3D': an extra backslash +# is erroneously retained in the final value. +# See also sister test pluseq11b.test. + +. ./defs || Exit 1 + +set -e + +cat >>configure.in <<'END' +AC_OUTPUT +END + +cat > Makefile.am <<'END' +## Use more line continuation to ensure we are robust and can (hopefully) +## cope any number of them, and not just one +FOO =3D \ +\ +\ +bar +## Both this two variable additions are required to trigger the bug. +FOO +=3D +FOO +=3D baz + +.PHONY: test +test: + case '$(FOO)' in *\\*) exit 1;; *) exit 0;; esac +END + +$ACLOCAL +$AUTOMAKE + +grep '^ *FOO *=3D.*\\.' Makefile.in && Exit 1 + +$AUTOCONF +./configure +$MAKE test + +: =2D-=20 1.7.1 --Boundary-00=_VwY1MJP6XMh49LR-- From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sun, 07 Nov 2010 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Stefano Lattarini Cc: Andy Wingo , Ben Denckla , 7333@debbugs.gnu.org, automake-patches@gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.128913610210684 (code B ref 7333); Sun, 07 Nov 2010 13:22:02 +0000 Received: (at 7333) by debbugs.gnu.org; 7 Nov 2010 13:21:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PF5Bl-0002mH-Vx for submit@debbugs.gnu.org; Sun, 07 Nov 2010 08:21:42 -0500 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PF5Bj-0002mC-9R for 7333@debbugs.gnu.org; Sun, 07 Nov 2010 08:21:40 -0500 Received: (qmail invoked by alias); 07 Nov 2010 13:26:13 -0000 Received: from dhcp-45-42.nomad.chalmers.se (EHLO ins.uni-bonn.de) [129.16.45.42] by mail.gmx.net (mp055) with SMTP; 07 Nov 2010 14:26:13 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX19+UuoVGIl+npN7/s/mwSuhDqwzHIxGSuHKBhaXby 217+0j51WgoYcg Date: Sun, 7 Nov 2010 14:26:09 +0100 From: Ralf Wildenhues Message-ID: <20101107132607.GD11896@ins.uni-bonn.de> Mail-Followup-To: Stefano Lattarini , automake-patches@gnu.org, Andy Wingo , Ben Denckla , 7333@debbugs.gnu.org References: <201011051214.38475.stefano.lattarini@gmail.com> <201011061810.46020.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201011061810.46020.stefano.lattarini@gmail.com> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.18 (2008-05-17) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Hello Stefano, Andy, * Stefano Lattarini wrote on Sat, Nov 06, 2010 at 06:10:44PM CET: > On Friday 05 November 2010, Stefano Lattarini wrote: > > I can confirm the bug with latest automake (from git master), with > > a much-reduced minimal testcase (see attachment). > > > > I still haven't looked for an explanation or a fix, though. > I've manged to find a very simple fix for the bug (see attached patch). > > OK to apply to maint? OK if it passes the whole testsuite. Thanks to both of you, for the report and the fast fix! Cheers, Ralf > From b8de299295e081909c6d0a8a1cef957b337e3732 Mon Sep 17 00:00:00 2001 > From: Stefano Lattarini > Date: Sat, 6 Nov 2010 12:46:52 +0100 > Subject: [PATCH] Fix a bug in variable concatanation with `+='. > > * lib/Automake/VarDef.pm (append): Remove extra backslash-escaped > newlines from the end of the variable's content, before appending > to it. > * tests/pluseq11.test: New test, exposing the bug. > * tests/Makefile.am (TESTS): Update. > > Reported by Andy Wingo. From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sun, 07 Nov 2010 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: automake-patches@gnu.org, 7333@debbugs.gnu.org Cc: Andy Wingo , Ben Denckla Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.128913976212201 (code B ref 7333); Sun, 07 Nov 2010 14:23:02 +0000 Received: (at 7333) by debbugs.gnu.org; 7 Nov 2010 14:22:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PF68n-0003Ak-Fl for submit@debbugs.gnu.org; Sun, 07 Nov 2010 09:22:41 -0500 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PF68l-0003Af-1V for 7333@debbugs.gnu.org; Sun, 07 Nov 2010 09:22:39 -0500 Received: by bwz12 with SMTP id 12so4210930bwz.3 for <7333@debbugs.gnu.org>; Sun, 07 Nov 2010 06:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:references:in-reply-to:cc:mime-version:content-type :content-transfer-encoding:message-id; bh=sOcHFziAvE8tyGTvZNx/SDvEA9rSrknQ7aV6lZ/jRFU=; b=B7rqEgPeAX2H9q8JOWNsRMqR1Pwf7cI0agDUn5JxLgOgZaSiYLPfi0ma3BkXzxR6Vf Rt4bey9juC/Hg5ZUb0jqVCErz9Tj6a0lZEABWJiZuLHypQ5DYSI08mr8Xpw9x5gC2+d/ JASpJeUpySYLxzCCvLnkEuUEGj+pDMpV+9Qzk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:references:in-reply-to:cc :mime-version:content-type:content-transfer-encoding:message-id; b=v4fGpPFdO/p+XxizgJsnFLfJ40WI2tx5pS3SWy7dJnrZD9jLrDorKvUl9arn55sg4L fhMpJnpPtqTXcUwJwl6L0hYmawOHQHgnm3ScDl4Pu1pwfBAQhunArNHzXN4c+G9Wp+Tn SS7R+BsXYDU65sWtTXBZp0i0UukW5hr5Kqx48= Received: by 10.204.76.79 with SMTP id b15mr3864005bkk.168.1289140033508; Sun, 07 Nov 2010 06:27:13 -0800 (PST) Received: from bigio.localnet (host91-53-dynamic.48-82-r.retail.telecomitalia.it [82.48.53.91]) by mx.google.com with ESMTPS id g8sm2898308bkg.23.2010.11.07.06.27.12 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 07 Nov 2010 06:27:12 -0800 (PST) From: Stefano Lattarini Date: Sun, 7 Nov 2010 15:26:52 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201011061810.46020.stefano.lattarini@gmail.com> <20101107132607.GD11896@ins.uni-bonn.de> In-Reply-To: <20101107132607.GD11896@ins.uni-bonn.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201011071526.54124.stefano.lattarini@gmail.com> X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sunday 07 November 2010, Ralf Wildenhues wrote: > Hello Stefano, Andy, > > * Stefano Lattarini wrote on Sat, Nov 06, 2010 at 06:10:44PM CET: > > On Friday 05 November 2010, Stefano Lattarini wrote: > > > I can confirm the bug with latest automake (from git master), with > > > a much-reduced minimal testcase (see attachment). > > > > > > I still haven't looked for an explanation or a fix, though. > > I've manged to find a very simple fix for the bug (see attached patch). > > > > OK to apply to maint? > > OK if it passes the whole testsuite. It does for me. BTW, I've also squashed a minor typofix in the new test's comments, and a better ChangeLog entry: Fix a bug in variable concatanation with `+='. * lib/Automake/VarDef.pm (append): Since the content of the "appended-to" variable is going to be unconditionally normalized later, simply separate the appended value with a single whitespace character, instead of trying to be uselesssly smarter by using escaped newlines. This fixes a bug in which extra backslashes where erroneously inserted in the variable's final value. * tests/pluseq11.test: New test, exposing the bug. * tests/Makefile.am (TESTS): Update. Reported by Andy Wingo. Now, should I also try to close the bug #7333 on debbugs? The instruction at seems quite clear about how to do so, so I think I can manage to get it right. BTW, Ouch! I see that my previous reply presenting the patch has erroneously opended a new, spurious bug report (#7345) in the tracker! Ralf, could you please you close that report as invalid? Regards, Stefano From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 08 Nov 2010 21:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Stefano Lattarini Cc: Andy Wingo , Ben Denckla , 7333@debbugs.gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.12892525021284 (code B ref 7333); Mon, 08 Nov 2010 21:42:01 +0000 Received: (at 7333) by debbugs.gnu.org; 8 Nov 2010 21:41:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFZTB-0000KZ-Gq for submit@debbugs.gnu.org; Mon, 08 Nov 2010 16:41:41 -0500 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PFZT4-0000KU-0a for 7333@debbugs.gnu.org; Mon, 08 Nov 2010 16:41:35 -0500 Received: (qmail invoked by alias); 08 Nov 2010 21:46:11 -0000 Received: from xdsl-89-0-159-90.netcologne.de (EHLO localhost.localdomain) [89.0.159.90] by mail.gmx.net (mp061) with SMTP; 08 Nov 2010 22:46:11 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX1+dvNtTHsqd8HRrQW29ml8Xx/l6Owjcr2mWHUPL/3 bmoOzYVuuYB6eL Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1PFZXV-0004pU-NH; Mon, 08 Nov 2010 22:46:09 +0100 Date: Mon, 8 Nov 2010 22:46:09 +0100 From: Ralf Wildenhues Message-ID: <20101108214609.GF18320@gmx.de> References: <201011061810.46020.stefano.lattarini@gmail.com> <20101107132607.GD11896@ins.uni-bonn.de> <201011071526.54124.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201011071526.54124.stefano.lattarini@gmail.com> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) merge 7333 7345 tags 7333 + patch close 7333 v1.11-222-g7a020d6 thanks * Stefano Lattarini wrote on Sun, Nov 07, 2010 at 03:26:52PM CET: > Now, should I also try to close the bug #7333 on debbugs? > The instruction at seems > quite clear about how to do so, so I think I can manage to get it > right. > > BTW, Ouch! I see that my previous reply presenting the patch > has erroneously opended a new, spurious bug report (#7345) in > the tracker! Ralf, could you please you close that report as > invalid? Not sure how that happened, probably the Subject: change. The commands above (Bcc:ed to control at debbugs) should merge and close both bugs. Cheers, Ralf From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 01:46:51 2010 Received: (at control) by debbugs.gnu.org; 9 Nov 2010 06:46:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFhyk-0005t8-S4 for submit@debbugs.gnu.org; Tue, 09 Nov 2010 01:46:51 -0500 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PFhyi-0005t3-K7 for control@debbugs.gnu.org; Tue, 09 Nov 2010 01:46:49 -0500 Received: (qmail invoked by alias); 09 Nov 2010 06:51:27 -0000 Received: from xdsl-89-0-145-142.netcologne.de (EHLO localhost.localdomain) [89.0.145.142] by mail.gmx.net (mp056) with SMTP; 09 Nov 2010 07:51:27 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX19tdbwCWvVttZOEYSAxC6aC9x41J4W+hTuQ8Tiwf/ lwwgFx1ea16TKT Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1PFi3C-0005FQ-As for control@debbugs.gnu.org; Tue, 09 Nov 2010 07:51:26 +0100 Date: Tue, 9 Nov 2010 07:51:26 +0100 From: Ralf Wildenhues To: control@debbugs.gnu.org Subject: bug#7333 Message-ID: <20101109065126.GC19221@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 7333 thanks From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Tue, 09 Nov 2010 07:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Ralf Wildenhues Cc: Stefano Lattarini , 7333@debbugs.gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.128928778926389 (code B ref 7333); Tue, 09 Nov 2010 07:30:03 +0000 Received: (at 7333) by debbugs.gnu.org; 9 Nov 2010 07:29:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFieK-0006ra-Ns for submit@debbugs.gnu.org; Tue, 09 Nov 2010 02:29:48 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFieI-0006rT-DK for 7333@debbugs.gnu.org; Tue, 09 Nov 2010 02:29:46 -0500 Received: from localhost ([127.0.0.1]:46297) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFiil-0006IE-Kq; Tue, 09 Nov 2010 02:34:23 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19672.63871.304150.971858@fencepost.gnu.org> Date: Tue, 9 Nov 2010 02:34:23 -0500 From: Glenn Morris In-Reply-To: <20101108214609.GF18320@gmx.de> References: <201011061810.46020.stefano.lattarini@gmail.com> <20101107132607.GD11896@ins.uni-bonn.de> <201011071526.54124.stefano.lattarini@gmail.com> <20101108214609.GF18320@gmx.de> X-Spam-Score: -6.2 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Ralf Wildenhues wrote (on Mon, 8 Nov 2010 at 22:46 +0100): > > BTW, Ouch! I see that my previous reply presenting the patch > > has erroneously opended a new, spurious bug report (#7345) in > > the tracker! Ralf, could you please you close that report as > > invalid? > > Not sure how that happened, probably the Subject: change. It was a combination of changing the subject plus cc'ing bug-automake. bug-automake is basically an alias for submit@debbugs now. Anything sent there that is not "obviously" replying to an existing report creates a new bug. There is no need to cc bug-automake on replies to reports; ###@debbugs can be thought of as an alias for that. The only time to use the bug-automake address now is in new bug reports. Sending to both just creates duplicates. > The commands above (Bcc:ed to control at debbugs) should merge and > close both bugs. The (first) close didn't work, I think it was because your version number started with a `v', not a digit. The second close worked. From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 10 Nov 2010 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Glenn Morris Cc: Stefano Lattarini , 7333@debbugs.gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.12894137099989 (code B ref 7333); Wed, 10 Nov 2010 18:29:02 +0000 Received: (at 7333) by debbugs.gnu.org; 10 Nov 2010 18:28:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGFPI-0002b3-DD for submit@debbugs.gnu.org; Wed, 10 Nov 2010 13:28:29 -0500 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PGFPF-0002ay-Nx for 7333@debbugs.gnu.org; Wed, 10 Nov 2010 13:28:26 -0500 Received: (qmail invoked by alias); 10 Nov 2010 18:33:08 -0000 Received: from xdsl-89-0-152-7.netcologne.de (EHLO localhost.localdomain) [89.0.152.7] by mail.gmx.net (mp055) with SMTP; 10 Nov 2010 19:33:08 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX18RqAMnk8cRwDmu5ifuKhVDHhtR3fGJI/2U15Aw8x JD79sLazVu2flq Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1PGFTn-0006Yd-WC; Wed, 10 Nov 2010 19:33:07 +0100 Date: Wed, 10 Nov 2010 19:33:07 +0100 From: Ralf Wildenhues Message-ID: <20101110183307.GH24598@gmx.de> References: <201011061810.46020.stefano.lattarini@gmail.com> <20101107132607.GD11896@ins.uni-bonn.de> <201011071526.54124.stefano.lattarini@gmail.com> <20101108214609.GF18320@gmx.de> <19672.63871.304150.971858@fencepost.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19672.63871.304150.971858@fencepost.gnu.org> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) * Glenn Morris wrote on Tue, Nov 09, 2010 at 08:34:23AM CET: > Ralf Wildenhues wrote (on Mon, 8 Nov 2010 at 22:46 +0100): > > The commands above (Bcc:ed to control at debbugs) should merge and > > close both bugs. > > The (first) close didn't work, I think it was because your version > number started with a `v', not a digit. The second close worked. Can that be fixed in debbugs? I would love to have both 'git describe' output as well as commit SHA1 strings be acceptable as version strings. git describe output starts with v but then contrains fairly much arbitrary characters as put in the last signed git tag. SHA1's are easier, and if the other is a problem then those would still be better than no version information, I guess. Thanks, Ralf From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 10 Nov 2010 20:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Ralf Wildenhues Cc: Stefano Lattarini , 7333@debbugs.gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.128942135913434 (code B ref 7333); Wed, 10 Nov 2010 20:36:02 +0000 Received: (at 7333) by debbugs.gnu.org; 10 Nov 2010 20:35:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGHOg-0003Ud-NI for submit@debbugs.gnu.org; Wed, 10 Nov 2010 15:35:59 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGHOe-0003UY-7D for 7333@debbugs.gnu.org; Wed, 10 Nov 2010 15:35:56 -0500 Received: from localhost ([127.0.0.1]:60020) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGHTD-0000Fy-9k; Wed, 10 Nov 2010 15:40:39 -0500 References: <201011061810.46020.stefano.lattarini@gmail.com> <20101107132607.GD11896@ins.uni-bonn.de> <201011071526.54124.stefano.lattarini@gmail.com> <20101108214609.GF18320@gmx.de> <19672.63871.304150.971858@fencepost.gnu.org> <20101110183307.GH24598@gmx.de> From: Glenn Morris X-Spook: propaganda Hamas Security Council diwn arrangements ASDIC X-Ran: +h` X-Hue: yellow X-Attribution: GM Date: Wed, 10 Nov 2010 15:40:38 -0500 In-Reply-To: <20101110183307.GH24598@gmx.de> (Ralf Wildenhues's message of "Wed\, 10 Nov 2010 19\:33\:07 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Ralf Wildenhues wrote: > Can that be fixed in debbugs? I would love to have both 'git describe' > output as well as commit SHA1 strings be acceptable as version strings. > git describe output starts with v but then contrains fairly much > arbitrary characters as put in the last signed git tag. SHA1's are > easier, and if the other is a problem then those would still be better > than no version information, I guess. Sure. Here is the current regexp: m/^close\s+\#?(-?\d+)(?:\s+(\d.*))?$/i $1 = bug number $2 = version number What would you like it to be? From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 10 Nov 2010 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Ralf Wildenhues , Stefano Lattarini , 7333@debbugs.gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.128942168013587 (code B ref 7333); Wed, 10 Nov 2010 20:42:02 +0000 Received: (at 7333) by debbugs.gnu.org; 10 Nov 2010 20:41:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGHTs-0003X6-79 for submit@debbugs.gnu.org; Wed, 10 Nov 2010 15:41:20 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGHTr-0003Wz-23 for 7333@debbugs.gnu.org; Wed, 10 Nov 2010 15:41:19 -0500 Received: from localhost ([127.0.0.1]:40695) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGHYQ-0000hb-Bl; Wed, 10 Nov 2010 15:46:02 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19675.1161.908121.509483@fencepost.gnu.org> Date: Wed, 10 Nov 2010 15:46:01 -0500 From: Glenn Morris In-Reply-To: References: <201011061810.46020.stefano.lattarini@gmail.com> <20101107132607.GD11896@ins.uni-bonn.de> <201011071526.54124.stefano.lattarini@gmail.com> <20101108214609.GF18320@gmx.de> <19672.63871.304150.971858@fencepost.gnu.org> <20101110183307.GH24598@gmx.de> X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: blue X-Ran: DN}x~Ahopsj=_zrsd?rP?$55sluMpO}zfGRMiyC%9v{dlPWPeyo*vX4SO[n8TH5Ko3l:A! X-Spam-Score: -6.2 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Actually, that was probably too glib a response. The version number information is probably used in other places, and needs to be sortable so that the fixed/found commands can work. So I don't think arbitrary version strings can work. You could use the date of a commit perhaps. From unknown Sat Jun 21 10:44:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 10 Nov 2010 21:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7333 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Glenn Morris Cc: Stefano Lattarini , 7333@debbugs.gnu.org Received: via spool by 7333-submit@debbugs.gnu.org id=B7333.128942442814921 (code B ref 7333); Wed, 10 Nov 2010 21:28:02 +0000 Received: (at 7333) by debbugs.gnu.org; 10 Nov 2010 21:27:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGICC-0003sc-58 for submit@debbugs.gnu.org; Wed, 10 Nov 2010 16:27:08 -0500 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PGIC9-0003sG-Co for 7333@debbugs.gnu.org; Wed, 10 Nov 2010 16:27:06 -0500 Received: (qmail invoked by alias); 10 Nov 2010 21:31:49 -0000 Received: from xdsl-89-0-152-7.netcologne.de (EHLO localhost.localdomain) [89.0.152.7] by mail.gmx.net (mp007) with SMTP; 10 Nov 2010 22:31:49 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX1/NOaJEqJ/N0X1WQxPwqTZoUvfGRAvTUvdJBov4Au YH1JG+i27dlkJb Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1PGIGh-0005et-OK; Wed, 10 Nov 2010 22:31:47 +0100 Date: Wed, 10 Nov 2010 22:31:47 +0100 From: Ralf Wildenhues Message-ID: <20101110213147.GF3546@gmx.de> References: <201011061810.46020.stefano.lattarini@gmail.com> <20101107132607.GD11896@ins.uni-bonn.de> <201011071526.54124.stefano.lattarini@gmail.com> <20101108214609.GF18320@gmx.de> <19672.63871.304150.971858@fencepost.gnu.org> <20101110183307.GH24598@gmx.de> <19675.1161.908121.509483@fencepost.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19675.1161.908121.509483@fencepost.gnu.org> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) * Glenn Morris wrote on Wed, Nov 10, 2010 at 09:46:01PM CET: > > Actually, that was probably too glib a response. The version number > information is probably used in other places, and needs to be sortable > so that the fixed/found commands can work. So I don't think arbitrary > version strings can work. You could use the date of a commit perhaps. If that's the case, let's I'd say just live with it. Anyway better to send mail to NNN-done, where one can include arbitrary detail. Thanks for checking, Ralf