GNU bug report logs - #73324
30.0.91; php-ts-mode: regression due to the latest patches for treesitter.c?

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73324: closed (30.0.91; php-ts-mode: regression due to the
 latest patches for treesitter.c?)
Date: Sun, 22 Sep 2024 06:48:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Sep 2024 23:45:47 -0700
with message-id <9A35527F-AF16-4210-9E12-5F2C7B216EA5 <at> gmail.com>
and subject line Re: bug#73324: 30.0.91; php-ts-mode: regression due to the latest patches for treesitter.c?
has caused the debbugs.gnu.org bug report #73324,
regarding 30.0.91; php-ts-mode: regression due to the latest patches for treesitter.c?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73324: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73324
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.91;
 php-ts-mode: regression due to the latest patches for treesitter.c?
Date: Tue, 17 Sep 2024 22:29:14 +0200

[Message part 3 (text/plain, inline)]

Ciao,
php-ts-mode no longer behaves as it used to. There seems to be some problems 
with the calculation of ranges covered by the parsers. In the image I attached 
you can see how the code is being parsed by both the php and javascript 
parsers. The namespace declaration has some elements colored as if they were 
escape sequences.
The php-ts-mode--get-parser-ranges function returns the following ranges:

((#<treesit-parser for html> nil) (#<treesit-parser for css> nil) (#<treesit-
parser for javascript> nil) (#<treesit-parser for php> nil) (#<treesit-parser 
for phpdoc> ((368 . 426))) (#<treesit-parser for jsdoc> ((368 . 426))))

The range for 'jsdoc' is wrong, there should be only the range for 'phpdoc'.
The attached gif screencast shows the strange behavior in updating the font-
lock.
It doesn't happen all the time. I'm trying to isolate the problem.

Any ideas about this?
The parsers were installed with php-ts-mode-install-parser.

GNU Emacs 30.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo 
version 1.18.0) of 2024-09-17, libtree-sitter-0.22.5-1.fc40.x86_64


Thanks.

Vincenzo

[range_issue_1.png (image/png, attachment)]

[reange_issue_2.gif (image/gif, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 73324-done <at> debbugs.gnu.org
Subject: Re: bug#73324: 30.0.91; php-ts-mode: regression due to the latest
 patches for treesitter.c?
Date: Sat, 21 Sep 2024 23:45:47 -0700

> On Sep 21, 2024, at 3:17 AM, Vincenzo Pupillo <v.pupillo <at> gmail.com> wrote:
> 
> In data sabato 21 settembre 2024 05:55:22 CEST, Yuan Fu ha scritto:
>>>> It works better, but the range update seems to be delayed or not
>>>> triggered by e.g. yank or undo, as you can see in the attached
>>>> screencast. After the yank the ranges are:
>>>> ((#<treesit-parser for html> ((2 . 483))) (#<treesit-parser for css> ((1
>>>> . 1))) (#<treesit-parser for javascript> ((1 . 1))) (#<treesit-parser
>>>> for php> nil) (#<treesit-parser for phpdoc> ((377 . 435))))> 
>>> Ok, yeah, I can reproduce this now! Working on it.
>>> 
>>> Yuan
>> 
>> It should be fixed now on emacs-30.
> Yes, it works. 
> Thank you Yuan.

Great! Closing this report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.