GNU bug report logs - #73320
[PATCH] project--vc-list-files: use Git's sparse-index

Previous Next

Full log

Message #37 received at 73320 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Sean Allred <allred.sean <at> gmail.com>, 73320 <at> debbugs.gnu.org
Subject: Re: bug#73320: [PATCH] project--vc-list-files: use Git's sparse-index
Date: Fri, 04 Oct 2024 09:48:53 +0200

Dmitry Gutov <dmitry <at> gutov.dev> writes:

Hi Dmitry,

> It could use some review, though. There aren't many examples of doing
> that in Emacs code.

In Eshell, Jim Porter makes extensive use of connection-local
variables. He has also added some functions which are useful (not
applied in Tramp yet).

> Michael, could you take a look? Does this look reasonable? Should
> :application be 'tramp' or 'vc-git'?

In general, it doesn't matter. But since your change is dedicated to
vc-git, using the application `vc-git' makes sense.

However, you use with-connection-local-variables, which uses the
application `tramp' by default. Either use
with-connection-local-application-variables instead, or let-bind
connection-local-default-application to `vc-git'.

I'm not sure how setq-connection-local behaves wrt to the application
(this function was written by Jim, I've never used it). But binding
connection-local-default-application should be good enough, I believe.

> Is the 'connection-local-set-profiles' call needed here at all or can
> be skipped?

It is needed. connection-local-set-profile-variables declares only the
variables, connection-local-set-profiles activates them.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.