GNU bug report logs - #73311
[PATCH] Add libliftoff

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73311 in the body.
You can then email your comments to 73311 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: The Man <squishypinkelephant <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add libliftoff
Date: Mon, 16 Sep 2024 21:43:12 -0500

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[libliftoff.patch (text/x-patch, attachment)]

Message #8 received at 73311 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 73311 <at> debbugs.gnu.org
Cc: Steve George <steve <at> futurile.net>
Subject: [PATCH v2 0/1] Add libliftoff
Date: Sun, 22 Sep 2024 15:07:06 +0100

Hi 'The Man',

Thanks for your contribution! Just be aware that it wasn't in the correct format so the CI system couldn't automatically build it. If it doesn't build a committer is less likely to take the time to look at it. Please have a look at the manual at the section preparing a patch (https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html) when you send your next contribution :-). Hopefully it will build automatically and a committer will have time to review it.

Review:
  * submission: corrected patch format
  * submission: checked source code hash
  * submission: checked license, patch applies, build/reproducibility
  * added Reviewed-by trailer
  * re-roll to trigger QA build

The Man (1):
  gnu: Add libliftoff.

 gnu/packages/freedesktop.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)


base-commit: b7c94d528875415ea7ec6225d88a6b3d55fa2e14
-- 
2.46.0

Message #11 received at 73311 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 73311 <at> debbugs.gnu.org
Cc: The Man <squishypinkelephant <at> gmail.com>, Steve George <steve <at> futurile.net>
Subject: [PATCH v2 1/1] gnu: Add libliftoff.
Date: Sun, 22 Sep 2024 15:07:07 +0100

From: The Man <squishypinkelephant <at> gmail.com>

* gnu/packages/freedesktop.scm (libliftoff): New variable.

Reviewed-by: Steve George <steve <at> futurile.net>

Change-Id: I19eda24aea4327bcd72a7e15ec0784ef1e302783
---
 gnu/packages/freedesktop.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 993bb84ec6..2a78895a20 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -354,6 +354,30 @@ (define-public libglib-testing
     (home-page "https://gitlab.gnome.org/pwithnall/libglib-testing")
     (license license:lgpl2.1+)))
 
+(define-public libliftoff
+  (package
+    (name "libliftoff")
+    (version "0.5.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://gitlab.freedesktop.org/emersion/libliftoff")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "163g8ndsbma7acy2k9mrnvlpb7yi4431hgkx1gygkafgwpq1ii1x"))))
+    (build-system meson-build-system)
+    (native-inputs (list pkg-config))
+    (inputs (list libdrm))
+    (home-page "https://gitlab.freedesktop.org/emersion/libliftoff")
+    (synopsis "Lightweight KMS plane library for compositors")
+    (description "Libliftoff eases the use of
+@acronym{KMS, Kernel Mode Setting} planes from userspace.  Users create
+\"virtual planes\" called layers, set KMS properties on them, and libliftoff
+will pick hardware planes for these layers if possible.")
+    (license license:expat)))
+
 (define-public malcontent
   (package
     (name "malcontent")
-- 
2.46.0

Message #14 received at 73311 <at> debbugs.gnu.org (full text, mbox):

From: The Man <squishypinkelephant <at> gmail.com>
To: Steve George <steve <at> futurile.net>
Cc: 73311 <at> debbugs.gnu.org
Subject: Re: [bug#73311] [PATCH v2 0/1] Add libliftoff
Date: Sun, 22 Sep 2024 14:22:27 -0500

[Message part 1 (text/plain, inline)]

My apologies. I did not consider the format of the patch could cause an
issue. I will consider better means of submitting patches in the future,
instead of through my Gmail.

On Sun, Sep 22, 2024, 9:11 AM Steve George <steve <at> futurile.net> wrote:

> Hi 'The Man',
>
> Thanks for your contribution! Just be aware that it wasn't in the correct
> format so the CI system couldn't automatically build it. If it doesn't
> build a committer is less likely to take the time to look at it. Please
> have a look at the manual at the section preparing a patch (
> https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html)
> when you send your next contribution :-). Hopefully it will build
> automatically and a committer will have time to review it.
>
> Review:
>   * submission: corrected patch format
>   * submission: checked source code hash
>   * submission: checked license, patch applies, build/reproducibility
>   * added Reviewed-by trailer
>   * re-roll to trigger QA build
>
> The Man (1):
>   gnu: Add libliftoff.
>
>  gnu/packages/freedesktop.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
>
> base-commit: b7c94d528875415ea7ec6225d88a6b3d55fa2e14
> --
> 2.46.0
>
>
>
>
>

[Message part 2 (text/html, inline)]

Message #19 received at 73311-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 73311-done <at> debbugs.gnu.org
Subject: Close
Date: Thu, 26 Sep 2024 09:45:30 +0200

QA does not seem to work right now. Given that the patch is more than
a week old and has been reviewed and that the package builds for me,
I take the liberty to apply it.

Thanks for the package and the review,

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.