Subject: bug#73305: closed ([PATCH 1/2] gnu: python-pycurl: Fix build by running the tests single-threaded.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 24 Nov 2024 14:55:01 +0000

Your bug report

#73305: [PATCH 1/2] gnu: python-pycurl: Fix build by running the tests single-threaded.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
73305: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73305
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: [PATCH 1/2] gnu: python-pycurl: Fix build by running the tests single-threaded.
From: Sharlatan Hellseher <[email-masked]>
To: [email-masked]
Date: Sun, 24 Nov 2024 14:53:12 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Pushed with minor commit message adjustments, and add follow up commit
removing pytest-xdist and nose completely.

--8<---------------cut here---------------start------------->8---
bdbf3ab4f0 * master gnu: python-pycurl: Adjust inputs.
e30c169bec * gnu: python-pycurl: Build from git.
851f0662a5 * gnu: python-pycurl: Fix build by running the tests single-threaded.

> ./pre-inst-env guix build python-pycurl --rounds=2
/gnu/store/pv1m7xfmgjb5aqfy94ppl0k3d1h9paxl-python-pycurl-7.45.22
--8<---------------cut here---------------end--------------->8---

--
Thanks,
Oleg

Subject: [PATCH 1/2] gnu: python-pycurl: Fix build by running the tests single-threaded.
From: [email-masked]
To: [email-masked]
Cc: Attila Lendvai <[email-masked]>
Date: Mon, 16 Sep 2024 22:53:47 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

From: Attila Lendvai <[email-masked]>

* gnu/packages/python-web.scm (python-pycurl): Make test run single-threaded.
Reenable some tests that used to fail due to threading.
[test_request_without_certinfo]: Disable test/timebomb that probably uses an
expired CA.

Change-Id: I62bc60757cf2e005ed55768c84d8c178f63c35ec
---
 gnu/packages/python-web.scm | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 8b29f1cd936..94e349bedb0 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2024,15 +2024,18 @@ (define-public python-pycurl
     (build-system pyproject-build-system)
     (arguments
      '(#:test-flags
-       (list "-n" "auto"
+       (list
+        ;; The test suite is not thread safe:
+        ;; - some tests want to use the same port: address already in use
+        ;; - some tests use signal.Signal, i.e. main-thread only
+        "-n" "1"
              "-k" (string-append
                    ;; Disable hanginging tests
                    "not test_multi_socket_select"
                    ;; E assert None is not None
                    ;; E+ where None =
                    ;; <tests.multi_callback_test.MultiCallbackTest
-                   ;; testMethod=test_easy_pause_unpause>.socket_result
-                   " and not test_easy_pause_unpause"
+                   ;; testMethod=test_multi_socket_action>.timer_result
                    " and not test_multi_socket_action"
                    ;; E pycurl.error: (1, '')
                    " and not test_http_version_3"
@@ -2045,9 +2048,9 @@ (define-public python-pycurl
                    ;; OSError: tests/fake-curl/libcurl/with_openssl.so: cannot
                    ;; open shared object file: No such file or directory
                    " and not test_libcurl_ssl_openssl"
-                   ;; pycurl.error: (56, 'Recv failure: Connection reset by
-                   ;; peer')
-                   " and not test_post_with_read_callback"))
+                   ;; Probably due to an expired CA
+                   " and not test_request_without_certinfo"
+                   ))
        #:phases (modify-phases %standard-phases
                   (add-before 'build 'configure-tls-backend
                     (lambda _

base-commit: 4f86fa20179ded1e6314eeba7da17309d501a32f
-- 
2.46.0