From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 11:40:09 2024 Received: (at submit) by debbugs.gnu.org; 16 Sep 2024 15:40:09 +0000 Received: from localhost ([127.0.0.1]:53089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqDph-0007Kb-8O for submit@debbugs.gnu.org; Mon, 16 Sep 2024 11:40:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:54554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqDpf-0007KR-20 for submit@debbugs.gnu.org; Mon, 16 Sep 2024 11:40:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqDpR-0007Oj-9r for guix-patches@gnu.org; Mon, 16 Sep 2024 11:39:53 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqDpO-0007Sr-SP for guix-patches@gnu.org; Mon, 16 Sep 2024 11:39:52 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-42ca4e0299eso35677985e9.2 for ; Mon, 16 Sep 2024 08:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726501188; x=1727105988; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=L7ycULewj21LLIB8ON1fukN/NdADpbRliXnmwMwasDY=; b=RvELhoRu6L/uGuwrqQ8SyBpJTZtJyPCChDonP0mFuHVXckcXurIdL3IVIMZHI0pMrV 0L2b4/yCLbVJWaSM31EEIvKJxHaMOssnB5iAGoM1Xg4d7lQqhKzVFptBqpbdluciCZPt GVTc4V5iKr2eVYddsL9EUxewk4qAAiukEj0DynT1m3Q3VvTE8qulTlZu+Qo1d2yM8uTl x64WjTBUCSA1GCKYh0YDAEF7VXtOr6dRg7nhZA3eOjwJZW8FO7olvQmVFHxI/Qrb/LSa sb+RKKgSijFGVGeFBFWlDSza9sg+zAFkX8gOhSduKQp+1s1WEt6FGG7ekH00XOQnoMBD 5rIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726501188; x=1727105988; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L7ycULewj21LLIB8ON1fukN/NdADpbRliXnmwMwasDY=; b=F79NGQomUkhzyYTphee6ue9czS0UrpAfgxHcO9pH9fIx1V8VJRWvG0OpPjGGCA+OI4 r0WZH+UUvKXQnzMh3JMyiUDBnvzwMK73tyZgfj9xU9tj98sS0jkzxosKwq9FYllzkLQd gMxcEqhlfyX9G14b1MtEsStXIrT4zsZafdee4rgqoE/5kETyEZ8m87fRfmemaL7DKMvD kAfNLnVe7k96fDiki7u6OtZtr7IWP9SbaWiOtpUhzfhGrTX4pvFTLNPkQsI0yzqVAMtf J8NmeHwdmX5D2NhvE6pnKSCNXScw20kkt5+YKD/z3HMBveFEIOWmjgvYGjJo5umPmLlE +Oig== X-Gm-Message-State: AOJu0YxpMvk+pcSqx96FG5KD/NQJpHgttKsmtM9nTLNsE13N5dmdviVy sN4pIq5pGNgPwQOmYzP/gzs2cn1f+2qiRPKeu4RTU1cPB3mX3qHlLgPxhmZu X-Google-Smtp-Source: AGHT+IEwBazEgTnUj17k2JxkWHNWsLlGOtv33FEuYB6pc4iVPMXiI/1TdWXIzHXubFyJYsZ5+Cti8w== X-Received: by 2002:adf:b30e:0:b0:374:c3e4:d6c5 with SMTP id ffacd0b85a97d-378c2d59673mr7566151f8f.57.1726501187383; Mon, 16 Sep 2024 08:39:47 -0700 (PDT) Received: from localhost ([141.226.162.35]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e71f068esm7585470f8f.3.2024.09.16.08.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 08:39:46 -0700 (PDT) From: Efraim Flashner To: guix-patches@gnu.org Subject: [PATCH] build/go: Replace symlinks with a copy of the file. Date: Mon, 16 Sep 2024 18:38:46 +0300 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Debbugs-Cc: Katherine Cox-Buday , Sharlatan Hellseher Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=efraim.flashner@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: Sharlatan Hellseher , Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) * guix/build/go-build-system.scm (fix-embed-files): New procedure. (%standard-phases): Add 'fix-embed-files after 'unpack. Co-authored-by: Sharlatan Hellseher Change-Id: I27bc46fa1a3f4675ff73b6cba4ef5c3d177c22b1 --- I saw this pattern coming up a couple of times in the go-team branch so I figured I could factor it out, as the comment said. I figure later we can adjust it to match other symlinked files. guix/build/go-build-system.scm | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 3f0f5700a1e..c953976b485 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -4,10 +4,11 @@ ;;; Copyright © 2019 Maxim Cournoyer ;;; Copyright © 2020 Jack Hill ;;; Copyright © 2020 Jakub Kądziołka -;;; Copyright © 2020, 2021, 2023 Efraim Flashner +;;; Copyright © 2020, 2021, 2023, 2024 Efraim Flashner ;;; Copyright © 2021 Sarah Morgensen ;;; Copyright © 2024 Ekaitz Zarraga ;;; Copyright © 2024 Picnoir +;;; Copyright © 2024 Sharlatan Hellseher ;;; ;;; This file is part of GNU Guix. ;;; @@ -201,6 +202,23 @@ (define* (setup-go-environment #:key inputs outputs goos goarch #:allow-other-ke (delete-file-recursively tmpdir)) #t) +(define* (fix-embed-files #:rest args) + "Golang can't determine the valid directory of the module of embed file +which is symlinked during setup environment phase, but easy resolved after +coping file from the store to the build directory of the current package." +;; see details in Golang source: +;; +;; - URL: +;; - commit: 82c14346d89ec0eeca114f9ca0e88516b2cda454 +;; - file: src/cmd/go/internal/load/pkg.go#L2059 + (for-each (lambda (file) + (when (eq? (stat:type (lstat file)) + 'symlink) + (let ((file-store-path (readlink file))) + (delete-file file) + (copy-recursively file-store-path file)))) + (find-files "src" ".*(editions_defaults.binpb)$"))) + (define* (unpack #:key source import-path unpack-path #:allow-other-keys) "Relative to $GOPATH, unpack SOURCE in UNPACK-PATH, or IMPORT-PATH when UNPACK-PATH is unset. If the SOURCE archive has a single top level directory, @@ -321,6 +339,7 @@ (define %standard-phases (delete 'patch-generated-file-shebangs) (add-before 'unpack 'setup-go-environment setup-go-environment) (replace 'unpack unpack) + (add-after 'unpack 'fix-embed-files fix-embed-files) (replace 'build build) (replace 'check check) (replace 'install install) base-commit: 0091fa2cc2ac2104d7945b585e4eaec908ca742f -- Efraim Flashner רנשלפ םירפא GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 16:11:18 2024 Received: (at 73299) by debbugs.gnu.org; 16 Sep 2024 20:11:18 +0000 Received: from localhost ([127.0.0.1]:53363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI45-0005eO-MR for submit@debbugs.gnu.org; Mon, 16 Sep 2024 16:11:18 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:50590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI43-0005e8-Mb for 73299@debbugs.gnu.org; Mon, 16 Sep 2024 16:11:16 -0400 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-42e5e758093so14190255e9.1 for <73299@debbugs.gnu.org>; Mon, 16 Sep 2024 13:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726517396; x=1727122196; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qJ4MgwlJycVjXtRfzmsTrzdJY99oMQLSwv1FwulqKxM=; b=F+Nrp5mZH8hXI9uUmeu0dnRzkcHs+8APQbQBmHGbjUdK10VUPWDvd5DZy2oebO70Ex Ml+8X4xtc/oH5WHE6sNJVGgTeb1ermPpS7Z/n9omI5e1MVdXE6qPW9uf2vC8W77QZzY7 FYsEVbIAlOvPJQCSKOpoaxOIpD5q/oxmfFiwL14lpHu34wqjWU9pkgUzo7UNASnscvPn m/r2dEqPlE6kAGNxiX02kYC87NFnPjnFg8zelBxMFW4J+sx50j8dpgdJIg1k2E+hex6x +iISlR3FwWzubpOrBj1kX81c71FkBlht+8s0amrdVeTS5SDzo0pnyY/b7F1ZeO7O4bLi OwzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726517396; x=1727122196; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qJ4MgwlJycVjXtRfzmsTrzdJY99oMQLSwv1FwulqKxM=; b=N1aNxuaWjyISANBZ9iq9eC3+7C61XnLRKx1lBTbjExre89bUkguOwh3/4ac7d/GEfV B5pZjUCnhfNla4m5yyA+JByNGATmnKvU8pDJFScH8ly9e3O6UJrAmQQtO3tsAU3iveWo ux46dWaiAtHM5gwigdx7Y68zAx35WHx1AklnPIum/4Zd1sMp7aYYa6Egz8sm05EaB4nU GkbkAYfDsd6ZiEBcKU1ypE8uzw75KGeAA1etA7YzJTxLNFSeZahbUeCu+3rzXsfUoJ02 X9LlPCNcDfE40glemptiGhDfm7ViygD8gt4/5BHA3eGziBkl4xMxfkkTfo6Cxqw4HDdt QkUA== X-Gm-Message-State: AOJu0YyMsIHu4toEdkwfmFZL1TcDBDSwmbeEibUny2B6OOYjeC1LyIEa aR96i1xe/2rLB2+w5VRddp8tvKSrnI+FSvbbuyEHzttPL+HEEuMo X-Google-Smtp-Source: AGHT+IFAzFg9CPboVNxPa0hG0H/7BongQYSYu27OvFAsTChW1ff3f8lutFjC4geGH3pXLXAV9Nceng== X-Received: by 2002:a5d:6482:0:b0:374:af19:7992 with SMTP id ffacd0b85a97d-378d61d508bmr9003755f8f.7.1726517395494; Mon, 16 Sep 2024 13:09:55 -0700 (PDT) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73f9b10sm7950689f8f.59.2024.09.16.13.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 13:09:54 -0700 (PDT) From: Sharlatan Hellseher To: 73299@debbugs.gnu.org Subject: [PATCH] build/go: Replace symlinks with a copy of the file. Date: Mon, 16 Sep 2024 21:09:40 +0100 Message-ID: <87jzfbbbsr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Efraim,=20=20 Thank you for implementing it as a procedure! I've slightly modifed your patch to have an optional list of other embed files or patterns which will be copied. It started appearing more and more during updates where project needs embed file(s) and Golang can't detect it location. Changes in v2: =2D implement #:embed-files key =2D implement building match pattern based on it =2D add documentation =2D add missing copyright for Troy, who implemented #:test-flags key =2D include 2 examples on how it solves for the case where go could not find more files I can apply it on go-team and clean up all TODOs. The branch would need some review as it contains adjustments to importer an build system. I do not want to push more changes for now and it would be great to merge it to master after resolving all potential build issues. Efraim Flashner (1): build/go: Replace symlinks with a copy of the file. Sharlatan Hellseher (2): gnu: go-github-com-prometheus-statsd-exporter: Remove redundant phase. gnu: go-github-com-golang-protobuf: Remove redundant phase. doc/guix.texi | 8 ++++++++ gnu/packages/golang-build.scm | 18 ------------------ gnu/packages/prometheus.scm | 24 +----------------------- guix/build-system/go.scm | 6 ++++++ guix/build/go-build-system.scm | 30 ++++++++++++++++++++++++++++-- 5 files changed, 43 insertions(+), 43 deletions(-) base-commit: f5449685143be0805a8a9b54ddecee94e368c6e9 prerequisite-patch-id: bf5c64d8c918f491f55da888b016e6a3f71119fc prerequisite-patch-id: 37d4fcd80049a0d2f23e4a2823be899ac9ba5a92 prerequisite-patch-id: df0368ad227844a04e5ee1c7f950629aa78261a4 prerequisite-patch-id: 7f84b54ceeed4e876b80c9719d01c4ac46107bc0 prerequisite-patch-id: 0296a60d5c71c1c0340dafc71805d73c1ecfd842 prerequisite-patch-id: 2d94a9caf8da756a9d7db97c05dd4bb389b8229e prerequisite-patch-id: 492ab0bbf944adbaa9781a5c5e52244f2b8658fe prerequisite-patch-id: 6f971b174a8ad69e9f3961ad9b85417e45623bb6 prerequisite-patch-id: dd63d8b78cd9683db737967abddd37bca9a6e857 prerequisite-patch-id: a32b4ef3062548909d14a0828e45df1394a3219b prerequisite-patch-id: 011f3c12c5c5982faf524c28778fb903426feaa2 prerequisite-patch-id: c38e1756dccf87c74efe631f64a1c7f441d11641 prerequisite-patch-id: 00e7d1dc1e39e512a4e2e9714f080291425dcfc8 prerequisite-patch-id: 28134b8dffa9d27fca725ba9f85e167c1274034a prerequisite-patch-id: 509868ff5c4a3a67b03d6a57e02a539e348284ee prerequisite-patch-id: 7ca3232011da5c664f65ba802b6786cab561bbad prerequisite-patch-id: 0ba03d80347c47d2c9f744d20bfd29912e40f318 prerequisite-patch-id: e3a8892e61c618e1d3920cf988d88554092dd8a8 prerequisite-patch-id: 6e9876b605b9ce55c6183614b1bfebcf26e59430 prerequisite-patch-id: b299291ef134206cfe8ad45c7a9a8010bb87f36a prerequisite-patch-id: e7729b0615445695d3f875a835824d73e02402fa prerequisite-patch-id: a684974f9b28cd9e77728a2701397ec43eb1b924 prerequisite-patch-id: 907c96345848d2412a52e3c819a2e7f23dadf2e8 prerequisite-patch-id: 743555a609ce940d60bef70239f3a343e7728538 prerequisite-patch-id: 02a0aecd4f35b17cf18fe2bbefb8351b002f0758 prerequisite-patch-id: 100395e419ab8f34297a225b09790ab164503819 prerequisite-patch-id: a643606e91d3d9e26c201ac548781c3dd681cfbf prerequisite-patch-id: 6251c5780a23f465765c0fe99dff91c1b650bc4d prerequisite-patch-id: a93ecc6c9fea0f862a25ae1905b15c6e3019de67 prerequisite-patch-id: 39a686620fec6dd9f0dc5dee02492391b40c5784 prerequisite-patch-id: bfb191d2c2e504d6f5d3aba89dac4c092b41b4c6 prerequisite-patch-id: ad344284c5c86bb7165e31e74613016ea88dd350 prerequisite-patch-id: ce8004b812d523cee9a164492958084660b862de prerequisite-patch-id: 0a15c680f1915b9c393f37a940ef5250dd378a1d prerequisite-patch-id: e7bfa7e3dcaf1e007fe55690e0a649b40bd02ff4 prerequisite-patch-id: 91b5c05f4ed9de44ca6eedb6955076a3c7721cdd prerequisite-patch-id: 94b5b61881f77c643a0d974a8716aa38feba6f7f prerequisite-patch-id: 12496373563bece7cbc951fda0f9544662f97746 prerequisite-patch-id: 94fd500b9a233a8b98592b68c01726d2c379debd prerequisite-patch-id: 76f762b24e013aabe2da2d5f8d4705b4d93b4970 prerequisite-patch-id: e4a4048a05a33eb8014250c4750159f6f9aa9884 prerequisite-patch-id: bae47578a5b697a3a74af34bf8e32d42ff1467aa prerequisite-patch-id: 5fb108815c9dedd829e7b124f0217eebe55d4858 prerequisite-patch-id: 149f495240146f7e24b611452db0e9013143056a prerequisite-patch-id: 459e11365cd3a343570a908a22c0e2aba3a58f09 prerequisite-patch-id: 5c88c28af5317f5342448b30267c4423726167f2 prerequisite-patch-id: 4d0443def5d0bc8aab514e0df86f001dda19ba2b prerequisite-patch-id: 9d1ad455f0cfdf22eade1c469a3c5b700603cad7 prerequisite-patch-id: 60c4b855690f700c6fc9edc6e0c61bd553fb20fb prerequisite-patch-id: 8f3af07731497a073f5bc421a26bc9889bbb62ce prerequisite-patch-id: b464542aee48a0ae9593185074cc7b66d75b36ed prerequisite-patch-id: b838bdbeceeec178d52cf544b4c1c784b458ae7d prerequisite-patch-id: 0f3961d4fea2f6b2d305e2ad500284c84b8d10dc prerequisite-patch-id: 26f6a0af3443ca07e0c20e5913c334aca3c209d6 prerequisite-patch-id: 4cd07ca6b74c163c3c762a5e956447b47b580369 prerequisite-patch-id: 4d34cd2070170fdbd86c84a455526bd12d941964 prerequisite-patch-id: d5f5089cf771ba0b76bfe6805abfe631d07c29dc prerequisite-patch-id: 9c13e9b901aa38db4cc150f227ddc9557ec5e511 prerequisite-patch-id: 9f5a14c05bb1a6dff24936d0f6702ca4993d775b prerequisite-patch-id: 458f5f792f7a019572a33ab49fc11c12ecb42472 prerequisite-patch-id: d93592a3623b23e76eb4cb37661d029433257eec prerequisite-patch-id: 068ca74f1ff9a38d4a3fedd6d91df582082e5ef4 prerequisite-patch-id: b940c60f2bf310201d566eab1b2e8a359a9bbaf4 prerequisite-patch-id: d628e14aeb629e70c99bd4c010a88a162ecbd5c0 prerequisite-patch-id: 5d6eddbbdfdd8fa4c8ea8d9621f0c2a23e130743 prerequisite-patch-id: 62332e6f9cefb59b437fe48f776221efa7281040 prerequisite-patch-id: 88bc78415d0c4b8a8323e20dcf511fa66af330c4 prerequisite-patch-id: fcbfc689c5711d222caa29c07053bf31eb4b91cd prerequisite-patch-id: da204ba21e647383281cfaf2a6c70ee1fa58e5a5 prerequisite-patch-id: 63b677332671f61d07929b9095bd0a74f3efe60e prerequisite-patch-id: 62d7b58ff66835200f5d83c3d4c0672b2633049a prerequisite-patch-id: dcd16fdaa2af61501818a4ea4323ca5c91a1127b prerequisite-patch-id: dc36b4bf9fd3ded6a39706107b265f93b80fe370 prerequisite-patch-id: 770a07cac55179ba07166ad048c97e86f4b13670 prerequisite-patch-id: 8d34c2ba148b861bec3a485a6543135698296886 prerequisite-patch-id: cc88568c0587fd723bdfa4c5358a5a9d6984457e prerequisite-patch-id: 1f016e814fb174e06d6b33ec07b0f95471cabf19 prerequisite-patch-id: 2c69132dce6ba24fa402a2b1c379a5b5c387dd7b prerequisite-patch-id: 2c5168b75d80a01bf0d6815f0055ff3ec30caa44 prerequisite-patch-id: e615055c1c3090731090aed42f05eb5d1fb6564a prerequisite-patch-id: 4caa2472b4c06ae0c8011b049197bedad5f5228e prerequisite-patch-id: 452f33dd740f65beb7e22e0ca81baef5457c82ab prerequisite-patch-id: c74579d2771af9098e24557c10ab3e4140746b75 prerequisite-patch-id: 7e84e3d0892975c807f3773d07424237c9639483 prerequisite-patch-id: 712126549fa65ec1babbb8710314319d5875362d prerequisite-patch-id: 43441e3a86f3c1711afcbf14df5ecd7a0b0343be prerequisite-patch-id: cae4bd98106f640d76904270244b1bf1315bcb1d prerequisite-patch-id: c9bf6829217ab6b460b522fb1252dcb6b39a71e3 prerequisite-patch-id: 59b16e880553456851031fde64db1060f36bb125 prerequisite-patch-id: 61cf441c09658a605c09e2afdfe6a0ed644153a5 prerequisite-patch-id: 20920fe50dbd3a4f8b28d8c08a18011efc020d0d prerequisite-patch-id: 408b7758d3decd92387ff19446590f6339c948c7 prerequisite-patch-id: 7bcb962bbbfb07ae864e005276b7629f5dd2a2a5 prerequisite-patch-id: 53d89343a81a8ef4a47b9ec5c34a7795930f3221 prerequisite-patch-id: 50a2ff5650b9bbbb111333e72a3180c9220c93b1 prerequisite-patch-id: e5587d038c63f97f5821c7d64e64968f6d23f18b prerequisite-patch-id: ebec5c6bcebd6ee0b34e02efb63e16e0c689e96e prerequisite-patch-id: e58d6eb187ba7a726cfc8fcbc02c636c63eeb01f prerequisite-patch-id: ff82775fa0be79e3ca23e91e15cf8b6d3934261a prerequisite-patch-id: 6cffdf3b490683f50f1478b02d7ec50982b52443 prerequisite-patch-id: 9f76593f3984482bb0c191a3c1753a8bc74a1bb5 prerequisite-patch-id: 91dd68bc14f8c88f82515077f229f67a91c47c98 prerequisite-patch-id: 564f47441f415c0f6a31ba97c4993824868a4c51 prerequisite-patch-id: 0f8321acaae45c42001a03f64fbda7c7789da377 prerequisite-patch-id: 9f529cf0218c6d6241bd1702b4be370fc30a71fa prerequisite-patch-id: 7bf436492ad84783eceb860aaada2f2820c205cc prerequisite-patch-id: b2dd4888a77f0d7e5da5be8ad13561913e818c9f prerequisite-patch-id: a18a8ee540d5ddd13367e0dc4a5a4608f9f87410 prerequisite-patch-id: a7de718aa40a43dffc015eea1c9aabe54ad853b4 prerequisite-patch-id: 3b7026bcb6dc9045ffcd88003ae80a969840b17b prerequisite-patch-id: 827b7210126c3e4af59768f027e8d9f0d9d9b88b prerequisite-patch-id: 1b04fe7abb2801551192579eaf449ec0575879a7 prerequisite-patch-id: 04c43ab1383ff99a18f125bd9494ce5e348d39c0 prerequisite-patch-id: 2ec07e430ae6410f1cbb515c7c94dfcbf48deb9d prerequisite-patch-id: 19d90156bd1b798376c1b48e8d97cb2e10e052eb prerequisite-patch-id: 83ad7de8b7d2987a67e2702d5b2a4e10dbfb8b88 prerequisite-patch-id: acb7e450a5c776f8aed85fee56ad4cd6eaa272ed prerequisite-patch-id: 9efbb939415534e6ac18e0bb1a7e44fafa309e92 prerequisite-patch-id: c779017f15fc711a693fde48429b9410b6b0703b prerequisite-patch-id: 6bae6f8cedbea090582ca108fa785f4ffa72194d prerequisite-patch-id: 6d440be966ddb0c5ec25209e2add9eba9281e602 prerequisite-patch-id: 2f5fff666441ab39aa5a41ff04a2008a5910131d prerequisite-patch-id: f3010317857ccda72dfd26c60517ecf2d7d68045 prerequisite-patch-id: 49c6204f732cb27ff947d27aedf919a76227396f =2D-=20 2.46.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmbokIQACgkQdtcnv/Ys 0rWncA/9F28gZhSV0QWBjBBjoJuWfq5DL5L1Oco4WFdFt4n1euaA6KOW1WDpv6ZR Qmjz5CSrnjsAWyXAQNNw/M3Aymfo4xki1AHp2D1HkAURjVCjplhFLzvwE7AG2bMV 9n0LOblhxoO0jfFEYLBv3Io+27/eg6/VeQeD3s/3a3sYz0+pJgKvSkaHH6kTiTRN gPHeob60Djg2wxsXMXUzg2/fMyHL1UBsS8FlU8NiV7Qe1/A8uhVLnzcj6hXuS83v sWC7URK6FTpVNraUuqdgcHn1tbcdhcEoCyg9oXMedAUPYmOA4z+jsfmbRO3sFEkP YfBt9QCYwaB/Hd6ypF2pbiiSN+P9EsxJTtu3wHSs9C37bAVU59MigWuMqBCOfGaK ste4oVhV9B0sU3MovveF01YgTUL+NsZPIxhaIyh6mypaVdJpoQW3Zph8kxWEaKLR UJ4xa2JDUYgkjJig9S1lfbPrdOSuLutZaWh2exF/8vKla4PSWDbd8kUJ+dShfpzP lEIRrGfiHSDRuIGFW2frzZikoRm8hoqMOJMopo7RyHeHoE67vDlurmNLImcBIO+H 3qqjsGp7uZ8kaIwyDPoGz34xwoLxU2J+Yf12HzyjygF8SHbEBt1sTydj4d0xSgTQ jiW3cOzXG9s2G3CI05aqQOyvvnHEqaBY0F10Kh38rF4qG1D1Dz0= =PrFj -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 16:12:20 2024 Received: (at 73299) by debbugs.gnu.org; 16 Sep 2024 20:12:20 +0000 Received: from localhost ([127.0.0.1]:53373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI55-0005gq-N4 for submit@debbugs.gnu.org; Mon, 16 Sep 2024 16:12:20 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:47330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI53-0005gO-I9 for 73299@debbugs.gnu.org; Mon, 16 Sep 2024 16:12:18 -0400 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-42cc8782869so48012645e9.2 for <73299@debbugs.gnu.org>; Mon, 16 Sep 2024 13:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726517458; x=1727122258; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3Kj8BT4AUHJ9JDxzokJowT6d9gHG7Quxxhgng0mENRw=; b=BCyHppONxZQsO3yGd9bJ5c1XgcJIUNfuCBfZsHU4qOyWV3cubzjOFvmQ2qcW9P215X OjTBttfFl1pbKT0GlJ9+52jsFl76ies7oZANs0waK1Syg0jJIA/+Y2toek02KHggEzSd F1roJyyE8dwktew6415z5xmOrmuaInco4Zwg2aMEey9a/kPDsWT5cwUM24IciduoUpWI WffBwCMMFZ7mE5EWB677hGrP/Jc+jYi4ti9rfz+TIo69pQDoa4FSDCP+kREgxnrHtRpn 1YGfz02m/guCwgkzkf2ckoBKI7Dzk/yWjeGUbuHl50FuXzWbvpVzWwuER+oFW5v/i6vB kbKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726517458; x=1727122258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Kj8BT4AUHJ9JDxzokJowT6d9gHG7Quxxhgng0mENRw=; b=VkzVVeTjzrYPeZyGSOGb+2sQ1Wq4zRDFtoRDA/LizkYndgaLMRgdUq++FNKNHlsncb ksaw/OTHv2z/AbKmVqQB046+a0NYOsM5UmmHNfRwbmtKvvj2I7EFEDExte9ZAgi7ODk9 yuIYRfv4R9ov7pwbsJpzzFzTK9PmbsmyP6YLVAkprguuNC+D4OZmJPqjoGoNJifX2hsW lr7w+I17kPfLOubWNHYL2A9D39o5+nMRbFjj/i2vCD/lb5ISY5votc1B7G4eWBKv/rDI zG9UzPsXgpHk7AYF2E4wW4SvOQcWKLNdM/enZtqLYcJg9CeuJ6P8ENG9Tz4XCz12VxCP UEQw== X-Gm-Message-State: AOJu0Yzx7k4hbT+6VDRSn4fYhzNKkWfj7yxVR4QFCDna+pVgpdPNkfQp MbS0jDsnE4t+QY1kYcxQitSDFITwQW0ox/IEfXMIBiwPvS3Dhr1mwepM1Nji X-Google-Smtp-Source: AGHT+IFnGEef0a5o2YJPNsXUaCJ5HnTdcwtUKaoexME7k05AkZZ8Z8ATHSdvvENCbxspTZ6OILRJrQ== X-Received: by 2002:a05:600c:4f0f:b0:42c:b9c7:f54b with SMTP id 5b1f17b1804b1-42cdb548b63mr151504685e9.16.1726517458131; Mon, 16 Sep 2024 13:10:58 -0700 (PDT) Received: from guxtil.incerto.xyz (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73f62bfsm7922576f8f.51.2024.09.16.13.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 13:10:57 -0700 (PDT) From: Sharlatan Hellseher To: 73299@debbugs.gnu.org Subject: [PATCH v2 2/3] gnu: go-github-com-prometheus-statsd-exporter: Remove redundant phase. Date: Mon, 16 Sep 2024 21:10:49 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: Sharlatan Hellseher X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/prometheus.scm (go-github-com-prometheus-statsd-exporter) [arguments]: <#:phases>: Remove 'fix-embed-files and relay on standard one. Change-Id: I1bc965c65bcd40fcaef7d0ace9943a01ef08bdd3 --- gnu/packages/prometheus.scm | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/gnu/packages/prometheus.scm b/gnu/packages/prometheus.scm index fe2fa18e95..a81932f62b 100644 --- a/gnu/packages/prometheus.scm +++ b/gnu/packages/prometheus.scm @@ -572,29 +572,7 @@ (define-public go-github-com-prometheus-statsd-exporter (arguments (list #:import-path "github.com/prometheus/statsd_exporter" - #:phases - #~(modify-phases %standard-phases - ;; TODO: Implement it in go-build-system. - ;; - ;; This happens due to Golang can't determine the valid directory of - ;; the module of embed file which is symlinked during setup - ;; environment phase, but easy resolved after coping file from the - ;; store to the build directory of the current package, see details - ;; in Golang source: - ;; - ;; - URL: - ;; - commit: 82c14346d89ec0eeca114f9ca0e88516b2cda454 - ;; - file: src/cmd/go/internal/load/pkg.go#L2059 - (add-before 'build 'fix-embed-files - (lambda _ - (for-each (lambda (file) - (let ((file-store-path (readlink file))) - (delete-file file) - (copy-recursively file-store-path file))) - (find-files "src" (string-append - ".*(editions_defaults.binpb" - "|landing_page.css" - "|landing_page.html)$")))))))) + #:embed-files #~(list "landing_page.css" "landing_page.html"))) (native-inputs (list go-github-com-stvp-go-udp-testing)) (propagated-inputs -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 16:12:23 2024 Received: (at 73299) by debbugs.gnu.org; 16 Sep 2024 20:12:23 +0000 Received: from localhost ([127.0.0.1]:53375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI59-0005h1-2X for submit@debbugs.gnu.org; Mon, 16 Sep 2024 16:12:23 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:51414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI53-0005gN-Fq for 73299@debbugs.gnu.org; Mon, 16 Sep 2024 16:12:18 -0400 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-374c326c638so2162022f8f.2 for <73299@debbugs.gnu.org>; Mon, 16 Sep 2024 13:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726517458; x=1727122258; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uwNXy6E6Ykc9mYCUXtFnfwhJAsQynkcndhUi/wF9RKE=; b=WZV7WKATZWrx+jn6ZvLHSt/5DogasAyIX6yMLQX8US8zEUbpnSCZDURdTGE5N2xIuD YfPNpF1QdK4FLjCHW6xONzdSpQxfWyFFrhEBRX3upm/wB5u093OCQOXXkGUJIa9Bt76F NHjBgdt+72RxBSIktBON3cY7sL3E4ymG7YC31v66V577a7LV9qxEvSEaTblmrJqAXovM i1R1s+BwpMBYUrhShNMOmu+xb2dpNgzQqbLFmWN0K8PH3G/iIIMAPGOmnj7Kb16ARCTM ZzVPhaqqUFkX5BJMonDjAg4LQZeV1XybHST8RF5mAMXX6F7wfUMYYHYKV+c4/POS2pOV MEVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726517458; x=1727122258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uwNXy6E6Ykc9mYCUXtFnfwhJAsQynkcndhUi/wF9RKE=; b=A/lleKt5gpa/u2gJHVe/9t8Ztp3ykM56HI8CLhmwsp0LzHxpj9ST9xAUm0pySi2mKP ipgXlXCAX19va23R/PVOyrVjB+jzAmYkWjxGceZqSJ8USQPByFKsDquKPf4qwY0lTnok bj1qJHjb1rgHyxi/KPNzq8ETboJDKHbVFvSjNEusNHBFhvdGL/x2/3oCKynFOcncsk97 mhdKxrgf7a62BSBvlTjAKIZT/jjxq+F26TndT7mPd+dD4dB/FvprKl165mUvw0eLTAxi H6+0MGEpIDxLRJVExztrvfGTcEwWs8B6f8t0NrSrdbX0AOCL+NiA+7jOjn2AHw0RZzIN QMRw== X-Gm-Message-State: AOJu0YwNENxu36/mwuRgReHIqSGsIX1S6wtSooQhUg2THH4QOb/pN6Od KRyOEePTT+A65vmlSNsbVLpYnqLS0VN6wHiysldHfiIqJ7owkwkxr12i3gdA X-Google-Smtp-Source: AGHT+IFg9jSEjGwal4XUGYqAeRtkNK+f7oSoyGHybgo25dkOc/ryx0HRrDSgytreOYrYKvpRmp6aMA== X-Received: by 2002:a05:6000:1049:b0:378:c887:5874 with SMTP id ffacd0b85a97d-378d625b559mr7116858f8f.59.1726517457088; Mon, 16 Sep 2024 13:10:57 -0700 (PDT) Received: from guxtil.incerto.xyz (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73f62bfsm7922576f8f.51.2024.09.16.13.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 13:10:55 -0700 (PDT) From: Sharlatan Hellseher To: 73299@debbugs.gnu.org Subject: [PATCH v2 1/3] build/go: Replace symlinks with a copy of the file. Date: Mon, 16 Sep 2024 21:10:48 +0100 Message-ID: <870204639eb63370aae42e86364899d333064749.1726516329.git.sharlatanus@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Katherine Cox-Buday , Ludovic Courtès , Maxim Cournoyer , Sharlatan Hellseher Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: Sharlatan Hellseher , Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Efraim Flashner * guix/build/go-build-system.scm (fix-embed-files): New procedure. (%standard-phases): Add 'fix-embed-files after 'unpack. * guix/build-system/go.scm (#:embed-files): New key parameter. * doc/guix.texi: (go-build-system): Document a new key. Co-authored-by: Sharlatan Hellseher Change-Id: I27bc46fa1a3f4675ff73b6cba4ef5c3d177c22b1 --- doc/guix.texi | 8 ++++++++ guix/build-system/go.scm | 6 ++++++ guix/build/go-build-system.scm | 30 ++++++++++++++++++++++++++++-- 3 files changed, 42 insertions(+), 2 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 4abe258af0..e780bde6cf 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -130,6 +130,9 @@ Copyright @copyright{} 2024 Dariqq@* Copyright @copyright{} 2024 Denis 'GNUtoo' Carikli@* Copyright @copyright{} 2024 Fabio Natali@* +Copyright @copyright{} 2024 Troy Figiel@* +Copyright @copyright{} 2024 Sharlatan Hellseher@* + Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.3 or @@ -9580,6 +9583,11 @@ Build Systems @code{#:test-flags} parameter, default is @code{'()}. See @code{go help test} and @code{go help testflag} for more details. +The key @code{#:embed-files}, default is @code{'()}, provides a list of +future embedded files or regexps matching files. They will be copied to +build directory after @code{unpack} phase. See +@url{https://pkg.go.dev/embed} for more details. + @end defvar @defvar glib-or-gtk-build-system diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index e6e8b84e48..97581a14c6 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -6,6 +6,8 @@ ;;; Copyright © 2021, 2023 Efraim Flashner ;;; Copyright © 2021 Sarah Morgensen ;;; Copyright © 2024 Christina O'Donnell +;;; Copyright © 2024 Troy Figiel +;;; Copyright © 2024 Sharlatan Hellseher ;;; ;;; This file is part of GNU Guix. ;;; @@ -197,6 +199,7 @@ (define* (go-build name inputs (outputs '("out")) (search-paths '()) (install-source? #t) + (embed-files ''()) (import-path "") (unpack-path "") (build-flags ''()) @@ -226,6 +229,7 @@ (define* (go-build name inputs #:substitutable? #$substitutable? #:goarch #$goarch #:goos #$goos + #:embed-files #$embed-files #:search-paths '#$(sexp->gexp (map search-path-specification->sexp search-paths)) @@ -264,6 +268,7 @@ (define* (go-cross-build name (system (%current-system)) (goarch (first (go-target target))) (goos (last (go-target target))) + (embed-files ''()) (guile #f) (imported-modules %go-build-system-modules) (modules '((guix build go-build-system) @@ -297,6 +302,7 @@ (define* (go-cross-build name #:target #$target #:goarch #$goarch #:goos #$goos + #:embed-files #$embed-files #:inputs %build-target-inputs #:native-inputs %build-host-inputs #:search-paths '#$(map search-path-specification->sexp diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 3f0f5700a1..14cb5ae687 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -4,10 +4,12 @@ ;;; Copyright © 2019 Maxim Cournoyer ;;; Copyright © 2020 Jack Hill ;;; Copyright © 2020 Jakub Kądziołka -;;; Copyright © 2020, 2021, 2023 Efraim Flashner +;;; Copyright © 2020, 2021, 2023, 2024 Efraim Flashner ;;; Copyright © 2021 Sarah Morgensen ;;; Copyright © 2024 Ekaitz Zarraga ;;; Copyright © 2024 Picnoir +;;; Copyright © 2024 Troy Figiel +;;; Copyright © 2024 Sharlatan Hellseher ;;; ;;; This file is part of GNU Guix. ;;; @@ -28,8 +30,9 @@ (define-module (guix build go-build-system) #:use-module ((guix build gnu-build-system) #:prefix gnu:) #:use-module (guix build union) #:use-module (guix build utils) - #:use-module (ice-9 match) + #:use-module (ice-9 format) #:use-module (ice-9 ftw) + #:use-module (ice-9 match) #:use-module (srfi srfi-1) #:use-module (rnrs io ports) #:use-module (rnrs bytevectors) @@ -201,6 +204,28 @@ (define* (setup-go-environment #:key inputs outputs goos goarch #:allow-other-ke (delete-file-recursively tmpdir)) #t) +(define* (fix-embed-files #:key embed-files #:allow-other-keys) + "Golang can't determine the valid directory of the module of embed file +which is symlinked during setup environment phase, but easy resolved after +coping file from the store to the build directory of the current package. Take +a list of files or regexps matching files from EMBED-FILES paramter, failover +to 'editions_defaults.binpb' which is a part of ." + ;; see details in Golang source: + ;; + ;; - URL: + ;; - commit: 82c14346d89ec0eeca114f9ca0e88516b2cda454 + ;; - file: src/cmd/go/internal/load/pkg.go#L2059 + (let ((embed-files (format #f "^(~{~a|~}~a)$" + embed-files + "editions_defaults.binpb"))) + (for-each (lambda (file) + (when (eq? (stat:type (lstat file)) + 'symlink) + (let ((file-store-path (readlink file))) + (delete-file file) + (copy-recursively file-store-path file)))) + (find-files "src" embed-files)))) + (define* (unpack #:key source import-path unpack-path #:allow-other-keys) "Relative to $GOPATH, unpack SOURCE in UNPACK-PATH, or IMPORT-PATH when UNPACK-PATH is unset. If the SOURCE archive has a single top level directory, @@ -321,6 +346,7 @@ (define %standard-phases (delete 'patch-generated-file-shebangs) (add-before 'unpack 'setup-go-environment setup-go-environment) (replace 'unpack unpack) + (add-after 'unpack 'fix-embed-files fix-embed-files) (replace 'build build) (replace 'check check) (replace 'install install) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 16:12:24 2024 Received: (at 73299) by debbugs.gnu.org; 16 Sep 2024 20:12:24 +0000 Received: from localhost ([127.0.0.1]:53377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI59-0005h5-Q9 for submit@debbugs.gnu.org; Mon, 16 Sep 2024 16:12:24 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:43292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI54-0005gQ-Dk for 73299@debbugs.gnu.org; Mon, 16 Sep 2024 16:12:19 -0400 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-374c5bab490so3976771f8f.1 for <73299@debbugs.gnu.org>; Mon, 16 Sep 2024 13:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726517459; x=1727122259; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GuHxGFYkzH+Na8JNM2sh7ZwX15dtgmJlmQPcfytYcSY=; b=PsjOkQMkdjH1QJ+AF1BhEOvlNJmNr/GcVLka5ejqATOewmuWMw38oMZZlTL0ebDAAq pEnrF+9ull8givzJqGghaiRbaRUG2Kcy4bI7Tr2nH3ygQFaT+nifgIBY3LLA4Ax9Xv/v DdwMY6/H5LIa0RDqDeDtcXuhmtDcbEMrELL0iywtWyF8Sh6xXfM1uziYJCeaqZrKVoXM aCUSIxJEMHI/UhKUmb4+kEyVIIDV0YVisIOssk/SWX3c9DE1J6fLM0AVCvJZ7XYQitqu Zl/SOaJKvtmqwpKQJqBLvBqPHpuvZwgQIKHUvhVMs9c0Zi6a5V3PSKdIScPcMyX6QNK/ ysqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726517459; x=1727122259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GuHxGFYkzH+Na8JNM2sh7ZwX15dtgmJlmQPcfytYcSY=; b=trbX/auwUx36qacbcbfM1rb51JddSBf3/hOdJRvpwHkHnL4KjO9MhEmjAK4VgcdqwP DpZ1t9eZzVgU0QDac4jPUjdiE8wQJKpObNrZ/8v1tx/JepB1Cobb680BpaJRoSOFq4FY QX7jVxnBUe6bxVR2cSQ/5a7CuF2QMpZEblH2KPxSILI3hEcasfn77AAHF+5QXw7ne1xG lwKsWvt/E62HUPtadmPP/RxhbzUaaQS+QhuK3wt5fQLLPQ4t6VuLNCGNejGJxFZi8PqT JKA2hzcfWxkCUWSnDLYHs56bucUi6LlN5qVyNUwKvDbHwZVweW6Wpiy7Jk07iE9DPKLh fS0Q== X-Gm-Message-State: AOJu0Yz66EPYeafh2a0xabc8l787FOtND0Crk3KgNJHp6IZCyK3YP24N u+sbw1mbetp8nXWClg2QeVMENjAB7hVlbRcBDPkK7+guLewKvy74hRpcIYOB X-Google-Smtp-Source: AGHT+IFr4bn+GjaDoJ6tbUKFdZmccbQ3TEmLjYU3yOO6kkdrkFuBcNdwgbTS1Ctm/GX1LDsc3A6uNQ== X-Received: by 2002:a5d:598a:0:b0:374:c6b6:c656 with SMTP id ffacd0b85a97d-378c27f94bbmr11872014f8f.21.1726517458855; Mon, 16 Sep 2024 13:10:58 -0700 (PDT) Received: from guxtil.incerto.xyz (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73f62bfsm7922576f8f.51.2024.09.16.13.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 13:10:58 -0700 (PDT) From: Sharlatan Hellseher To: 73299@debbugs.gnu.org Subject: [PATCH v2 3/3] gnu: go-github-com-golang-protobuf: Remove redundant phase. Date: Mon, 16 Sep 2024 21:10:50 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: Sharlatan Hellseher X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/packages/golang-build.scm (go-github-com-golang-protobuf) [arguments]: <#:phases>: Remove 'fix-embed-files and relay on standard one. Change-Id: Ife4d86e8072588d562364534a66d41ff01851361 --- gnu/packages/golang-build.scm | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/gnu/packages/golang-build.scm b/gnu/packages/golang-build.scm index 8fdd652b63..7049acf8c2 100644 --- a/gnu/packages/golang-build.scm +++ b/gnu/packages/golang-build.scm @@ -103,24 +103,6 @@ (define-public go-github-com-golang-protobuf #:import-path "github.com/golang/protobuf" #:phases #~(modify-phases %standard-phases - ;; TODO: Implement it in go-build-system. - ;; - ;; This happens due to Golang can't determine the valid directory of - ;; the module of embed file which is symlinked during setup - ;; environment phase, but easy resolved after coping file from the - ;; store to the build directory of the current package, see details - ;; in Golang source: - ;; - ;; - URL: - ;; - commit: 82c14346d89ec0eeca114f9ca0e88516b2cda454 - ;; - file: src/cmd/go/internal/load/pkg.go#L2059 - (add-after 'unpack 'fix-embed-files - (lambda _ - (for-each (lambda (file) - (let ((file-store-path (readlink file))) - (delete-file file) - (copy-recursively file-store-path file))) - (find-files "src" ".*(editions_defaults.binpb)$")))) ;; XXX: Workaround for go-build-system's lack of Go modules ;; support. (delete 'build) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 09:28:18 2024 Received: (at 73299-done) by debbugs.gnu.org; 19 Sep 2024 13:28:18 +0000 Received: from localhost ([127.0.0.1]:60059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srHCk-0007HE-Ir for submit@debbugs.gnu.org; Thu, 19 Sep 2024 09:28:18 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:54390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srHCi-0007Gr-Eo for 73299-done@debbugs.gnu.org; Thu, 19 Sep 2024 09:28:17 -0400 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-42cae102702so6963105e9.0 for <73299-done@debbugs.gnu.org>; Thu, 19 Sep 2024 06:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726752412; x=1727357212; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=uBxLxQWkzsLzrk41nvg13eFolwSKSPGjE+UZzBi2ni4=; b=T2Ek7qiGMbZ6AVMFwYYYXq+4el8zOoex0tZiFrNtmppE0VN3HcyhLq5635CmAXm/7A robjVzsFh3SBLFLdgTiA2YJ6DwwTvejENMZ3ngDCh8ze9rzxxYS8jpYfkSq1mIo0LTjp 1dO3Vusj62kssNMmZnKxk34T5K5K5lyZi+0E9nJBtzJXaZeWXN9u4PXzXi4FFHi6U20i Eiz5vQb3Iq+MVugorMyuW75wxJkb6W/2qhc2XRG0GOTbcUR4+fTINs93bKFzTmo9exhI 9SHyfj3Xj33w9JA0sD33qQChDx1MwMkmFOgAzU9ZOuZAzqe/mAFQ8mVKWigIdH3dh5HZ uAtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726752412; x=1727357212; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uBxLxQWkzsLzrk41nvg13eFolwSKSPGjE+UZzBi2ni4=; b=djVEocDpyEy25W3W183zo9M6ab/9F1yJoXGO+N4Sgub7xG5HuvDBfU9n75Ed2u+UT/ r8Ru64A35Hk2dk+IE+zSw9hhzHcPwbItS2aZn3YFmDOryLwCD0jY3iCRRWoLnlwErNoO CHBuW4+G0Ec3XxrVuoQ/9S+CguMKahRUGdAf5Jac2BHfWowbCdYzwAn56jP1YLWvTtJI H10GzLWxy0PrWRYOB1OY5YlPQoSi6+J5fSzwp5GxXvmRjF+srnYOSurkqzNdvfBWjocL l9j5p2hqjV3bHLy68quBDk2IrhMwJEI3kIKhnEVHM7jaxS9w57K/IAe722swJC8tBxXJ snGQ== X-Gm-Message-State: AOJu0YzeIOKqp5XXVJijXrIAAWAv0zcYnZex41yMrxtVqCojDFLSuI5Z ZWX8LljvaoTJF7/nXk0kaUAbZPpj7c/R9PgK1GLyFDAslyhmd5MT8TXf5Eef X-Google-Smtp-Source: AGHT+IEI9FSFUiknMxwW7eX/dtAHgrFL8Ray6mQBzkf00praKn7Pbsak8ZMYawmNnt/uRzMW58UeuA== X-Received: by 2002:a05:600c:468a:b0:426:6326:4cec with SMTP id 5b1f17b1804b1-42d964e0f42mr157922475e9.29.1726752411856; Thu, 19 Sep 2024 06:26:51 -0700 (PDT) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7544455bsm22084715e9.25.2024.09.19.06.26.50 for <73299-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2024 06:26:50 -0700 (PDT) From: Sharlatan Hellseher To: 73299-done@debbugs.gnu.org Subject: [PATCH] build/go: Replace symlinks with a copy of the file. Date: Thu, 19 Sep 2024 14:26:49 +0100 Message-ID: <87zfo34vvq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi, Pushed as: - 272cdbb16d * go-team gnu: build/go: Apply default 'fix-embed-files phase. - 870204639e * build/go: Replace symlinks with a copy of the file. to go-team branch. -- Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmbsJpkACgkQdtcnv/Ys 0rXjhQ/6ApGIMsW5xIE1A/VOGx5G37ZlRv7+QiCwrHzcUGZEMf8zz3rhJpSMDNXv oZOe+d8lOyLbTMDSkHw/gmJTuGqh7T4qum7i2zTKZEC9ng7vkNlihx2ongyDf1dw 5/ccaFn54fHMBee8N4tregtjKWUyjFgASqnU6dlQD5I8qayin36m4KTUxThGG62U JDyRocA5vBDhC+6MxZArX52nrFoSVRluVZ58XAfFKVm8eov6OTAc9Y4bWsispeIG VZ94jkqu1+N6rf0FVt5Ybt9AwDjaTbcfsmazDeoUtQKOfnl9cyeVrOWyW0Q3viwM 1X4PufpPrlE5pKlYwnXx8whbOYqfV7gvqSh4fRFvofZwleJsdNFL9yFwcw6i7jOw 5n3EMqfRjjSSRcQc/ptSOkskNcbTwvzPVQJFJf9gcLOMrOCNvA23FA2OmCsfUY6N 6qHkTVcyWiIABC0Fl3TpaIUkjgVqpmwGSesfAVbsf9i1hF1SRSXujzu9VKn3pU/i 1Y3v642S3+UJHoCy2zACwbrRS/4gIZbiSDyLwqLJKjreHUFI+ueSvY9ATXFp0snz p7daQga5w0wAEl8qhOUR1BZ/s3CIrN1TQDxfCDAqLmY2xR8jM+ymJMjtoHj48swP ZCPQpk4H414daqs6pFIwF2Ol10wYFyxkNfB6lPV/V56XVzE3dPU= =Bkf/ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 09:24:04 2024 Received: (at 73299) by debbugs.gnu.org; 26 Sep 2024 13:24:04 +0000 Received: from localhost ([127.0.0.1]:33597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stoTT-0007d8-TH for submit@debbugs.gnu.org; Thu, 26 Sep 2024 09:24:04 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:44056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stoTR-0007cb-Af for 73299@debbugs.gnu.org; Thu, 26 Sep 2024 09:24:02 -0400 Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2da4e84c198so761163a91.0 for <73299@debbugs.gnu.org>; Thu, 26 Sep 2024 06:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727356948; x=1727961748; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eolKqvcdiBccxYywBpHpMijJ1ePyTd86xq628zf4GBc=; b=ZrYX157LPf/RafF4pnq9v3UYj0X78glL+SEBvQlgMyVxXdUpE0CeWq46TlZz600krS fczMRQwmGO7tjVqtrg9VsxoOQATr/9cIeoqfyrmQ2bL3h9gngjcwDHDPAeEsTTf062sT /5bHOE7Bu+WyUA9OtDGxwuccCztw+VhbouHA6ZLFi0LRqFvtf8Fvs0Kvr/9ftzFHfASg XHPElluqg1RkQByk2g6uUfSOAqcFwNad2clmHt+UkTVfeSV0zZbZBd6OIVwSJq7rh/to YVKo4wP8dqAUfvpgpXKitIHYcXppfgU6YHiD6oX5V92s9uHg2pSRsqbT5zVp+qLIAH1P R33w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727356948; x=1727961748; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eolKqvcdiBccxYywBpHpMijJ1ePyTd86xq628zf4GBc=; b=gKqiPRrjTwD4vpBqANmmn6PXaaWGdRkiE7vJcdeBWDTfOGjsCXlTTNL42THd8LVx2r zsF5lalerafDe0uhOsUNVxxC7eUXXtZmqEP7GvpiC/+orfvSrYdk5iKooA9pY8mLDty4 l1YtZ7Sm3CefbeCQ0j10Hr6O6O4SEELWg5SlgVNHA/NTXg3jEWddDVpgo50gBNsNKUHv pLkpD/GVyrOD8U+pbTGB/B+c5sdeZYO35R89RHGjgiTXyOdCb2usXl2+kI2R9MSZjfq8 zKw7036gMv8FHQAqdUnCEubF2GVU/kptqXG0gjA5/xbo2NnupR8E6uH2gokcuY6dkXQt gxJg== X-Gm-Message-State: AOJu0Yyo1rLskNqF2iKjhf2u/2gMkUvOmW4etmEf3RcQKF64UfV4C1eo oZECWtC+C83n0zxaCIdJMKlBSNZuhkqQ8WHtQuVdHISGIHkswoCz X-Google-Smtp-Source: AGHT+IFK2I/efHY2GyaX8GLWk2jCMjIvVhCzj2bdxrPhLhvpiqLbu66QIPu/XYCx00370vXzMUtufg== X-Received: by 2002:a17:90b:3510:b0:2d8:f11e:f7e with SMTP id 98e67ed59e1d1-2e06ae5e2a0mr5987741a91.12.1727356947816; Thu, 26 Sep 2024 06:22:27 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e06e2256c1sm3447471a91.36.2024.09.26.06.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 06:22:26 -0700 (PDT) From: Maxim Cournoyer To: Sharlatan Hellseher Subject: Re: [bug#73299] [PATCH v2 1/3] build/go: Replace symlinks with a copy of the file. In-Reply-To: <870204639eb63370aae42e86364899d333064749.1726516329.git.sharlatanus@gmail.com> (Sharlatan Hellseher's message of "Mon, 16 Sep 2024 21:10:48 +0100") References: <870204639eb63370aae42e86364899d333064749.1726516329.git.sharlatanus@gmail.com> Date: Thu, 26 Sep 2024 22:22:23 +0900 Message-ID: <8734lmft2o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: Katherine Cox-Buday , Ludovic =?utf-8?Q?Court=C3=A8s?= , Florian Pelz , 73299@debbugs.gnu.org, Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Sharlatan, Some small nitpicks below: Sharlatan Hellseher writes: > From: Efraim Flashner > > * guix/build/go-build-system.scm (fix-embed-files): New procedure. > (%standard-phases): Add 'fix-embed-files after 'unpack. > * guix/build-system/go.scm (#:embed-files): New key parameter. > * doc/guix.texi: (go-build-system): Document a new key. > > Co-authored-by: Sharlatan Hellseher > Change-Id: I27bc46fa1a3f4675ff73b6cba4ef5c3d177c22b1 > --- > doc/guix.texi | 8 ++++++++ > guix/build-system/go.scm | 6 ++++++ > guix/build/go-build-system.scm | 30 ++++++++++++++++++++++++++++-- > 3 files changed, 42 insertions(+), 2 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index 4abe258af0..e780bde6cf 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -130,6 +130,9 @@ > Copyright @copyright{} 2024 Dariqq@* > Copyright @copyright{} 2024 Denis 'GNUtoo' Carikli@* > Copyright @copyright{} 2024 Fabio Natali@* > +Copyright @copyright{} 2024 Troy Figiel@* Is this accurate? Should another Co-authored-by: git trailer be added for them? [...] [...] > diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.= scm > index 3f0f5700a1..14cb5ae687 100644 > --- a/guix/build/go-build-system.scm > +++ b/guix/build/go-build-system.scm > @@ -4,10 +4,12 @@ > ;;; Copyright =C2=A9 2019 Maxim Cournoyer > ;;; Copyright =C2=A9 2020 Jack Hill > ;;; Copyright =C2=A9 2020 Jakub K=C4=85dzio=C5=82ka > -;;; Copyright =C2=A9 2020, 2021, 2023 Efraim Flashner > +;;; Copyright =C2=A9 2020, 2021, 2023, 2024 Efraim Flashner > ;;; Copyright =C2=A9 2021 Sarah Morgensen > ;;; Copyright =C2=A9 2024 Ekaitz Zarraga > ;;; Copyright =C2=A9 2024 Picnoir > +;;; Copyright =C2=A9 2024 Troy Figiel > +;;; Copyright =C2=A9 2024 Sharlatan Hellseher > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -28,8 +30,9 @@ (define-module (guix build go-build-system) > #:use-module ((guix build gnu-build-system) #:prefix gnu:) > #:use-module (guix build union) > #:use-module (guix build utils) > - #:use-module (ice-9 match) > + #:use-module (ice-9 format) > #:use-module (ice-9 ftw) > + #:use-module (ice-9 match) > #:use-module (srfi srfi-1) > #:use-module (rnrs io ports) > #:use-module (rnrs bytevectors) > @@ -201,6 +204,28 @@ (define* (setup-go-environment #:key inputs outputs = goos goarch #:allow-other-ke > (delete-file-recursively tmpdir)) > #t) >=20=20 > +(define* (fix-embed-files #:key embed-files #:allow-other-keys) > + "Golang can't determine the valid directory of the module of embed file ^ *an* emb= ed file or embed fileS I typically prefer 'cannot' vs can't and likewise for 'do not' vs doesn't, etc., which I feel reads more "formal". > +which is symlinked during setup environment phase, but easy resolved aft= er easy resolved -> easily resolved > +coping file from the store to the build directory of the current package= . Take coping file -> copying the file; missing double space before 'Take'. > +a list of files or regexps matching files from EMBED-FILES paramter, fai= lover paramter -> parameter > +to 'editions_defaults.binpb' which is a part of ." > + ;; see details in Golang source: Please use fully punctuated sentences for standalone comments; e.g. : "For the details, consult the Golang source:" > + ;; > + ;; - URL: > + ;; - commit: 82c14346d89ec0eeca114f9ca0e88516b2cda454 > + ;; - file: src/cmd/go/internal/load/pkg.go#L2059 You could use github's raw URL for the file, which doesn't require any javascript to be viewed. That's it! Thank you for working on improving Go on Guix. --=20 Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 09:35:06 2024 Received: (at 73299) by debbugs.gnu.org; 26 Sep 2024 13:35:06 +0000 Received: from localhost ([127.0.0.1]:33635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stoeA-0008PN-H5 for submit@debbugs.gnu.org; Thu, 26 Sep 2024 09:35:06 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:60540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stoe8-0008Or-5S for 73299@debbugs.gnu.org; Thu, 26 Sep 2024 09:35:04 -0400 Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c245c62362so1112370a12.0 for <73299@debbugs.gnu.org>; Thu, 26 Sep 2024 06:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727357611; x=1727962411; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=/N/7L75f7q0oPX23FhJdvwtHFT9TKDcoy6fsRrFZU0I=; b=gN46VEA9+k/XrIvCLYzSqO6qy8a4umzyDGK1YBL0n8MsxWHtHsrj8d3UUPDA2thyyU KJxFBaGhIVwRNVjMR3K7rOf6yl0ld5JLpBpNTV/CZSIZvH67M5ocjUbM7iz9adR7ilM7 dk1kHhJBFRuzqWNv+V+2MA/TPr3VIQDnXOydcEaNCVdtshhjvzDQ22QsvQPoN/BCXavm QflW07q1frs7SU+k+W0VwRIRS+klbC8+D+eOXUOm7k5lMk9cBi5IkGBtFrcbLZSFSyvh qvAYTzhfzB5foU33QaGbKH2wphh55EQrVEt/TfvAlsnRSjfYI90B2q0vRs5a8cYe+faz 0P8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727357611; x=1727962411; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/N/7L75f7q0oPX23FhJdvwtHFT9TKDcoy6fsRrFZU0I=; b=BBmpLKydAOcYbsOr68kIb3cdYrDlbL3A+45/tD9pA1fkhdV8zyXVrbpvy/Kk1llFQc lWpciHh5ktXL17B8nKAsgWMbINV4ApL2AYEua2bWakhdGUqkXcCtJ3tVD6NNSC/LsPGp d0NvoVfhp/TzTUk5BPebDvMb9MFQ/mT56KSKCPI6PN6rFpSkQJDDzu10PuB3c+5kwkqU op9zlC7sv/a1zKX2BQggi37FMU1Uincm2cm/07ZVXcAavviV/UHXMxIn3bpMj6zFPE/0 kPXBhd8cE+4oDZc6SdNNqV3LERTM6uS2Ckgmf9TdEaB/1HUbAEqPZtLYxC9oL/GZlGvo nluA== X-Gm-Message-State: AOJu0YywiW7TgJkwp2JjqmpBSVC5igVmKakYM4iw13DwZMVnzjPe9iZl sjUdXDQhndkfia8oylPQERGwrE6lu3ihJbigTqYDPQYgk+rNV2DiQelwjmCl X-Google-Smtp-Source: AGHT+IFozdFvekUcsXiYNM+FxH7HZFOIy7PWwUrdwdmvwNh1AMfHUzOunfWsASqpDHjevwsGzlReHg== X-Received: by 2002:a17:907:f1d0:b0:a8d:35cf:85f6 with SMTP id a640c23a62f3a-a93a066ec79mr505151566b.57.1727357610763; Thu, 26 Sep 2024 06:33:30 -0700 (PDT) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93930f470asm350513966b.151.2024.09.26.06.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 06:33:30 -0700 (PDT) From: Sharlatan Hellseher To: 73299@debbugs.gnu.org Subject: [PATCH] build/go: Replace symlinks with a copy of the file. Date: Thu, 26 Sep 2024 14:33:22 +0100 Message-ID: <87ed56o7z1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Maxim, Thanks for a feedback! I currently polishing go-team branch (rebasing, adjusting failed builds, etc.) Is it ok to apply your suggestions, modify the commit and rebase the branch once again or it would be ok to apply adjustment commit on top of it? Thanks, -- Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmb1YqIACgkQdtcnv/Ys 0rX1mw//a6RkKio5PLHHJ/BnuThcAg5I6Upj56cXT1+abY+HAc9JR4seRkWlJcgy YcnuYGniW7OQFUx8521TZ+8+Y1M+7Vne+izzoMKUEvSEAFAPHDVUrPieKCtqzTIv Q3eFli51dyK1/w2zwjKPNC8y1+nTTYPvxz5QJPu7Oc4OJQUmn7smntcOk3nz89YC 0d+10r94IraICDeOTxNPglW29cy12zmksT5WC9fYjIZ4qKcAfCqRNxMbsRGhyVsS EV2pMEmW/6MgD4dxUp5i6Ib+OB4PfCF4o4d8NJnYdZOtL7v3nBXHviTYB0r/opyT 3EJacadN/D/qWsb6QC2HmuUGJS77qbJn/d/h5e4n8FJLsnBE0pIndi/b3hv/qgnu EJYLNB1EkGxsVw04WEgoPMJilMSaYkNqO6ik9XBKVwE+DMk6S2bMq1NgpbKwE6w9 4h304a15kFA1+qyFFICAedz6SdWLmLVt+nETGYzNpCmoZeYhLcfGEScFEHS3BeNT 2AkfbUyvOWRzB2s1+wZL2llLlhQjicaIhygmLgGyOklXRNjv2UuYdyc2t+LSM8aa KpW8fN3pigFJbU4rSgjFnFa9Oz02kPVnPDX27yzoY50kH2AWigQ+oUB+W7uRomK2 CcrZw+O+0t7mf/W/ah6xkt140AMFX+dlskPuLfsgirJZqxGkE6o= =eeoM -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 10:25:21 2024 Received: (at 73299) by debbugs.gnu.org; 26 Sep 2024 14:25:21 +0000 Received: from localhost ([127.0.0.1]:38445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stpQm-0004EL-Kf for submit@debbugs.gnu.org; Thu, 26 Sep 2024 10:25:21 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:43256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stp8M-0002yb-Hp for 73299@debbugs.gnu.org; Thu, 26 Sep 2024 10:06:19 -0400 Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7a99fd5beb6so177190885a.0 for <73299@debbugs.gnu.org>; Thu, 26 Sep 2024 07:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727359485; x=1727964285; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=v9iGAV4LIhSEaKc5tm07DMTyKtGuWf6fq5Go2gIXm5A=; b=SCxDx2lrm0Cxh7J2yDjWc2Ul9sukNvVzVOHAsaIymS+JWdoffgyY6rDzJ8say8EONK no1vQScnaCAVm/fRoe8zHT2Xek3u9qGbzvK6TmCsUoedqCeMoWfDSvJAR/zMeq1Jq771 HWQOjsvfHvTp7fEKgHYPsr6JlDHGfG9FlmZd5532p5RVh2SAR+bm6mIMpGcgrLMkKhxK O5iG/nPJYMqElypYxKyS9hTvBDzdIYfGZEuoBDF+OUztoaHVb+RjbPPNzNrYX8+YCshY GxdmkyfaMnKPig+ayAdVQDBzGYYHLoVGYD5FaZPnHB8GqnrnFVWOgCzrLq0gfTdt++3n /L2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727359485; x=1727964285; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v9iGAV4LIhSEaKc5tm07DMTyKtGuWf6fq5Go2gIXm5A=; b=eHp51EZ9cFcr5imeDStKUIv8OmNgVgDjD6ANHUaPRRtkrcHd4qLBwbyROVj8gjp2Bv p2QHc1Sm/5LsZphh2h0Oqw4mDzuX9KjCZip0pXiHsp2CgfJtMFf+tlsCLANc2hGa+JPP R/lOjy8e0MKF0TtBlCheEvjVq0gIDsfCbIZ44RDPtFq/DO0UqeWGahyS4FLkbe/EfqEN Zy6QUFI8zwiQA1KcMhoM30Htj9xkI9OQWTBGHJqgkbVibqdOHLi59EcI0uX7f68JKUUT VHrdUrLMe7iViheo9+r9rBJNmg7KPFP4O/VRzDv4fsS7cICtQwj6oGU4ueZZmEiNV1vp sMag== X-Gm-Message-State: AOJu0YyWO9ePjsfm5+QeBUUM/nGEmZq/E+gLG1/wSt/6FwLskG/3p9lY FcSPZPG4SfPdUVrZoobLL/RynX4rNmL3ZmGXGZwhZj5DyirKtz2ck3JWOKol X-Google-Smtp-Source: AGHT+IH0aBEw2hLKaEGPHFoCUE8Wba/j8VLoSg32vefrgEEoNUnNRQiVads3hghgnakiSIIY3Mjr1A== X-Received: by 2002:a05:6a21:6b0a:b0:1cf:1218:fa8 with SMTP id adf61e73a8af0-1d4ebeab830mr4845858637.22.1727359017839; Thu, 26 Sep 2024 06:56:57 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71afc9c6c81sm4326750b3a.200.2024.09.26.06.56.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 06:56:57 -0700 (PDT) From: Maxim Cournoyer To: Sharlatan Hellseher Subject: Re: [PATCH] build/go: Replace symlinks with a copy of the file. In-Reply-To: <87ed56o7z1.fsf@gmail.com> (Sharlatan Hellseher's message of "Thu, 26 Sep 2024 14:33:22 +0100") References: <87ed56o7z1.fsf@gmail.com> Date: Thu, 26 Sep 2024 22:56:54 +0900 Message-ID: <87jzeyecwp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: 73299@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Sharlatan, Sharlatan Hellseher writes: > Hi Maxim, > > Thanks for a feedback! > > I currently polishing go-team branch (rebasing, adjusting failed builds, > etc.) > Is it ok to apply your suggestions, modify the commit and rebase the > branch once again or it would be ok to apply adjustment commit on top I think it'd be safer to have a fixup commit; unless you are sure nobody cherry-picked some commits from the branch to master or elsewhere (which would then appear duplicated once the go-team branch gets merged into that same branch). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 15:40:20 2024 Received: (at 73299) by debbugs.gnu.org; 26 Sep 2024 19:40:20 +0000 Received: from localhost ([127.0.0.1]:51758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stuLc-0000Tg-5C for submit@debbugs.gnu.org; Thu, 26 Sep 2024 15:40:20 -0400 Received: from mail-lf1-f43.google.com ([209.85.167.43]:53351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stu0S-0007Z2-1v for 73299@debbugs.gnu.org; Thu, 26 Sep 2024 15:18:28 -0400 Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5356aa9a0afso2172612e87.2 for <73299@debbugs.gnu.org>; Thu, 26 Sep 2024 12:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727378214; x=1727983014; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=c1npVyfV4FXxJ8NdMN7lQSGTI65Vf/3Tx6cNOly1TIE=; b=Vww66FfEiqMyDGkLQRcZPAkwl2Rhd5xZdU3KkJRq+e7EmA9kB3VeHw24otJlpoonVJ +XL/Mokq1zrv60b3kVdekltwcwX8OfBlZ8DM5AikM5+OnWKOtTfijnWjhnR/YTZp1saU TMLFw6vJ7EY1zBkDN0NsP9WQsh6QdDNuqHroOZGYeDL/Qw2cQWmDs98KTGaZE0bXYwe8 E548XPfU0bH34cG19Twog7mygzCJzH1+ZrOvDqwKIVU6Nz0+bPD7pua1Zgm8D5oIW7n+ ofBx8cwXYX6GeaHgGavfa4zCqW2efRw6Sg3MIF8QAr7suKFrVmQO3FUEJ6q2abMxYdq1 B8Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727378214; x=1727983014; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=c1npVyfV4FXxJ8NdMN7lQSGTI65Vf/3Tx6cNOly1TIE=; b=Q09bJ6xLlf9wCsPl5ji94xnvP8movhwdWgY0QjZz0k3Y/BoA6XjpaAWVfsae5BuSBb MBTZrv0stEl54E6KPuM+RP9lxx/++mZFavxekYgsFtmGw+O/4YTyziKXzsCSvZQf6rdS iFpyYIs12kGNJDZGqH/aloPiaksUek8WTRMf3yAT8LgUEO3sCRZ1aYpScTTXJ9xiZzWL kMbm0Sw+YyRyNzoPL8QZ/KsUltnJlYKrrGm0hXJmaDcoGXAQOjsOMcSczA03XpQGUYmD njdYVceqEpW4d+Eo26/kbblyVgqxQWOfD27gpQfZ9yj0cX+l2JC8S7Jm7m9o9bPQyFuR FlVA== X-Gm-Message-State: AOJu0YxV7TDXi/2eyoZqqECKeaW6mQfnR5/eNSpEfkev14FUfDJyVPi2 yLQC+rUh+KX8AWXayuq5q5hZQF8LJVJWXE9sd9zcLrW89j2EINifsvs+j5q8 X-Google-Smtp-Source: AGHT+IELMToVtsbSxQCVy19YAELWbpQiDO6su5v5kHK4GfL7fn46sMPhzANi/PsNKTCdxjGFx63Hlg== X-Received: by 2002:a2e:1312:0:b0:2f7:6653:8053 with SMTP id 38308e7fff4ca-2f9d3e49a52mr4657041fa.18.1727377779485; Thu, 26 Sep 2024 12:09:39 -0700 (PDT) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c299ac60sm28502966b.221.2024.09.26.12.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 12:09:38 -0700 (PDT) From: Sharlatan Hellseher To: 73299@debbugs.gnu.org Subject: [PATCH] build/go: Replace symlinks with a copy of the file. Date: Thu, 26 Sep 2024 20:09:37 +0100 Message-ID: <87bk0ansem.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi, Pushed to go-team as https://git.savannah.gnu.org/cgit/guix.git/commit/?h=go-team&id=ad39aa197af0833523b6c43ecc798790e0f9c060 -- Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmb1sXEACgkQdtcnv/Ys 0rXIaw/+MtaG+U/jr4ppoF/joJ9QRYJvz+/eXjeLQlElkBPheejR1vY9XQssf78J 8LW4RE/W8cdiI/8i9AhUiC78NGUVga94EDavfJiZVkdqEnFg+RK6TAux9pwco5C/ ujxtKuJRs7wDJTijpvlNi9ihcrPnHHhMfNC1gQ28pvy4ysT5mHt3nhqmZLcHvzaG Iu8YO9yRZvUk6/ybltEf82WLoPvvyNdJ77cnRjKxVDeKU0H3tjJZ7ARI+INISMUn vi07hfMRSPXJtIO25W5MWl90zW5IikD9cjTZIhMoAiGSu+Wma18268/3U6H8uwrj OxFQ2pIl4+Kvr0C1I3YMQSgFIDAtafwLeLCJ1EX2mVI89iCTFLNlOMM2cNmm+N63 GMTD+3LR7Xh6QZrszWa9ATaRIrwaSz+knmLu73dV/RAofhPW/dv0JJKcaTaGyy7f DW8eiOTRD5P0XxfLiG7mlX8PqYcqKpYrIciMiz2xyYSs9awVGmvl7tZXVaUbwXZ7 fYmSvhSQrn1vK68tYxVaEM+MS2gTEnhYQ7V7TkVeo7gnF+TRwGZNy6BfTPs2JuJB OFGNwCttnoIh3jS69mHOs7DG2d+xwSL/Rj8YHEXmi46kM3XrNzJR4okQ1YkK607X l3ZRIMS97DLLKa9wuTPo2G58+pzt7A4h/JoFPzfrZ2lo0SO0KQg= =cn39 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 27 02:58:48 2024 Received: (at 73299) by debbugs.gnu.org; 27 Sep 2024 06:58:48 +0000 Received: from localhost ([127.0.0.1]:45341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1su4wB-0002Iz-Mq for submit@debbugs.gnu.org; Fri, 27 Sep 2024 02:58:47 -0400 Received: from mail-pl1-f172.google.com ([209.85.214.172]:51363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1su4w9-0002Ik-9Z for 73299@debbugs.gnu.org; Fri, 27 Sep 2024 02:58:46 -0400 Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-20b483f2c4aso650765ad.2 for <73299@debbugs.gnu.org>; Thu, 26 Sep 2024 23:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727420231; x=1728025031; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=QX5ESn1wuCaLQsocuLfcylVBhzJXL01DoGkR4gwIhGA=; b=cKXPUb3Qqgi+n1KDkbnD23Gcn6Q9FngOkDm4CB+CtcY0cZdCACO77NnR2XpaMgIo69 kDHcYHTCaXqzsFEuSWiNou8W+nHnprS2if7GZSJKUbVZSUT60EhKdbdYVixIBsX6zanb PMtytbheouFJBECiEaiDtH3E8UyBUQgJPa3Zg37qvBs8fPGs6VQFmZTlAqw2lgNFP+na QtvBEwYh0wtIAo8mfjNR1TNDLqMxb8XCc5+Wsd4ffUbyA6nuM61eWNvqjKCbRZvthiYq 7/w50wqt8j4FzAJz/mGNJD1nUF0G/+raVEsaSLjoA7kYFxWRWZx9seB6Jn0af/3SnQS5 jzlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727420231; x=1728025031; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QX5ESn1wuCaLQsocuLfcylVBhzJXL01DoGkR4gwIhGA=; b=HeRaHbmeMixi+rSIufqkeS8TKLU/s1/w8yR7O+4NAn2KZDcLymR657fyIP9qBXZFiH KzSRqtACr7JjdskhHXYnI48sPAWs1slnbsEfkiid7s7mLT7f7gEkw5OjWSmcsdL6bLeQ MaVTuVV1OiU8zRppMutlc30cDjUkO/arkTiYtSmluWHZkNI6MD737eWbgyDHJfi0+Cg1 ekPratg5G4Ue7MGGIDN5j8kOPbpHRI1Der90LDpPEXJfl94uh6XDO6T2ZlVMwZQ/as7t Kh12x+p8tq23GILNk41ovHS62xhUmtbDZP/MvLpUS5quQvf8wK/igfcY52/QvN4olJkd FGVw== X-Gm-Message-State: AOJu0Yz+uCPtKG4ujhP2BWHtsv0vGITG8W6bRzpnuxZ/IaZC0IM2wsOH p4UjjwxAt2oCbvLFR5BtZJdNVG4AJzU6GSPp7hneAx7hPE9DGJhUDnL/PhVX X-Google-Smtp-Source: AGHT+IEdfrvZxVTdsPCO+rTYNc/2LDYdPodV+QYUUBX6qMlrdf1VS106RhdRX2JvmFYMlFWecUlyYg== X-Received: by 2002:a17:902:ccc6:b0:205:5427:2231 with SMTP id d9443c01a7336-20b37b912a9mr32849155ad.47.1727420230612; Thu, 26 Sep 2024 23:57:10 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37d60ec9sm7899205ad.21.2024.09.26.23.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 23:57:09 -0700 (PDT) From: Maxim Cournoyer To: Sharlatan Hellseher Subject: Re: [PATCH] build/go: Replace symlinks with a copy of the file. In-Reply-To: <87bk0ansem.fsf@gmail.com> (Sharlatan Hellseher's message of "Thu, 26 Sep 2024 20:09:37 +0100") References: <87bk0ansem.fsf@gmail.com> Date: Fri, 27 Sep 2024 15:57:07 +0900 Message-ID: <874j61eg8s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73299 Cc: 73299@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Sharlatan Hellseher writes: > Hi, > > Pushed to go-team as https://git.savannah.gnu.org/cgit/guix.git/commit/?h=go-team&id=ad39aa197af0833523b6c43ecc798790e0f9c060 Thank you for taking the effort to address my (small) comments! -- Maxim From unknown Thu Jun 19 14:30:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Oct 2024 11:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator