GNU bug report logs - #73291
31.0.50; `clean-buffer-list' activates `midnight-mode'

Previous Next

Full log

Message #44 received at 73291 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: michael_heerdegen <at> web.de, 73291 <at> debbugs.gnu.org, manuel <at> ledu-giraud.fr
Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode'
Date: Thu, 19 Sep 2024 08:53:38 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Wed, 18 Sep 2024 16:52:25 -0700
> Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 73291 <at> debbugs.gnu.org
> 
> Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs <at> gnu.org> writes:
> 
> > I think the following patch does the trick.
> 
> Previously, putting this in your init file enabled midnight-mode:
> 
>     (require 'midnight)
> 
> Now, one needs to say this instead:
> 
>     (midnight-mode +1)
> 
> Right?  If yes, this change is backwards-incompatible and should be
> called out in NEWS.

Agreed.  The user manual already says (in effect) to use the latter,
so we are good in that department.

> I still think this is worth doing, because we want to avoid side-effects
> like enabling modes just from loading an Emacs Lisp library.  This is
> one of few such places that we have left.  Not having midnight-mode on
> should also usually not be a very big problem.

Yes, agreed.

> Since the latter will work on previous versions of Emacs all the way
> back to 25.1, I think we might as well install the below documentation
> patch on the emacs-30 branch too.

Agreed.

So please install all the other changes on master and this one on the
release branch.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.