From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 03:50:09 2024 Received: (at submit) by debbugs.gnu.org; 16 Sep 2024 07:50:09 +0000 Received: from localhost ([127.0.0.1]:51023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sq6Uq-0006QS-O4 for submit@debbugs.gnu.org; Mon, 16 Sep 2024 03:50:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:50464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sq6Up-0006QL-Gl for submit@debbugs.gnu.org; Mon, 16 Sep 2024 03:50:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sq6Uc-00036Q-25 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 03:49:54 -0400 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sq6UY-0005WN-JH for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 03:49:53 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=YsGqetsB mavBtrAhw4OtUsb9hLg11Ijlqb2oglsqI9U=; h=date:subject:to:from; d=ledu-giraud.fr; b=OAnDmFKXuW6tlq2Ld/IUKP2zmBpCX0KZSkQfnEyFVtAdqUD/0E M1xcRIf1n0yqSNwCb4Lxh2BE/kYYukeNNpAw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=YsGqetsBmavBtrAh w4OtUsb9hLg11Ijlqb2oglsqI9U=; h=date:subject:to:from; d=ledu-giraud.fr; b=LsCd3+AxW4n4cfPjkhLzhwOwRG9tQxgg4+1pl4HKg7NVLfHU4q iYL4PzA10B4Mv3KbCMIN9aijkFskA3LiJ+Ce+tnx3iTmFOYiFaKeMdRKklKnaUwZwiK73w MxpH5DxalL6X1t+7htzAPJeqITOGcb7c5i6lN4hhklUMP4HosyHn5vY6evrDgdP2wtC5m6 uDcOKenKmRjlUm+mEil6NsAoL2x7NN5fGtVl3hcR7QcL5v7S2OZdzX+NJCdprbWqQ7tpfq ks354jZo9dJ+nyftZuVGkj5fvFeY478XozUV2dMET9fRmWbTQF+CSZ8mm5GaExwIMY2u4p AX6xSwqLMSyA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 013eaaff (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Mon, 16 Sep 2024 09:49:45 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 31.0.50; `clean-buffer-list' activates `midnight-mode' X-Debbugs-Cc: Date: Mon, 16 Sep 2024 09:49:43 +0200 Message-ID: <87plp4vy08.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, It seems that calling `clean-buffer-list' once activates `midnight-mode'. How to reproduce it: - emacs -Q - Open some buffers - M-x clean-buffer-list ;; Obviously not much buffers are killed - Wait one day and go into your emacs window - In the *Messages* buffer, you can see that cleaning occured recently I think that one call to `clean-buffer-list' should only clean the buffer list once. The documentation does not seem to imply otherwise. Best regards, In GNU Emacs 31.0.50 (build 30, x86_64-unknown-openbsd7.6) of 2024-09-15 built on computer Repository revision: 2cd5774689f96522709250b7805370522dcd4334 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: OpenBSD computer 7.6 GENERIC.MP#312 amd64 Configured using: 'configure CC=egcc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-cairo --without-compress-install' Configured features: DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Group Minor modes in effect: gnus-topic-mode: t display-time-mode: t display-battery-mode: t desktop-save-mode: t exwm-randr-mode: t server-mode: t gnus-undo-mode: t electric-pair-mode: t override-global-mode: t repeat-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/prog/elisp/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-randr /home/manuel/prog/elisp/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm /home/manuel/prog/elisp/exwm/exwm-xsettings hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-xsettings /home/manuel/prog/elisp/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-xim /home/manuel/prog/elisp/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-workspace /home/manuel/prog/elisp/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-systemtray /home/manuel/prog/elisp/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-manage /home/manuel/prog/elisp/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-layout /home/manuel/prog/elisp/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-input /home/manuel/prog/elisp/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-floating /home/manuel/prog/elisp/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-core /home/manuel/prog/elisp/exwm/exwm-background hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-background /home/manuel/.emacs.d/elpa/ef-themes-1.8.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/31.0.50/lisp/theme-loaddefs Features: (info-look dictionary external-completion dictionary-connection shortdoc comp-common shadow emacsbug gnus-fun smerge-mode diff epa-file find-dired flow-fill gnus-async gnus-bcklg gnus-ml smtpmail sort dabbrev mailalias ispell gnus-cite mail-extr gnus-topic qp utf-7 imap rfc2104 nndoc nndraft nnmh nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss org-duration cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew cal-julian holidays holiday-loaddefs cal-iso face-remap org-indent oc-basic ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi org-agenda org-element org-persist org-id org-element-ast inline avl-tree gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-cycle org-table org-keys oc org-loaddefs ol org-fold org-fold-core org-compat org-macs finder-inf mm-archive ef-winter-theme ef-tritanopia-dark-theme ef-trio-dark-theme ef-rosa-theme ef-owl-theme ef-night-theme ef-melissa-dark-theme ef-maris-dark-theme ef-elea-dark-theme ef-duo-dark-theme ef-dream-theme ef-deuteranopia-dark-theme ef-dark-theme ef-cherie-theme ef-bio-theme ef-autumn-theme ef-symbiosis-theme man mule-util shr-color textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check network-stream url-cache vc-hg vc-bzr view tramp-cmds tramp-cache time-stamp tramp-sh pulse ffap display-line-numbers tabify conf-mode sh-script smie treesit executable misearch multi-isearch cl-print midnight help-fns radix-tree cus-start make-mode vc-dir ewoc on-screen eww url-queue mm-url pdf-occur ibuf-ext ibuffer ibuffer-loaddefs tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet pdf-isearch let-alist pdf-misc imenu pdf-tools pdf-view bookmark jka-compr pdf-cache pdf-info tq pdf-util pdf-macs image-mode exif gnus-dired vc macrostep-c cmacexp vc-git diff-mode track-changes vc-dispatcher bug-reference time battery desktop frameset exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server ef-kassio-theme ef-themes modus-operandi-theme modus-themes zone speed-type url-http url-auth url-gw nsm ytdious mpdired transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win ebdb-message message yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils mailheader ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base timezone icalendar gnus nnheader gnus-util range sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils web-mode derived disp-table erlang-start skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep compat slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline comint ansi-osc ansi-color ring hyperspec thingatpt elec-pair edmacro kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs pcase dired-x dired-aux dired dired-loaddefs use-package-core repeat easy-mmode cus-edit pp cus-load wid-edit debbugs-autoloads ebdb-autoloads cl-extra help-mode ef-themes-autoloads exwm-autoloads hyperbole-autoloads kotl-autoloads hact set hhist on-screen-autoloads osm-autoloads pdf-tools-autoloads rust-mode-autoloads info slime-autoloads macrostep-autoloads speed-type-autoloads tablist-autoloads transmission-autoloads xelb-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 1839679 363033) (symbols 48 64933 4) (strings 32 496457 25800) (string-bytes 1 13760816) (vectors 16 193093) (vector-slots 8 2656445 237930) (floats 8 1346 9473) (intervals 56 62796 4763) (buffers 992 82)) -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 09:09:47 2024 Received: (at 73291) by debbugs.gnu.org; 16 Sep 2024 13:09:47 +0000 Received: from localhost ([127.0.0.1]:51281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqBUB-0006ug-Fi for submit@debbugs.gnu.org; Mon, 16 Sep 2024 09:09:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqBU9-0006uS-6d for 73291@debbugs.gnu.org; Mon, 16 Sep 2024 09:09:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqBTp-0005wu-DW; Mon, 16 Sep 2024 09:09:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sE8nMLwI9hlEwqptchDwJlNpN9YFaQP94qFIEstmlro=; b=dW06hBbl4BSS xX7NETTI1/d7mTN3nCfqLsEKn666v0fDbKEaLh58WbouEY1yMVedVAaMw78Mo8I1RAq5IvvgwPxC1 DBuKMOUvafVrKu5FHXLBstyJ6GNqt1lng/w7DCfkr5scedazLFNfSxaHgGtSxfl1gb8s2xqsbVNjz 70BgsM+g2o5nCPydMLmoKuUInwoMpB47QRFQ343SVgjNQZ2VzW6ifmjyG7maUnJe3biXNFwaf4ZjM Am5kTlqsMTUUOVMbRGPgLwwcx3GONNaxi8xb6gWGLKytXgcb28H8X+k4KedtVi8bgpSi74rMUQGX7 9Ur1PIuVRu+Y5hqW9g1Bhg==; Date: Mon, 16 Sep 2024 16:09:22 +0300 Message-Id: <86ikuvd9tp.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87plp4vy08.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' References: <87plp4vy08.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73291 Cc: 73291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 16 Sep 2024 09:49:43 +0200 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > It seems that calling `clean-buffer-list' once activates > `midnight-mode'. How to reproduce it: > > - emacs -Q > - Open some buffers > - M-x clean-buffer-list ;; Obviously not much buffers are killed > - Wait one day and go into your emacs window > - In the *Messages* buffer, you can see that cleaning occured > recently > > I think that one call to `clean-buffer-list' should only clean the > buffer list once. The documentation does not seem to imply otherwise. This is because clean-buffer-list is autoloaded, and loading midnight.el evaluates midnight-delay, which :set function activates the midnight timer. I think the solution is to modify midnight-delay-set to activate the timer only if is already non-nil. Like this: diff --git a/lisp/midnight.el b/lisp/midnight.el index bfa99d6..73d049a 100644 --- a/lisp/midnight.el +++ b/lisp/midnight.el @@ -205,10 +205,11 @@ midnight-delay-set (cl-assert (eq symb 'midnight-delay) t "Invalid argument to `midnight-delay-set': `%s'") (set symb tm) - (when (timerp midnight-timer) (cancel-timer midnight-timer)) - (setq midnight-timer - (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) - midnight-period #'run-hooks 'midnight-hook))) + (when (timerp midnight-timer) + (cancel-timer midnight-timer) + (setq midnight-timer + (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) + midnight-period #'run-hooks 'midnight-hook)))) (defcustom midnight-delay 3600 "The number of seconds after the midnight when the `midnight-timer' is run. Can you try this and see if it solves the problem, and doesn't break the other uses of midnight-mode and or clean-buffer-list? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 04:20:03 2024 Received: (at 73291) by debbugs.gnu.org; 17 Sep 2024 08:20:03 +0000 Received: from localhost ([127.0.0.1]:53800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqTRL-00044M-Cs for submit@debbugs.gnu.org; Tue, 17 Sep 2024 04:20:03 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:8194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqTRJ-00043n-Ab for 73291@debbugs.gnu.org; Tue, 17 Sep 2024 04:20:02 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=gCD5gE5P 89MHjlxt/QLcfVHQOuafI9TXYbOLzDnfPKc=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=2sRpB37Sa967zpi0tFm96nunOEfmeZ dJYRXvOFT8+0dPSypco6pM9cIb//+I7DHfFp1MEG5pgjqFrC2e1+n0Cw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=gCD5gE5P89MHjlxt /QLcfVHQOuafI9TXYbOLzDnfPKc=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=n/CPTAtbkqdV1OzUpM5zQmtbGSQg2sof8vUXck RZ44KtWgfE04GvmwK4qfuOKH01EDnQcHdC31df3kBl4YQgucQg//vhgXZ5vDdwzdJhNghh i58GU8cFv6j4L0YmPpx3p2Ym7Vh+O/6jG+MrK8wY6rQKnXMpNCITy4ILK3NV/v/cCcnH9h y1+k7ouM3/E2pwo9YcNc2Vej3NtlTnuNEBwRThPPPrJKQ0Ti5IpAJaVT72b1MlsKRPZSJJ jftyGGRG+9bC9YCIIR9MtxlIVpS94Qy6EutYVNwMeIPYXP/3BT0XGISyF0Ht/VnqJ4ldNJ O219xyx6pxHREu6hVrbFhngg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 66507c53 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 17 Sep 2024 10:19:42 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' In-Reply-To: <86ikuvd9tp.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Sep 2024 16:09:22 +0300") References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> Date: Tue, 17 Sep 2024 10:19:41 +0200 Message-ID: <87frpyofoi.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73291 Cc: 73291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > diff --git a/lisp/midnight.el b/lisp/midnight.el > index bfa99d6..73d049a 100644 > --- a/lisp/midnight.el > +++ b/lisp/midnight.el > @@ -205,10 +205,11 @@ midnight-delay-set > (cl-assert (eq symb 'midnight-delay) t > "Invalid argument to `midnight-delay-set': `%s'") > (set symb tm) > - (when (timerp midnight-timer) (cancel-timer midnight-timer)) > - (setq midnight-timer > - (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) > - midnight-period #'run-hooks 'midnight-hook))) > + (when (timerp midnight-timer) > + (cancel-timer midnight-timer) > + (setq midnight-timer > + (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) > + midnight-period #'run-hooks 'midnight-hook)))) > > (defcustom midnight-delay 3600 > "The number of seconds after the midnight when the `midnight-timer' is run. > > Can you try this and see if it solves the problem, and doesn't break > the other uses of midnight-mode and or clean-buffer-list? Thanks. It solves the issue of activacting the midnight-mode: now `clean-buffer-list' is just done once and won't run the next day. But now, when I do M-x midnight-mode, I get the following error: --8<---------------cut here---------------start------------->8--- timer--activate: Invalid or uninitialized timer --8<---------------cut here---------------end--------------->8--- -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 08:50:40 2024 Received: (at 73291) by debbugs.gnu.org; 17 Sep 2024 12:50:40 +0000 Received: from localhost ([127.0.0.1]:54194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqXfE-0002Tv-Dz for submit@debbugs.gnu.org; Tue, 17 Sep 2024 08:50:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqXfC-0002Tb-Ho for 73291@debbugs.gnu.org; Tue, 17 Sep 2024 08:50:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqXer-0003nP-5t; Tue, 17 Sep 2024 08:50:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yexPaHUafh/nxFJozo34hYYQAcMBMQ1GN4vgt0O8WCg=; b=Tob/iFDoNUSN KeyLmmdkNnqkqHI3/X9MgTfHHrBUUBUH8M66syDP2VksSCnAOeFDgGGsO4T8gs3DZGFi69yy6ri3c o5M07zlEOaNq7g/PilQaW7/XN9chDVL5UqBxgK9uvRSnrXMRnndwRTA5bGJ3O338bPqVIJ+3ZQZ4S VH3bM+7ouswrmX43QQaPL0badebk/UMAJEy+XMEecrNPy1/MKFZrvQdKcLBXi9gGy7hw6HT8sNwxf TEZ2xq2zF9H0EkpcEmpwSmxhfxlVQvfCA02ypxHDyVGBrlVzE9wafCYTY1kvPItfiTLDUU009SLn3 f83i6QD2QybJXHP4hgogyQ==; Date: Tue, 17 Sep 2024 15:50:11 +0300 Message-Id: <86h6aebg1o.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87frpyofoi.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 17 Sep 2024 10:19:41 +0200) Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73291 Cc: 73291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 73291@debbugs.gnu.org > Date: Tue, 17 Sep 2024 10:19:41 +0200 > > Eli Zaretskii writes: > > > Can you try this and see if it solves the problem, and doesn't break > > the other uses of midnight-mode and or clean-buffer-list? > > Thanks. It solves the issue of activacting the midnight-mode: now > `clean-buffer-list' is just done once and won't run the next day. But > now, when I do M-x midnight-mode, I get the following error: > > --8<---------------cut here---------------start------------->8--- > timer--activate: Invalid or uninitialized timer > --8<---------------cut here---------------end--------------->8--- So not only did it activate the timer when loading the package, it also relied on that for the mode to work... The fix is to add (midnight-delay-set 'midnight-delay midnight-delay) to midnight-mode function. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 09:15:46 2024 Received: (at 73291) by debbugs.gnu.org; 17 Sep 2024 13:15:47 +0000 Received: from localhost ([127.0.0.1]:54211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqY3W-0003rs-Hn for submit@debbugs.gnu.org; Tue, 17 Sep 2024 09:15:46 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:2322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqY3T-0003rf-9I for 73291@debbugs.gnu.org; Tue, 17 Sep 2024 09:15:44 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=+5E84kDJ BaCqf1JMO9tjQgB3bdxAfsF5AU9/sltvbUk=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=2l/Tp4FzODr4fLB34kxr+eB0tEwxv+ KZh8IHkvduWbWgHYqEubax/eVTDn9zYYzNVxYqb/EY4C5Nl4TBBw7CBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=+5E84kDJBaCqf1JM O9tjQgB3bdxAfsF5AU9/sltvbUk=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=tcb3sACmCqpX6PWsqP0HinhfMaM2Da4075JCaE 4IhhaZxWgfMAobj2IHwrfnXJMI5mEoEJnJwQ1Ie1DwtmC8Mqv/kBaaSwgE+BAfxbPR36eV CZX615/RzCeSnO1SLqxp14FaN7L09+YDKOn/idhAvO3FDJhQK5IkGVEtJ7G4vJ6jiVUGlE 35uQ9lt9IQiHFT7zG/FfFsBA2fFxjOLmAgQ+gUhVXkbHSs015bLRbBBzBCQicgs2KtO4jF apMDP0htAoQPs4XJ7dBLKJjFM0TFJSGf9CixU5g+q6kBuZ/M1R8xtDeMv1wlK0oKYpesQR tsqJ0FQlGhWHbtxIrBuXxAJQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 9fb1ff63 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 17 Sep 2024 15:15:26 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' In-Reply-To: <86h6aebg1o.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Sep 2024 15:50:11 +0300") References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <86h6aebg1o.fsf@gnu.org> Date: Tue, 17 Sep 2024 15:15:26 +0200 Message-ID: <877cbamnf5.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73291 Cc: 73291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 73291@debbugs.gnu.org >> Date: Tue, 17 Sep 2024 10:19:41 +0200 >> >> Eli Zaretskii writes: >> >> > Can you try this and see if it solves the problem, and doesn't break >> > the other uses of midnight-mode and or clean-buffer-list? >> >> Thanks. It solves the issue of activacting the midnight-mode: now >> `clean-buffer-list' is just done once and won't run the next day. But >> now, when I do M-x midnight-mode, I get the following error: >> >> --8<---------------cut here---------------start------------->8--- >> timer--activate: Invalid or uninitialized timer >> --8<---------------cut here---------------end--------------->8--- > > So not only did it activate the timer when loading the package, it > also relied on that for the mode to work... > > The fix is to add > > (midnight-delay-set 'midnight-delay midnight-delay) > > to midnight-mode function. I tried building with the following patch but I get the same error when doing M-x midnight-mode. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=midnight.patch diff --git a/lisp/midnight.el b/lisp/midnight.el index 6e1e7b5ccb7..a4b0ac00c83 100644 --- a/lisp/midnight.el +++ b/lisp/midnight.el @@ -57,6 +57,7 @@ midnight-mode ;; via setting 'midnight-delay', which calls 'midnight-delay-set', ;; which starts the timer. (when (timerp midnight-timer) (cancel-timer midnight-timer)) + (midnight-delay-set 'midnight-delay midnight-delay) (if midnight-mode (timer-activate midnight-timer))) ;;; clean-buffer-list stuff @@ -206,10 +207,11 @@ midnight-delay-set (cl-assert (eq symb 'midnight-delay) t "Invalid argument to `midnight-delay-set': `%s'") (set symb tm) - (when (timerp midnight-timer) (cancel-timer midnight-timer)) - (setq midnight-timer - (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) - midnight-period #'run-hooks 'midnight-hook))) + (when (timerp midnight-timer) + (cancel-timer midnight-timer) + (setq midnight-timer + (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) + midnight-period #'run-hooks 'midnight-hook)))) (defcustom midnight-delay 3600 "The number of seconds after the midnight when the `midnight-timer' is run. --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 09:17:22 2024 Received: (at 73291) by debbugs.gnu.org; 17 Sep 2024 13:17:22 +0000 Received: from localhost ([127.0.0.1]:54223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqY53-0003vX-Vz for submit@debbugs.gnu.org; Tue, 17 Sep 2024 09:17:22 -0400 Received: from mout.web.de ([212.227.17.11]:40513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqY4y-0003uz-Fk for 73291@debbugs.gnu.org; Tue, 17 Sep 2024 09:17:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1726579014; x=1727183814; i=michael_heerdegen@web.de; bh=AeYo0v8Ldb/K9Azzntn/+c15SOp5JcQ/ri6jKsbeQis=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=eOi9p3+0u1vQLLJEUivP4W0eob57ytuL8+0M5uoMVm5kqBc/8xh9WLUhLoq9UeKy E52cQxPqJ/TkGfcmQP8kaRKdcBwpawzzm4xvfRjA8Aa1qL/DGFX4YACA6g/FXRD6K nYB3sCBMKnFnF3UPovB/9PCfalHFVOBGGhgX4Vs93xvTC9nb79DSsoIm+/3kfxcgF wKTyUfeWdF2wv+Z6zSwhmletqT1IKvHivvgst9N05pQCS8FW/0KNlPF5nhASBjEWS 7KKhc1NHK0SmTg7JbosKqJ57mp+wxwI311WawwQ+4AsEvT1+HsUOAXYtOn276kkLK d2LFQ5mU9ezlPPc12Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.158]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N1d3a-1roj9i0MZM-013ZWe; Tue, 17 Sep 2024 15:16:54 +0200 From: Michael Heerdegen To: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' In-Reply-To: <87frpyofoi.fsf@ledu-giraud.fr> (Manuel Giraud via's message of "Tue, 17 Sep 2024 10:19:41 +0200") References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> Date: Tue, 17 Sep 2024 15:17:45 +0200 Message-ID: <87frpyh11i.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:DJLg/VCploTSvi257M2tOmK+8QUyBSspPWqf06ZU0ilk6FIT6FY jN9eSQoYoeiMvbckXp2MYocxgvRmRXSQhcAy28A+vLXZhM3i7s4lvZnZ2o7JSHh7InFuQLi 1D34ccNaBg/npyRRQkvuZ1ZPe9YKMqQqOPVY4xM5c3jsozIJvBnwI/A/JJLl0h5Hw1K1XrI H/hH+jKJ/iPQs/bQIqqdA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:PqUtWpIFppU=;s2/qAclpWAOV03xCSpVMM5aNch3 HV9LcXp9Nz2x1E2XeCpuJXF8SgNnnfs93Pf9FKlq8sYxkRK47BH5jJFK75BNVYAeiAla+7g7V NySGOkdkbxOU9uE04qtVAI2Q3xq3C7dG595K9t8747htsO8tdbEU8Lzhc60LCUN+ig1oKgysb 1p2CBdFv2kADMApeZEX9tQzuYtlrDjs3SHbIjaAYzVcKBsLVVuiph3L3iDJ81DPrsJIkf5Bc5 ILqEhCiqYc5trbptcw7QgpAgd8DHQTi5C/aahTs/8tHa+utBBviPyAri2ErozRMwoxtlq4LMD GI1LP8BUJcUsSwmWv1V7gt6uSZDw2x/FOaY3i/NzOUJlfUwg8LN+Y1nnChleoKixGDdLD/IDO pGXl98CqovcTpc8iLgJiKPPTU974f1VRPCoUwwSR6LKevbB6IX7cJ4bh5HzyTkCCfKljOIqtL LPFRZr46GQ/hHctasLGt+Gh/DEhvXkUUhWpwoeqbAFfnapo6ZJFWXwulBjj8FJiOzp8B2wVQd MX0zii1JWp/DKe5wLZi1Tuy4Cs2pp8PGMPZmLeGKcZRRNXN4+8y2TC6m4MnOHx/k59Q5gEs/1 9DHom6hXzgRaaxvUobPENa8bdJfl1orSIRH7QaypEONs8GifHZpeQaF9pGFNIovEfCTngmAho VcXnijOWAkXW81RMjcYpCvrXhvTwsunNSb0BRP5kkcjZD82WNw9LMSOUkZEiNKZjTkm3Gz1tL an8E4hM769y2DzxABUfUO4LnWh8evPABKPe7P2w1e82nS5c48zDR7IDABkDH9yJ7zEYaHsafw ZYJRXFwBpDgFFo83s1hLOc4a/Yp4Do4SkbBeZ2y8U1qgw= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73291 Cc: Eli Zaretskii , 73291@debbugs.gnu.org, Manuel Giraud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > > - (when (timerp midnight-timer) (cancel-timer midnight-timer)) > > - (setq midnight-timer > > - (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) > > - midnight-period #'run-hooks 'midnight-hook))) > > + (when (timerp midnight-timer) > > + (cancel-timer midnight-timer) > > + (setq midnight-timer > > + (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) > > + midnight-period #'run-hooks 'midnight-hook)))) > > > > (defcustom midnight-delay 3600 > > "The number of seconds after the midnight when the `midnight-timer'= is run. > > > > Can you try this and see if it solves the problem, and doesn't break > > the other uses of midnight-mode and or clean-buffer-list? > > Thanks. It solves the issue of activacting the midnight-mode: now > `clean-buffer-list' is just done once and won't run the next day. But > now, when I do M-x midnight-mode, I get the following error: > > timer--activate: Invalid or uninitialized timer Maybe we could instead check whether `midnight-mode' is on, Eli? Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 09:46:26 2024 Received: (at submit) by debbugs.gnu.org; 17 Sep 2024 13:46:27 +0000 Received: from localhost ([127.0.0.1]:54252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqYXC-0005j4-Fx for submit@debbugs.gnu.org; Tue, 17 Sep 2024 09:46:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:44514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqYX9-0005ir-HY for submit@debbugs.gnu.org; Tue, 17 Sep 2024 09:46:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqYWs-0003m8-Uv for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2024 09:46:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqYWr-00046X-RK; Tue, 17 Sep 2024 09:46:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WXrsNGU65lhu0Me4RDZ+MR396PV84AYVtWEFonLj/0c=; b=rprQ2E7oh0gg POZ7gSu0cXrMMBu5NIPa4r67Yw3Sl/WBj19QzpBTdLwRQCimDKVjYkhl7md0DwhrpEZBw76bZRSxx C9HOIIoiZ/85um+WaC7iWwligunfgw3KTU9G4FA9kNpwuXz3eQA7KmMYJUlM8+xzoM+cwm8bRrT65 JhW1AVNJByH+azo6uvE6Rs4d7q6iQf//fjaO6a6bYDJ/r9dB/+pLaUSmk5bhSPf+NtLRujN2rZUVA 4Q2PckR2lCOucPAohe9rLUbCPB/Wy90yfYRgb4hfJjlvTbXmKd3UnPODGHkmo5R1Ry0BGGGHrM2Ew gQNyk1lNBvePs+Z/Yrmlqw==; Date: Tue, 17 Sep 2024 16:46:02 +0300 Message-Id: <868qvqbdgl.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87frpyh11i.fsf@web.de> (message from Michael Heerdegen on Tue, 17 Sep 2024 15:17:45 +0200) Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, 73291@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: Eli Zaretskii , Manuel Giraud , > 73291@debbugs.gnu.org > Date: Tue, 17 Sep 2024 15:17:45 +0200 > > Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > > - (when (timerp midnight-timer) (cancel-timer midnight-timer)) > > > - (setq midnight-timer > > > - (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) > > > - midnight-period #'run-hooks 'midnight-hook))) > > > + (when (timerp midnight-timer) > > > + (cancel-timer midnight-timer) > > > + (setq midnight-timer > > > + (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) > > > + midnight-period #'run-hooks 'midnight-hook)))) > > > > > > (defcustom midnight-delay 3600 > > > "The number of seconds after the midnight when the `midnight-timer' is run. > > > > > > Can you try this and see if it solves the problem, and doesn't break > > > the other uses of midnight-mode and or clean-buffer-list? > > > > Thanks. It solves the issue of activacting the midnight-mode: now > > `clean-buffer-list' is just done once and won't run the next day. But > > now, when I do M-x midnight-mode, I get the following error: > > > > timer--activate: Invalid or uninitialized timer > > Maybe we could instead check whether `midnight-mode' is on, Eli? Sorry, I don't understand what you have in mind: check where? What needs to be done is to make sure midnight-timer is a timer (calling timer-create if not) before we call midnight-delay-set, because it will only initialize the delay if midnight-timer is already a timer. Alternatively, we could call run-at-time directly from midnight-mode. But I guess you meant some third possibility? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 15:06:35 2024 Received: (at 73291) by debbugs.gnu.org; 17 Sep 2024 19:06:35 +0000 Received: from localhost ([127.0.0.1]:55966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqdX0-00074f-TK for submit@debbugs.gnu.org; Tue, 17 Sep 2024 15:06:35 -0400 Received: from mout.web.de ([212.227.15.3]:44623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqdWy-00074N-Gs for 73291@debbugs.gnu.org; Tue, 17 Sep 2024 15:06:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1726599970; x=1727204770; i=michael_heerdegen@web.de; bh=eNijYnylC5S0bhUEflyKTkrWkZ15JD88mm2EHdfmCJY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=jaHpcYyXidhU7bkvFU7B1r1QcFUPgEHN8pqALJefug8acrxucvgnijQZgStZBxU7 3zcAfUqEP1rHq3/sgzVy/GqNnBmXGZQuyNMP7bcOBQsOt/C/UWdqpdzpPTE6M9BXX GGHsNi4QbbTrzZf5pQ1g+SxOrfryTvnKpTxVhPOVgufvqzWB7MFvxZRoi+yEJkIod R3msdnVVMqeicw5yFrlxsvsx9c26fnyvx3IBBpfuNRH1wQaigx3I3jktsPsmAEuCg CzNVfVYxiqXK3LsysO51WE45XD71z0Ypv6kN0uOXBtZB8gqkVl1V+yoVyDA0m2SOj L583bAf3MvbYCXjPSA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.158]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MdwJO-1sIxCW1326-00okxx; Tue, 17 Sep 2024 21:06:10 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' In-Reply-To: <868qvqbdgl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Sep 2024 16:46:02 +0300") References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> <868qvqbdgl.fsf@gnu.org> Date: Tue, 17 Sep 2024 21:07:04 +0200 Message-ID: <87bk0mgkvb.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:rPrdBup/FcAch5GQoXlHRskxKHgzdo9w6oRO9BXUxvjH6bZ/nC4 HosqHrCcwN2srnlJj4Nnx8TpjAXyztqJAR04sU3VwbyvJR/ttt6nFLdVTFbPN4EI36xwbTi PanyrOdBCBk6b9iUK9Rxg44h1R/EskbLNVimVJVrCjR9X6wE9kIQ7V/OZJ3joFBQ8cXmP03 xSG2y4vJrhDbNcN8r4imA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/DWp64EjjH8=;zd7h0bv5TiVybHgW2n6KxBEBAtz Gbbtx0ZeDHSYpUhf6JG51EMMuHNpRo6BAomJGonL+pX0HlpDGaNyLT5rlOsRsIh5a+msnqT7+ 5DCv7fElivXqEDkj+kOtAK7JO/xut4e/V7bnQaJqAQuodjW7+h7DK8oVUTkLVqvvleO+p+CVm 3LcwfHwwfo22+94tqIy2ZaNkwo5lqInhIwdG6RNu0ml6tbsxcmJZ4lR1QxEfub77uKwZlCL75 KWS3oPCfwE5VdLxtmHIbVa0aiq6trl/pWij29tIwJ87mDI+hOsjUsaI8mw8a3oasFm1dImknk N98Dm8az5eCbHe8XydNEZ6r19lpTfzdutQHITh6y1gw3H1D1Cv5vWnXXbdJX/htDbCSF6cv6q g/ZGc4EjuR/R3aSy/hyFtYJewX1q4x+0MpmBz+w4nOdClbJW8VgsVa+ZkPZR3VqZU/FQTftBd lRzXWgi7nuetkxcoTwjQIJc/+ee3Adrq2Ezn915pvKdhfrqC2VBRwKf7RjtWU6e0Utp1HBeOX V9slKlke/G41/LNPx4mv08ZGrrN20eCoCfXJNWXpby9io4Yd1L7FfbeRzFUbJBtJJPH+UABta g5015lWyEqypkGdMO+qoM9jA0dhod+Qb8T6e3YnzGFg4kog+BdIllo7XPDxHXJV7sAbtPBOdI qdTyi9511WfVzVhI9B1DKiGlWgrvfJTMRPlqvzni96iyhrKAipoKu92c/jgiTXn06afrV75+o GUOotUy1+92ZqqjNa5yykWHUkbyYZ37SB7ki2DVD+kcLqSzBz83JCgyIfvnUIeQAVaVHSY4LR 7GQWC+t0QpaXOWLu+sxwPZ5Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73291 Cc: 73291@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > Alternatively, we could call run-at-time directly from midnight-mode. Short answer: This would be better. Long answer: The current design is bad: `midnight-delay-set', the custom setter of the user option `midnight-delay', is the _only_ place in the whole library where a timer is ever created. The mode function itself does not start a timer (also not indirectly). `midnight-delay-set' OTOH starts the timer unconditionally, no matter if `midnight-mode' is on or off. The timer function also doesn't check whether the mode is on. We need to redesign: we should make the mode start and stop the timer. The setter function should only manipulate the timer, and only when the mode is really turned on. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 15:28:23 2024 Received: (at 73291) by debbugs.gnu.org; 17 Sep 2024 19:28:23 +0000 Received: from localhost ([127.0.0.1]:56020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqds6-0008Gl-N4 for submit@debbugs.gnu.org; Tue, 17 Sep 2024 15:28:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqds4-0008GW-G7 for 73291@debbugs.gnu.org; Tue, 17 Sep 2024 15:28:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqdrh-0005sN-0A; Tue, 17 Sep 2024 15:27:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t6OOXe1+3iGOc6QQiwvEdgLWh7sq3UjLNKEw+aJMtnE=; b=M+uCeJCaqRIT A0qMa1Jha4xOxjsj0p9mIT1+iOJy/t3P/mJ2VwvoVu0ggCN1K0kRjwjB+Mhv+JCyTL2rjGGiJeELa K/d7DBU2aILLQJBwFZoDXjkqDrWH2V4xrej4n+UC5wjMglt8fT81u5H2FwCBh9ETVejNeCoxifbJD MQJ4QmJRaEVAAJpI/cdwpTilhuiWR3KgAFh6iYyU+JFk6M2n7pEMZgLHtNvftyCyCEMQqKf3znd2D Es6/0tkqdFE3n9H4cIejr+ln97p9Ark/0s5KTlx+slKbEz5Xlc9/vKzOPJY08nJgNzRiWUibcYUcN SHnsbxkdNkNCOcUhyfR0+A==; Date: Tue, 17 Sep 2024 22:26:54 +0300 Message-Id: <86y13q9j41.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87bk0mgkvb.fsf@web.de> (message from Michael Heerdegen on Tue, 17 Sep 2024 21:07:04 +0200) Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> <868qvqbdgl.fsf@gnu.org> <87bk0mgkvb.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73291 Cc: 73291@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: 73291@debbugs.gnu.org, manuel@ledu-giraud.fr > Date: Tue, 17 Sep 2024 21:07:04 +0200 > > We need to redesign: we should make the mode start and stop the timer. > The setter function should only manipulate the timer, and only when the > mode is really turned on. I agree; patches to that effect are welcome. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 05:06:56 2024 Received: (at 73291) by debbugs.gnu.org; 18 Sep 2024 09:06:57 +0000 Received: from localhost ([127.0.0.1]:57001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqqeG-0006Hc-BK for submit@debbugs.gnu.org; Wed, 18 Sep 2024 05:06:56 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:14589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqqeC-0006HQ-Pl for 73291@debbugs.gnu.org; Wed, 18 Sep 2024 05:06:54 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=LSdee8D1 DaJAjbwlpUIGNLuREOmulN4H2GKsZ+P9RsQ=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=wzf8ZduzzKxgj3Y4qvjMCwnRxANFC1 Xd2BtuMbW4XcI9wQy8bw53VNRpegoPndA/Adaov/1ArkjFYI/RLXMGCA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=LSdee8D1DaJAjbwl pUIGNLuREOmulN4H2GKsZ+P9RsQ=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Z9y6mq/sln65Xq1pn0zzkAeieW+uLWbpkVVwfR yxfZx7y3h7ewoOVucO9Q7ZVGT7/MhY6kcWHwEkV/OjiHoiApAMNRG9Zzq/POzRKvE2fN2s qDoGf2oqlSqS27S+N7YoTLTeI+bq48eeNSBPC42qEMqos80fg/ch/eIOeKqFl/vFkeD8NI DDlYDgrExmpPoiBOBGMudl/0qugeQIBDxgPq2v2Mtv4F5v9bMTRHt4G6nqltyuiMRNWXue e2W5NKHx5X/HGG2cj49s00cr9aZRwGFQqmdsgTQEw8ez/zPGgW5KH7iSB4kEeozpGsOLaU GunL/Fl9TKraSbzf67LMJgIg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id f99edc93 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 18 Sep 2024 11:06:33 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' In-Reply-To: <86y13q9j41.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Sep 2024 22:26:54 +0300") References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> <868qvqbdgl.fsf@gnu.org> <87bk0mgkvb.fsf@web.de> <86y13q9j41.fsf@gnu.org> Date: Wed, 18 Sep 2024 11:06:32 +0200 Message-ID: <87a5g5l49z.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73291 Cc: Michael Heerdegen , 73291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi, I think the following patch does the trick. Here is what I tested with it: - A call to `clean-buffer-list' cleans up the list once and does not activate the midnight-timer. - The midnight mode is toggled on/off by calling `midnight-mode'. - Calling (customize-variable 'midnight-delay) stops and restarts the midnight-timer with the updated delay. Maybe the line ":initialize #'custom-initialize-default" could be removed, I don't know. WDYT? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=midnight.patch diff --git a/lisp/midnight.el b/lisp/midnight.el index 6e1e7b5ccb7..ff1392abc05 100644 --- a/lisp/midnight.el +++ b/lisp/midnight.el @@ -52,12 +52,11 @@ midnight-mode "Non-nil means run `midnight-hook' at midnight." :global t :initialize #'custom-initialize-default - ;; Disable first, since the ':initialize' function above already - ;; starts the timer when the mode is turned on for the first time, - ;; via setting 'midnight-delay', which calls 'midnight-delay-set', - ;; which starts the timer. - (when (timerp midnight-timer) (cancel-timer midnight-timer)) - (if midnight-mode (timer-activate midnight-timer))) + ;; Call `midnight-delay-set' again because it takes care of starting + ;; the timer if the mode is on. The ':initialize' function above + ;; (which ends up calling `midnight-delay-set') did not know yet if + ;; the mode was on or not. + (midnight-delay-set 'midnight-delay midnight-delay)) ;;; clean-buffer-list stuff @@ -207,9 +206,11 @@ midnight-delay-set "Invalid argument to `midnight-delay-set': `%s'") (set symb tm) (when (timerp midnight-timer) (cancel-timer midnight-timer)) - (setq midnight-timer - (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) - midnight-period #'run-hooks 'midnight-hook))) + ;; Only start the timer if the mode is turned on. + (when midnight-mode + (setq midnight-timer + (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) + midnight-period #'run-hooks 'midnight-hook)))) (defcustom midnight-delay 3600 "The number of seconds after the midnight when the `midnight-timer' is run. --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 19:53:50 2024 Received: (at 73291) by debbugs.gnu.org; 18 Sep 2024 23:53:50 +0000 Received: from localhost ([127.0.0.1]:59396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sr4UY-0004r5-0p for submit@debbugs.gnu.org; Wed, 18 Sep 2024 19:53:50 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:46305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sr4UW-0004qq-DU for 73291@debbugs.gnu.org; Wed, 18 Sep 2024 19:53:49 -0400 Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c3d20eed0bso346625a12.0 for <73291@debbugs.gnu.org>; Wed, 18 Sep 2024 16:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726703546; x=1727308346; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=/FdaLG47ArChtwvPmAMr46coKqOm+6SgIqLP8JCdvAA=; b=i1BUqYQxpc2gPRjFhB82BfoJgnJ66du89fT4K5C7uiIPFXXfvZxO7ghr1AMNY7bz28 XXxLlipMjQVryTNVwj53F+u8PCbd782wGUsejp9FWKNIbP7j4POvvsQcM1kJdYs33NxC qB8aQqVFIjMfza6XjyCKGhF1mbufcisDxV3880EWDJQ93T+o12Ps63hR2NTd7DapW9ls a4oTUtEl8PMkSp3olXMpNhkGWnjK+CbtzqSUyRCjtL/mkRaZJHr3evsrsIJ5azU1pTGu ftf37Ec1/10NlgmrosePs409SQclWtXDPrSSTRiPFnETdiWmjdHKoUk0I03l167rw69c di/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726703546; x=1727308346; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/FdaLG47ArChtwvPmAMr46coKqOm+6SgIqLP8JCdvAA=; b=XZ9yYnIHxGdxbBOjRnuIYNewxd8kWbX0RhCst4LusXkpK5LtJhz7dAeCcWGpnOb/VR 71jjqw+Jk4isnsPKk1c8ZifIkJ9DXyQSkg8p4e3qaFfOtIDVN+NJcjl9WK/WNCvM6BW2 9tz4GcHpzB4j3z5eZbfljRhG/clPaseUclAmQjYcZH7E1O1sAL362EzCdFSzKIk5+WR5 ZbIGLIN94MVq5DEXmesELDBtSpq+CBqJPPnI2owcBy0JVf1YbXh8KzAku8e4q9lioInt PRbSLVGdZqUXe47DnT4oHPCIkscTg6NzWZS5K3E8J6WJo34LXeoiB6XMZVdd9fa7Y2/f CdKA== X-Forwarded-Encrypted: i=1; AJvYcCWCfgiQX3f+xz9estUe8/w0OEdGTnNBiVVKkw9aQR3yNYrUxvTo73DJSV5q/jR8L1HRSlLziQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwC28Bo5pdCUp5f2qLEEVZ+bVacAbajS1aqzehwMK/HzPmvBZMq 0hgvzErWhLJqGo5RocwSt1qBW1JuvhRAj1d6RTCSPVwrJBloDEAozwvVBto3DoUU2xMprvbTp/q I4ZJzOMfLW+eVunJXFY1sZVwFjVk= X-Google-Smtp-Source: AGHT+IG7xoEt40+RIThrv+MEZtHdeDoCo6d3DsvGwJ9ichd9d0umnSBf3W8mZ3DDI+tRU3ziYboveByESveXpY46hJg= X-Received: by 2002:a05:6402:3506:b0:5c4:95b:b150 with SMTP id 4fb4d7f45d1cf-5c413cbd9e5mr20309067a12.0.1726703545841; Wed, 18 Sep 2024 16:52:25 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Sep 2024 16:52:25 -0700 From: Stefan Kangas In-Reply-To: <87a5g5l49z.fsf@ledu-giraud.fr> References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> <868qvqbdgl.fsf@gnu.org> <87bk0mgkvb.fsf@web.de> <86y13q9j41.fsf@gnu.org> <87a5g5l49z.fsf@ledu-giraud.fr> MIME-Version: 1.0 Date: Wed, 18 Sep 2024 16:52:25 -0700 Message-ID: Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' To: Manuel Giraud , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73291 Cc: Michael Heerdegen , 73291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > I think the following patch does the trick. Previously, putting this in your init file enabled midnight-mode: (require 'midnight) Now, one needs to say this instead: (midnight-mode +1) Right? If yes, this change is backwards-incompatible and should be called out in NEWS. I still think this is worth doing, because we want to avoid side-effects like enabling modes just from loading an Emacs Lisp library. This is one of few such places that we have left. Not having midnight-mode on should also usually not be a very big problem. Since the latter will work on previous versions of Emacs all the way back to 25.1, I think we might as well install the below documentation patch on the emacs-30 branch too. diff --git a/lisp/midnight.el b/lisp/midnight.el index bfa99d6a7a8..cc9150ccc9e 100644 --- a/lisp/midnight.el +++ b/lisp/midnight.el @@ -23,7 +23,7 @@ ;;; Commentary: -;; To use the file, put (require 'midnight) into your .emacs. Then, at +;; To use the file, put (midnight-mode) into your .emacs. Then, at ;; midnight, Emacs will run the normal hook `midnight-hook'. You can ;; put whatever you like there, say, `calendar'; by default there is ;; only one function there - `clean-buffer-list'. It will kill the From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 01:54:26 2024 Received: (at 73291) by debbugs.gnu.org; 19 Sep 2024 05:54:26 +0000 Received: from localhost ([127.0.0.1]:59646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srA7W-0007ev-15 for submit@debbugs.gnu.org; Thu, 19 Sep 2024 01:54:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srA7S-0007eb-OQ for 73291@debbugs.gnu.org; Thu, 19 Sep 2024 01:54:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srA75-0006y8-GA; Thu, 19 Sep 2024 01:53:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LDlkld0Kz4RhQwVSscXZ3srYyBYNr430tPegf1BqpAM=; b=LhEA0lGHLEG0 7DlKDdKmDIuQMX+SpeFJWmb4XxcqcewNSLZuBG5VbhGW7LrSMGrERVX+bTJ0Lk38qSoJaYqYUws2K Z2/jiEjNfzqF6Uble4oD4sxFuJz3xMIyPvoC2n6AMk3smicO59x5HAUGMUMWcyAxukB2MpC7jTSoi jxgkH9Pr/blGV6M5si6iOw0BQiLiSC/7Lbe11D5JecCFDfc79FRx2j71gf7LTvfA+xRUT+CilIHSB 74QkGTw9MUALphgfx1cpoeOST7Oqvq5EMsmfWTQNC6SlGmdY7JsZmys2l53+jB/LBQgDeh02tVh8q 61NadGG2mO/PKBry93XkLw==; Date: Thu, 19 Sep 2024 08:53:38 +0300 Message-Id: <865xqs9okd.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Wed, 18 Sep 2024 16:52:25 -0700) Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> <868qvqbdgl.fsf@gnu.org> <87bk0mgkvb.fsf@web.de> <86y13q9j41.fsf@gnu.org> <87a5g5l49z.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73291 Cc: michael_heerdegen@web.de, 73291@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 18 Sep 2024 16:52:25 -0700 > Cc: Michael Heerdegen , 73291@debbugs.gnu.org > > Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > I think the following patch does the trick. > > Previously, putting this in your init file enabled midnight-mode: > > (require 'midnight) > > Now, one needs to say this instead: > > (midnight-mode +1) > > Right? If yes, this change is backwards-incompatible and should be > called out in NEWS. Agreed. The user manual already says (in effect) to use the latter, so we are good in that department. > I still think this is worth doing, because we want to avoid side-effects > like enabling modes just from loading an Emacs Lisp library. This is > one of few such places that we have left. Not having midnight-mode on > should also usually not be a very big problem. Yes, agreed. > Since the latter will work on previous versions of Emacs all the way > back to 25.1, I think we might as well install the below documentation > patch on the emacs-30 branch too. Agreed. So please install all the other changes on master and this one on the release branch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 20:28:34 2024 Received: (at 73291) by debbugs.gnu.org; 21 Sep 2024 00:28:35 +0000 Received: from localhost ([127.0.0.1]:36770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srnzG-0006uY-KV for submit@debbugs.gnu.org; Fri, 20 Sep 2024 20:28:34 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:49527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srnzE-0006uG-7e for 73291@debbugs.gnu.org; Fri, 20 Sep 2024 20:28:33 -0400 Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c5b6161022so737056a12.3 for <73291@debbugs.gnu.org>; Fri, 20 Sep 2024 17:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726878427; x=1727483227; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=p+nCYbSt40cdzkAZRDmfLhoutDGkz9vYn7dph0cassU=; b=OBoSyjvjTiRUoo77cTgY34MD6Yx+iRnztnmdA5oxjFA7sdtR9tiNPix76o+OK4zAb5 RTvLlPgzw50+ZqPFq4SUF+eoc9uQYrVsyVvILgqY0dUNssw+8xEH42P9ZwMOc8v5d+S2 NMshv6ZCBxMmC+dc19A2dbmwSr6/9lgfqMv2bwabHc/FGb+n6xCx9gVZJSeX7W/hzgmG 623DBwEVeG+MixSbJUu7Nno1iE+lBJDaKiwxEOfx4VTJJocGokaPLp7PZg0CZqc0lFON Mcu15I9n22dbcCngbtW5BBYZ8SRh70YA8VnC7fdfx7NzDqXOJRAGuSWn3tI7KaRB9VOV 2yVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726878427; x=1727483227; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p+nCYbSt40cdzkAZRDmfLhoutDGkz9vYn7dph0cassU=; b=An/pY0Bsyri+0huptYyaRxcoUuJMbDpVLRkeRJYXaiIWOSIbJ7nWbC3u8Tiaam/474 naujM7VM2/PbGOk1XHcbhmsRnpgJq3tASvvt9khkU9A/1j2SKKmM9TjoWuNiafB5Wx79 PoiSrmqE33X71pXhNpDMoII/NKIaOFyclHz6cVg9XARkjr3Z4GLEzrwvlXm7ijTMMaf4 0Ja62jxsUj0Tcn4cUjcVgv9I759b/135cWddeKVPar3IAkd8m5kJmTad9J6yFeOizDLj KMTKViwfDl6kqxTxkaqFMlk+QqMQ+eozOyByNSOMAtMj0IUASsGU8jorMiUQ0myMteVc JzuA== X-Forwarded-Encrypted: i=1; AJvYcCWdiNuaK4wwWo9w8TL62/91dTVTAioZ+WCruJTO8C17vN63LWz411bpkyo2lQKqweUPDTdB8Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy+MfcGyQo3h3trANUb6LdTN+Si4zXB9EzxcU7B/Wu3BIjJ1sv6 0wbxOfdhJa+0Hq5wv+ijpi/7b3uD5FuKGu8tz6v+g0IWH6toDi4oE6J8xTOcowYHRlkX2T41//p 9KChGbpwY/5+zL2853VCIAcHwg70= X-Google-Smtp-Source: AGHT+IHmraO2J/slbNNIiNgdDqKTFNp2OxTDh3KTccVn9j/eQsPZc79yV102fyawBK8FiFFEZB76VHImD8KJ2ygwqCs= X-Received: by 2002:a05:6402:358c:b0:5c2:4cbe:ac1c with SMTP id 4fb4d7f45d1cf-5c46466458amr3392828a12.4.1726878426582; Fri, 20 Sep 2024 17:27:06 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 Sep 2024 17:27:05 -0700 From: Stefan Kangas In-Reply-To: <865xqs9okd.fsf@gnu.org> References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> <868qvqbdgl.fsf@gnu.org> <87bk0mgkvb.fsf@web.de> <86y13q9j41.fsf@gnu.org> <87a5g5l49z.fsf@ledu-giraud.fr> <865xqs9okd.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 20 Sep 2024 17:27:05 -0700 Message-ID: Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73291 Cc: michael_heerdegen@web.de, 73291@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > So please install all the other changes on master and this one on the > release branch. I did the second part. Manuel, could you please resubmit your patch as formatted by git format-patch -1 ? That way, we'll get the attribution right. Please also add a ChangeLog entry as always. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 21 08:55:32 2024 Received: (at 73291) by debbugs.gnu.org; 21 Sep 2024 12:55:32 +0000 Received: from localhost ([127.0.0.1]:37557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srze8-0005ca-0B for submit@debbugs.gnu.org; Sat, 21 Sep 2024 08:55:32 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:34270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srze5-0005aJ-AK for 73291@debbugs.gnu.org; Sat, 21 Sep 2024 08:55:30 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=FLOgRPg6 2HDi7CQQwkMWHSARnHmU0i9EzMOoesfpjH8=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=PXu7DF6a2ATERIDcETbLbW0cUV+g9f e98ByLkaPXlXRj1AczP+UKF+vWH9kpx7xzcUGBhtRJ6NcUmq8oqX/9AA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=FLOgRPg62HDi7CQQ wkMWHSARnHmU0i9EzMOoesfpjH8=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=osqWE7uEsqhceZ5lDtZoICO3ZNTHKsStgU4KuG pjB6a710KfDgwsiClbtGTLLXpcokEks3yTRKW22rDlqMIdpYFQxRIw/4lscmjVi4FnxJ4H Tb2Z84iD65pKej8yyjH3r4DJU0lEIaSYweIJzbdp3iBBigkRcYNM3tnkwqDpXmPbyR7gYp rzf32tFqfdZqkVpkya6SzRw0ARAOIEo7aosSd/q1NzJ3FjpO0Si7jJK5W5dn621acD8lGJ W99yEk50s7tZuGeW0Ge7KbCgoVjLn31jPAvXP4xqqlZRDlwm/FjmeNFNJ8R/GrC4Uujazj 2oo4ZDlHJYTnpLJMcCSlJHpg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 633ae95d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 21 Sep 2024 14:55:06 +0200 (CEST) From: Manuel Giraud To: Stefan Kangas Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' In-Reply-To: (Stefan Kangas's message of "Fri, 20 Sep 2024 17:27:05 -0700") References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> <868qvqbdgl.fsf@gnu.org> <87bk0mgkvb.fsf@web.de> <86y13q9j41.fsf@gnu.org> <87a5g5l49z.fsf@ledu-giraud.fr> <865xqs9okd.fsf@gnu.org> Date: Sat, 21 Sep 2024 14:55:05 +0200 Message-ID: <87v7ypxj2u.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73291 Cc: michael_heerdegen@web.de, Eli Zaretskii , 73291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Kangas writes: > Eli Zaretskii writes: > >> So please install all the other changes on master and this one on the >> release branch. > > I did the second part. > > Manuel, could you please resubmit your patch as formatted by Here. I also add the NEWS entry as suggested by Eli. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-clean-buffer-list-don-t-activate-midnight-mode.patch >From 8d668972fad20b1baba3d7a56f3612e0d7689e25 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sat, 21 Sep 2024 14:51:21 +0200 Subject: [PATCH] clean-buffer-list don't activate midnight-mode Bug#73291 * lisp/midnight.el (midnight-mode): Call `midnight-delay-set' again when mode is activated. (midnight-delay-set): Only start the timer if the mode is turned on. * etc/NEWS: Document the change in behaviour. --- etc/NEWS | 7 +++++++ lisp/midnight.el | 19 ++++++++++--------- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 6c97ffacd15..46abc908c6e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -390,6 +390,13 @@ functionality of the standard 'xref' commands in TeX buffers. You can restore the standard 'etags' backend with the 'M-x xref-etags-mode' toggle. +** Midnight mode + +--- +*** Change for activating the mode +Putting (require 'midnight) in your init file no longer activates the +mode. Now, one needs to say (midnight-mode +1) instead. + * New Modes and Packages in Emacs 31.1 diff --git a/lisp/midnight.el b/lisp/midnight.el index ea30f5462f2..e5dd7221591 100644 --- a/lisp/midnight.el +++ b/lisp/midnight.el @@ -52,12 +52,11 @@ midnight-mode "Non-nil means run `midnight-hook' at midnight." :global t :initialize #'custom-initialize-default - ;; Disable first, since the ':initialize' function above already - ;; starts the timer when the mode is turned on for the first time, - ;; via setting 'midnight-delay', which calls 'midnight-delay-set', - ;; which starts the timer. - (when (timerp midnight-timer) (cancel-timer midnight-timer)) - (if midnight-mode (timer-activate midnight-timer))) + ;; Call `midnight-delay-set' again because it takes care of starting + ;; the timer if the mode is on. The ':initialize' function above + ;; (which ends up calling `midnight-delay-set') did not know yet if + ;; the mode was on or not. + (midnight-delay-set 'midnight-delay midnight-delay)) ;;; clean-buffer-list stuff @@ -207,9 +206,11 @@ midnight-delay-set "Invalid argument to `midnight-delay-set': `%s'") (set symb tm) (when (timerp midnight-timer) (cancel-timer midnight-timer)) - (setq midnight-timer - (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) - midnight-period #'run-hooks 'midnight-hook))) + ;; Only start the timer if the mode is turned on. + (when midnight-mode + (setq midnight-timer + (run-at-time (if (numberp tm) (+ (midnight-next) tm) tm) + midnight-period #'run-hooks 'midnight-hook)))) (defcustom midnight-delay 3600 "The number of seconds after the midnight when the `midnight-timer' is run. -- 2.46.0 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 21 09:06:29 2024 Received: (at 73291-done) by debbugs.gnu.org; 21 Sep 2024 13:06:29 +0000 Received: from localhost ([127.0.0.1]:37582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srzoi-0006MG-Oy for submit@debbugs.gnu.org; Sat, 21 Sep 2024 09:06:29 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:51277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srzog-0006Lv-Rx for 73291-done@debbugs.gnu.org; Sat, 21 Sep 2024 09:06:27 -0400 Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5c2561e8041so4005856a12.2 for <73291-done@debbugs.gnu.org>; Sat, 21 Sep 2024 06:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726923901; x=1727528701; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=57gBX/uh3zW1de/4SII/HvKVHyCczWz6o2Ozoo9vKTs=; b=gqZhnIkWMuml/5RG1s69ksB22xW8OJq9Lp2+eATE1dcEo0lAsNvl7us9jblzWopntY 2k4s5bwCuq5rfEkcJ2c4OnB2Gbemb2Hki0MJdDWROhyYiCPuCJb5V3TZaPR8L9W+qAMG rbpQDz3XYl0JU5Z7QnpZLEdcKmviaa1Q5Aiis2Jpu8zJCuKOp8SEBtA/hhzrV3x9kjRk QTZyuJxgyLo5dprdd8Et+ZAzqIfsaO94hzUMnRt4I97t6UXc/8Wncl4v0YrveMf68Nuy kZnJXzM7r1i9Y57db4YSlreOeyWcsNEjX4m0+O/skUxvav75wKeLQHIBMZS39uuwR6j+ sZaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726923901; x=1727528701; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=57gBX/uh3zW1de/4SII/HvKVHyCczWz6o2Ozoo9vKTs=; b=NAu7sOuyflp7k4WQt/KUXlnnk2D/LyEBq2edGIirwqGIcvCgiwr1NWkYXknDdazwtM qVQRMhqT2buuLoMHYm88AaJBmw19Bj+WEnRoAW30BL/XDsJiWS0ZAX0WBJkVdxdgY7mE vZMsGE99aIbF76YpycBDyMRzsEoTIJVJXGfJ23z6f8WggUqudU2y9y2b6VMWfzj3OuX6 CSWBqilchgvG4d9QYpl89RKsnp5wqiy3QliSDz/gcEAycu3C9b1HM9ZY60604DWDKskU q1dcUVzjCc4Sik/H9RvC9e4VZq8I/VPp5RPaEEiy++tAcngaZ50E043P+6m1oxs1C8Kk m4bA== X-Forwarded-Encrypted: i=1; AJvYcCWIp2HNHVwZdtBe3smp/NJfdgqG2r3lBgzxFAp4EfDPxGSTUGaQPi5kqWIHYio1Hf3OHWXjCkjKFuXf@debbugs.gnu.org X-Gm-Message-State: AOJu0YyeIquEd6KOFpuyQ6p7sxQA/7X1N04tL25GxI4DVbpfOjJ/xuRK bjke1C0qWFIxpZ7/FIK78pmQwRol74WBLsx0tLjByiVsH7/KqBYjWDyvAS9PxYgzToqTF+frsmR QiqArXDo4VVzfMAW1fc72Ycq5Dc4= X-Google-Smtp-Source: AGHT+IGilzQuEIOurk9exgufjgl1e0SMcJ1dtfG8QRXYKJSTMJFgn1P8IzJQOs+kp/aF/8PfNCHVVXxrsrjzso5ktOE= X-Received: by 2002:a05:6402:3786:b0:5c0:bb1c:723 with SMTP id 4fb4d7f45d1cf-5c464a3ebf9mr4942675a12.14.1726923900644; Sat, 21 Sep 2024 06:05:00 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 21 Sep 2024 06:04:59 -0700 From: Stefan Kangas In-Reply-To: <87v7ypxj2u.fsf@ledu-giraud.fr> References: <87plp4vy08.fsf@ledu-giraud.fr> <86ikuvd9tp.fsf@gnu.org> <87frpyofoi.fsf@ledu-giraud.fr> <87frpyh11i.fsf@web.de> <868qvqbdgl.fsf@gnu.org> <87bk0mgkvb.fsf@web.de> <86y13q9j41.fsf@gnu.org> <87a5g5l49z.fsf@ledu-giraud.fr> <865xqs9okd.fsf@gnu.org> <87v7ypxj2u.fsf@ledu-giraud.fr> MIME-Version: 1.0 Date: Sat, 21 Sep 2024 06:04:59 -0700 Message-ID: Subject: Re: bug#73291: 31.0.50; `clean-buffer-list' activates `midnight-mode' To: Manuel Giraud Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73291-done Cc: michael_heerdegen@web.de, Eli Zaretskii , 73291-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Manuel Giraud writes: > Here. I also add the NEWS entry as suggested by Eli. Thanks. Thanks, pushed to master (commit 4745bafa6a1) with some minor copy editing of the commit message. I'm therefore closing this bug report. From unknown Tue Jun 17 01:43:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 20 Oct 2024 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator