GNU bug report logs - #73287
[PATCH 0/3] Add ericw-tools and TrenchBroom.

Previous Next

Full log

Message #26 received at 73287 <at> debbugs.gnu.org (full text, mbox):

From: James Smith <jsubuntuxp <at> disroot.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 73287 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/3] gnu: Add embree-2.
Date: Fri, 20 Sep 2024 17:35:33 -0700

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Sonntag, dem 15.09.2024 um 19:16 -0700 schrieb James Smith:
>> +    ;; Tries to build with SSE2 and AVX support on ARM, so disable
>> building for
>> +    ;; those systems.
> Comments should be full sentences.  Also, this is a hint that it uses
> SSE2 and AVX on the platforms below too – we should disable them, as
> they won't work with every CPU.
I've investigated on disabling them, but it seems that embree 2 (and 3
for that matter) has a hard requirement for SSE2 and have updated the
comment as such. I've gone ahead and implemented your suggestions for
the other patches though and will be sending them shortly.
>> +    (supported-systems (list "i686-linux" "x86_64-linux"))))
>> +
>
> Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.