GNU bug report logs - #73287
[PATCH 0/3] Add ericw-tools and TrenchBroom.

Previous Next

Full log

Message #17 received at 73287 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: James Smith <jsubuntuxp <at> disroot.org>, 73287 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/3] gnu: Add embree-2.
Date: Fri, 20 Sep 2024 09:58:45 +0200

Am Sonntag, dem 15.09.2024 um 19:16 -0700 schrieb James Smith:
> * gnu/packages/graphics.scm: (embree-2): New variable.
> 
> Change-Id: I2b2143b4d93c402ba940d408280ef1b37ab552ea
> ---
>  gnu/packages/graphics.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
> index 3d03802245..d893c9dfee 100644
> --- a/gnu/packages/graphics.scm
> +++ b/gnu/packages/graphics.scm
> @@ -37,6 +37,7 @@
>  ;;; Copyright © 2023 David Thompson <dthompson2 <at> worcester.edu>
>  ;;; Copyright © 2023 Eric Bavier <bavier <at> posteo.net>
>  ;;; Copyright © 2023, 2024 Artyom V. Poptsov
> <poptsov.artyom <at> gmail.com>
> +;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -490,6 +491,27 @@ (define-public embree-3
>                 (base32
>                 
> "1kcvz7g6j56anv9zjyd3gidxl46vipw0gg82lns12m45cd43iwxm"))))))
>  
> +(define-public embree-2
> +  (package/inherit embree
> +    (version "2.17.7")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference (url
> "https://github.com/RenderKit/embree")
> +                           (commit (string-append "v" version))))
> +       (file-name (git-file-name (package-name embree) version))
> +       (sha256
> +        (base32
> "19v60zdfix33c772x6dzmhsarhafsns8qy7c2ysqr7a9j16whgql"))))
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments embree)
> +       ((#:configure-flags configure-flags)
> +        #~(append (list "-DEMBREE_TUTORIALS=OFF") #$configure-
> flags))))
> +    (inputs (modify-inputs (package-inputs embree)
> +              (replace "tbb" tbb-2020)))
> +    ;; Tries to build with SSE2 and AVX support on ARM, so disable
> building for
> +    ;; those systems.
Comments should be full sentences.  Also, this is a hint that it uses
SSE2 and AVX on the platforms below too – we should disable them, as
they won't work with every CPU.
> +    (supported-systems (list "i686-linux" "x86_64-linux"))))
> +

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.