GNU bug report logs - #73260
Add libguestfs

Previous Next

Full log

Message #23 received at 73260 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Giacomo Leidi <goodoldpaul <at> autistici.org>
Cc: 73260 <at> debbugs.gnu.org
Subject: Re: bug#73260: Add libguestfs
Date: Mon, 30 Sep 2024 19:07:04 +0200

Giacomo Leidi <goodoldpaul <at> autistici.org> skribis:

> * gnu/packages/virtualization.scm (libguestfs-minimal): New variable.
> * gnu/packages/patches/libguestfs-syms.patch: Add file.
> * gnu/local.mk: Add it.
>
> Change-Id: Ide22707724ecd41145243c9f41adc3f5557c593e

[...]

> +++ b/gnu/packages/patches/libguestfs-syms.patch
> @@ -0,0 +1,26 @@
> +diff -urN a/lib/Makefile.am b/lib/Makefile.am

As suggested by ‘guix lint’ :-), please add a couple of lines at the top
explaining what the patch does and what its upstream status is.


[...]

> +               (modify-phases %standard-phases
> +                 (add-after 'unpack 'patch-makefiles
> +                   (lambda _
> +                     (for-each patch-shebang
> +                               (find-files "."))
> +                     (for-each (lambda (makefile)
> +                                 (substitute* "ocaml/Makefile.am"
> +                                   (("\\$\\(DESTDIR\\)\\$\\(OCAMLLIB\\)")
> +                                    lib/ocaml)))
> +                               '("ocaml/Makefile.am"
> +                                 "ocaml/Makefile.in"))))
> +                 (replace 'bootstrap
> +                   (lambda _
> +                     (invoke "autoreconf" "-vif")))

You can arrange to only modify ‘Makefile.in’, in which case the
‘bootstrap’ phase is unnecessary and autotools can be removed from the
inputs.

> +                        ;; The ‘validate-runpath’ phase fails to find libguestfs.so.0.
> +                        (invoke (string-append #$(this-package-native-input "patchelf")
> +                                               "/bin/patchelf")
> +                                "--add-rpath" (string-append #$output "/lib") sofile))
> +                      '("perl/blib/arch/auto/Sys/Guestfs/Guestfs.so"
> +                        "ocaml/dllmlguestfs.so"))))

Same comment as on the previous patch.  :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.