GNU bug report logs - #73258
31.0.50; w32 drag-n-dropping multiple files is broken

Previous Next

Full log

View this message in rfc822 format

From: Cecilio Pardo <cpardo <at> imayhem.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73258 <at> debbugs.gnu.org
Subject: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken
Date: Sat, 21 Sep 2024 15:41:03 +0200

[Message part 1 (text/plain, inline)]

On 21/09/2024 12:11, Eli Zaretskii wrote:
> This causes the following warning while byte-compiling:
>
>    In w32-dropped-file-to-url:
>    term/w32-win.el:129:29: Warning: reference to free variable `window'
>
> And indeed, 'window' is not bound to any value here, and
> dnd-handle-multiple-urls does need it to be a valid window.  If I try
> drag-and-drop with your patch installed, Emacs signals an error about
> 'window' being void.  I don't understand how it worked for you.
>
> Also, what about this comment:
>
>    ;; FIXME: is the W32 build capable only of receiving a single file
>    ;; from each drop?
>
> I guess it is no longer pertinent and should be deleted?

I messed up when preparing the patch file, I'm sorry.

Here is the correct one.

[0001-Fix-multifile-drag-n-drop-on-win32.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.