From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 15:33:19 2024 Received: (at submit) by debbugs.gnu.org; 14 Sep 2024 19:33:19 +0000 Received: from localhost ([127.0.0.1]:47827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spYWF-0002dy-4D for submit@debbugs.gnu.org; Sat, 14 Sep 2024 15:33:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:49374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spYWC-0002dq-PS for submit@debbugs.gnu.org; Sat, 14 Sep 2024 15:33:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spYW1-0001XZ-L2 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 15:33:05 -0400 Received: from mail.imayhem.com ([82.223.54.191] helo=zealous-pike.82-223-54-191.plesk.page) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spYVz-0003pV-Bl for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 15:33:05 -0400 Received: from [192.168.68.102] (111.red-88-21-7.staticip.rima-tde.net [88.21.7.111]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 3BD34800C9 for ; Sat, 14 Sep 2024 19:33:01 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[192.168.68.102] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Type: multipart/mixed; boundary="------------Ef2MHH9OQMcMOatTvpTlMznv" Message-ID: Date: Sat, 14 Sep 2024 21:33:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: es-ES To: bug-gnu-emacs@gnu.org From: Cecilio Pardo Subject: 31.0.50; w32 drag-n-dropping multiple files is broken Received-SPF: pass client-ip=82.223.54.191; envelope-from=cpardo@imayhem.com; helo=zealous-pike.82-223-54-191.plesk.page X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------Ef2MHH9OQMcMOatTvpTlMznv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit dnd-handle-multiple-urls is called once for each file. This brings problems, such that when dropping two directories, emacs open the first one on dired, then tries to copy the contents of the second to the first. The attached patch fixes this. -- Cecilio Pardo --------------Ef2MHH9OQMcMOatTvpTlMznv Content-Type: text/plain; charset=UTF-8; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvdGVybS93MzItd2luLmVsIGIvbGlzcC90ZXJtL3czMi13aW4u ZWwKaW5kZXggM2MwYWNmMzY4ZjQuLjI5NjI5YzkwNzJjIDEwMDY0NAotLS0gYS9saXNwL3Rl cm0vdzMyLXdpbi5lbAorKysgYi9saXNwL3Rlcm0vdzMyLXdpbi5lbApAQCAtMTAwLDcgKzEw MCw3IEBAIHczMi1jb2xvci1tYXAKIDs7ICAgKGludGVyYWN0aXZlICJlIikKIDs7ICAgKHBy aW5jIGV2ZW50KSkKIAotKGRlZnVuIHczMi1oYW5kbGUtZHJvcHBlZC1maWxlICh3aW5kb3cg ZmlsZS1uYW1lKQorKGRlZnVuIHczMi1kcm9wcGVkLWZpbGUtdG8tdXJsIChmaWxlLW5hbWUp CiAgIChsZXQgKChmIChpZiAoZXEgc3lzdGVtLXR5cGUgJ2N5Z3dpbikKICAgICAgICAgICAg ICAgIChjeWd3aW4tY29udmVydC1maWxlLW5hbWUtZnJvbS13aW5kb3dzIGZpbGUtbmFtZSB0 KQogICAgICAgICAgICAgIChzdWJzdC1jaGFyLWluLXN0cmluZyA/XFwgPy8gZmlsZS1uYW1l KSkpCkBAIC0xMTcsMTQgKzExNywxMiBAQCB3MzItaGFuZGxlLWRyb3BwZWQtZmlsZQogICAg ICAgICAgICAgICAgICAgICAgKHNwbGl0LXN0cmluZyAoZW5jb2RlLWNvZGluZy1zdHJpbmcg ZiBjb2RpbmcpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvIikKICAg ICAgICAgICAgICAgICAgICAgICIvIikpKQotICA7OyBGSVhNRTogaXMgdGhlIFczMiBidWls ZCBjYXBhYmxlIG9ubHkgb2YgcmVjZWl2aW5nIGEgc2luZ2xlIGZpbGUKLSAgOzsgZnJvbSBl YWNoIGRyb3A/Ci0gIChkbmQtaGFuZGxlLW11bHRpcGxlLXVybHMgd2luZG93IChsaXN0IChj b25jYXQKLQkJCSAgICAgICAgICAgICAgICAgIChpZiAoZXEgc3lzdGVtLXR5cGUgJ2N5Z3dp bikKLQkJCQkgICAgICAgICAgICAgICJmaWxlOi8vIgotCQkJICAgICAgICAgICAgICAgICAg ICAiZmlsZToiKQotCQkJICAgICAgICAgICAgICAgICAgZmlsZS1uYW1lKSkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAncHJpdmF0ZSkpCisKKyAgKGNvbmNhdAorICAgKGlmIChl cSBzeXN0ZW0tdHlwZSAnY3lnd2luKQorICAgICAgICJmaWxlOi8vIgorICAgICAiZmlsZToi KQorICAgZmlsZS1uYW1lKSkKIAogKGRlZnVuIHczMi1kcmFnLW4tZHJvcCAoZXZlbnQgJm9w dGlvbmFsIG5ldy1mcmFtZSkKICAgIkVkaXQgdGhlIGZpbGVzIGxpc3RlZCBpbiB0aGUgZHJh Zy1uLWRyb3AgRVZFTlQuCkBAIC0xNDYsOCArMTQ0LDExIEBAIHczMi1kcmFnLW4tZHJvcAog ICAgICAgKHJhaXNlLWZyYW1lKQogICAgICAgKHNldHEgd2luZG93IChzZWxlY3RlZC13aW5k b3cpKQogCi0gICAgICAobWFwYyAoYXBwbHktcGFydGlhbGx5ICMndzMyLWhhbmRsZS1kcm9w cGVkLWZpbGUgd2luZG93KQotICAgICAgICAgICAgKGNhciAoY2RyIChjZHIgZXZlbnQpKSkp KSkpCisgICAgICAoZG5kLWhhbmRsZS1tdWx0aXBsZS11cmxzCisgICAgICAgd2luZG93IAor ICAgICAgIChtYXBjYXIgIyd3MzItZHJvcHBlZC1maWxlLXRvLXVybCAKKyAgICAgICAgICAg ICAgIChjYXIgKGNkciAoY2RyIGV2ZW50KSkpKQorICAgICAgICdwcml2YXRlKSkpKQogCiAo ZGVmdW4gdzMyLWRyYWctbi1kcm9wLW90aGVyLWZyYW1lIChldmVudCkKICAgIkVkaXQgdGhl IGZpbGVzIGxpc3RlZCBpbiB0aGUgZHJhZy1uLWRyb3AgRVZFTlQsIGluIG90aGVyIGZyYW1l cy4K --------------Ef2MHH9OQMcMOatTvpTlMznv-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 15 04:25:42 2024 Received: (at 73258) by debbugs.gnu.org; 15 Sep 2024 08:25:42 +0000 Received: from localhost ([127.0.0.1]:48318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spkZh-0004AP-O8 for submit@debbugs.gnu.org; Sun, 15 Sep 2024 04:25:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spkZf-0004AC-TL for 73258@debbugs.gnu.org; Sun, 15 Sep 2024 04:25:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spkZO-0001NU-9L; Sun, 15 Sep 2024 04:25:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j/bpYy/jaG21KUvQG60Xvzegy9VwJrdfvxXP/X1M4gQ=; b=OkQFQlAp8lyL q6r6xdMkL8GKgjikVvHP2w9Pgn/Nr747RUIniQlBQwGHdMjrMF5klmdABrK4Oz0vTQt0QQ65XTT54 gfc8N6oB4PPN8gON1b3nHMNm2Y5H4EDTAzpi/wzIRG5WQDwvHbU8+NOQ4h+KhAVpu6L7BUAX8UcPM xsG7J6IMBUx18Ngkfe08AB7WTyeYJu1ji6uV30Kcz3ko0TOFTAAV2KZmdMkMPpcvxpufApTZMKbs5 auu3xWrprxXjZ3O8IMbLCBQTRmfEyXeEOfgTyyt21XErJDZWCl1X8RLiSv8bu7bTcOl/rsZBmTE2m ofbdPDzzT+BFdlRw25yTzw==; Date: Sun, 15 Sep 2024 11:25:18 +0300 Message-Id: <86a5g9e32p.fsf@gnu.org> From: Eli Zaretskii To: Cecilio Pardo In-Reply-To: (message from Cecilio Pardo on Sat, 14 Sep 2024 21:33:00 +0200) Subject: Re: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73258 Cc: 73258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 14 Sep 2024 21:33:00 +0200 > From: Cecilio Pardo > > dnd-handle-multiple-urls is called once for each file. This brings > problems, such that when dropping two directories, emacs open the first > one on dired, then tries to copy the contents of the second to the > first. The attached patch fixes this. -- Cecilio Pardo Thanks. We cannot remove or make backward-incompatible changes in a public API. So removing/renaming w32-handle-dropped-file and/or changing its signature is out of the question. Can you rewrite the patch such that it keeps this function and its arguments, and just change the implementation to fix the problem? Also, please accompany your changes with a ChangeLog-style description (see CONTRIBUTE for the details), to make the job of installing the changes easier. Thanks again for working on this. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 15 15:22:54 2024 Received: (at 73258) by debbugs.gnu.org; 15 Sep 2024 19:22:54 +0000 Received: from localhost ([127.0.0.1]:50528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spuph-0007hs-Qg for submit@debbugs.gnu.org; Sun, 15 Sep 2024 15:22:54 -0400 Received: from mail.imayhem.com ([82.223.54.191]:58201 helo=zealous-pike.82-223-54-191.plesk.page) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spupe-0007hX-W4 for 73258@debbugs.gnu.org; Sun, 15 Sep 2024 15:22:52 -0400 Received: from [192.168.68.103] (111.red-88-21-7.staticip.rima-tde.net [88.21.7.111]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id CD1DF80175; Sun, 15 Sep 2024 19:22:32 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[192.168.68.103] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Type: multipart/mixed; boundary="------------tE7FmmLV5SipvZG4540Ok3Zt" Message-ID: Date: Sun, 15 Sep 2024 21:22:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken To: Eli Zaretskii References: <86a5g9e32p.fsf@gnu.org> Content-Language: es-ES From: Cecilio Pardo In-Reply-To: <86a5g9e32p.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73258 Cc: 73258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------tE7FmmLV5SipvZG4540Ok3Zt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/09/2024 10:25, Eli Zaretskii wrote: > We cannot remove or make backward-incompatible changes in a public > API. So removing/renaming w32-handle-dropped-file and/or changing its > signature is out of the question. Can you rewrite the patch such that > it keeps this function and its arguments, and just change the > implementation to fix the problem? > > Also, please accompany your changes with a ChangeLog-style description > (see CONTRIBUTE for the details), to make the job of installing the > changes easier. See the attached patch. Hope I did it right, let me know. Thanks. --------------tE7FmmLV5SipvZG4540Ok3Zt Content-Type: text/plain; charset=UTF-8; name="0001-Fix-multifile-drag-n-drop-on-win32.patch" Content-Disposition: attachment; filename="0001-Fix-multifile-drag-n-drop-on-win32.patch" Content-Transfer-Encoding: base64 RnJvbSAzZmVjZTFjYThkODkyNThjMGEwMjg5NzExMGUyZjlkNGMzMWViMzZhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDZWNpbGlvIFBhcmRvIDxjcGFyZG9AaW1heWhlbS5j b20+CkRhdGU6IFN1biwgMTUgU2VwIDIwMjQgMjE6MDY6MDAgKzAyMDAKU3ViamVjdDogW1BB VENIXSBGaXggbXVsdGlmaWxlIGRyYWctbi1kcm9wIG9uIHdpbjMyCgpQYXNzIGFsbCBkcm9w cGVkIGZpbGVzIHRvIGRuZC1oYW5kbGUtbXVsdGlwbGUtdXJscwpvbiBvbmUgY2FsbCBpbnN0 ZWFkIG9uIGRvaW5nIG11bHRpcGxlIGNhbGxzIChCdWcjNzMyNTgpLgoqIGxpc3AvdGVybS93 MzItd2luLmVsICh3MzItZHJvcHBlZC1maWxlLXRvLXVybCk6IE5ldyBmdW5jdGlvbiB0bwpj b252ZXJ0IGZpbGUgbmFtZSB0byBhIHVybCBmb3IgZG5kCih3MzItaGFuZGxlLWRyb3BwZWQt ZmlsZSk6IENoYW5nZWQgdG8gdXNlIHczMi1kcm9wcGVkLWZpbGUtdG8tdXJsCih3MzItZHJh Zy1uLWRyb3ApOiBDaGFuZ2VkIHRvIHBhc3MgYWwgZmlsZXMgdG8KZG5kLWhhbmRsZS1tdWx0 aXBsZS11cmxzCi0tLQogbGlzcC90ZXJtL3czMi13aW4uZWwgfCAxNCArKysrKysrKysrKyst LQogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvbGlzcC90ZXJtL3czMi13aW4uZWwgYi9saXNwL3Rlcm0vdzMyLXdpbi5l bAppbmRleCAzYzBhY2YzNjhmNC4uOTVjMmIzNTc2NjYgMTAwNjQ0Ci0tLSBhL2xpc3AvdGVy bS93MzItd2luLmVsCisrKyBiL2xpc3AvdGVybS93MzItd2luLmVsCkBAIC0xMDEsNiArMTAx LDEzIEBAIHczMi1jb2xvci1tYXAKIDs7ICAgKHByaW5jIGV2ZW50KSkKIAogKGRlZnVuIHcz Mi1oYW5kbGUtZHJvcHBlZC1maWxlICh3aW5kb3cgZmlsZS1uYW1lKQorICAoZG5kLWhhbmRs ZS1tdWx0aXBsZS11cmxzCisgICB3aW5kb3cKKyAgIChsaXN0CisgICAgKHczMi1kcm9wcGVk LWZpbGUtdG8tdXJsIGZpbGUtbmFtZSkpCisgICAncHJpdmF0ZSkpCisKKyhkZWZ1biB3MzIt ZHJvcHBlZC1maWxlLXRvLXVybCAoZmlsZS1uYW1lKQogICAobGV0ICgoZiAoaWYgKGVxIHN5 c3RlbS10eXBlICdjeWd3aW4pCiAgICAgICAgICAgICAgICAoY3lnd2luLWNvbnZlcnQtZmls ZS1uYW1lLWZyb20td2luZG93cyBmaWxlLW5hbWUgdCkKICAgICAgICAgICAgICAoc3Vic3Qt Y2hhci1pbi1zdHJpbmcgP1xcID8vIGZpbGUtbmFtZSkpKQpAQCAtMTQ2LDggKzE1MywxMSBA QCB3MzItZHJhZy1uLWRyb3AKICAgICAgIChyYWlzZS1mcmFtZSkKICAgICAgIChzZXRxIHdp bmRvdyAoc2VsZWN0ZWQtd2luZG93KSkKIAotICAgICAgKG1hcGMgKGFwcGx5LXBhcnRpYWxs eSAjJ3czMi1oYW5kbGUtZHJvcHBlZC1maWxlIHdpbmRvdykKLSAgICAgICAgICAgIChjYXIg KGNkciAoY2RyIGV2ZW50KSkpKSkpKQorICAgICAgKGRuZC1oYW5kbGUtbXVsdGlwbGUtdXJs cworICAgICAgIHdpbmRvdworICAgICAgIChtYXBjYXIgIyd3MzItZHJvcHBlZC1maWxlLXRv LXVybAorICAgICAgICAgICAgICAgKGNhciAoY2RyIChjZHIgZXZlbnQpKSkpCisgICAgICAg J3ByaXZhdGUpKSkpCiAKIChkZWZ1biB3MzItZHJhZy1uLWRyb3Atb3RoZXItZnJhbWUgKGV2 ZW50KQogICAiRWRpdCB0aGUgZmlsZXMgbGlzdGVkIGluIHRoZSBkcmFnLW4tZHJvcCBFVkVO VCwgaW4gb3RoZXIgZnJhbWVzLgotLSAKMi4zNS4xLndpbmRvd3MuMgoK --------------tE7FmmLV5SipvZG4540Ok3Zt-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 07:20:35 2024 Received: (at 73258) by debbugs.gnu.org; 20 Sep 2024 11:20:35 +0000 Received: from localhost ([127.0.0.1]:34255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srbgh-0003o1-88 for submit@debbugs.gnu.org; Fri, 20 Sep 2024 07:20:35 -0400 Received: from mail.imayhem.com ([82.223.54.191]:51163 helo=zealous-pike.82-223-54-191.plesk.page) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srbge-0003kP-7V for 73258@debbugs.gnu.org; Fri, 20 Sep 2024 07:20:33 -0400 Received: from [10.0.12.77] (66.red-2-136-43.staticip.rima-tde.net [2.136.43.66]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 412F185457; Fri, 20 Sep 2024 11:20:07 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 2.136.43.66) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[10.0.12.77] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Type: multipart/alternative; boundary="------------NxPfhW3SSmk087hMAHaEqkMk" Message-ID: Date: Fri, 20 Sep 2024 13:20:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken From: Cecilio Pardo To: Eli Zaretskii References: <86a5g9e32p.fsf@gnu.org> Content-Language: es-ES In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73258 Cc: 73258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------NxPfhW3SSmk087hMAHaEqkMk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Did you get a chance to review this? On 15/09/2024 21:22, Cecilio Pardo wrote: > > On 15/09/2024 10:25, Eli Zaretskii wrote: >> We cannot remove or make backward-incompatible changes in a public >> API.  So removing/renaming w32-handle-dropped-file and/or changing its >> signature is out of the question.  Can you rewrite the patch such that >> it keeps this function and its arguments, and just change the >> implementation to fix the problem? >> >> Also, please accompany your changes with a ChangeLog-style description >> (see CONTRIBUTE for the details), to make the job of installing the >> changes easier. > > See the attached patch. Hope I did it right, let me know. > > Thanks. --------------NxPfhW3SSmk087hMAHaEqkMk Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Did you get a chance to review this?

On 15/09/2024 21:22, Cecilio Pardo wrote:

On 15/09/2024 10:25, Eli Zaretskii wrote:
We cannot remove or make backward-incompatible changes in a public
API.  So removing/renaming w32-handle-dropped-file and/or changing its
signature is out of the question.  Can you rewrite the patch such that
it keeps this function and its arguments, and just change the
implementation to fix the problem?

Also, please accompany your changes with a ChangeLog-style description
(see CONTRIBUTE for the details), to make the job of installing the
changes easier.

See the attached patch. Hope I did it right, let me know.

Thanks.
--------------NxPfhW3SSmk087hMAHaEqkMk-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 09:26:33 2024 Received: (at 73258) by debbugs.gnu.org; 20 Sep 2024 13:26:33 +0000 Received: from localhost ([127.0.0.1]:34384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srdea-0002T8-NG for submit@debbugs.gnu.org; Fri, 20 Sep 2024 09:26:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srdeZ-0002Su-35 for 73258@debbugs.gnu.org; Fri, 20 Sep 2024 09:26:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srdeA-0005rn-Td; Fri, 20 Sep 2024 09:26:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HyL3rluoUBbcMdkcUJJFX9uhTGe8Tsyq8yVm+5J6Xh4=; b=nlbUUtzhG87i FVMw6NH4DOS/SyDh7Dc6hfcRpbuFb0fKcOJRMNzIobSU6S1EB3wcOJIGQnqo83ibeiSJg47x9+RBj 4MeV8x/SkKPMVT4jlyzthCNoS8p/BIsId2W9pKVCeKTDwyPZuAE20bPa5eOIWiRxdSHVGcF1nKNwI kxaxBlXSwFdKGcFMJUzQnSyF7y32IdYBOrg8TkUVIzvnG0+AaIfLbzRYiozD81v4cJNOCNphj0N7Z w0KOPvdeFvWGs/xoCOY2BELAZTT+ioenUcFY1sAaJrTwT7uR1HgtmPyDLmyxCehIUbMuVGwLM+l4w NF41B3JjtSUJkMzyUM82cA==; Date: Fri, 20 Sep 2024 16:26:03 +0300 Message-Id: <86bk0i78yc.fsf@gnu.org> From: Eli Zaretskii To: Cecilio Pardo In-Reply-To: (message from Cecilio Pardo on Fri, 20 Sep 2024 13:20:05 +0200) Subject: Re: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken References: <86a5g9e32p.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73258 Cc: 73258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 20 Sep 2024 13:20:05 +0200 > From: Cecilio Pardo > Cc: 73258@debbugs.gnu.org > > Did you get a chance to review this? Not yet. Will do soon. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 21 06:12:10 2024 Received: (at 73258) by debbugs.gnu.org; 21 Sep 2024 10:12:10 +0000 Received: from localhost ([127.0.0.1]:37238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srx62-00058W-3n for submit@debbugs.gnu.org; Sat, 21 Sep 2024 06:12:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srx5z-00058H-47 for 73258@debbugs.gnu.org; Sat, 21 Sep 2024 06:12:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srx5Z-0003Fz-9G; Sat, 21 Sep 2024 06:11:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JQ9HYCHDhuhO1u5lOZMeYd2949M3qxDPNUvuytL+AAE=; b=jOyatwui8CUg l5+7fb0eEeIswDpOtYkvc5OSv65ENjX+szwd+a0vIPUORU2095JaPGYjiC/MrapHNcZeRG4NcPru6 ciyS4krnFcRpMaf6vBctizfIM5tQysMfpi2pv1WmY0cibVeY0GZ9XNDLdsw07r+WHzet53OJySpBT /pJru6C7998tymS70ZAoH5MqbgQ31teXL9QPFBURHP8iV/nD7q7XTuEwRLUEeUzIxkx54l40Geb1h 06lONvuLGCzgOwlIIXSxPzhoOgaEmWt+1PWEJC41+1eRDoMR2T2GlyAt2RK2O4WkvyXzVw/zaHtmB TrjE1+rVIRmn6hi11OW53Q==; Date: Sat, 21 Sep 2024 13:11:26 +0300 Message-Id: <86a5g148q9.fsf@gnu.org> From: Eli Zaretskii To: Cecilio Pardo In-Reply-To: (message from Cecilio Pardo on Sun, 15 Sep 2024 21:22:32 +0200) Subject: Re: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken References: <86a5g9e32p.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73258 Cc: 73258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 15 Sep 2024 21:22:32 +0200 > Cc: 73258@debbugs.gnu.org > From: Cecilio Pardo > > On 15/09/2024 10:25, Eli Zaretskii wrote: > > We cannot remove or make backward-incompatible changes in a public > > API. So removing/renaming w32-handle-dropped-file and/or changing its > > signature is out of the question. Can you rewrite the patch such that > > it keeps this function and its arguments, and just change the > > implementation to fix the problem? > > > > Also, please accompany your changes with a ChangeLog-style description > > (see CONTRIBUTE for the details), to make the job of installing the > > changes easier. > > See the attached patch. Hope I did it right, let me know. This causes the following warning while byte-compiling: In w32-dropped-file-to-url: term/w32-win.el:129:29: Warning: reference to free variable `window' And indeed, 'window' is not bound to any value here, and dnd-handle-multiple-urls does need it to be a valid window. If I try drag-and-drop with your patch installed, Emacs signals an error about 'window' being void. I don't understand how it worked for you. Also, what about this comment: ;; FIXME: is the W32 build capable only of receiving a single file ;; from each drop? I guess it is no longer pertinent and should be deleted? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 21 09:41:31 2024 Received: (at 73258) by debbugs.gnu.org; 21 Sep 2024 13:41:32 +0000 Received: from localhost ([127.0.0.1]:37614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss0Md-0008Pk-Gx for submit@debbugs.gnu.org; Sat, 21 Sep 2024 09:41:31 -0400 Received: from mail.imayhem.com ([82.223.54.191]:45683 helo=zealous-pike.82-223-54-191.plesk.page) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss0Mb-0008PY-Ju for 73258@debbugs.gnu.org; Sat, 21 Sep 2024 09:41:30 -0400 Received: from [192.168.68.103] (111.red-88-21-7.staticip.rima-tde.net [88.21.7.111]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 7CB7F825FE; Sat, 21 Sep 2024 13:41:03 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[192.168.68.103] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Type: multipart/mixed; boundary="------------6quecPipE0cPTf2DB7twqt0i" Message-ID: Date: Sat, 21 Sep 2024 15:41:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken To: Eli Zaretskii References: <86a5g9e32p.fsf@gnu.org> <86a5g148q9.fsf@gnu.org> Content-Language: es-ES From: Cecilio Pardo In-Reply-To: <86a5g148q9.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73258 Cc: 73258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------6quecPipE0cPTf2DB7twqt0i Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/09/2024 12:11, Eli Zaretskii wrote: > This causes the following warning while byte-compiling: > > In w32-dropped-file-to-url: > term/w32-win.el:129:29: Warning: reference to free variable `window' > > And indeed, 'window' is not bound to any value here, and > dnd-handle-multiple-urls does need it to be a valid window. If I try > drag-and-drop with your patch installed, Emacs signals an error about > 'window' being void. I don't understand how it worked for you. > > Also, what about this comment: > > ;; FIXME: is the W32 build capable only of receiving a single file > ;; from each drop? > > I guess it is no longer pertinent and should be deleted? I messed up when preparing the patch file, I'm sorry. Here is the correct one. --------------6quecPipE0cPTf2DB7twqt0i Content-Type: text/plain; charset=UTF-8; name="0001-Fix-multifile-drag-n-drop-on-win32.patch" Content-Disposition: attachment; filename="0001-Fix-multifile-drag-n-drop-on-win32.patch" Content-Transfer-Encoding: base64 RnJvbSAzYzVhZjE0YjVjMGQ5NTYxNTNkODNmZTlhNTA0MWFlODk3ZTViOWViIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDZWNpbGlvIFBhcmRvIDxjcGFyZG9AaW1heWhlbS5j b20+CkRhdGU6IFNhdCwgMjEgU2VwIDIwMjQgMTU6MzA6MjcgKzAyMDAKU3ViamVjdDogW1BB VENIXSBGaXggbXVsdGlmaWxlIGRyYWctbi1kcm9wIG9uIHdpbjMyCgpQYXNzIGFsbCBkcm9w cGVkIGZpbGVzIHRvIGRuZC1oYW5kbGUtbXVsdGlwbGUtdXJscwpvbiBvbmUgY2FsbCBpbnN0 ZWFkIG9uIGRvaW5nIG11bHRpcGxlIGNhbGxzIChCdWcjNzMyNTgpLgoqIGxpc3AvdGVybS93 MzItd2luLmVsICh3MzItZHJvcHBlZC1maWxlLXRvLXVybCk6IE5ldyBmdW5jdGlvbiB0bwpj b252ZXJ0IGZpbGUgbmFtZSB0byBhIHVybCBmb3IgZG5kCih3MzItaGFuZGxlLWRyb3BwZWQt ZmlsZSk6IENoYW5nZWQgdG8gdXNlIHczMi1kcm9wcGVkLWZpbGUtdG8tdXJsCih3MzItZHJh Zy1uLWRyb3ApOiBDaGFuZ2VkIHRvIHBhc3MgYWxsIGZpbGVzIHRvCmRuZC1oYW5kbGUtbXVs dGlwbGUtdXJscwotLS0KIGxpc3AvdGVybS93MzItd2luLmVsIHwgMjcgKysrKysrKysrKysr KysrKystLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMTAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXJtL3czMi13aW4uZWwgYi9saXNw L3Rlcm0vdzMyLXdpbi5lbAppbmRleCAzYzBhY2YzNjhmNC4uYjU3YjNkZDNiZWYgMTAwNjQ0 Ci0tLSBhL2xpc3AvdGVybS93MzItd2luLmVsCisrKyBiL2xpc3AvdGVybS93MzItd2luLmVs CkBAIC0xMDEsNiArMTAxLDEzIEBAIHczMi1jb2xvci1tYXAKIDs7ICAgKHByaW5jIGV2ZW50 KSkKIAogKGRlZnVuIHczMi1oYW5kbGUtZHJvcHBlZC1maWxlICh3aW5kb3cgZmlsZS1uYW1l KQorICAoZG5kLWhhbmRsZS1tdWx0aXBsZS11cmxzCisgICB3aW5kb3cKKyAgIChsaXN0Cisg ICAgKHczMi1kcm9wcGVkLWZpbGUtdG8tdXJsIGZpbGUtbmFtZSkpCisgICAncHJpdmF0ZSkp CisKKyhkZWZ1biB3MzItZHJvcHBlZC1maWxlLXRvLXVybCAoZmlsZS1uYW1lKQogICAobGV0 ICgoZiAoaWYgKGVxIHN5c3RlbS10eXBlICdjeWd3aW4pCiAgICAgICAgICAgICAgICAoY3ln d2luLWNvbnZlcnQtZmlsZS1uYW1lLWZyb20td2luZG93cyBmaWxlLW5hbWUgdCkKICAgICAg ICAgICAgICAoc3Vic3QtY2hhci1pbi1zdHJpbmcgP1xcID8vIGZpbGUtbmFtZSkpKQpAQCAt MTE3LDE0ICsxMjQsMTEgQEAgdzMyLWhhbmRsZS1kcm9wcGVkLWZpbGUKICAgICAgICAgICAg ICAgICAgICAgIChzcGxpdC1zdHJpbmcgKGVuY29kZS1jb2Rpbmctc3RyaW5nIGYgY29kaW5n KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLyIpCiAgICAgICAgICAg ICAgICAgICAgICAiLyIpKSkKLSAgOzsgRklYTUU6IGlzIHRoZSBXMzIgYnVpbGQgY2FwYWJs ZSBvbmx5IG9mIHJlY2VpdmluZyBhIHNpbmdsZSBmaWxlCi0gIDs7IGZyb20gZWFjaCBkcm9w PwotICAoZG5kLWhhbmRsZS1tdWx0aXBsZS11cmxzIHdpbmRvdyAobGlzdCAoY29uY2F0Ci0J CQkgICAgICAgICAgICAgICAgICAoaWYgKGVxIHN5c3RlbS10eXBlICdjeWd3aW4pCi0JCQkJ ICAgICAgICAgICAgICAiZmlsZTovLyIKLQkJCSAgICAgICAgICAgICAgICAgICAgImZpbGU6 IikKLQkJCSAgICAgICAgICAgICAgICAgIGZpbGUtbmFtZSkpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgJ3ByaXZhdGUpKQorICAoY29uY2F0CisgICAoaWYgKGVxIHN5c3RlbS10 eXBlICdjeWd3aW4pCisgICAgICAgImZpbGU6Ly8iCisgICAgICJmaWxlOiIpCisgICBmaWxl LW5hbWUpKQogCiAoZGVmdW4gdzMyLWRyYWctbi1kcm9wIChldmVudCAmb3B0aW9uYWwgbmV3 LWZyYW1lKQogICAiRWRpdCB0aGUgZmlsZXMgbGlzdGVkIGluIHRoZSBkcmFnLW4tZHJvcCBF VkVOVC4KQEAgLTE0Niw4ICsxNTAsMTEgQEAgdzMyLWRyYWctbi1kcm9wCiAgICAgICAocmFp c2UtZnJhbWUpCiAgICAgICAoc2V0cSB3aW5kb3cgKHNlbGVjdGVkLXdpbmRvdykpCiAKLSAg ICAgIChtYXBjIChhcHBseS1wYXJ0aWFsbHkgIyd3MzItaGFuZGxlLWRyb3BwZWQtZmlsZSB3 aW5kb3cpCi0gICAgICAgICAgICAoY2FyIChjZHIgKGNkciBldmVudCkpKSkpKSkKKyAgICAg IChkbmQtaGFuZGxlLW11bHRpcGxlLXVybHMKKyAgICAgICB3aW5kb3cKKyAgICAgICAobWFw Y2FyICMndzMyLWRyb3BwZWQtZmlsZS10by11cmwKKyAgICAgICAgICAgICAgIChjYXIgKGNk ciAoY2RyIGV2ZW50KSkpKQorICAgICAgICdwcml2YXRlKSkpKQogCiAoZGVmdW4gdzMyLWRy YWctbi1kcm9wLW90aGVyLWZyYW1lIChldmVudCkKICAgIkVkaXQgdGhlIGZpbGVzIGxpc3Rl ZCBpbiB0aGUgZHJhZy1uLWRyb3AgRVZFTlQsIGluIG90aGVyIGZyYW1lcy4KLS0gCjIuMzUu MS53aW5kb3dzLjIKCg== --------------6quecPipE0cPTf2DB7twqt0i-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 22 05:50:08 2024 Received: (at 73258-done) by debbugs.gnu.org; 22 Sep 2024 09:50:08 +0000 Received: from localhost ([127.0.0.1]:40893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssJEG-0007TK-5r for submit@debbugs.gnu.org; Sun, 22 Sep 2024 05:50:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssJED-0007Sg-Ii for 73258-done@debbugs.gnu.org; Sun, 22 Sep 2024 05:50:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssJDm-0006Ib-5K; Sun, 22 Sep 2024 05:49:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KibmjCHI7aSe9B6SJvLodLTBEAHyezBqHOsctyXydJ8=; b=lpWaEVHUdpQn JXVK3gRlqcBrluVfufbbf0pFdUjw8PURfzKoSfpYVUk3cqwQIu7iMuSQvF/jGO6mAaOmDWKqFjdR5 AO5zEzygvowTyS+SVRHJVwOnSNXHmvTn3F1CrKrFd8EvGrI/ssY6cxQD1Z0dbv6pWdifujExBhcSb /tnqAqhkg2kSNeF6bALI97PewZX1nP1tHOz1sH4oNzF6LLziGP9cLAu9jVwQ7idGm45kNmbdvCRbs /Hw4WfZvl+rtN58JTwd0r2Za/AeUGBN9FXni4I0ULcjhEa+B54qjOnr2Mx33dYtAgpbwD4ZG57Y7s TOTukwtrdTcwYv4hCHOKaQ==; Date: Sun, 22 Sep 2024 12:49:31 +0300 Message-Id: <8634lshvbo.fsf@gnu.org> From: Eli Zaretskii To: Cecilio Pardo In-Reply-To: (message from Cecilio Pardo on Sat, 21 Sep 2024 15:41:03 +0200) Subject: Re: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken References: <86a5g9e32p.fsf@gnu.org> <86a5g148q9.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73258-done Cc: 73258-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 21 Sep 2024 15:41:03 +0200 > Cc: 73258@debbugs.gnu.org > From: Cecilio Pardo > > I messed up when preparing the patch file, I'm sorry. > > Here is the correct one. Thanks, installed on the master branch, and closing the bug. From unknown Mon Jun 23 07:49:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 20 Oct 2024 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator