GNU bug report logs - #73239
[PATCH v1 0/2] Fix shortcut key issue with xfce4-pulseaudio-plugin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73239 in the body.
You can then email your comments to 73239 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
Subject: [PATCH v1 0/2] Fix shortcut key issue with xfce4-pulseaudio-plugin
Date: Sat, 14 Sep 2024 03:26:23 +0530

This patch series resolves the issue with media key while using xfce4-pulseaudio-plugin.
Since the media keys work fine now, there's no need to provide xfce4-volumed-pulse as
another input for the xfce metapackage.

Ashvith Shetty (2):
  gnu: xfce4-pulseaudio-plugin: Add inputs "keybinder" and "pavucontrol"
  gnu: xfce: Remove input "xfce4-volumed-pulse"

 gnu/packages/xfce.scm | 108 +++++++++++++++++++++---------------------
 1 file changed, 55 insertions(+), 53 deletions(-)

-- 
2.46.0

Message #8 received at 73239 <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
To: 73239 <at> debbugs.gnu.org
Cc: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
Subject: [PATCH v1 1/2] gnu: xfce4-pulseaudio-plugin: Add inputs "keybinder"
 and "pavucontrol"
Date: Sat, 14 Sep 2024 03:29:55 +0530

* gnu/packages/xfce.scm (xfce4-pulseaudio-plugin)[inputs]: Add the missing inputs "keybinder" and "pavucontrol"

Change-Id: Iab871e33e4821c2631d6ad19759e1d1a0b3af02d
---
 gnu/packages/xfce.scm | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 33b8d59051..8277668f2c 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -504,15 +504,22 @@ (define-public xfce4-pulseaudio-plugin
        (method url-fetch)
        (uri (string-append "https://archive.xfce.org/src/panel-plugins/"
                            "xfce4-pulseaudio-plugin/"
-                           (version-major+minor version) "/"
-                           "xfce4-pulseaudio-plugin-" version ".tar.bz2"))
+                           (version-major+minor version)
+                           "/"
+                           "xfce4-pulseaudio-plugin-"
+                           version
+                           ".tar.bz2"))
        (sha256
         (base32 "0j037wnx0z22nw11mq0y3cnq1srr52zckjap3klj3hirghh2nx5x"))))
     (build-system gnu-build-system)
-    (native-inputs
-     (list intltool pkg-config dbus-glib dbus))
-    (inputs
-     (list exo libnotify libxfce4ui pulseaudio xfce4-panel))
+    (native-inputs (list intltool pkg-config dbus-glib dbus))
+    (inputs (list exo
+                  keybinder
+                  libnotify
+                  libxfce4ui
+                  pavucontrol
+                  pulseaudio
+                  xfce4-panel))
     (home-page "https://git.xfce.org/panel-plugins/xfce4-pulseaudio-plugin/")
     (synopsis "PulseAudio panel plugin for Xfce")
     (description
-- 
2.46.0

Message #11 received at 73239 <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
To: 73239 <at> debbugs.gnu.org
Cc: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
Subject: [PATCH v1 2/2] gnu: xfce: Remove input "xfce4-volumed-pulse"
Date: Sat, 14 Sep 2024 03:29:56 +0530

* gnu/packages/xfce.scm (xfce)[inputs]: Remove input "xfce4-volumed-pulse"

Change-Id: I80a80064c75907b2a1e6e880fab9f1e772921b13
---
 gnu/packages/xfce.scm | 89 ++++++++++++++++++++-----------------------
 1 file changed, 42 insertions(+), 47 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 8277668f2c..5ece50b69b 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -1207,61 +1207,56 @@ (define-public xfce
   (package
     (name "xfce")
     (version (package-version xfce4-session))
-    (source #f)
+    (source
+     #f)
     (build-system trivial-build-system)
     (arguments
      '(#:modules ((guix build union))
-       #:builder
-       (begin
-         (use-modules (ice-9 match)
-                      (guix build union))
-         (match %build-inputs
-           (((names . directories) ...)
-            (union-build (assoc-ref %outputs "out")
-                         directories)
-            #t)))))
-    (inputs
-     (list exo
-           garcon
-           adwaita-icon-theme
-           elementary-xfce-icon-theme
-           greybird-gtk-theme
-           hicolor-icon-theme
-           mate-polkit-for-xfce
-           mousepad
-           ristretto
-           shared-mime-info
-           thunar
-           thunar-volman
-           tumbler
-           xfce4-appfinder
-           xfce4-notifyd                          ;for pop-up notifications
-           xfce4-panel
-           xfce4-power-manager
-           xfce4-screenshooter
-           xfce4-session
-           xfce4-settings
-           xfce4-taskmanager
-           xfce4-terminal
-           xfconf
-           xfdesktop
-           xfwm4
-           xfwm4-themes
-           xkill
-           ;; Panel plugins.
-           xfce4-battery-plugin
-           xfce4-clipman-plugin
-           xfce4-pulseaudio-plugin
-           xfce4-volumed-pulse
-           xfce4-xkb-plugin))
+       #:builder (begin
+                   (use-modules (ice-9 match)
+                                (guix build union))
+                   (match %build-inputs
+                     (((names . directories) ...)
+                      (union-build (assoc-ref %outputs "out") directories) #t)))))
+    (inputs (list exo
+                  garcon
+                  adwaita-icon-theme
+                  elementary-xfce-icon-theme
+                  greybird-gtk-theme
+                  hicolor-icon-theme
+                  mate-polkit-for-xfce
+                  mousepad
+                  ristretto
+                  shared-mime-info
+                  thunar
+                  thunar-volman
+                  tumbler
+                  xfce4-appfinder
+                  xfce4-notifyd ;for pop-up notifications
+                  xfce4-panel
+                  xfce4-power-manager
+                  xfce4-screenshooter
+                  xfce4-session
+                  xfce4-settings
+                  xfce4-taskmanager
+                  xfce4-terminal
+                  xfconf
+                  xfdesktop
+                  xfwm4
+                  xfwm4-themes
+                  xkill
+                  ;; Panel plugins.
+                  xfce4-battery-plugin
+                  xfce4-clipman-plugin
+                  xfce4-pulseaudio-plugin
+                  xfce4-xkb-plugin))
     (propagated-inputs
      ;; Default font that applications such as IceCat require.
      (list font-dejavu))
     (native-search-paths
      ;; For finding panel and thunar plugins.
-     (append
-      (package-native-search-paths xfce4-panel)
-      (package-native-search-paths thunar)))
+     (append (package-native-search-paths xfce4-panel)
+             (package-native-search-paths thunar)))
     (home-page "https://www.xfce.org/")
     (synopsis "Desktop environment (meta-package)")
     (description
-- 
2.46.0

Message #16 received at 73239-done <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
To: 73239-done <at> debbugs.gnu.org
Cc: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
Subject: Re: [PATCH v1 0/2] Fix shortcut key issue with xfce4-pulseaudio-plugin
Date: Fri, 06 Dec 2024 01:04:29 +0530

Patch has been applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.