GNU bug report logs - #73227
Remove phase 'skip-gtk-update-icon-cache from Tilix

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73227 in the body.
You can then email your comments to 73227 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: jgart <at> dismail.de
Subject: Remove phase 'skip-gtk-update-icon-cache from Tilix
Date: Fri, 13 Sep 2024 18:32:53 +0530

[Message part 1 (text/plain, inline)]

Hello,
I should've made this clearer in the previous issue that I've opened. 
There is no to keep the phase 'skip-gtk-update-icon-cache, as the two 
new native-inputs I've added respectively, `(,glib "bin") and `(,gtk+ 
"bin") fixes the issues with meson's post-install Python script.

[Message part 2 (text/html, inline)]

Message #8 received at 73227 <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
To: 73227 <at> debbugs.gnu.org
Cc: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
Subject: [PATCH v1] gnu: tilix: Remove phase 'skip-gtk-update-icon-cache.
Date: Fri, 13 Sep 2024 19:31:42 +0530

* gnu/packages/terminals.scm (tilix)[arguments]<#:phases>: Remove
phase 'skip-gtk-update-icon-cache.

Change-Id: I7eb068764f67fd047854e65c9dcdecd45ac18dd3
---
 gnu/packages/terminals.scm | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index eadf58fbf3..30a64acb36 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -1451,17 +1451,11 @@ (define-public tilix
     (arguments
      (list
       #:glib-or-gtk? #t
-      #:phases
-      #~(modify-phases %standard-phases
-          (add-after 'unpack 'set-env-variables
-            (lambda _
-              (setenv "CC"
-                      #$(cc-for-target))))
-          (add-after 'unpack 'skip-gtk-update-icon-cache
-            (lambda _
-              (substitute* "meson_post_install.py"
-                (("gtk-update-icon-cache") (which "true"))
-                (("update-desktop-database") (which "true"))))))))
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'set-env-variables
+                     (lambda _
+                       (setenv "CC"
+                               #$(cc-for-target)))))))
     (inputs (list dbus
                   dconf
                   gettext-minimal
-- 
2.46.0

Message #11 received at 73227 <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
To: 73227 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>, jgart <at> dismail.de
Subject: Re: Remove phase 'skip-gtk-update-icon-cache from Tilix
Date: Tue, 3 Dec 2024 17:45:40 +0000

[Message part 1 (text/plain, inline)]

Hello,

Just wanted to ping about this patch I had created around September, which
removes the need for having to substitute text unnecessarily. This is
actually a follow-up to the previous patch at
https://issues.guix.gnu.org/73105.

Regards,
Ashvith

[Message part 2 (text/html, inline)]

Message #16 received at 73227-done <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty0010 <at> zohomail.in>
To: "73227-done" <73227-done <at> debbugs.gnu.org>
Subject: Re: Remove phase 'skip-gtk-update-icon-cache from Tilix
Date: Mon, 03 Mar 2025 01:03:45 +0530

This issue was already resolved. Closing this.

Message #19 received at 73227-done <at> debbugs.gnu.org (full text, mbox):

From: Ashvith Shetty <ashvithshetty0010 <at> zohomail.in>
To: 73227-done <at> debbugs.gnu.org
Cc: Ashvith Shetty <ashvithshetty10 <at> gmail.com>
Subject: Re: Remove phase 'skip-gtk-update-icon-cache from Tilix
Date: Mon, 03 Mar 2025 01:00:41 +0530

This issue was already resolved, so closing this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.