GNU bug report logs - #73218
[PATCH] Fix Fortran indent below do_not_a_loop=42

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ken Mankoff <km <at> kenmankoff.com>
Subject: bug#73218: closed (Re: bug#73218: [PATCH] Fix Fortran indent
 below do_not_a_loop=42)
Date: Sat, 14 Sep 2024 14:21:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#73218: [PATCH] Fix Fortran indent below do_not_a_loop=42

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73218 <at> debbugs.gnu.org.

-- 
73218: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73218
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Mankoff <km <at> kenmankoff.com>
Cc: 73218-done <at> debbugs.gnu.org
Subject: Re: bug#73218: [PATCH] Fix Fortran indent below do_not_a_loop=42
Date: Sat, 14 Sep 2024 17:20:01 +0300

> From: Ken Mankoff <km <at> kenmankoff.com>
> Cc: 73218 <at> debbugs.gnu.org
> Date: Sat, 14 Sep 2024 07:09:02 -0700
> 
> Hi Eli,
> 
> On 2024-09-14 at 04:15 -07, Eli Zaretskii <eliz <at> gnu.org> wrote...
> >> From: Ken Mankoff <km <at> kenmankoff.com>
> >> Cc: 73218 <at> debbugs.gnu.org
> >> Date: Fri, 13 Sep 2024 08:44:45 -0700
> >> 
> >> >> --- a/lisp/progmodes/fortran.el
> >> >> +++ b/lisp/progmodes/fortran.el
> >> >> @@ -1631,7 +1631,7 @@ fortran-calculate-indent
> >> >>                 (setq icol (+ icol fortran-if-indent)))
> >> >>                ((looking-at "where[ \t]*(.*)[ \t]*\n")
> >> >>                 (setq icol (+ icol fortran-if-indent)))
> >> >> -              ((looking-at "do\\b")
> >> >> +              ((looking-at "do[\\ |0-9]+.*=[\\ a-z0-9_]*,[\\ a-z0-9_]*")
> >
> > Since the SPC is optional in Fortran, how about the following instead?
> >
> >   "do *[0-9]* *[a-z0-9_]+ *= *[a-z0-9_]+ *, *[a-z0-9_]+"
> >
> 
> Yes this pattern works.

Thanks, so I've now installed this on the master branch, and I'm
closing this bug.

[Message part 3 (message/rfc822, inline)]

From: Ken Mankoff <km <at> kenmankoff.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix Fortran indent below do_not_a_loop=42
Date: Thu, 12 Sep 2024 11:44:44 -0700

[Message part 4 (text/plain, inline)]

Tags: patch

Hello,

Following up from https://lists.gnu.org/archive/html/emacs-devel/2024-08/msg00904.html I'm submitting a patch to fix Fortran indentation due to an overly aggressive match for do loops.

In GNU Emacs 29.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33,
 cairo version 1.16.0) of 2024-08-20 built on t480
Repository revision: ae8f815613c2e072e92aa8fe7b4bcf2fdabc7408
Repository branch: HEAD
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.5 LTS

Configured using:
 'configure --prefix=/home/kdm/local/emacs'

[0001-Fix-Fortran-indent-below-do_not_a_loop-42.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.