Subject: Re: [bug#73216] [PATCH 1/2] gnu: Add emacs-org-texlive-collection.

From: Nicolas Goaziou <[email-masked]>
Date: Fri, 13 Sep 2024 19:00:30 +0200

Hello,

Maxim Cournoyer <[email-masked]> writes:

> +(define-public emacs-org-texlive-collection
> +  (package
> +    (inherit emacs-org)

I don't understand why this inherits from Emacs Org. You're basically
creating a specific TeX Live collection here. This should probably go to
"tex.scm".

> +    (name "emacs-org-texlive-collection")
> +    (source #f)
> +    (build-system trivial-build-system)
> +    (arguments (list #:builder #~(mkdir #$output)))
> +    (native-inputs '())
> +    (inputs '())
> +    (propagated-inputs
> +     (list texlive-amsmath
> +           texlive-capt-of
> +           texlive-graphics             ;for graphicx, rotating
> +           texlive-hyperref
> +           texlive-titling
> +           texlive-tools                ;for longtable
> +           texlive-ulem
> +           texlive-wrapfig
> +           texlive-scheme-small))      ;for amsfonts, fontspec, inputenc, etc.

This is much larger than what Org expects. The scheme above provides
XeTeX and Metapost, for example. I think it should be leaner if it
propagated provided texlive-collection-latexrecommended and a few
additional packages.

Note that texlive-tools, texlive-graphics and texlive-amsmath are
included already in texlive-scheme-small (and
texlive-collection-latexrecommended for that matter).

Out of my memories, I think it also needs texlive-soul.

> +    (synopsis "Basic TexLive packages for Org-mode LaTeX export")

Nitpick: TeX Live. Org mode.

> +    (description "This meta-package propagates the TexLive packages minimally
> +required by the Org-mode produced LaTeX output.")))

Ditto.

> +
>  (define-public emacs-org-contacts
>    ;; XXX: Upstream does not tag version bumps. Commit below matches latest
>    ;; version bump.
>
> base-commit: f5449685143be0805a8a9b54ddecee94e368c6e9

Regards,
-- 
Nicolas Goaziou