GNU bug report logs - #73210
[PATCH] gnu: smalltalk: Fix tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73210 in the body.
You can then email your comments to 73210 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH] gnu: smalltalk: Fix tests.
Date: Thu, 12 Sep 2024 19:38:23 +0000

* gnu/packages/smalltalk.scm (smalltalk)[native-inputs]: Add
'(libc-utf8-locales-for-target)'.

Change-Id: Idf49394e5c4dbd3398a6774319184339ed18585c
---
 gnu/packages/smalltalk.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm
index 64146813d1f..988410d93d9 100644
--- a/gnu/packages/smalltalk.scm
+++ b/gnu/packages/smalltalk.scm
@@ -62,6 +62,7 @@ (define-public smalltalk
     (build-system gnu-build-system)
     (native-inputs
      (list pkg-config
+           (libc-utf8-locales-for-target)
            ;; XXX: To be removed with the next release of Smalltalk.
            autoconf
            automake

base-commit: d4869b7e43d823bccc8f6d81dd9f5d2c13cb8f25
-- 
2.46.0

Message #8 received at 73210 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Greg Hogan <code <at> greghogan.com>
Cc: 73210 <at> debbugs.gnu.org
Subject: Re: [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
Date: Fri, 13 Sep 2024 09:59:26 +0000

[Message part 1 (text/plain, inline)]

Hi.
I tried your patch, but some tests are still failing for me.
More specifically, the "ANSI compliancy tests" are all failing with the
same error:

--8<---------------cut here---------------start------------->8---
--- ./tests/testsuite.dir/046/testsuite.log ---------------------------------

#                             -*- compilation -*-
46. testsuite.at:82: testing ArrayANSITest ...
{ (cd /tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91 && timeout 600s gst -I /tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/tests/gst.im -f /tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91
/tests/AnsiRun.st ArrayANSITest); echo exit 0 > retcode; } | tr -d '\r' | tee stdout; . ./retcode
./testsuite.at:82: { (cd $abs_top_builddir && $TIMEOUT gst $image_path -f $abs_srcdir/AnsiRun.st ArrayANSITest); echo exit $? > retcode; } | tr -d '\r' | tee stdout; . ./retcode
--- /dev/null   2024-09-13 06:57:13.374888392 +0000
+++ /tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/tests/testsuite.dir/at-groups/46/stderr     2024-09-13 09:48:39.319595098 +0000
@@ -0,0 +1,13 @@
+gst: Aborted
+gst: Error occurred while not in byte code interpreter!!
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/libgst/.libs/libgst.so.7(+0x728f7)[0x7ffff7f568f7]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(+0x3e560)[0x7ffff7b87560]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(+0x883fc)[0x7ffff7bd13fc]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(gsignal+0x12)[0x7ffff7b874c2]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(abort+0xc9)[0x7ffff7b714a3]
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/libgst/.libs/libgst.so.7(+0x10c19)[0x7ffff7ef4c19]
+/gnu/store/q46ljxrs7jh0r7qniqdcjvz3kny9226f-libsigsegv-2.14/lib/libsigsegv.so.2(+0x1288)[0x7ffff7edf288]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(+0x3e560)[0x7ffff7b87560]
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/libgst/.libs/libgst.so.7(+0x56e48)[0x7ffff7f3ae48]
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/libgst/.libs/libgst.so.7(+0x72469)[0x7ffff7f56469]
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/tests/testsuite.dir/at-groups/46/test-source: line 20: 22611 Aborted                 $TIMEOUT gst $image_path -f $abs_srcdir/AnsiRun.st ArrayANSITest
stdout:
./testsuite.at:82: exit code was 134, expected 0
46. testsuite.at:82: 46. ArrayANSITest (testsuite.at:82): FAILED (testsuite.at:82)
--8<---------------cut here---------------end--------------->8---

Does the build work for you every time?
What architecture are you using? I'm on x86-64 Guix system.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 73210 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 73210 <at> debbugs.gnu.org
Subject: Re: [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
Date: Fri, 13 Sep 2024 08:18:29 -0400

On Fri, Sep 13, 2024 at 5:59 AM Guillaume Le Vaillant <glv <at> posteo.net> wrote:
>
> Hi.
> I tried your patch, but some tests are still failing for me.
> More specifically, the "ANSI compliancy tests" are all failing with the
> same error:
>
> [...]
>
> Does the build work for you every time?
> What architecture are you using? I'm on x86-64 Guix system.

I have built the package two more times without errors (though the
output is non-deterministic). The only error I have seen was the I18N
test failure before adding this locales patch.

My system is x86-64 on a foreign distro.

Message #14 received at 73210 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Greg Hogan <code <at> greghogan.com>
Cc: 73210 <at> debbugs.gnu.org
Subject: Re: [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
Date: Fri, 13 Sep 2024 17:23:00 +0000

[Message part 1 (text/plain, inline)]

Greg Hogan <code <at> greghogan.com> skribis:

> On Fri, Sep 13, 2024 at 5:59 AM Guillaume Le Vaillant <glv <at> posteo.net> wrote:
>>
>> Hi.
>> I tried your patch, but some tests are still failing for me.
>> More specifically, the "ANSI compliancy tests" are all failing with the
>> same error:
>>
>> [...]
>>
>> Does the build work for you every time?
>> What architecture are you using? I'm on x86-64 Guix system.
>
> I have built the package two more times without errors (though the
> output is non-deterministic). The only error I have seen was the I18N
> test failure before adding this locales patch.
>
> My system is x86-64 on a foreign distro.

Given that the patch is correct (adding a missing input), I applied it
as 22a34ea792ef0df15fd30d46f557b572c61d5404.
The build farm built it fine for i686, but on x86-64 it got the same
error as me (https://ci.guix.gnu.org/build/5765437/details).

A strange thing is that if I keep the files of the failed build (with
"guix build -K") and then run the tests by hand, they all succeed.

I wonder where the difference with what you get could come from...
What CPU does your machine have? And how much RAM?

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 73210 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 73210 <at> debbugs.gnu.org
Subject: Re: [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
Date: Fri, 13 Sep 2024 15:56:00 -0400

On Fri, Sep 13, 2024 at 1:23 PM Guillaume Le Vaillant <glv <at> posteo.net> wrote:
>
> A strange thing is that if I keep the files of the failed build (with
> "guix build -K") and then run the tests by hand, they all succeed.
>
> I wonder where the difference with what you get could come from...
> What CPU does your machine have? And how much RAM?

It's an AWS r7a (AMD EPYC 9R14), typically the smallest variant (2 CPU
threads, 16 GiB RAM).

Message #22 received at 73210-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Greg Hogan <code <at> greghogan.com>
Cc: 73210-done <at> debbugs.gnu.org
Subject: Re: [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
Date: Sat, 14 Sep 2024 09:12:39 +0000

[Message part 1 (text/plain, inline)]

For now I disabled the tests on x86-64 in
607280fa8fe26b500ad76a3769da8e4f917cae16.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.