GNU bug report logs - #73200
[PATCH] gnu: sleef: Update to 3.6.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73200 in the body.
You can then email your comments to 73200 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] gnu: sleef: Update to 3.6.1.
Date: Thu, 12 Sep 2024 18:29:38 +0300

* gnu/packages/maths.scm (sleef): Update to 3.6.1.
[arguments]: Set build-type to release.  Update configure-flags to only
set building a shared library.
[inputs]: Remove openssl-1.1.  Add mpfr, openssl.

Change-Id: I3dab4b84a755a49f187e93e684e85659af0e2a49
---
 gnu/packages/maths.scm | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index a0cc0788caf..9a08e78d56b 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -8,7 +8,7 @@
 ;;; Copyright © 2015–2024 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2015 Sou Bunnbu <iyzsong <at> gmail.com>
 ;;; Copyright © 2015, 2018 Mark H Weaver <mhw <at> netris.org>
-;;; Copyright © 2015-2023 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2015-2024 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2015 Fabian Harfert <fhmgufs <at> web.de>
 ;;; Copyright © 2016 Roel Janssen <roel <at> gnu.org>
 ;;; Copyright © 2016, 2018, 2020, 2021 Kei Kebreau <kkebreau <at> posteo.net>
@@ -812,7 +812,7 @@ (define-public gsl
 (define-public sleef
   (package
     (name "sleef")
-    (version "3.5.1")
+    (version "3.6.1")
     (source
      (origin
        (method git-fetch)
@@ -821,17 +821,15 @@ (define-public sleef
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1jybqrl2dvjxzg30xrhh847s375n2jr1pix644wi6hb5wh5mx3f7"))))
+        (base32 "14y1zf621zp0333vs29pc7pcc31gsrrs3q49b6qmd1kz6c7a7fp2"))))
     (build-system cmake-build-system)
     (arguments
      (list
+      #:build-type "Release"
       #:configure-flags
-      #~(list "-DCMAKE_BUILD_TYPE=Release"
-              (string-append "-DCMAKE_INSTALL_LIBDIR=" #$output "/lib")
-              (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))))
-    ;; XXX: Removed mpfr because of https://github.com/shibatch/sleef/issues/458
+      #~(list "-DSLEEF_BUILD_SHARED_LIBS=ON")))
     (inputs
-     (list fftw gmp openssl-1.1))
+     (list fftw gmp mpfr openssl))
     (home-page "https://sleef.org/")
     (synopsis "SIMD library for evaluating elementary functions and DFT")
     (description

base-commit: d4869b7e43d823bccc8f6d81dd9f5d2c13cb8f25
-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Message #8 received at 73200 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Eric Bavier <bavier <at> posteo.net>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>, 73200 <at> debbugs.gnu.org
Subject: Re: [bug#73200] [PATCH] gnu: sleef: Update to 3.6.1.
Date: Fri, 13 Sep 2024 11:18:45 +0200

Hello Efraim,

Am Thu, Sep 12, 2024 at 06:29:38PM +0300 schrieb Efraim Flashner:
> * gnu/packages/maths.scm (sleef): Update to 3.6.1.
> [arguments]: Set build-type to release.  Update configure-flags to only
> set building a shared library.
> [inputs]: Remove openssl-1.1.  Add mpfr, openssl.

the changes look good to me (but I did not try to build the package,
assuming you have alredy done so).

Why build only a shared library?

Andreas

Message #11 received at 73200 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> posteo.net>
To: debbugs-submit <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>,
 73200 <at> debbugs.gnu.org
Cc: Andreas Enge <andreas <at> enge.fr>, Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [bug#73200] [PATCH] gnu: sleef: Update to 3.6.1.
Date: Fri, 13 Sep 2024 14:11:09 +0000

[Message part 1 (text/plain, inline)]

Hi Efraim,

Also looks good to me. I tested with build of llama-cpp for x86_64. Some other Python users currently FTBFS for other reasons it seems.

This version of Sleef even comes with RISC-V Vector extension support :-) .

`~Eric

On September 12, 2024 3:29:38 PM UTC, Efraim Flashner <efraim <at> flashner.co.il> wrote:
>* gnu/packages/maths.scm (sleef): Update to 3.6.1.
>[arguments]: Set build-type to release.  Update configure-flags to only
>set building a shared library.
>[inputs]: Remove openssl-1.1.  Add mpfr, openssl.
>
>Change-Id: I3dab4b84a755a49f187e93e684e85659af0e2a49
>---
> gnu/packages/maths.scm | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
>diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
>index a0cc0788caf..9a08e78d56b 100644
>--- a/gnu/packages/maths.scm
>+++ b/gnu/packages/maths.scm
>@@ -8,7 +8,7 @@
> ;;; Copyright © 2015–2024 Ricardo Wurmus <rekado <at> elephly.net>
> ;;; Copyright © 2015 Sou Bunnbu <iyzsong <at> gmail.com>
> ;;; Copyright © 2015, 2018 Mark H Weaver <mhw <at> netris.org>
>-;;; Copyright © 2015-2023 Efraim Flashner <efraim <at> flashner.co.il>
>+;;; Copyright © 2015-2024 Efraim Flashner <efraim <at> flashner.co.il>
> ;;; Copyright © 2015 Fabian Harfert <fhmgufs <at> web.de>
> ;;; Copyright © 2016 Roel Janssen <roel <at> gnu.org>
> ;;; Copyright © 2016, 2018, 2020, 2021 Kei Kebreau <kkebreau <at> posteo.net>
>@@ -812,7 +812,7 @@ (define-public gsl
> (define-public sleef
>   (package
>     (name "sleef")
>-    (version "3.5.1")
>+    (version "3.6.1")
>     (source
>      (origin
>        (method git-fetch)
>@@ -821,17 +821,15 @@ (define-public sleef
>              (commit version)))
>        (file-name (git-file-name name version))
>        (sha256
>-        (base32 "1jybqrl2dvjxzg30xrhh847s375n2jr1pix644wi6hb5wh5mx3f7"))))
>+        (base32 "14y1zf621zp0333vs29pc7pcc31gsrrs3q49b6qmd1kz6c7a7fp2"))))
>     (build-system cmake-build-system)
>     (arguments
>      (list
>+      #:build-type "Release"
>       #:configure-flags
>-      #~(list "-DCMAKE_BUILD_TYPE=Release"
>-              (string-append "-DCMAKE_INSTALL_LIBDIR=" #$output "/lib")
>-              (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))))
>-    ;; XXX: Removed mpfr because of https://github.com/shibatch/sleef/issues/458
>+      #~(list "-DSLEEF_BUILD_SHARED_LIBS=ON")))
>     (inputs
>-     (list fftw gmp openssl-1.1))
>+     (list fftw gmp mpfr openssl))
>     (home-page "https://sleef.org/")
>     (synopsis "SIMD library for evaluating elementary functions and DFT")
>     (description
>
>base-commit: d4869b7e43d823bccc8f6d81dd9f5d2c13cb8f25
>-- 
>Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
>GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
>Confidentiality cannot be guaranteed on emails sent or received unencrypted
>
>
>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[Message part 2 (text/html, inline)]

Message #14 received at 73200 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Andreas Enge <andreas <at> enge.fr>
Cc: Eric Bavier <bavier <at> posteo.net>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>, 73200 <at> debbugs.gnu.org
Subject: Re: [bug#73200] [PATCH] gnu: sleef: Update to 3.6.1.
Date: Sun, 15 Sep 2024 15:47:56 +0300

[Message part 1 (text/plain, inline)]

On Fri, Sep 13, 2024 at 11:18:45AM +0200, Andreas Enge wrote:
> Hello Efraim,
> 
> Am Thu, Sep 12, 2024 at 06:29:38PM +0300 schrieb Efraim Flashner:
> > * gnu/packages/maths.scm (sleef): Update to 3.6.1.
> > [arguments]: Set build-type to release.  Update configure-flags to only
> > set building a shared library.
> > [inputs]: Remove openssl-1.1.  Add mpfr, openssl.
> 
> the changes look good to me (but I did not try to build the package,
> assuming you have alredy done so).
> 
> Why build only a shared library?

The current version only provides a shared library but the new version
defaults to a static library. This changes it back to what we have now.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 73200 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Eric Bavier <bavier <at> posteo.net>
Cc: Andreas Enge <andreas <at> enge.fr>, Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 debbugs-submit <at> debbugs.gnu.org, 73200 <at> debbugs.gnu.org
Subject: Re: [bug#73200] [PATCH] gnu: sleef: Update to 3.6.1.
Date: Sun, 15 Sep 2024 15:48:07 +0300

[Message part 1 (text/plain, inline)]

On Fri, Sep 13, 2024 at 02:11:09PM +0000, Eric Bavier wrote:
> Hi Efraim,
> 
> Also looks good to me. I tested with build of llama-cpp for x86_64. Some other Python users currently FTBFS for other reasons it seems.
> 
> This version of Sleef even comes with RISC-V Vector extension support :-) .
> 
> `~Eric

I think for the vector support on RISC-V we need to build with gcc-14 or
llvm-17+.

At first build this fixes build failures on aarch64 and riscv64, but
breaks support for i686 and one of the other architectures. I was hoping
to get feedback from the QA system to see if it built there and just not
on my hardware.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 73200 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Efraim Flashner <efraim <at> flashner.co.il>, 73200 <at> debbugs.gnu.org,
 Eric Bavier <bavier <at> posteo.net>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [bug#73200] [PATCH] gnu: sleef: Update to 3.6.1.
Date: Mon, 16 Sep 2024 11:35:34 +0200

Am Sun, Sep 15, 2024 at 03:47:56PM +0300 schrieb Efraim Flashner:
> > Why build only a shared library?
> The current version only provides a shared library but the new version
> defaults to a static library. This changes it back to what we have now.

Okay, fine then! I wonder whether it makes sense to build both
(which seems to be the Autotools default), but I think static libraries
are rarely useful actually, and since we did not build one before and
noone complained, we can leave it to a shared library.

Andreas

Message #25 received at 73200-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 73200-done <at> debbugs.gnu.org
Subject: Re: bug#73200: Acknowledgement ([PATCH] gnu: sleef: Update to 3.6.1.)
Date: Tue, 17 Sep 2024 21:25:50 +0300

[Message part 1 (text/plain, inline)]

Patch applied

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.