From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 10:20:23 2024 Received: (at submit) by debbugs.gnu.org; 12 Sep 2024 14:20:23 +0000 Received: from localhost ([127.0.0.1]:41603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sokgI-0004mY-NF for submit@debbugs.gnu.org; Thu, 12 Sep 2024 10:20:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:52802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sokgG-0004mP-N2 for submit@debbugs.gnu.org; Thu, 12 Sep 2024 10:20:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sokg8-0001FP-BH for bug-gnu-emacs@gnu.org; Thu, 12 Sep 2024 10:20:12 -0400 Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sokg6-0004wm-4I for bug-gnu-emacs@gnu.org; Thu, 12 Sep 2024 10:20:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1726150804; x=1726755604; i=michael.albinus@gmx.de; bh=Iqkn4HcgnSUXANBRBx5kJ9pvZ+Cfw1lQKkNSwCGQGjs=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=cdwrGDEWyIfpNkpHlei5pG+K6cTQYbADOWo0mbWSG36i50nffPMP+vFWWlt3Q7mT RPnoXtuIrMOI//xg32n3+6RIIwrlJSoqmsiSwbuGGM9mnYPDJs9aEdYZDn9xRz4Rc j7H47E4BpXxrOlC5kTCGL9jiDP+bnMx7UKRuhzGP1KddFFkFl6Jg775djtkMqFOgm XWLW6pBFaCLKIGv+6Ck4DRUzvNxIawOXYWjgMre1DkAWcFSSX9OEFlXmN4szc7toH 6PzJ0g1+rvRWCABtJHcTMJ3lHicZD47rfLFtBfjxwYd76AwCuhJfBghhCH79zSLj5 P5WWAbRNbZ+RzIUytQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MqaxU-1sAxsq2wzI-00meuW for ; Thu, 12 Sep 2024 16:20:04 +0200 From: Michael Albinus To: bug-gnu-emacs@gnu.org Subject: soap-client; soap-invoke-internal is not thread-safe X-Debbugs-Cc: Alexandru Harsanyi Date: Thu, 12 Sep 2024 16:20:03 +0200 Message-ID: <87cyl9j6ng.fsf@gmx.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ZNus5ZSjC+4BN4xZotPLr6oIlt18oJDZEAKgVBbu9iwtIge8QkJ NRpT5ItNEqa94f/C1nWHDALN+V9naAD8ZJ1sTOKjTtfbgud5eDMsKdBSwMU+QrEH42lqjPH xLtaArihXE06QNF8J3mG+Pk4i0ZhZ2P/8M9vQhtKPK1usv+05TpyWsRxG2bEoidIxGmECk8 II3CE/6UW6b5bbkG5Xv7w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:DJeF/rwcIo4=;1QpkrGpL82DJOCeO4CaNYgQbYBF JUxSiTIDZ34JVCXlCA2ollwh5d8rScrRf4amBlE2Nk7lyQLE55OX3mOcNvnhxeWouKfwzewFt y22oBZ9xfJc5fXRYw1fBg//Y0hBJcjTyIaBAxkO77+ll4C41s/tLWBwtfpyl2yYwRaK/xEKsr /jRQXwVRpxkDjWccW0U0tzLMU5R3AwdsBdnf6fhponIrN/kA5iHOzdi4OiKpl7pVJVMW6a8Uo QqJ+buQ4oQVdQdlfMxYwbQsqI5MY64dR3gpLMmJ5hxrPT02dgFGWTDjKqxQuQAy0ztLX8m00d VxprZVR0yCSW55RrzGEwFv5q9jVGLrmrEi3J0WWA5XwGnKlujxHpgYqAFcU0AXMKRvG1Of7H8 FrLd+RzOpQrE5u8/H72qo1mAlenIZIQMKnRLq1nF93wjwMMOVJo2JxncbW0bhz9r2lLbbuMuy gcmHqSEN1dCRL+SZli8UA4rz54OT5fiF8Sdj5ktR1bQen203xtIPCLgw2/t3SCuQDVHSHN2vH A5cUU93a0bGxKHzsqyLsHM+x1s0DXqzpASJ8wWQHNg1JHVcO763618A9lNgKeh/svI9buuxVI 4Uj8h+lWH8m0BqlBwRbD66xQ7olfsYq2Jr75vGDae4cDZFcV4mZlFUcerB0/6xqMalCXHCvDs GKKSxO/fCGGAHX5Nxdgz3B8nE7RVordxb23FESs8br936MJKdM28/PEuXo1adeTgzjDNEubmN 2oDEn7jJU2QuumDVvHJo/3LpcA9N+/9bqkZGUwLCFzATXbMaI9UfikX2pbzJmiJBF4wB+xhUR 3hDhYTfNFR06nxyo/sTyKdnA== Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Forward to debbugs From: Michael Albinus Subject: soap-client; soap-invoke-internal is not thread-safe To: Alexandru Harsanyi Date: Thu, 12 Sep 2024 15:57:45 +0200 (19 minutes, 24 seconds ago) In package debbugs, I try to use Emacs Lisp threads when retrieving SOAP data from the debbugs server. However, ocaasionally I run into the error --8<---------------cut here---------------start------------->8--- (error "Attempt to accept output from process debbugs.gnu.org locked to thread #") --8<---------------cut here---------------end--------------->8--- My work around is to advice url-http-create-request --8<---------------cut here---------------start------------->8--- (advice-add 'url-http-create-request :around (lambda (orig-fun) "Set `url-http-attempt-keepalives' to nil." (setq url-http-attempt-keepalives nil) (funcall orig-fun)) '(name debbugs-advice)) --8<---------------cut here---------------end--------------->8--- However, it would be great if soap-invoke-internal could care. Emacs : GNU Emacs 31.0.50 (build 35, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-09-12 Package: soap-client From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 10:07:11 2024 Received: (at submit) by debbugs.gnu.org; 14 Sep 2024 14:07:11 +0000 Received: from localhost ([127.0.0.1]:47439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spTQc-0000aQ-TQ for submit@debbugs.gnu.org; Sat, 14 Sep 2024 10:07:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:37908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spTQa-0000a9-Bh for submit@debbugs.gnu.org; Sat, 14 Sep 2024 10:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spTQP-0005Gl-HJ for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 10:06:57 -0400 Received: from mail.fitzsim.org ([69.165.165.189]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spTQN-0000cM-31 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 10:06:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rHZqKbOz1TT9kQ0uANILJf9hAjmlQowbuoiM0HvN2+E=; b=ar60v3q1WsTd48Y+5QWt99xgdV PwvdYooN+iUqVA72DmyOvDh/DX/azmE5AXbpqfaA3Fqs6n9zuT/VsTnuwZKnXQ7mj1WzLJfBe2dx4 lubIVcg+xrQTf8GQ0qxZPC+ZmU2lkyC7OsAYp6GsGz6ziOdizEspP/1Wozdn5s7btNJ+xZdhKCS0c FJEWjXHlRVy1zdgqCJ3Pej5wliUMASPO0NF7sP9rY+NZFSjtY7/+GXTA4dAqhQHdfmQ9hJGpnvHtB jW742VNzT4IeAYyZPLSMBa/iUQK/Gzk0BUf8NVPmhVFMzz3MNKQ0c5RSelJ1r67Y8DXNfPJUlNm4A nzEeEolQ==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1spTQF-000Dsl-22; Sat, 14 Sep 2024 10:06:48 -0400 From: Thomas Fitzsimmons To: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#73199: soap-client; soap-invoke-internal is not thread-safe In-Reply-To: <87cyl9j6ng.fsf@gmx.de> (Michael Albinus via's message of "Thu, 12 Sep 2024 16:20:03 +0200") References: <87cyl9j6ng.fsf@gmx.de> Date: Sat, 14 Sep 2024 10:06:47 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=69.165.165.189; envelope-from=fitzsim@fitzsim.org; helo=mail.fitzsim.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Alexandru Harsanyi , Michael Albinus , 73199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Michael, Michael Albinus writes: > Forward to debbugs > > From: Michael Albinus > Subject: soap-client; soap-invoke-internal is not thread-safe > To: Alexandru Harsanyi > Date: Thu, 12 Sep 2024 15:57:45 +0200 (19 minutes, 24 seconds ago) > > In package debbugs, I try to use Emacs Lisp threads when retrieving SOAP > data from the debbugs server. However, ocaasionally I run into the error > > --8<---------------cut here---------------start------------->8--- > (error "Attempt to accept output from process debbugs.gnu.org locked to thread #") > --8<---------------cut here---------------end--------------->8--- > > My work around is to advice url-http-create-request > > --8<---------------cut here---------------start------------->8--- > (advice-add > 'url-http-create-request :around > (lambda (orig-fun) > "Set `url-http-attempt-keepalives' to nil." > (setq url-http-attempt-keepalives nil) > (funcall orig-fun)) > '(name debbugs-advice)) > --8<---------------cut here---------------end--------------->8--- > > However, it would be great if soap-invoke-internal could care. I am not able to test Excorporate's usage of soap-client anymore to check if a candidate patch would break anything. I will ask on emacs-devel if anyone wants to take over maintenance of Excorporate and its dependencies. A starting point for adding thread safety would be a minimal test case that calls soap-invoke-internal against the debbugs server from multiple different threads. Are you able to extract such a test case? If the resulting patch is obviously safe for single-threaded usage by Excorporate, then I could push it to soap-client.el. Thanks, Thomas From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 05:59:02 2024 Received: (at 73199) by debbugs.gnu.org; 20 Sep 2024 09:59:02 +0000 Received: from localhost ([127.0.0.1]:34096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sraPl-0007aE-Kb for submit@debbugs.gnu.org; Fri, 20 Sep 2024 05:59:01 -0400 Received: from mout.gmx.net ([212.227.17.22]:55255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sraPj-0007Zz-73 for 73199@debbugs.gnu.org; Fri, 20 Sep 2024 05:59:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1726826301; x=1727431101; i=michael.albinus@gmx.de; bh=Sfy8A+OZpgLv05mq8bZXns5UkzEOmdSUGmJm09ovngk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=BjARMMxw9OpJfiGZ76Rfq3+XJGuG7SLeeGdHxcVLVgUz5OOXV0rQaFxdtmx+PjDo PeBWEeNzvFerRacmqtc2vrbjy+RltvswwwWsM6b85ma9yRb8vBqooVavXJs2x4JIO TSf6r8Q75E83ZzCzCkOlFJ5xru7SuHNHyvti1PVY0qFrUEBbYLODraQKKCqi0E6Wr rA3Y7K5B+jJWg47UFsMzcoChX8hdEenkeNS9mmznoqa0E+pVN16oVxg66KIimH2sw +fY9BpVf7o33Q4nLYNIrzTzIEFnWt2qv4zT//wV5J3GczHMm36YsFKwXLYU0xduI0 Y2QntTfHODfuSwFm5w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MSKu0-1sOxj23eiu-00Sdy0; Fri, 20 Sep 2024 11:58:21 +0200 From: Michael Albinus To: Thomas Fitzsimmons Subject: Re: bug#73199: soap-client; soap-invoke-internal is not thread-safe In-Reply-To: (Thomas Fitzsimmons's message of "Sat, 14 Sep 2024 10:06:47 -0400") References: <87cyl9j6ng.fsf@gmx.de> Date: Fri, 20 Sep 2024 11:58:13 +0200 Message-ID: <875xqqk5oq.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:m8gOCTwP0nfmLZMiYkNdpfgtQTxdNNlWT4hHLQu6ToCP7LQLJP4 MxEgwwqgOHm7jByvKkQ0z1qwgJ8rHvMXyOrksudKOzzKzKUrp2E58k9s8xpyjVdpRLkbSmX sQFfJPO5qubjqxxBw6ytg7MlHURccHxRsSJFQHPV+4FBXeJSMeu585QKTN691TI32iWpNeD ifoxnKsRFODFBNKKuoycg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:BjhHB7xpK+M=;+N3PykFycQnX0kmcG+u0d0mOK4c +OFrqGFnkmWR77n9vK3uRN2ZSKmhCTyLEFig/FloD7//DQycR4lpjdzGVajTii15vSFY6rawk 6p3+SuyLURpN/DfjhCdlLAjWVPr2jt0b2TfpyoO7iTCa90V22kfdcORKH72ReZW51P+BmR0Yw rMgkKwfirp/ljeR2yWZ7Rmstks2wUZUXSQsMosDzQq1+/FTu7U2Zx+vEVlZpN11iaRs+veito D6Ne/yf+U1MnJAQ4MyM5ZqPaxzFmoY5bNflHgBNOpvrbnqWgazVnxx0H3m3SbZh7WuHnnrcj3 b/B8fL4M5Kglg6nR9G9WobXjBMDy2GslcnCBdhJBe/hPTVuj9DR3DB66MVPVstq/UXlykLPU2 qksHcYDv33tWg7hhiTsBc+WZ6zsZGw8ubBQMBkyEiGWeVyaqsh99+kEGkW7IMHToNrHeYShSj OO7gQFDEsJFhY445RMSzL7bCOj7eljVWbdpc67pJJ59HrnImrQz9WcV3vBizUhjQyUiLvlEG1 mxsMUwBqaamzRRdyzsKwiQ0ZCgzcIfvtgYm/zJRPefjmccEQXJcxKf63KTLiJW4gDF9zUKm+n urL56E4dq/HtkBKZH7P4I7w68G/tpR9SP/S5gKiuqUVnE3O0c7uFGLYqubJpLeQ5Ty7PU0l3v ph/DMd2kQ0BtxGsDZDdL4XfZudpY2avqKZck9D4tVyTxdllFwztq+6P4vxYLS9mO3dZjH5liw yeuPOsDAxU3j+3Fk6TO1006GsZt4HDt5EV3krHEkFvKOGLDqmP2Enq8/QKwN6DHxa/4+52Q46 TyIEs+ICMFRSkcWfEziJz19g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73199 Cc: "Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Alexandru Harsanyi , 73199@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thomas Fitzsimmons writes: > Hi Michael, Hi Thomas, sorry for the late reply, I was out of order for a week. > A starting point for adding thread safety would be a minimal test case > that calls soap-invoke-internal against the debbugs server from multiple > different threads. Are you able to extract such a test case? Install the just-released debbugs 0.41. Open a new Emacs session, load debbugs-gnu. Deactivate the advice I have added to mitigate the problem. --8<---------------cut here---------------start------------->8--- (defalias 'debbugs-compat-add-debbugs-advice 'ignore) (defalias 'debbugs-compat-remove-debbugs-advice 'ignore) --8<---------------cut here---------------end--------------->8--- Retrieve the most recent 10 bugs. This happens in the main thread. --8<---------------cut here---------------start------------->8--- M-x debbugs-gnu-bugs RET RET --8<---------------cut here---------------end--------------->8--- Retrieve the most recent 100 bugs. This happens in another thread. --8<---------------cut here---------------start------------->8--- M-x debbugs-gnu-bugs RET -100 RET --8<---------------cut here---------------end--------------->8--- You'll see the error. --8<---------------cut here---------------start------------->8--- Error #: (error "Attempt to accept output from process debbugs.gnu.org locked to thread #") --8<---------------cut here---------------end--------------->8--- BTW, in a short discussion on emacs-devel, Stefan Monnier proposed to fix this problem in url-http.el. Don't know what's the better approach. > Thanks, > Thomas Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 03:27:43 2024 Received: (at control) by debbugs.gnu.org; 30 Sep 2024 07:27:43 +0000 Received: from localhost ([127.0.0.1]:44560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svAol-00064T-C2 for submit@debbugs.gnu.org; Mon, 30 Sep 2024 03:27:43 -0400 Received: from mout.gmx.net ([212.227.15.18]:58221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svAoE-00062d-9f for control@debbugs.gnu.org; Mon, 30 Sep 2024 03:27:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1727681179; x=1728285979; i=michael.albinus@gmx.de; bh=337kZKhjtZGiHAZ/4kCavaXowYgQw7u7Ie5UzLO2L7k=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=gKvKvyUNL6n2RqPsBHY2aRxwWnma9NNmfkt8spaKgLhmDx19LgZcK7r8gA9//QRw ACIqijjLTlw3plMqis9VzjSz1RqnXaO7xMBRx58tkr3Fa3ofwO/efnJ9DuDRJ7oT+ t2/6yCiP3Ga8N0NFsX8rhJqNY7F7TLGtvnFyanmEnRec8kqNhE+1jd/DyqibwxScD ahWn+4XV2gBPgpvH1Hv6O0qyZC94rjZeOopJAFrG6pDbAUQ9eF8MG+AYpMX/07SdF Zv5ralSW4qklMey5iK0OIipcaxZEYLWYwPlu/Sc0/ROrpxsE8dk+fTwHmH/HW69tY k/CigTSagsrivWqEwA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MiJV6-1sIFPJ0MHW-00gKpm for ; Mon, 30 Sep 2024 09:26:19 +0200 From: Michael Albinus To: control@debbugs.gnu.org Subject: control message for bug #73199 Date: Mon, 30 Sep 2024 09:26:14 +0200 Message-ID: <87cyklmwkp.fsf@gmx.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:apbH5kg/jq35PkXAVWlAI6RseZaV6kann7Dzk0xNmLVGH6oPVpj CS7GGqu8PV9yMyX0G4ILbh7Iqnz9A84y00C4DDiqe1Qw/SdrDjqBrX3X4B68gzoI8cCwiSt mG0JBsoXrTnFef/TW+clqyq7Xyv9d6wvnUfX9qW3fJegyIB4Ljhc2Ta5g3xFMeU4enizDf4 1O2fevW4lVgpC+izlag1A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QvH5Q3hYlx8=;/zbO6djVLXwniHCIAHKumM/TJff CvnIOka4Zpih1Hd/LUnqqzYguvFCLASqw5Rh7jUtonUoSzTfBdIo59ra9smTsbL8kqbFwASLC ERqveKYTjsRqg/4uHkjaZUnl8HNHxRAiu2JqeHsNK8E40TDlnDU2v8nA4jFcWNLALl+57S+/H IplETmSv7m5WQvLiVNbSRsrSuskrbcky7f4DsJ13CLZNt7SHxvcCOmb5s3jUO1n6XXWbq9u8n f9Jylv7EjFLxapblfEmHgXKWFVYGSt4C53/3+Gd7Z/MFanFpo45KDgR6ZMPNjzBEagpD/x/To mN78II5oXqM2fVhyRP/pBVxBikh5dWOqKwxKsQXqmvPR/UIisOvaZz6723pmE97VhSXYYHECo 8OY0xDpYVtAmHItdBcw03Hlf1vqh2dhjQc9Tgy/sl33SMJ7p6Zokxom+0JrGQ6GJI69QcdkTL pVXeBnjTzuOF8jScanVd5Vrv3jVFf27AapDgKZhifdlfz++05+TmvA4X1ai+MyANE6WVU0ALc pCB299KrEhAGek4+gq5MkuMyN6y7E5hbIcJgB8LW3EnT2zZF5Ziv0OHDGH4aQN34WAkxO0Wni F0AE2uQ9tGlswowsAyt4dgmF5l42mVXU+6qfWKxwayxEM45Dd5Awm/WxV7+eEWEMWvSQ9at0S RuczTgM+XtZSNkFYOmRspZta40ogc3BZq7w77qxl1D9tUO13RdwCgSy6xEw8ORGa1egFuXfmk +bhM61k1DWu05P76wbIfn2Y9VVb+HDzSszMkj/RArEyBZ9mXIYCuuPF9Lh/DF9n/GH9ajnPA0 y+oLDR8M2afuq+x8I+ktk7iw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 73199 url-retrieve is not thread-safe quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 11:13:32 2024 Received: (at 73199) by debbugs.gnu.org; 30 Sep 2024 15:13:32 +0000 Received: from localhost ([127.0.0.1]:45372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svI5c-0002zN-Hk for submit@debbugs.gnu.org; Mon, 30 Sep 2024 11:13:32 -0400 Received: from mout.gmx.net ([212.227.15.19]:44673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svI5Y-0002zH-Va for 73199@debbugs.gnu.org; Mon, 30 Sep 2024 11:13:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1727709160; x=1728313960; i=michael.albinus@gmx.de; bh=RYdSLVNnns+YWzgP2tKmOu9zEwRiflwHhZSsV3dT1hE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=kcKcKmYNm8NKwK39TvMUPDYkaT0PhjTpPqHQ1d6g7YRmuo/MoBWJ5FsxHOGBFyf/ e1M2EZegh3+L4WmnUJeq0r8JfeQbT8lfLA++QRXb3yvqMeaZ0OMy+VWpCvPTpbms9 SgKoDccr/ib6AfA0rFYOHG3NfwiAdrC9FC0xwx4zlFVZGGbB3O3evticYjFAfmKg5 CXHktKgzZ466/l5aMwU+4zRe/xlq6aXQKst9ANtZS38UErYR//O+SopsJzea78xFf i27q4hjMHEoeZ484rH+4XoQcpZnhRJU2y5l02mc4+bxUhRcoQvQh+PM1tx3xqGmTb NDrTrjkxIfSv1yeCsg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MRmjw-1sSAKj2IPa-00XD6V; Mon, 30 Sep 2024 17:12:39 +0200 From: Michael Albinus To: 73199@debbugs.gnu.org Subject: Re: bug#73199: url-retrieve is not thread-safe In-Reply-To: <875xqqk5oq.fsf@gmx.de> (Michael Albinus's message of "Fri, 20 Sep 2024 11:58:13 +0200") References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> Date: Mon, 30 Sep 2024 17:12:34 +0200 Message-ID: <87wmit9nvh.fsf_-_@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:YJIb9M5rSzoB9TiXjQ6xH1ioFTDE4b56uAg376+s8g7MdNGUoaz /BYaHHXMyY/3t13DeoTVZdZSewQshmTBB8n57JZe9ANGyDHvbRSD6zv8RIaEXGpA80ppZbU g4dkj8HdzTEXJHly+Ip50giqZs6LvNaNgys5tYfK+hyL4eXr68O4zEOR+HdV+/5W/lB/0ov G5QCkhHgvhtrUHpUaFp3Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:6XW89AYR614=;bCk78wXnMkDYCnJq5ZDkd1GP+dz FYkmBhSSc5kqdwwCo8sU2xVlgTpQMf81V/X0MWNjIqdtK2mKH/TDGKau2G436yDbBq4WFA1ZC 9WwOMYZM+b/+Y0cMO9EmcgYiXilnwuMY9I3mi9p/nZsfH1c9C6sPf/qnT9SOBChEvj1EJ1bhf IXbSWTwVGWUHwvD//OTSpfbq3o9kMsPrKcEb9VZ/fCgzYEpGWOBixKqS41iPTfdqhq//WEwwW Qmffi8yQN2YbtK3kDm2lXOmwrDvWmRWwXd3kJva110En49sUZ91ajPLegNAMuWVNzbR1qWPtx crYchsy1COxKIuIxcPjI3DEPcV+AJJIPZZB8Dn786VkmuytXVHygfHU/BGIjvu6QyKtN/x/71 7ASxCuuwFtO1tXxPnwmnjDLUY2aqOFHjgXqkJBnZsgIzY6gLG8nJ4oErbLfeJyfRD46mHk5e8 v4+eooSzna87dQHu5PhnKhtouW5upoCo/RD4fEGLdfRXQAZvILKIRDax/XniV5E4PLp8ceOLC NmFsH0D0eJra1dl32JjuAkHwdk7zh8+uy/17zXw+1HU7/DeDIifJTLwsq4I1lKXEzHi5BFTCb wPp1eWqjBvjxxPxkkxHnhJy97K8yDy0WWIWfGU78wV6R572an798tS4yY4eQ3TEMEst3ctS97 /SUmqKh7GskwCZomzLH1czhwp1JYPQcLMS8ZII63potOTYVj+KgemQrXMmic/NSkWVI9UN9jt pC/awLIyIiRMaJRuSfxPUdQwE9lguHWOd03725yzZe+3DNUU/U0qGkGGlsTME5PkECGlY69yh J6v5B4p6WCMUc1XFlKm/6FvA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73199 Cc: AlexHarsanyi@gmail.com, Thomas Fitzsimmons , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Michael Albinus writes: Hi, > BTW, in a short discussion on emacs-devel, Stefan Monnier proposed to > fix this problem in url-http.el. Don't know what's the better approach. I gave it a try. The appended patch seems to fix the problem. At least in my use case, there's no error anymore when I use debbugs w/o the advice in debbugs-compat.el. Comments? Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment VC backend : Git Working dir: ~/src/emacs/ Branch : master Tracking : origin/master Remote : albinus@git.sv.gnu.org:/srv/git/emacs.git Stash : Nothing stashed ./ etc/ edited etc/NEWS unregistered etc/NEWS-checklist lisp/ unregistered lisp/man.el.formatted edited lisp/server.el lisp/url/ edited lisp/url/url-http.el test/infra/ unregistered test/infra/emba-gitlab.history unregistered test/infra/emba-runner.history --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 11:42:50 2024 Received: (at 73199) by debbugs.gnu.org; 30 Sep 2024 15:42:50 +0000 Received: from localhost ([127.0.0.1]:45501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svIXu-0008HJ-CT for submit@debbugs.gnu.org; Mon, 30 Sep 2024 11:42:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svIWb-0007rM-6r for 73199@debbugs.gnu.org; Mon, 30 Sep 2024 11:42:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svIVx-00089H-UH; Mon, 30 Sep 2024 11:40:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=m2BWvNTbzbOzg/jYSq4KwdM4jeQseDDjsRAmWBuVlHE=; b=oYe0+fVyp+bX DJaoiRauLaMvPXPNNTNVu5y37kYqdl72dgef/GD6sHce0FXRR7OlT+A7jFy+FpRwOCbsp2HIHyhs3 nJJTnpWIc0MP711uwP/vg7Y4wM8nPZyKNdbRk2sfb493MuFrtGH7FWjC8XW50HBFjLpKQ2VDdqD78 tdAicx+15GxtdCINTql3qEcaUaEYFWxAl4ZHOFae6EeiwClWfHlaCnjQNPR6iABEnkj4La3Ld2393 2zQZz5h+KV+W8UrkKhyyFzHCiJU2WlN8MPxnBTRaLifBnJ06JRndjGkVVsFSf0NwQ63XBybEUOJXs SY0KTCy4snf6asyGhX5JAg==; Date: Mon, 30 Sep 2024 18:40:42 +0300 Message-Id: <86frph2lqd.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87wmit9nvh.fsf_-_@gmx.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#73199: url-retrieve is not thread-safe References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> <87wmit9nvh.fsf_-_@gmx.de> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73199 Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, 73199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Cc: AlexHarsanyi@gmail.com, Thomas Fitzsimmons , > monnier@iro.umontreal.ca > Date: Mon, 30 Sep 2024 17:12:34 +0200 > From: Michael Albinus via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > BTW, in a short discussion on emacs-devel, Stefan Monnier proposed to > > fix this problem in url-http.el. Don't know what's the better approach. > > I gave it a try. The appended patch seems to fix the problem. At least > in my use case, there's no error anymore when I use debbugs w/o the > advice in debbugs-compat.el. > > Comments? ENOPATCH From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 12:49:06 2024 Received: (at 73199) by debbugs.gnu.org; 30 Sep 2024 16:49:07 +0000 Received: from localhost ([127.0.0.1]:45825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svJa6-0003aF-I6 for submit@debbugs.gnu.org; Mon, 30 Sep 2024 12:49:06 -0400 Received: from mout.gmx.net ([212.227.17.21]:57117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svJa3-0003Yo-EH for 73199@debbugs.gnu.org; Mon, 30 Sep 2024 12:49:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1727714904; x=1728319704; i=michael.albinus@gmx.de; bh=vjW3lY80LFnMxjeiiJkrQg/yRDzOofXbjGB4/FejYcM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=caYHjD8EpoOjOnJSCesOhwsBVUSez60rM+R7t5fqwlSIZaNdZFak/k7WLSqmPQR4 rR09v7LWcJMWVhRBUfv+sSz3br0UHdiAfhwbSyAzsBs/ZzAMeJWCAvpit7/Pk/P6R jd0XcRbQuo2AkuTw4ES3vf7Vdho+tDz/yOxgv4VQ+Twwt4s4HfloXxkNLeQIZSYTn +14KWayuszJwonBSuK/LNTVS7YNnvgOrZ0EqCcB1UWHH9udIAAyLIdtvjHiezTxhF m2YgfENyq3NwKxkYen+rKRIBuN9oJhebL8Ya82hEu0Gf2RkwoOaZO5OBa4NgE1SsY +glgcAsDZzWqCiwczQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N95eJ-1rrx1o1ggh-00zmtX; Mon, 30 Sep 2024 18:42:59 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#73199: url-retrieve is not thread-safe In-Reply-To: <86frph2lqd.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Sep 2024 18:40:42 +0300") References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> <87wmit9nvh.fsf_-_@gmx.de> <86frph2lqd.fsf@gnu.org> Date: Mon, 30 Sep 2024 18:42:55 +0200 Message-ID: <87seth9jow.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:IwQ3G1WPcJ8Pxy1esA5XWZ/vJ4LIFw6XNm/MxauIG1s7diDvDU1 yUPBQ3aYRUlpFGfUbsW97AXfkq/RfOXVfguRciPg4s4oP/77WFG4OMKDn9h6o4suA3cO+kF yI/XFBYzCbPCzYimYb/Nhe7OQnwvJv/J99OvQLfKA8BkkRXweKJxVCVZyEUA36bbnxCOo8B qMkXQv6drRm+MCUrwwcNg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:s0UXp1Ze9mg=;aPNrOPnnt1A97PJZPNZ3r9wJte1 mXDyxjyxFj3mporvGvVlcJOik2yBXYQEexQU1M1KCDKEG9qo4vsGP0NRnl1O17vrpg0IfFTUo m15DtG7T5ZlqIlHgMCjkX4BuDDq25dtIbhkTpsBqAMfksxyhfmpgHnzWNqv3Om6xnbJ/qrzQr oFnqnwvcBco4KjNP6zCTGrpQwXAxNb5GwyhVjZnTrHws7uYYYMv0+CVLBvcDOSBGO4ugikYqz esjUUOyhvjYgsnsSv9qTEpBwxxzxubGAfmVbvv+uvohcFFZxPmYzTOQH6nzsvINCH+1ArrmaY P1fyIJRkTK/1LmzQHpsU2gnrKT/wZLQr52q1yE9KEsPDdorvq+n/0zOXeyiQxA4PYH4usvCEd bZ+hHSMaE7an+xBYBk0JrFRt3sX3Q2pgDYHxpBhHqdwqlFA89ky045jvMgE6kQ/IiEgOXnrIa IFjX0QndOml1RUpgdQMZ6426jbAlMXFY2IZxo10kU5npt9c2PH91x0fbbDrAIkyHEyrM5rLqK zgugHPsKHFTzmRCXlbLilBZ9T5rW8c8J/DfWPo7CSGPjS5BFfs/OBxNaYR9ZiVtxx4zAVsIzc gUeaD8Rq23Gf2Hr5O4dbk78l7gvskE7fEY9gRqirlXF/qaMHNh410CMmEVurzH7qT+2l3z+VP YR9lj6V74D2jZum979YRG3JrGrM5eOBPYDQg3gKji6btD74e4xILHQjJOv7G/2X4oi0EJPgQL qSOXVFlSp/B1RoSq6sDGASWDJsqg3+gxHsLJ4xVSJBZzpmD1ZWwBHF1tvj00AAjhrqyjmz5k4 U1pv67nGrTicW4uRgHzrD+CQ== X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 73199 Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, 73199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Comments? > > ENOPATCH Oops, sorry. I've appended the vc-dir buffer, not the vc-diff ... --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 184c1278072..019ba2d7e57 100644 =2D-- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -74,7 +74,9 @@ url-http-proxy-basic-auth-storage (defvar url-http-open-connections (make-hash-table :test 'equal :size 17) - "A hash table of all open network connections.") + "A hash table of all open network connections. +If Emacs is compiled with thread support, the key is a list `(host port +thread)'. Otherwise, it is a cons cell `(host . port)'.") (defvar url-http-version "1.1" "What version of HTTP we advertise, as a string. @@ -154,26 +156,33 @@ url-http-debug (apply #'url-debug 'http args)) (defun url-http-mark-connection-as-busy (host port proc) - (url-http-debug "Marking connection as busy: %s:%d %S" host port proc) - (set-process-query-on-exit-flag proc t) - (puthash (cons host port) - (delq proc (gethash (cons host port) url-http-open-connections)) - url-http-open-connections) - proc) + (let ((key (if main-thread + (list host port (funcall 'current-thread)) (cons host po= rt)))) + (url-http-debug "Marking connection as busy: %s:%d %S" host port proc= ) + (set-process-query-on-exit-flag proc t) + (puthash key + (delq proc (gethash key url-http-open-connections)) + url-http-open-connections) + proc)) (defun url-http-mark-connection-as-free (host port proc) - (url-http-debug "Marking connection as free: %s:%d %S" host port proc) - (when (memq (process-status proc) '(open run connect)) - (set-process-buffer proc nil) - (set-process-sentinel proc 'url-http-idle-sentinel) - (set-process-query-on-exit-flag proc nil) - (puthash (cons host port) - (cons proc (gethash (cons host port) url-http-open-connections)) - url-http-open-connections)) - nil) + (let ((key (if main-thread + (list host port (funcall 'current-thread)) (cons host po= rt)))) + (url-http-debug "Marking connection as free: %s:%d %S" host port proc= ) + (when (memq (process-status proc) '(open run connect)) + (set-process-buffer proc nil) + (set-process-sentinel proc 'url-http-idle-sentinel) + (set-process-query-on-exit-flag proc nil) + (puthash key + (cons proc (gethash key url-http-open-connections)) + url-http-open-connections)) + nil)) (defun url-http-find-free-connection (host port &optional gateway-method) - (let ((conns (gethash (cons host port) url-http-open-connections)) + (let ((conns (gethash + (if main-thread + (list host port (funcall 'current-thread)) (cons host= port)) + url-http-open-connections)) (connection nil)) (while (and conns (not connection)) (if (not (memq (process-status (car conns)) '(run open connect))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 14:04:29 2024 Received: (at 73199) by debbugs.gnu.org; 30 Sep 2024 18:04:29 +0000 Received: from localhost ([127.0.0.1]:46147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svKl3-0004Sx-1N for submit@debbugs.gnu.org; Mon, 30 Sep 2024 14:04:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svKkx-0004SW-0R for 73199@debbugs.gnu.org; Mon, 30 Sep 2024 14:04:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svKMH-00052C-DQ; Mon, 30 Sep 2024 13:38:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hVXEgHxyxkPN0VrQ4CJNdREFXeCrIfDLiolfrb3DD4k=; b=GHuWnmoruBF8 pH1/1gY1kiXyDRYXd0cw3JaNOnn7GLn+yhSEfOIfgauBjqxDG03LsBxODcDj7Gt8rUoN6k7zIhXYF 9u/h4q7wRVqXBYmgZoXZhV7O36aQ1vi/GJLnBjvNgxfGQ0opLmR5QcBOqrib+rDpUrtfJSAx5gKLC W1tDcF5PvwR98lx7Fyh+Jr3Kdef/sMnARJjSz82i19UDXkYbRFECvKaBu7BY8Et5M9Eqo9+87lH8+ U9ycEWs5+g/A3psAW5OMg8oxCGt2R85Rt5245rjpSWOUTss5YCIyv/GgFsa6f3rhcj42RdSXGhEqJ UNCbhHSDbHxSoZDjFDDUyg==; Date: Mon, 30 Sep 2024 20:38:49 +0300 Message-Id: <86cykl2g9i.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87seth9jow.fsf@gmx.de> (message from Michael Albinus on Mon, 30 Sep 2024 18:42:55 +0200) Subject: Re: bug#73199: url-retrieve is not thread-safe References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> <87wmit9nvh.fsf_-_@gmx.de> <86frph2lqd.fsf@gnu.org> <87seth9jow.fsf@gmx.de> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73199 Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, 73199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Michael Albinus > Cc: 73199@debbugs.gnu.org, AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, > monnier@iro.umontreal.ca > Date: Mon, 30 Sep 2024 18:42:55 +0200 > > Oops, sorry. I've appended the vc-dir buffer, not the vc-diff ... Thanks. I'd appreciate if you could explain why url-retrieve is currently not thread-safe, and how this patch is supposed to solve that. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 12:35:28 2024 Received: (at 73199) by debbugs.gnu.org; 2 Oct 2024 16:35:28 +0000 Received: from localhost ([127.0.0.1]:59092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw2Jz-0002k8-Q7 for submit@debbugs.gnu.org; Wed, 02 Oct 2024 12:35:28 -0400 Received: from mout.gmx.net ([212.227.15.15]:33947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw2Jx-0002jt-20 for 73199@debbugs.gnu.org; Wed, 02 Oct 2024 12:35:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1727886906; x=1728491706; i=michael.albinus@gmx.de; bh=oqBqZqIRdF+EgDtYmkPnOreEu4Y8+b7n19cXSB2B3zU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=jwJYhlKdWbfoWcuTfCybHyV9lFxxH83xVClxhi6HLyt/4TOiXEHpstaJTZLmmsU/ s1KxUSnaej+PI+yDuln5pYuFJbtpSg64A7gxzcp0xhqB9IEIsehndyzKUn2geeXMn BHr+VI2HWTqyYvh5FsjEq0LVKjPSbmxWIAOwxM8lPYQg3mOg8h1CsSUvn1amBSVz4 gGPlItRpbkgX9Jj72cOK2Iuti5O5CM4G/cPK1vRl/2y9sTvyobGGlXAPk11ww0Hk9 X5kH+0tyY6hyyxjxb0XqnpeXvkntLuYOyX0vKKXoFRoco3lpu14NHQcruXpOGbU6g QNpib1zQJyAeboOaNw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MxUnz-1ryQXg2jDF-00tvwi; Wed, 02 Oct 2024 18:35:06 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#73199: url-retrieve is not thread-safe In-Reply-To: <86cykl2g9i.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Sep 2024 20:38:49 +0300") References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> <87wmit9nvh.fsf_-_@gmx.de> <86frph2lqd.fsf@gnu.org> <87seth9jow.fsf@gmx.de> <86cykl2g9i.fsf@gnu.org> Date: Wed, 02 Oct 2024 18:34:55 +0200 Message-ID: <87wmiq8nv4.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:zzrahammdckDPNU32UFnP8zDDNwCmTMmadpVJrIHbq0fJ/p7v+2 piWIs8o42SNttbvQnRO7NOETsYPDowhazr60fpJ1SJC+67Fnlas94juT8Qw6XKSI2Ts90HW UwdtttAXpxk+qY83ZXfprwrWKssIsHkYMYTqoVGmCXiU3/ExPLHIMSpVoW5e/n28z/eTIkf 6FIQEjhc9A9xC3t4m4GOw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:axmwujf9HC0=;gdySRMZ0W1nt16gsdFuMR8bMqB+ KF3TdPLS+xIunnuhOdVVqBM637beWdwaYEv8uJdgZPfDmVolY8XFgxa0ZX0rbxWLAsYvQqwfo AKdX9blbGRvplURZ9hF+mo1RaiIbN2KTDYBOG8a9TMJ/mmif831YDgYt7VmYhU5uVYkkpC1vt IZyS5oKiV/b43/DEjYINUWSk2bb8w6NRcAfJ14dUkXQwRRmvzAp5ouy/sFmplPWflhAyMnn0n vCKZSYpbTRU26bRdgUB4cohpwBra8SgY410v6Z4Hjt2LsK4a/hfGCJw0vJeRPbsBOt8E90p4I uK5EwyPmE1bKEo4GvJkGfTuncsFc6c0VqjkvnRNFgMOguVgeqsNpeileGqoPXDgmTj2qEm4Qn vNMkU6I5PdZBenJ3SYK2CrNqaBIkTq4NXDj9ofLGYfijsbTS98zn1abVRiYZhQJ5MeGN/5Wow MTUiuMBokEC6L6djwijXlhrGNXIU49knbjSqoGSpmeM9YBeos3CdVce4/oIU/YXrHpejJvlih 8y1CgUYsrkmXDAz+ifAEJisj/AkrxlqGVx2lzsXkFtOcI4e1XnK6L6C5jez/H2USiqpnQUD5h s/LnBmqczQW2qlkM0JGd5Se4I2bqxROGWSTofIKbZc0oOGRxromGIfrjq2VjyPgMcbUEZXCaG 4CazAXsGzUztRnFMaIg0+2mKUGMJfuYz8SWg97kgO8Bfnvu8axp4PaWNK4+GK9TIS4Ech4t5+ 9/Bc0RXe4LOv7B5krymYeYKgPelr4ee7HR1IGdoZzEPzCWryjLt4Jx1GfpdqgLpHPmGrpP77x mw0IBjzRFwzq6I/FbiydrdGA== X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 73199 Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, 73199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Michael Albinus >> Cc: 73199@debbugs.gnu.org, AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, >> monnier@iro.umontreal.ca >> Date: Mon, 30 Sep 2024 18:42:55 +0200 >> >> Oops, sorry. I've appended the vc-dir buffer, not the vc-diff ... > > Thanks. I'd appreciate if you could explain why url-retrieve is > currently not thread-safe, and how this patch is supposed to solve > that. In , there's a recipe for reproduction. The general problem is when you want to access the same HTTP server from a different thread, and url-http-attempt-keepalives is set to t. This happens, for example, in debbugs 0.41. Let's assume, there is an access to debbugs:443 from a given thread, for example the main thread. Soap-client serves. It also binds url-http-attempt-keepalives to t, the https process stays alive. Later on, there is an access to debbugs:443 from another thread. It checks, whether there is a running process for that target, and tries to reuse. We get the error --8<---------------cut here---------------start------------->8--- Error #: (error "Attempt to accept output from process debbugs.gnu.org locked to thread #") --8<---------------cut here---------------end--------------->8--- My patch tries to fix this. The list of still open processes is the hash table url-http-open-connections. It has the ky (cons host port), and as value a list of processes. My patch changes this such a way, that the key is now (list host port thread). Therefore, only open processes which belong to the same thread are checked. This seems to work sufficiently. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 14:30:27 2024 Received: (at 73199) by debbugs.gnu.org; 2 Oct 2024 18:30:27 +0000 Received: from localhost ([127.0.0.1]:59211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw47H-0000Um-KB for submit@debbugs.gnu.org; Wed, 02 Oct 2024 14:30:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw47F-0000UY-UY for 73199@debbugs.gnu.org; Wed, 02 Oct 2024 14:30:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sw478-00047f-HO; Wed, 02 Oct 2024 14:30:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=; b=NrnSlVPakjhb CtMzXb/tnh5lkxwIvS6aX7ILVkg1bi0rbjizDenTyomuogsxK04UKqXfzNv8E2/UlYZKopkb8C8MW tMeHeAD+KEQW5+3IZdJviNQ0KBWSJlqJk+0LN5NoIBqfZZ0C18hADp7BxFlJ4aNlwMlcUB5eKPVG6 DP5+r0QTaccRde0pmeDURnlv+gYo/0DpuI6i6ZUgCbEsGr0HkG1BDjDAnI2Nzq/nbSrfmr5ezIoT9 mSMWEf/DwJDsDOJ3IbOfcS+NJ5A4n+9Noq+jLwWVXYlV095DuLvwgblOC+mWw44kzttek5yI/66pF qZx9rpEcGLjGxhXPm6AD/A==; Date: Wed, 02 Oct 2024 21:30:11 +0300 Message-Id: <86a5fm1hos.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87wmiq8nv4.fsf@gmx.de> (message from Michael Albinus on Wed, 02 Oct 2024 18:34:55 +0200) Subject: Re: bug#73199: url-retrieve is not thread-safe References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> <87wmit9nvh.fsf_-_@gmx.de> <86frph2lqd.fsf@gnu.org> <87seth9jow.fsf@gmx.de> <86cykl2g9i.fsf@gnu.org> <87wmiq8nv4.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73199 Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, 73199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 10 07:30:22 2024 Received: (at 73199) by debbugs.gnu.org; 10 Oct 2024 11:30:22 +0000 Received: from localhost ([127.0.0.1]:58879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syrN7-0003y2-IP for submit@debbugs.gnu.org; Thu, 10 Oct 2024 07:30:22 -0400 Received: from mout.gmx.net ([212.227.15.15]:37299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syrN5-0003qD-2D for 73199@debbugs.gnu.org; Thu, 10 Oct 2024 07:30:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1728559788; x=1729164588; i=michael.albinus@gmx.de; bh=fIuOyAFk0SaJJHapgmgBm0fs47oiq6/pXo+MHaRz+L0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=lgE8cD3a0SvhBSRqagYBws8KITtIAB+X4rAwEeBkV1pbEJhftOKePGY0dICEqarL 3V+YgKtc85kzI2jIgkkDH82ApTL6i5LwKS7tY8bsGdw39i68CBGhmLU0vf0MrG/12 /uxNCMCgzOQ5XU7G7k7+V9RUa5YLnFlcFMjBJJnI3Y9U/AhDQzKJuF5SLKm66Yl0u VE28WBYipyqNRRBVUh02VSUskBwljuk+O/oUt6fw6P1GE9Ba6kmwN/LaJR6LMdsFT 8D7OPuHk3iLEzQOZ90tnbYTRE+zQBYGX/ad4hDLEZ09Bg73g5r12MFrjGiYyHRs4K UFw7KtwBYF9xXc9AxQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MxlzI-1tuVtN3yfO-00vfaz; Thu, 10 Oct 2024 13:29:48 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#73199: url-retrieve is not thread-safe In-Reply-To: <87wmiq8nv4.fsf@gmx.de> (Michael Albinus's message of "Wed, 02 Oct 2024 18:34:55 +0200") References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> <87wmit9nvh.fsf_-_@gmx.de> <86frph2lqd.fsf@gnu.org> <87seth9jow.fsf@gmx.de> <86cykl2g9i.fsf@gnu.org> <87wmiq8nv4.fsf@gmx.de> Date: Thu, 10 Oct 2024 13:29:42 +0200 Message-ID: <87h69kp55l.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ZEnK2xhNVtfTkeyB6jdyjEKzaIrvfCQpzo7Og2+0vh95H+wg+9O 7bNWpjhVb64M6pnuKh8keGCQsw34mpPDsHklDwFJOmFoKLX1y9jb9O9CS7N8XeJaOAjs2bd 0EARzLslHXzqDm9qofY/kaxd5j1W49NilUqzDlsr9TosbonzUpNCOjK1REoE+2GoykRMCOU opRwrw+PpNznAWcoozH2w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:kANn/uNUn2A=;Q4sqTnCrSoBkPqof67T0ILVY+JS praVQIDkap6VV5r3m+FIBgy8DjZj18rNKNDWvzhigwlgKdHwzGOdeQD9cIUSnDD0GlM/0z4tK /wq2JFjVsqPflxRLE3v5qX37t1bqUPb0O1nZGopb39iPUfbN09iJhVejeHRoj5v1gD7jLFFjL 1qev8RSY5qXlONbYDvtzQhdo9w7JXd+zGdqF4Kb+Nu4QmnmXH9Q7fPmjoh5F28iMyeiaZ2IVJ Q9w2MjZJqJVTAsWGcpEZBd/J4QzF0l+86+qaBiFga/5+lx9mg39UncxOI7KOizS6BkPu2rrSD JI5DoC7S7XtZV2nRb2BqJeLqyAaDtPV+kIj3CmPoaPmwymkVOdYfl/RB4IlwACqVZjCOzNsZo w2PzUWkKCrD/Sbkh2PLBkLEBGSBywKwtul/XFoxkJogZRVdTvc1p+w+Tb0bq9im20zA5AHicF rDcOBTb6bvs3x8r5gTSuRzvvImUYh0jfFk88h3MZpJ1byxQPlfO5xWVeG16q3A38j0r29iqpU JCYCJ87IB6xxUQPe+7gzpyjjt4bhi2YEocp0Qwt4L4V1Fl5X7iffk3Dtr7vwgZpwU49PLUUPG 66wXYCXlaQOL45dofLER8fscXEk0GQMJarqhqhfSk3nSL2NWCILhqhMiK1sPrP1JEKgrd3RyX +RuqH6M6w2Glfnet0N0Z+fgDmWbrgsPG21h3aJRsO3ts7eY8jxB4A6IDMbZ8ZveVyhD2MLUAS j9PPNUQMKLNfF+W6LJ4KS40/NKIQbaChmAIKyNJmbtpnZIQiiQekZAl6KBy+1dPlsxEmFJQEx VgGaLHeDegPN0CVHJIEgPhhg== X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 73199 Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, 73199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: > Eli Zaretskii writes: > >>> From: Michael Albinus >>> Cc: 73199@debbugs.gnu.org, AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, >>> monnier@iro.umontreal.ca >>> Date: Mon, 30 Sep 2024 18:42:55 +0200 >>> >>> Oops, sorry. I've appended the vc-dir buffer, not the vc-diff ... >> >> Thanks. I'd appreciate if you could explain why url-retrieve is >> currently not thread-safe, and how this patch is supposed to solve >> that. > > In , there's a > recipe for reproduction. > > The general problem is when you want to access the same HTTP server from > a different thread, and url-http-attempt-keepalives is set to t. This > happens, for example, in debbugs 0.41. > > Let's assume, there is an access to debbugs:443 from a given thread, for > example the main thread. Soap-client serves. It also binds > url-http-attempt-keepalives to t, the https process stays alive. > > Later on, there is an access to debbugs:443 from another thread. It > checks, whether there is a running process for that target, and tries to > reuse. We get the error > > Error #: (error "Attempt to accept output from process debbugs.gnu.org locked to thread #") > > My patch tries to fix this. The list of still open processes is the hash > table url-http-open-connections. It has the ky (cons host port), and as > value a list of processes. > > My patch changes this such a way, that the key is now (list host port > thread). Therefore, only open processes which belong to the same thread > are checked. > > This seems to work sufficiently. Ping. Any comments? Otherwise, I'll install the patch in a couple of days. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 10 09:11:03 2024 Received: (at 73199) by debbugs.gnu.org; 10 Oct 2024 13:11:04 +0000 Received: from localhost ([127.0.0.1]:59019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syswZ-0000jd-HP for submit@debbugs.gnu.org; Thu, 10 Oct 2024 09:11:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syswX-0000jA-MJ for 73199@debbugs.gnu.org; Thu, 10 Oct 2024 09:11:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1syswE-0007l0-He; Thu, 10 Oct 2024 09:10:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ab0+CD7ojyGSYageiHWdLaBQbTli1/fOmnzHb7qleT0=; b=Vg8Bi9d0+qU8 oC7gFsR3eQ4jV6NXnzl+GBnnUePFB7RDGNrfZi8tCmONgUval79KWFCc0Gncew8ST8TOwRYCUbgay Xh1qDmDry5R4k3xcivL6qnTOvrE0uZMNNaMxtKJ9bBEWu5phthYcbBR7y8yx9Wl0UblN2NYIUQfg7 oV1NxYNq82p5m3YJtmoJI6MgIYtSkZIoTlQectb2zY/NMMEGaCHzSITvFmnrHH7JigvTBMCG3pto3 OKvaXNTeILVx81VhGkpuwXSaQ9rY96rBXToRzMP0qcZZYChidz3xQYxtSWh7xjGWvjdBy/SJ9ob58 ODEzJs+47Q28rSZKSVjBzA==; Date: Thu, 10 Oct 2024 16:10:29 +0300 Message-Id: <86msjc14u2.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87h69kp55l.fsf@gmx.de> (message from Michael Albinus on Thu, 10 Oct 2024 13:29:42 +0200) Subject: Re: bug#73199: url-retrieve is not thread-safe References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> <87wmit9nvh.fsf_-_@gmx.de> <86frph2lqd.fsf@gnu.org> <87seth9jow.fsf@gmx.de> <86cykl2g9i.fsf@gnu.org> <87wmiq8nv4.fsf@gmx.de> <87h69kp55l.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73199 Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, 73199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, > 73199@debbugs.gnu.org > Date: Thu, 10 Oct 2024 13:29:42 +0200 > > Ping. Any comments? Otherwise, I'll install the patch in a couple of days. Sorry, too much stuff on my table. Please go ahead and install, I think the patch is okay. (I presume you know about set-process-thread, and that it doesn't help in this scenario?) From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 06:44:57 2024 Received: (at 73199-done) by debbugs.gnu.org; 11 Oct 2024 10:44:57 +0000 Received: from localhost ([127.0.0.1]:33607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szD8i-000254-Ss for submit@debbugs.gnu.org; Fri, 11 Oct 2024 06:44:57 -0400 Received: from mout.gmx.net ([212.227.17.22]:60333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szD8e-00024l-WE for 73199-done@debbugs.gnu.org; Fri, 11 Oct 2024 06:44:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1728643461; x=1729248261; i=michael.albinus@gmx.de; bh=NayEsX8x6mwyl1+GbgK+CWjhJ2AlCKjj2nozFmGT7jw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=fS1dWeDtWZc9zDJsi9JgIttOkClamvwfHwbphiiWyLoeC7P4vVb1ev3XRn5P0VEs 6g5UfqWYeX4rlt3J4OyXATRh5fZZTosecXhRxS7+M8OeaPzTvxznU0LzKE24SrNIU wAOoRAWqkZIsBpw+A1XDjNpiUha2+IKi1hHBKy5Ss9oIA7DfbIkFJV04ntHgTO2xV uj0KlY4ZRq6/lKu404mtyIuwUpeZ1ouHnG1/aXEz5VLhL6/JlccZf7RS+AJL7IMkD zCNyB2lOMHN1XZm8PvMiA/1XzM6IqeFFYHjK5/xHf28qVmn+On5zTvsK0EmYYIdT7 LNOi2SgsnB/20NTIDw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4z6q-1u09SL09Jc-0160A2; Fri, 11 Oct 2024 12:44:21 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#73199: url-retrieve is not thread-safe In-Reply-To: <86msjc14u2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Oct 2024 16:10:29 +0300") References: <87cyl9j6ng.fsf@gmx.de> <875xqqk5oq.fsf@gmx.de> <87wmit9nvh.fsf_-_@gmx.de> <86frph2lqd.fsf@gnu.org> <87seth9jow.fsf@gmx.de> <86cykl2g9i.fsf@gnu.org> <87wmiq8nv4.fsf@gmx.de> <87h69kp55l.fsf@gmx.de> <86msjc14u2.fsf@gnu.org> Date: Fri, 11 Oct 2024 12:44:14 +0200 Message-ID: <87set2udfl.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:oGyfdve9WkhmXv0CAkEuyozn2pa0XDNSeNBYyJu83MYRmT84VVM EsnFEZuzyKzdZp4SUoHp+o3J7mTI/j0aPwBvZkU9ONsMh2n4OV3GpQO7JzW7UZJRxVEeS7Z 4iyT3oiRuF/nSL0AvRzHCWOT1/Bqefi1Y+tvpXkeE9hFN2lzkrEwncDJmZ363wyzagHP+yP kiUlfXz6d7AAsXvhQB+jg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:xjhYQCvm5nE=;Bv2ExUTsHAdj8TXGpHyVrcYBQtY j1MpvxcRI6uNxdJgOOV3DrFCspi7UeOqA/hjHcPf7OBXgG3YzG+h8NshY8oJZstgX87XkkRX/ Z1DNf9nGEdgVthgwzJPDuK5E258LRu12MisN8unZPgJQA327D/DaQRiMk5Yr63SaUbmJVqCCP 0YGrFxpY06qQAub9XUxC5PA+RruaYXBH/GMTB7xJXThV6s4+tRajQA6Ok/bngsSwNHrcGtr5l xycrHwu8c+Ye+T+HAnZbKYCgcLCNEGzxhYoMk8FLIUrk/wsIVsE4pvNeHJZ7dRBr5pXcfa+px yoS69JhHUMl8YB0fvKR3W/hLwe8cdxnPXIH7p/L3Xw63P//m1yFrGKvLE4oHCXATMSF4YBsFs QCJJt5g26oAwir/3kpY8BGKuDk0DqcXMMIN3+o1mGLKuv/ywy4juwB/mFfpnYlx7RkvRsNeKC hIyrGFAIQ4gvA7Rz6xyiOQJwbwVbMuzGRgf3fyfj8sQmsTIEf5lNDfOdJ8gIsm/r3VwOTcYXU V/DEFRCfth+708IA24zhub2ErLu3BQ91dsTZ3A7qJOQ9bxGN1ybnZSfK+wNfrNJx9JRVz0+G0 eD+sr4OWEQZVuYNOpOMQJzbmxBcoQgilmyBRGGXI9SLn+ATka85kum3lSXtziPowh3igcxJYU 5JehiWAjzn9qewn9LjgEMlJThRlhU/DNS6swC9H2t8erDHd+qeulVB0fdJlanbqnvynfeJAvM Og7d9EyTLItekEv8HG+W8CcKFs8gWzECN6j3vhu16jti9106LVHrPopMMlLHCnHfyRTjBFk31 XFHO4xJUL8fSQzoCul/D8eXQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73199-done Cc: AlexHarsanyi@gmail.com, fitzsim@fitzsim.org, monnier@iro.umontreal.ca, 73199-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Version: 31.1 Eli Zaretskii writes: Hi Eli, > Please go ahead and install, I think the patch is okay. Done. I'm closing the bug, therefore. > (I presume you know about set-process-thread, and that it doesn't help > in this scenario?) Yes, I know it. But I cannot use it; the process is already in the proper thread where it should be. Best regards, Michael. From unknown Sun Jul 27 05:17:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 Nov 2024 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator