GNU bug report logs - #73190
[PATCH 0/3] gnu: dyninst: Update to 13.0.0.

Previous Next

Full log

Message #17 received at 73190 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Cc: Andreas Enge <andreas <at> enge.fr>, 73190 <at> debbugs.gnu.org
Subject: Re: [bug#73190] [PATCH 2/3] gnu: make-libiberty: Build with -fPIC.
Date: Thu, 12 Sep 2024 19:00:01 +0200

Hello,

Nguyễn Gia Phong <mcsinyx <at> disroot.org> skribis:

> Since iberty is a static library, linking a PIC-enabled target to it
> requires it to also have been built with PIC.  (The target is Dyninst
> in this case.)
>
> * gnu/packages/gcc.scm (make-libiberty)[arguments]:
>   Adjust make-flags to add -fPIC to CFLAGS.
>
> Change-Id: I155045d05f4434cb68be933a95b7bc9fdec98818

[...]

> +       #:make-flags '("CFLAGS=-fPIC")

I believe this overrides the default ‘CFLAGS’, and the end result is
that the library would be compiled with ‘-O0 -g0’.

So unless I’m mistaken, you should instead have:

  "CFLAGS=-O2 -g -fPIC"

Apart from that, the patch series looks good to me.

Could you send updated patches?

Thanks in advance,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.