GNU bug report logs - #73178
31.0.50; [PATCH] Improve the widget to customize icon

Previous Next

Full log

View this message in rfc822 format

From: David Ponce <da_vid <at> orange.fr>
To: Eli Zaretskii <eliz <at> gnu.org>, Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 73178 <at> debbugs.gnu.org
Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon
Date: Thu, 9 Jan 2025 11:01:40 +0100

[Message part 1 (text/plain, inline)]

On 2025-01-09 08:07, Eli Zaretskii wrote:
>> Date: Wed, 8 Jan 2025 10:59:27 -0300
>> Cc: Eli Zaretskii <eliz <at> gnu.org>
>> From: Mauro Aranda <maurooaranda <at> gmail.com>
>>
[...]
>> I think this is an improvement.  Thanks David.
> 
> Thanks for the review.
> 
> I wanted to install this, but byte-compiler produces a warning:
> 
>      ELC      cus-edit.elc
> 
>    In toplevel form:
>    cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget'
> 
> Is that a typo, and you actually meant custom-icon--texts-sub-type?
> 
> Also, could you please accompany the patch with the ChangeLog-style
> commit log message (see CONTRIBUTE for the details)?  Otherwise, I
> will have to write the log message manually when installing your
> changes.
> 
> Thanks.

Hello Eli,

Hmm, it seems you didn't install the correct patch?
I attached the correct patch (V2) which applies cleanly for me.
Also below is my proposed ChangeLog.

Thank you, and thanks Mauro for your review.


2025-01-09  David Ponce  <da_vid <at> orange.fr>

    Improve usability of the widget used to customize icon.

    * lisp/cus-edit.el (custom-icon--images-sub-type)
    (custom-icon--emojis-sub-type, custom-icon--symbols-sub-type)
    (custom-icon--texts-sub-type): New constant.
    (custom-icon--type): New constant.
    (custom-icon-value-create): Use it.

[improve-widget-to-customize-icon-V2.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.