From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Sep 2024 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 73178@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172606493321006 (code B ref -1); Wed, 11 Sep 2024 14:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Sep 2024 14:28:53 +0000 Received: from localhost ([127.0.0.1]:39319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soOKz-0005Sj-5U for submit@debbugs.gnu.org; Wed, 11 Sep 2024 10:28:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:48280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soOKv-0005SY-RA for submit@debbugs.gnu.org; Wed, 11 Sep 2024 10:28:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soOKi-0003d0-E4 for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 10:28:43 -0400 Received: from smtp-15.smtpout.orange.fr ([80.12.242.15] helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soOKf-0003Yl-CV for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 10:28:36 -0400 Received: from [192.168.1.21] ([2.7.225.247]) by smtp.orange.fr with ESMTPA id oOKWsyzIseJiWoOKWsxi1n; Wed, 11 Sep 2024 16:28:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1726064905; bh=F8tDx2Kmc0qFfqaoqg1RhBmR0qWtJD+JfZ9HcevW2Es=; h=Message-ID:Date:MIME-Version:To:From:Subject; b=q0uB4IIu36E1Rhrqgn1IEGTCHwlLXIpPDNiGL5e2OJsKN7xTwlZSGsKQaM1xaft52 Mj22l0c9iMIVYCPwJEr1ZTTJArXbppW8VKSkl8q/stdgmfRjyRIsoLe9vWrG9bxYOf QBVL2GYYzVSkonp2D76bqogq+Muq9Xt82ozK5xmy3uwtZi2QXa8Cfsn5uolRSHqkYG iAUKMxweywuIUqNk1C8UMLb1GfnFdLdWoV6k9AFTfyZaFymFzOqM1w8SjshZCuKPpE Z8gkV3mxkDB082UhUwOU8BYaEEnNXrKvrGdrDy6koygPeb5lpSM7HJHQVNkixch/sH eGl5M67HrKBeA== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Wed, 11 Sep 2024 16:28:25 +0200 X-ME-IP: 2.7.225.247 Content-Type: multipart/mixed; boundary="------------VpcLuYVgaJwoscLCCTCeyusE" Message-ID: <4cd4a62c-6642-49a3-8b2c-5eda13ac79af@orange.fr> Date: Wed, 11 Sep 2024 16:28:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: fr, en-US From: David Ponce Received-SPF: pass client-ip=80.12.242.15; envelope-from=da_vid@orange.fr; helo=smtp.smtpout.orange.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------VpcLuYVgaJwoscLCCTCeyusE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello, Whenever I try to use Emacs' built-in icons, I have some difficulty understanding the user interface for customizing an icon. For example, regardless of the type of icon element, all the fields have similar labels, which makes the interface difficult to understand and use. For instance, for Images, it is not clear that the String field is intended to enter the image file name: Choice: Value Menu [Images|Colorful Emojis|Monochrome Symbols|Text only] Repeat: INS DEL String: INS Plist: INS DEL : Key: Value: INS Also, nothing guides you regarding usage of this complex widget. I propose the attached patch that improves the widget used to customize an icon. Possible ChangeLog: 2024-09-11 David Ponce Improve usability of the widget used to customize icon. * lisp/cus-edit.el (custom-icon--images-sub-type) (custom-icon--emojis-sub-type, custom-icon--symbols-sub-type) (custom-icon--texts-sub-type): New constant. (custom-icon--type): New constant. (custom-icon-value-create): Use it. With this patch, a quick help summarizes usage, and the different fields are named according to the kind of icon element. Here is a view of the new UI when customizing the default `button' icon: --------------------------------------------------------------- Hide Button: Icon elements: - Only the first occurrence of a same element counts. - Missing elements will take their default value.: - At least one element should be provided with a valid value. INS DEL Choice: Value Menu Images: Values: INS DEL Image filename: INS Image attributes: INS DEL : Key: :face Value: icon-button INS INS DEL Choice: Value Menu Colorful Emojis: Values: INS DEL Emoji text: 🔵 INS Emoji text properties: INS DEL : Key: :face Value: icon INS INS DEL Choice: Value Menu Monochrome Symbols: Values: INS DEL Symbol text: ● INS Symbol text properties: INS DEL : Key: :face Value: icon-button INS INS DEL Choice: Value Menu Texts Only: Values: INS DEL Text: button INS Text properties: INS DEL : Key: :face Value: icon-button INS INS --------------------------------------------------------------- WDYT? Thanks! In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-09-11 Repository revision: 69e1aca041c57ba425425d31471e1c8f86d3bf04 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 40 (KDE Plasma) Configured using: 'configure --with-x-toolkit=gtk3 --with-cairo-xcb --with-native-compilation=no PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_TIME: fr_FR.utf8 value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix --------------VpcLuYVgaJwoscLCCTCeyusE Content-Type: text/x-patch; charset=UTF-8; name="improve-widget-to-customize-icon-V0.patch" Content-Disposition: attachment; filename="improve-widget-to-customize-icon-V0.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4 IDNhYjVmMTE1MzJlLi5mZDc5MGIxODYzMCAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5l bAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC01NTI1LDYgKzU1MjUsNTMgQEAgY3VzdG9t LWljb24tZXh0ZW5kZWQtbWVudQogICAiQSBtZW51IGZvciBgY3VzdG9tLWljb24nIHdpZGdl dHMuCiBVc2VkIGluIGBjdXN0b20taWNvbi1hY3Rpb24nIHRvIHNob3cgYSBtZW51IHRvIHRo ZSB1c2VyLiIpCiAKKyhkZWZjb25zdCBjdXN0b20taWNvbi0taW1hZ2VzLXN1Yi10eXBlCisg ICcobGlzdCA6Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiSW1hZ2Vz IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIGltYWdlKQorICAgICAgICAgKHJlcGVhdCA6 dGFnICJWYWx1ZXMiCisgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiSW1hZ2UgZmls ZW5hbWUiKSkKKyAgICAgICAgIChwbGlzdCAgOnRhZyAiSW1hZ2UgYXR0cmlidXRlcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgJyhsaXN0IDpm b3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJDb2xvcmZ1bCBFbW9qaXMi CisgICAgICAgICAoY29uc3QgIDp0YWcgIiIgZW1vamkpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJFbW9qaSB0ZXh0 IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIkVtb2ppIHRleHQgcHJvcGVydGllcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1zeW1ib2xzLXN1Yi10eXBlCisgICcobGlzdCA6 Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiTW9ub2Nocm9tZSBTeW1i b2xzIgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHN5bWJvbCkKKyAgICAgICAgIChyZXBl YXQgOnRhZyAiVmFsdWVzIgorICAgICAgICAgICAgICAgICAoc3RyaW5nIDp0YWcgIlN5bWJv bCB0ZXh0IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIlN5bWJvbCB0ZXh0IHByb3BlcnRp ZXMiKSkpCisKKyhkZWZjb25zdCBjdXN0b20taWNvbi0tdGV4dHMtc3ViLXR5cGUKKyAgJyhs aXN0IDpmb3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJUZXh0cyBPbmx5 IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHRleHQpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJUZXh0IikpCisg ICAgICAgICAocGxpc3QgIDp0YWcgIlRleHQgcHJvcGVydGllcyIpKSkKKworKGRlZmNvbnN0 IGN1c3RvbS1pY29uLS10eXBlCisgIGAocmVwZWF0IDpmb3JtYXQgLChjb25jYXQgIiV7JXQl fSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvcGVydGl6ZSAiOiIgJ2Rpc3Bs YXkgIiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlxuXG4ldiVpXG4iKQorICAg ICAgICAgICA6dGFnICJJY29uIGVsZW1lbnRzOgorLSBPbmx5IHRoZSBmaXJzdCBvY2N1cnJl bmNlIG9mIGEgc2FtZSBlbGVtZW50IGNvdW50cy4KKy0gTWlzc2luZyBlbGVtZW50cyB3aWxs IHRha2UgdGhlaXIgZGVmYXVsdCB2YWx1ZS4KKy0gQXQgbGVhc3Qgb25lIGVsZW1lbnQgc2hv dWxkIGJlIHByb3ZpZGVkIHdpdGggYSB2YWxpZCB2YWx1ZS4iCisgICAgKGNob2ljZSA6dm9p ZCAsY3VzdG9tLWljb24tLXRleHRzLXdpZGdldAorICAgICAgICAgICAgOmV4dHJhLW9mZnNl dCAtMworICAgICAgICAgICAgLGN1c3RvbS1pY29uLS1pbWFnZXMtc3ViLXR5cGUKKyAgICAg ICAgICAgICxjdXN0b20taWNvbi0tZW1vamlzLXN1Yi10eXBlCisgICAgICAgICAgICAsY3Vz dG9tLWljb24tLXN5bWJvbHMtc3ViLXR5cGUKKyAgICAgICAgICAgICxjdXN0b20taWNvbi0t dGV4dHMtc3ViLXR5cGUpKSkKKwogKGRlZnVuIGN1c3RvbS1pY29uLXZhbHVlLWNyZWF0ZSAo d2lkZ2V0KQogICAiSGVyZSBpcyB3aGVyZSB5b3UgZWRpdCB0aGUgaWNvbidzIHNwZWNpZmlj YXRpb24uIgogICAoY3VzdG9tLWxvYWQtd2lkZ2V0IHdpZGdldCkKQEAgLTU1MzUsMTMgKzU1 ODIsNyBAQCBjdXN0b20taWNvbi12YWx1ZS1jcmVhdGUKIAkgKGZvcm0gKHdpZGdldC1nZXQg d2lkZ2V0IDpjdXN0b20tZm9ybSkpCiAJIChzeW1ib2wgKHdpZGdldC1nZXQgd2lkZ2V0IDp2 YWx1ZSkpCiAJICh0YWcgKHdpZGdldC1nZXQgd2lkZ2V0IDp0YWcpKQotCSAodHlwZSAnKHJl cGVhdAotICAgICAgICAgICAgICAgICAobGlzdCAoY2hvaWNlIChjb25zdCA6dGFnICJJbWFn ZXMiIGltYWdlKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFn ICJDb2xvcmZ1bCBFbW9qaXMiIGVtb2ppKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChjb25zdCA6dGFnICJNb25vY2hyb21lIFN5bWJvbHMiIHN5bWJvbCkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiVGV4dCBPbmx5IiB0ZXh0KSkK LSAgICAgICAgICAgICAgICAgICAgICAgKHJlcGVhdCBzdHJpbmcpCi0gICAgICAgICAgICAg ICAgICAgICAgIHBsaXN0KSkpCisJICh0eXBlIGN1c3RvbS1pY29uLS13aWRnZXQpCiAJIChw cmVmaXggKHdpZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tcHJlZml4KSkKIAkgKGxhc3QgKHdp ZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tbGFzdCkpCiAJIChzdHlsZSAod2lkZ2V0LWdldCB3 aWRnZXQgOmN1c3RvbS1zdHlsZSkpCg== --------------VpcLuYVgaJwoscLCCTCeyusE-- From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon References: <4cd4a62c-6642-49a3-8b2c-5eda13ac79af@orange.fr> In-Reply-To: <4cd4a62c-6642-49a3-8b2c-5eda13ac79af@orange.fr> Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Sep 2024 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 73178@debbugs.gnu.org Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.172606801031718 (code B ref 73178); Wed, 11 Sep 2024 15:21:02 +0000 Received: (at 73178) by debbugs.gnu.org; 11 Sep 2024 15:20:10 +0000 Received: from localhost ([127.0.0.1]:39416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soP8c-0008FA-16 for submit@debbugs.gnu.org; Wed, 11 Sep 2024 11:20:10 -0400 Received: from smtp-67.smtpout.orange.fr ([80.12.242.67]:50477 helo=msa.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soP8Z-0008Eo-82 for 73178@debbugs.gnu.org; Wed, 11 Sep 2024 11:20:08 -0400 Received: from [192.168.1.21] ([2.7.225.247]) by smtp.orange.fr with ESMTPA id oP8QsZ5M8MDtnoP8Qsuo59; Wed, 11 Sep 2024 17:19:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1726067999; bh=zzSXLiaN6kukedQDkUPFGuTBUNk+Hw3tC9QHAlw/Rqw=; h=Message-ID:Date:MIME-Version:To:From:Subject; b=BAJItQps4hITCyJXooKilGNdBYkmdzh6+AWdqo2gGeQt/kbwpBz3Urt794pIQVj41 BwNwZI4cDtXbZTTuxhFEny31oBCfeOqmXn8gButMDST5OMbdFUAWwj89emXmV7EW64 dG/qWgoISVuyOk0YyHq2sQojxyPCC+9CCiwgHX21qyzVF234D2L0jjMVRuZDB85g46 P2E8W3MZqqWLcM28k0xNe6PlhQ9CDeg1GN7hSCQh/WOmr1Ni6IVkRLEUQkjIXyGzMa HH9CFmzAxEQqqy2ay4RRG1D0nd3vQ/3lvqW2MzUNbAHItczB8t+Tb6BwP95CBqKndP HGT/W64OGQBfg== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Wed, 11 Sep 2024 17:19:59 +0200 X-ME-IP: 2.7.225.247 Content-Type: multipart/mixed; boundary="------------drCT4lsfSb1xq4lLJO8KCUT1" Message-ID: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> Date: Wed, 11 Sep 2024 17:19:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: fr, en-US From: David Ponce X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------drCT4lsfSb1xq4lLJO8KCUT1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Attached the correct patch. Sorry --------------drCT4lsfSb1xq4lLJO8KCUT1 Content-Type: text/x-patch; charset=UTF-8; name="improve-widget-to-customize-icon-V1.patch" Content-Disposition: attachment; filename="improve-widget-to-customize-icon-V1.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4 IDNhYjVmMTE1MzJlLi5mZDc5MGIxODYzMCAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5l bAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC01NTI1LDYgKzU1MjUsNTMgQEAgY3VzdG9t LWljb24tZXh0ZW5kZWQtbWVudQogICAiQSBtZW51IGZvciBgY3VzdG9tLWljb24nIHdpZGdl dHMuCiBVc2VkIGluIGBjdXN0b20taWNvbi1hY3Rpb24nIHRvIHNob3cgYSBtZW51IHRvIHRo ZSB1c2VyLiIpCiAKKyhkZWZjb25zdCBjdXN0b20taWNvbi0taW1hZ2VzLXN1Yi10eXBlCisg ICcobGlzdCA6Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiSW1hZ2Vz IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIGltYWdlKQorICAgICAgICAgKHJlcGVhdCA6 dGFnICJWYWx1ZXMiCisgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiSW1hZ2UgZmls ZW5hbWUiKSkKKyAgICAgICAgIChwbGlzdCAgOnRhZyAiSW1hZ2UgYXR0cmlidXRlcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgJyhsaXN0IDpm b3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJDb2xvcmZ1bCBFbW9qaXMi CisgICAgICAgICAoY29uc3QgIDp0YWcgIiIgZW1vamkpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJFbW9qaSB0ZXh0 IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIkVtb2ppIHRleHQgcHJvcGVydGllcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1zeW1ib2xzLXN1Yi10eXBlCisgICcobGlzdCA6 Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiTW9ub2Nocm9tZSBTeW1i b2xzIgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHN5bWJvbCkKKyAgICAgICAgIChyZXBl YXQgOnRhZyAiVmFsdWVzIgorICAgICAgICAgICAgICAgICAoc3RyaW5nIDp0YWcgIlN5bWJv bCB0ZXh0IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIlN5bWJvbCB0ZXh0IHByb3BlcnRp ZXMiKSkpCisKKyhkZWZjb25zdCBjdXN0b20taWNvbi0tdGV4dHMtc3ViLXR5cGUKKyAgJyhs aXN0IDpmb3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJUZXh0cyBPbmx5 IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHRleHQpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJUZXh0IikpCisg ICAgICAgICAocGxpc3QgIDp0YWcgIlRleHQgcHJvcGVydGllcyIpKSkKKworKGRlZmNvbnN0 IGN1c3RvbS1pY29uLS10eXBlCisgIGAocmVwZWF0IDpmb3JtYXQgLChjb25jYXQgIiV7JXQl fSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvcGVydGl6ZSAiOiIgJ2Rpc3Bs YXkgIiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlxuXG4ldiVpXG4iKQorICAg ICAgICAgICA6dGFnICJJY29uIGVsZW1lbnRzOgorLSBPbmx5IHRoZSBmaXJzdCBvY2N1cnJl bmNlIG9mIGEgc2FtZSBlbGVtZW50IGNvdW50cy4KKy0gTWlzc2luZyBlbGVtZW50cyB3aWxs IHRha2UgdGhlaXIgZGVmYXVsdCB2YWx1ZS4KKy0gQXQgbGVhc3Qgb25lIGVsZW1lbnQgc2hv dWxkIGJlIHByb3ZpZGVkIHdpdGggYSB2YWxpZCB2YWx1ZS4iCisgICAgKGNob2ljZSA6dm9p ZCAsY3VzdG9tLWljb24tLXRleHRzLXdpZGdldAorICAgICAgICAgICAgOmV4dHJhLW9mZnNl dCAtMworICAgICAgICAgICAgLGN1c3RvbS1pY29uLS1pbWFnZXMtc3ViLXR5cGUKKyAgICAg ICAgICAgICxjdXN0b20taWNvbi0tZW1vamlzLXN1Yi10eXBlCisgICAgICAgICAgICAsY3Vz dG9tLWljb24tLXN5bWJvbHMtc3ViLXR5cGUKKyAgICAgICAgICAgICxjdXN0b20taWNvbi0t dGV4dHMtc3ViLXR5cGUpKSkKKwogKGRlZnVuIGN1c3RvbS1pY29uLXZhbHVlLWNyZWF0ZSAo d2lkZ2V0KQogICAiSGVyZSBpcyB3aGVyZSB5b3UgZWRpdCB0aGUgaWNvbidzIHNwZWNpZmlj YXRpb24uIgogICAoY3VzdG9tLWxvYWQtd2lkZ2V0IHdpZGdldCkKQEAgLTU1MzUsMTMgKzU1 ODIsNyBAQCBjdXN0b20taWNvbi12YWx1ZS1jcmVhdGUKIAkgKGZvcm0gKHdpZGdldC1nZXQg d2lkZ2V0IDpjdXN0b20tZm9ybSkpCiAJIChzeW1ib2wgKHdpZGdldC1nZXQgd2lkZ2V0IDp2 YWx1ZSkpCiAJICh0YWcgKHdpZGdldC1nZXQgd2lkZ2V0IDp0YWcpKQotCSAodHlwZSAnKHJl cGVhdAotICAgICAgICAgICAgICAgICAobGlzdCAoY2hvaWNlIChjb25zdCA6dGFnICJJbWFn ZXMiIGltYWdlKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFn ICJDb2xvcmZ1bCBFbW9qaXMiIGVtb2ppKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChjb25zdCA6dGFnICJNb25vY2hyb21lIFN5bWJvbHMiIHN5bWJvbCkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiVGV4dCBPbmx5IiB0ZXh0KSkK LSAgICAgICAgICAgICAgICAgICAgICAgKHJlcGVhdCBzdHJpbmcpCi0gICAgICAgICAgICAg ICAgICAgICAgIHBsaXN0KSkpCisJICh0eXBlIGN1c3RvbS1pY29uLS10eXBlKQogCSAocHJl Zml4ICh3aWRnZXQtZ2V0IHdpZGdldCA6Y3VzdG9tLXByZWZpeCkpCiAJIChsYXN0ICh3aWRn ZXQtZ2V0IHdpZGdldCA6Y3VzdG9tLWxhc3QpKQogCSAoc3R5bGUgKHdpZGdldC1nZXQgd2lk Z2V0IDpjdXN0b20tc3R5bGUpKQo= --------------drCT4lsfSb1xq4lLJO8KCUT1-- From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Sep 2024 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 73178@debbugs.gnu.org Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.17260685361083 (code B ref 73178); Wed, 11 Sep 2024 15:29:02 +0000 Received: (at 73178) by debbugs.gnu.org; 11 Sep 2024 15:28:56 +0000 Received: from localhost ([127.0.0.1]:39428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soPH6-0000HP-Ee for submit@debbugs.gnu.org; Wed, 11 Sep 2024 11:28:56 -0400 Received: from msa-210.smtpout.orange.fr ([193.252.23.210]:54020 helo=msa.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soPH3-0000HF-0Y for 73178@debbugs.gnu.org; Wed, 11 Sep 2024 11:28:54 -0400 Received: from [192.168.1.21] ([2.7.225.247]) by smtp.orange.fr with ESMTPA id oPGusbitQ96QfoPGusKKSn; Wed, 11 Sep 2024 17:28:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1726068525; bh=u1NA9VcoPObux9yzy7HgMYr5oBeJPsMI52mzjj4XCZQ=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=QOgOK5W6B5uEBzBE+rq0dZhQobw9YGwyYpV3dT4cQMDJMDXCdlrxYdZMSJ7rDzXmd Oz2mAMgPDbY74sOfi2OhRfn3Ebgp55wN/kCBA4paUp1hPOrSuUyOPrc2FpPHpSoJja EG06N+AS0S/jp5ukDI6V3Gb5BMn4lOtnvKp9PaWuD7H/lOGCReNin/3zhhIbZzbzi8 9xzwdftFJJJSX8/Kv1oqm+BL3dI9gj6Xa5mHpUt3lXbZvCgxfXYTGxGA6dqwWLidmW nTlCNnoyfr01zuc5fXFbIKijHj9BihcbkP12/0D+kc0XiYajdCz4gV8Bo4uIlhBklb yPRGiUwq8yXOA== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Wed, 11 Sep 2024 17:28:45 +0200 X-ME-IP: 2.7.225.247 Content-Type: multipart/mixed; boundary="------------xMOks0EhLZGJmY9mT4kklrR3" Message-ID: Date: Wed, 11 Sep 2024 17:28:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: David Ponce References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> Content-Language: fr, en-US In-Reply-To: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------xMOks0EhLZGJmY9mT4kklrR3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/09/2024 5:19 PM, David Ponce wrote: > Attached the correct patch. > Sorry Should be the good one this time. Sorry again. --------------xMOks0EhLZGJmY9mT4kklrR3 Content-Type: text/x-patch; charset=UTF-8; name="improve-widget-to-customize-icon-V2.patch" Content-Disposition: attachment; filename="improve-widget-to-customize-icon-V2.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4 IDNhYjVmMTE1MzJlLi5mZDc5MGIxODYzMCAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5l bAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC01NTI1LDYgKzU1MjUsNTMgQEAgY3VzdG9t LWljb24tZXh0ZW5kZWQtbWVudQogICAiQSBtZW51IGZvciBgY3VzdG9tLWljb24nIHdpZGdl dHMuCiBVc2VkIGluIGBjdXN0b20taWNvbi1hY3Rpb24nIHRvIHNob3cgYSBtZW51IHRvIHRo ZSB1c2VyLiIpCiAKKyhkZWZjb25zdCBjdXN0b20taWNvbi0taW1hZ2VzLXN1Yi10eXBlCisg ICcobGlzdCA6Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiSW1hZ2Vz IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIGltYWdlKQorICAgICAgICAgKHJlcGVhdCA6 dGFnICJWYWx1ZXMiCisgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiSW1hZ2UgZmls ZW5hbWUiKSkKKyAgICAgICAgIChwbGlzdCAgOnRhZyAiSW1hZ2UgYXR0cmlidXRlcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgJyhsaXN0IDpm b3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJDb2xvcmZ1bCBFbW9qaXMi CisgICAgICAgICAoY29uc3QgIDp0YWcgIiIgZW1vamkpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJFbW9qaSB0ZXh0 IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIkVtb2ppIHRleHQgcHJvcGVydGllcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1zeW1ib2xzLXN1Yi10eXBlCisgICcobGlzdCA6 Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiTW9ub2Nocm9tZSBTeW1i b2xzIgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHN5bWJvbCkKKyAgICAgICAgIChyZXBl YXQgOnRhZyAiVmFsdWVzIgorICAgICAgICAgICAgICAgICAoc3RyaW5nIDp0YWcgIlN5bWJv bCB0ZXh0IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIlN5bWJvbCB0ZXh0IHByb3BlcnRp ZXMiKSkpCisKKyhkZWZjb25zdCBjdXN0b20taWNvbi0tdGV4dHMtc3ViLXR5cGUKKyAgJyhs aXN0IDpmb3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJUZXh0cyBPbmx5 IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHRleHQpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJUZXh0IikpCisg ICAgICAgICAocGxpc3QgIDp0YWcgIlRleHQgcHJvcGVydGllcyIpKSkKKworKGRlZmNvbnN0 IGN1c3RvbS1pY29uLS10eXBlCisgIGAocmVwZWF0IDpmb3JtYXQgLChjb25jYXQgIiV7JXQl fSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvcGVydGl6ZSAiOiIgJ2Rpc3Bs YXkgIiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlxuXG4ldiVpXG4iKQorICAg ICAgICAgICA6dGFnICJJY29uIGVsZW1lbnRzOgorLSBPbmx5IHRoZSBmaXJzdCBvY2N1cnJl bmNlIG9mIGEgc2FtZSBlbGVtZW50IGNvdW50cy4KKy0gTWlzc2luZyBlbGVtZW50cyB3aWxs IHRha2UgdGhlaXIgZGVmYXVsdCB2YWx1ZS4KKy0gQXQgbGVhc3Qgb25lIGVsZW1lbnQgc2hv dWxkIGJlIHByb3ZpZGVkIHdpdGggYSB2YWxpZCB2YWx1ZS4iCisgICAgKGNob2ljZSA6dm9p ZCAsY3VzdG9tLWljb24tLXRleHRzLXN1Yi10eXBlCisgICAgICAgICAgICA6ZXh0cmEtb2Zm c2V0IC0zCisgICAgICAgICAgICAsY3VzdG9tLWljb24tLWltYWdlcy1zdWItdHlwZQorICAg ICAgICAgICAgLGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgICAgICAgICAgICxj dXN0b20taWNvbi0tc3ltYm9scy1zdWItdHlwZQorICAgICAgICAgICAgLGN1c3RvbS1pY29u LS10ZXh0cy1zdWItdHlwZSkpKQorCiAoZGVmdW4gY3VzdG9tLWljb24tdmFsdWUtY3JlYXRl ICh3aWRnZXQpCiAgICJIZXJlIGlzIHdoZXJlIHlvdSBlZGl0IHRoZSBpY29uJ3Mgc3BlY2lm aWNhdGlvbi4iCiAgIChjdXN0b20tbG9hZC13aWRnZXQgd2lkZ2V0KQpAQCAtNTUzNSwxMyAr NTU4Miw3IEBAIGN1c3RvbS1pY29uLXZhbHVlLWNyZWF0ZQogCSAoZm9ybSAod2lkZ2V0LWdl dCB3aWRnZXQgOmN1c3RvbS1mb3JtKSkKIAkgKHN5bWJvbCAod2lkZ2V0LWdldCB3aWRnZXQg OnZhbHVlKSkKIAkgKHRhZyAod2lkZ2V0LWdldCB3aWRnZXQgOnRhZykpCi0JICh0eXBlICco cmVwZWF0Ci0gICAgICAgICAgICAgICAgIChsaXN0IChjaG9pY2UgKGNvbnN0IDp0YWcgIklt YWdlcyIgaW1hZ2UpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnN0IDp0 YWcgIkNvbG9yZnVsIEVtb2ppcyIgZW1vamkpCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGNvbnN0IDp0YWcgIk1vbm9jaHJvbWUgU3ltYm9scyIgc3ltYm9sKQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFnICJUZXh0IE9ubHkiIHRleHQp KQotICAgICAgICAgICAgICAgICAgICAgICAocmVwZWF0IHN0cmluZykKLSAgICAgICAgICAg ICAgICAgICAgICAgcGxpc3QpKSkKKwkgKHR5cGUgY3VzdG9tLWljb24tLXR5cGUpCiAJIChw cmVmaXggKHdpZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tcHJlZml4KSkKIAkgKGxhc3QgKHdp ZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tbGFzdCkpCiAJIChzdHlsZSAod2lkZ2V0LWdldCB3 aWRnZXQgOmN1c3RvbS1zdHlsZSkpCg== --------------xMOks0EhLZGJmY9mT4kklrR3-- From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2024 09:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: David Ponce , Mauro Aranda Cc: 73178@debbugs.gnu.org Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.17263075318134 (code B ref 73178); Sat, 14 Sep 2024 09:53:02 +0000 Received: (at 73178) by debbugs.gnu.org; 14 Sep 2024 09:52:11 +0000 Received: from localhost ([127.0.0.1]:44851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spPRq-000277-Ex for submit@debbugs.gnu.org; Sat, 14 Sep 2024 05:52:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spPRo-00026s-8L for 73178@debbugs.gnu.org; Sat, 14 Sep 2024 05:52:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spPRY-00011I-2f; Sat, 14 Sep 2024 05:51:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VIejcSj3PIgtp/yQfJO9Q7HOm6wx1DCVxKSb/Tf2ISo=; b=CQE/I8tow5bpmB3VTKg9 cu6vy4Kx025u/FBOZZiyYFEjUARMkxWO/JqB2zZUPRKRuVt7/DumZq11husyU/oxSQ67nMwlklZ0g ddkyxjs9E3I8d7lVAo7rlFbDOUzGPqejt1+srlCNLoIBA4T40fC9tgqcd6Zn57gmfhy8nnBFHm+hI IfI5kmeoJHPXBsou6A5UgSMJ6bjd9kfBRwNtss/yReMc0y+p2+yuYBazhhbDLqOsvBUWrRWHL3sN3 0aqgO6lBE9RkZaMSnGVAz1xnIfSt/2XyXptqiloXbewjNOSKKXtMR4ncOV4BPNDohhVD/LWpUWvGF LGGRM6UCBt0GMA==; Date: Sat, 14 Sep 2024 12:51:50 +0300 Message-Id: <86frq2h8ax.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <4cd4a62c-6642-49a3-8b2c-5eda13ac79af@orange.fr> (bug-gnu-emacs@gnu.org) References: <4cd4a62c-6642-49a3-8b2c-5eda13ac79af@orange.fr> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 11 Sep 2024 16:28:24 +0200 > From: David Ponce via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Whenever I try to use Emacs' built-in icons, I have some difficulty > understanding the user interface for customizing an icon. For example, > regardless of the type of icon element, all the fields have similar > labels, which makes the interface difficult to understand and use. > For instance, for Images, it is not clear that the String field is > intended to enter the image file name: > > Choice: Value Menu [Images|Colorful Emojis|Monochrome Symbols|Text only] > Repeat: > INS DEL String: > INS > Plist: > INS DEL : > Key: > Value: > INS > > Also, nothing guides you regarding usage of this complex widget. > > I propose the attached patch that improves the widget used to > customize an icon. Possible ChangeLog: > > 2024-09-11 David Ponce > > Improve usability of the widget used to customize icon. > > * lisp/cus-edit.el (custom-icon--images-sub-type) > (custom-icon--emojis-sub-type, custom-icon--symbols-sub-type) > (custom-icon--texts-sub-type): New constant. > (custom-icon--type): New constant. > (custom-icon-value-create): Use it. > > With this patch, a quick help summarizes usage, and the different > fields are named according to the kind of icon element. > > Here is a view of the new UI when customizing the default `button' icon: > > --------------------------------------------------------------- > Hide Button: > Icon elements: > - Only the first occurrence of a same element counts. > - Missing elements will take their default value.: > - At least one element should be provided with a valid value. > > INS DEL Choice: Value Menu Images: > > Values: > INS DEL Image filename: > INS > Image attributes: > INS DEL : > Key: :face > Value: icon-button > INS > > INS DEL Choice: Value Menu Colorful Emojis: > > Values: > INS DEL Emoji text: 🔵 > INS > Emoji text properties: > INS DEL : > Key: :face > Value: icon > INS > > INS DEL Choice: Value Menu Monochrome Symbols: > > Values: > INS DEL Symbol text: ● > INS > Symbol text properties: > INS DEL : > Key: :face > Value: icon-button > INS > > INS DEL Choice: Value Menu Texts Only: > > Values: > INS DEL Text: button > INS > Text properties: > INS DEL : > Key: :face > Value: icon-button > INS > > INS > --------------------------------------------------------------- > > WDYT? > > Thanks! Thanks. Mauro, could you please review and comment? > diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el > index 3ab5f11532e..fd790b18630 100644 > --- a/lisp/cus-edit.el > +++ b/lisp/cus-edit.el > @@ -5525,6 +5525,53 @@ custom-icon-extended-menu > "A menu for `custom-icon' widgets. > Used in `custom-icon-action' to show a menu to the user.") > > +(defconst custom-icon--images-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Images" > + (const :tag "" image) > + (repeat :tag "Values" > + (string :tag "Image filename")) > + (plist :tag "Image attributes"))) > + > +(defconst custom-icon--emojis-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Colorful Emojis" > + (const :tag "" emoji) > + (repeat :tag "Values" > + (string :tag "Emoji text")) > + (plist :tag "Emoji text properties"))) > + > +(defconst custom-icon--symbols-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Monochrome Symbols" > + (const :tag "" symbol) > + (repeat :tag "Values" > + (string :tag "Symbol text")) > + (plist :tag "Symbol text properties"))) > + > +(defconst custom-icon--texts-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Texts Only" > + (const :tag "" text) > + (repeat :tag "Values" > + (string :tag "Text")) > + (plist :tag "Text properties"))) > + > +(defconst custom-icon--type > + `(repeat :format ,(concat "%{%t%}" > + (propertize ":" 'display "") > + "\n\n%v%i\n") > + :tag "Icon elements: > +- Only the first occurrence of a same element counts. > +- Missing elements will take their default value. > +- At least one element should be provided with a valid value." > + (choice :void ,custom-icon--texts-widget > + :extra-offset -3 > + ,custom-icon--images-sub-type > + ,custom-icon--emojis-sub-type > + ,custom-icon--symbols-sub-type > + ,custom-icon--texts-sub-type))) > + > (defun custom-icon-value-create (widget) > "Here is where you edit the icon's specification." > (custom-load-widget widget) > @@ -5535,13 +5582,7 @@ custom-icon-value-create > (form (widget-get widget :custom-form)) > (symbol (widget-get widget :value)) > (tag (widget-get widget :tag)) > - (type '(repeat > - (list (choice (const :tag "Images" image) > - (const :tag "Colorful Emojis" emoji) > - (const :tag "Monochrome Symbols" symbol) > - (const :tag "Text Only" text)) > - (repeat string) > - plist))) > + (type custom-icon--widget) > (prefix (widget-get widget :custom-prefix)) > (last (widget-get widget :custom-last)) > (style (widget-get widget :custom-style)) From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2024 09:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: David Ponce , Mauro Aranda Cc: 73178@debbugs.gnu.org Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.17263075688201 (code B ref 73178); Sat, 14 Sep 2024 09:53:02 +0000 Received: (at 73178) by debbugs.gnu.org; 14 Sep 2024 09:52:48 +0000 Received: from localhost ([127.0.0.1]:44855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spPSS-00028C-2X for submit@debbugs.gnu.org; Sat, 14 Sep 2024 05:52:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spPSQ-000280-Vd for 73178@debbugs.gnu.org; Sat, 14 Sep 2024 05:52:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spPSB-000138-7q; Sat, 14 Sep 2024 05:52:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c+FsRUSUUXcJvlRKvBoN0gw53Adca3jIDKcyHi7X5Sw=; b=EQ7vYOS46EQJ r48nClTEgT20ZG+4Kro2sEP0JZOpwwJQxBfjElOlJtpCLvhRWxyRNyyz8bPgflNTxe0bIWWQ7LJtO wUB/e5aFeM4ltCrePwtXm1RiLw7L+zPxtoFn6e2f6RSvc+qOr0tot5obe0xpVuEy+9JdyTPiVz2y1 Lq5Ts0nMlRfwYsMJzsRBPt4PFZJxUyGQ/5mmA5MFiVBaX454UD070Fwaa9fJNO9CDUzqFCRhTkiLx ZHYKd6t3EjjXbyGDOQ4GxtfUayxuF9dU4IzX5/Y4eGjWjTjyRvYYsaL1oEAxOGlalkmUza7/lQLKj 6kEBcdl01smsU60WKXPoEg==; Date: Sat, 14 Sep 2024 12:52:28 +0300 Message-Id: <86ed5mh89v.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> (bug-gnu-emacs@gnu.org) References: <4cd4a62c-6642-49a3-8b2c-5eda13ac79af@orange.fr> <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 11 Sep 2024 17:19:58 +0200 > From: David Ponce via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Attached the correct patch. > Sorry > > diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el > index 3ab5f11532e..fd790b18630 100644 > --- a/lisp/cus-edit.el > +++ b/lisp/cus-edit.el > @@ -5525,6 +5525,53 @@ custom-icon-extended-menu > "A menu for `custom-icon' widgets. > Used in `custom-icon-action' to show a menu to the user.") > > +(defconst custom-icon--images-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Images" > + (const :tag "" image) > + (repeat :tag "Values" > + (string :tag "Image filename")) > + (plist :tag "Image attributes"))) > + > +(defconst custom-icon--emojis-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Colorful Emojis" > + (const :tag "" emoji) > + (repeat :tag "Values" > + (string :tag "Emoji text")) > + (plist :tag "Emoji text properties"))) > + > +(defconst custom-icon--symbols-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Monochrome Symbols" > + (const :tag "" symbol) > + (repeat :tag "Values" > + (string :tag "Symbol text")) > + (plist :tag "Symbol text properties"))) > + > +(defconst custom-icon--texts-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Texts Only" > + (const :tag "" text) > + (repeat :tag "Values" > + (string :tag "Text")) > + (plist :tag "Text properties"))) > + > +(defconst custom-icon--type > + `(repeat :format ,(concat "%{%t%}" > + (propertize ":" 'display "") > + "\n\n%v%i\n") > + :tag "Icon elements: > +- Only the first occurrence of a same element counts. > +- Missing elements will take their default value. > +- At least one element should be provided with a valid value." > + (choice :void ,custom-icon--texts-widget > + :extra-offset -3 > + ,custom-icon--images-sub-type > + ,custom-icon--emojis-sub-type > + ,custom-icon--symbols-sub-type > + ,custom-icon--texts-sub-type))) > + > (defun custom-icon-value-create (widget) > "Here is where you edit the icon's specification." > (custom-load-widget widget) > @@ -5535,13 +5582,7 @@ custom-icon-value-create > (form (widget-get widget :custom-form)) > (symbol (widget-get widget :value)) > (tag (widget-get widget :tag)) > - (type '(repeat > - (list (choice (const :tag "Images" image) > - (const :tag "Colorful Emojis" emoji) > - (const :tag "Monochrome Symbols" symbol) > - (const :tag "Text Only" text)) > - (repeat string) > - plist))) > + (type custom-icon--type) > (prefix (widget-get widget :custom-prefix)) > (last (widget-get widget :custom-last)) > (style (widget-get widget :custom-style)) From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2025 14:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: David Ponce , 73178@debbugs.gnu.org Cc: Eli Zaretskii Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.173634477916125 (code B ref 73178); Wed, 08 Jan 2025 14:00:03 +0000 Received: (at 73178) by debbugs.gnu.org; 8 Jan 2025 13:59:39 +0000 Received: from localhost ([127.0.0.1]:46509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVWax-0004C1-Bp for submit@debbugs.gnu.org; Wed, 08 Jan 2025 08:59:39 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:56349) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVWau-0004Bk-TG for 73178@debbugs.gnu.org; Wed, 08 Jan 2025 08:59:37 -0500 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2163b0c09afso248081965ad.0 for <73178@debbugs.gnu.org>; Wed, 08 Jan 2025 05:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736344771; x=1736949571; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=XFIvwYKb1hlEApdeVPhxrBZuVMX9X+/QvtbwW9qdX2A=; b=jgigPvGtNpsC7yCV4I3dWa7FWkBFOC83TVIN/Yu6KWVTtyMQI2pFQwH+MhMpJydA8l p0vk8E/zbtTrNX3zE+3wSsyBi2GTsiKu+q76/VDnUi8EIIffblexr151/yEKBbY50bIR YNxJUl0IRGJB7nEzLsffHu8TwJF0Hv02LZNvjdTSRGnGOixBlGYdeWpsULlB5DZ6D9iv a5jpQJ2/AEcA42SLeTj/yAnrjjkuWmxnIZATNJi/kQuL58zeSveB8EHDERjRnFMrW70R 2uideqcb6kOLMbeQUrIBo93HJ2iqa+2zZVFPElFDcNH8LxwOwGKYNW/G4yL42eokBG7o z1Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736344771; x=1736949571; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XFIvwYKb1hlEApdeVPhxrBZuVMX9X+/QvtbwW9qdX2A=; b=fn84/mmeEzEek00Z4ZnCLq63USO7YA1InUAk2LWXJgmv21x5kY/mxRoZwaNA5a3m3v w5RMMfyk0ShU1BJ2wHToqhMc639G1YhhEOjrUh6Q9JkZt+7L+xNQbIZFAqxHG241spUw a5Y7YwFftVZ47T6YQTD1Mjjlf5Y5PeMfbOkkgX59O4mu1WqyqTdzC5ykq3aG3mfUr5/U BF9lVyKux8/sIqZ/qUTBcvH7AvBp1ms4S6A3ebb4OpUh96Ge5OrRXU2gz+xY6TN4Lcpo 3ctci0zIT6qerYajnaS2nqmSKYUM5U+ChfnrKkeaikyKzNzxLFii1KS3m9wT4Jd0A+94 kl3A== X-Forwarded-Encrypted: i=1; AJvYcCVzt5/j8bo4a+2u9TXn35Pu3IrBrGr1B0y7+aYK/jg8P9oUsWO47AY5tZfj0K4oyRZlexQRNw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxpgb6fHUh4wJo4actU9vZYOu6bti1qbH/1ZSvdKFNS836ihyPy SUnQi6e3DrkuS5cjScJitrz+PmscoaNMQaCgPfwPj6MXjGDyxw5d X-Gm-Gg: ASbGnct2VljQsqtYb0+ApEAGn6wEsSaJuQYbJtJrLTk4Oy67JDvbT0R3FlgBT1oqx5T 5drbErQztXUwkLIU7boU9XM8Rh7DMhxsR++STA4ZPqZ4WpAdjb7hHtns3RHQImEhLvcccbKEu/R F2nyo1YJiyRXyOloDNwPWuXx7yhJClVwBVkJxf9RPA4zYx61uBWIBTKviWCjsnZH4au2CAlYdtZ etDcEuqZlgglf5QzMQ+0ZlKIzFLxS9mikDtTnlngSSSSi51SYFgl8dPkXDx+4w= X-Google-Smtp-Source: AGHT+IF2eGs+qZlUMGUoTmyQnq3gMfVYIOhzJ8orP03eAM1fFE6Q2x6RXUAwVLQihIkTmp1bb8WQxg== X-Received: by 2002:a17:903:1cf:b0:21a:8300:b9d5 with SMTP id d9443c01a7336-21a83f4cd36mr48068715ad.23.1736344770608; Wed, 08 Jan 2025 05:59:30 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842aba72f71sm32743473a12.9.2025.01.08.05.59.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 05:59:29 -0800 (PST) Message-ID: <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> Date: Wed, 8 Jan 2025 10:59:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> Content-Language: en-US From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) David Ponce writes: > On 11/09/2024 5:19 PM, David Ponce wrote: >> Attached the correct patch. >> Sorry > Should be the good one this time. > Sorry again. > > diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el > index 3ab5f11532e..fd790b18630 100644 > --- a/lisp/cus-edit.el > +++ b/lisp/cus-edit.el > @@ -5525,6 +5525,53 @@ custom-icon-extended-menu > "A menu for `custom-icon' widgets. > Used in `custom-icon-action' to show a menu to the user.") > > +(defconst custom-icon--images-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Images" > + (const :tag "" image) > + (repeat :tag "Values" > + (string :tag "Image filename")) > + (plist :tag "Image attributes"))) > + > +(defconst custom-icon--emojis-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Colorful Emojis" > + (const :tag "" emoji) > + (repeat :tag "Values" > + (string :tag "Emoji text")) > + (plist :tag "Emoji text properties"))) > + > +(defconst custom-icon--symbols-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Monochrome Symbols" > + (const :tag "" symbol) > + (repeat :tag "Values" > + (string :tag "Symbol text")) > + (plist :tag "Symbol text properties"))) > + > +(defconst custom-icon--texts-sub-type > + '(list :format "%{%t%}:\n%v\n" > + :tag "Texts Only" > + (const :tag "" text) > + (repeat :tag "Values" > + (string :tag "Text")) > + (plist :tag "Text properties"))) > + > +(defconst custom-icon--type > + `(repeat :format ,(concat "%{%t%}" > + (propertize ":" 'display "") > + "\n\n%v%i\n") > + :tag "Icon elements: > +- Only the first occurrence of a same element counts. > +- Missing elements will take their default value. > +- At least one element should be provided with a valid value." > + (choice :void ,custom-icon--texts-sub-type > + :extra-offset -3 > + ,custom-icon--images-sub-type > + ,custom-icon--emojis-sub-type > + ,custom-icon--symbols-sub-type > + ,custom-icon--texts-sub-type))) > + > (defun custom-icon-value-create (widget) > "Here is where you edit the icon's specification." > (custom-load-widget widget) > @@ -5535,13 +5582,7 @@ custom-icon-value-create > (form (widget-get widget :custom-form)) > (symbol (widget-get widget :value)) > (tag (widget-get widget :tag)) > - (type '(repeat > - (list (choice (const :tag "Images" image) > - (const :tag "Colorful Emojis" emoji) > - (const :tag "Monochrome Symbols" symbol) > - (const :tag "Text Only" text)) > - (repeat string) > - plist))) > + (type custom-icon--type) > (prefix (widget-get widget :custom-prefix)) > (last (widget-get widget :custom-last)) > (style (widget-get widget :custom-style)) I think this is an improvement. Thanks David. From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 07:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: da_vid@orange.fr, Mauro Aranda Cc: 73178@debbugs.gnu.org Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.173640648623025 (code B ref 73178); Thu, 09 Jan 2025 07:09:02 +0000 Received: (at 73178) by debbugs.gnu.org; 9 Jan 2025 07:08:06 +0000 Received: from localhost ([127.0.0.1]:50165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVmeD-0005zI-RC for submit@debbugs.gnu.org; Thu, 09 Jan 2025 02:08:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46756) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVmeB-0005yn-Oy for 73178@debbugs.gnu.org; Thu, 09 Jan 2025 02:08:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVme5-0002ui-Hu; Thu, 09 Jan 2025 02:07:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mF3nlXDNjGRi795QTgEq0SnCcXWfm3pBeZNVWj3q4Gs=; b=DP+ayYl9vcgk bbyuTVq4prmGW8f4WB/l3rc9WB/qdhmRpZmE7H28M6QSMl1SC/+6Dk/yl0OdXzq1rDcjWyihRe0Hl lTfDg/uf2K+ebF4Otxhsfs0Dj6WBKl5KiqmpZPEAXKONm8SYr1zNvcSZcwJYHqTPwD9QPXKQJLW1y obyZlZ+FiS6vfJZ3q0Wm7ecqfpgP9odsQFuRXZkHcoI1WItbVdFj6BuTvm6iy76oHfF8PQ5yJc4jw xdEc3af6XsO3ZmsDYj/pGYNh4KoXqLDKHEq8BUbkDiB3kORvPKjvBfLy9aVCMMv7l7/691wUzhPp1 1PeNhSX/krLRY+hGJTXc4g==; Date: Thu, 09 Jan 2025 09:07:53 +0200 Message-Id: <86ed1c31o6.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> (message from Mauro Aranda on Wed, 8 Jan 2025 10:59:27 -0300) References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 8 Jan 2025 10:59:27 -0300 > Cc: Eli Zaretskii > From: Mauro Aranda > > David Ponce writes: > > > On 11/09/2024 5:19 PM, David Ponce wrote: > >> Attached the correct patch. > >> Sorry > > Should be the good one this time. > > Sorry again. > > > > diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el > > index 3ab5f11532e..fd790b18630 100644 > > --- a/lisp/cus-edit.el > > +++ b/lisp/cus-edit.el > > @@ -5525,6 +5525,53 @@ custom-icon-extended-menu > > "A menu for `custom-icon' widgets. > > Used in `custom-icon-action' to show a menu to the user.") > > > > +(defconst custom-icon--images-sub-type > > + '(list :format "%{%t%}:\n%v\n" > > + :tag "Images" > > + (const :tag "" image) > > + (repeat :tag "Values" > > + (string :tag "Image filename")) > > + (plist :tag "Image attributes"))) > > + > > +(defconst custom-icon--emojis-sub-type > > + '(list :format "%{%t%}:\n%v\n" > > + :tag "Colorful Emojis" > > + (const :tag "" emoji) > > + (repeat :tag "Values" > > + (string :tag "Emoji text")) > > + (plist :tag "Emoji text properties"))) > > + > > +(defconst custom-icon--symbols-sub-type > > + '(list :format "%{%t%}:\n%v\n" > > + :tag "Monochrome Symbols" > > + (const :tag "" symbol) > > + (repeat :tag "Values" > > + (string :tag "Symbol text")) > > + (plist :tag "Symbol text properties"))) > > + > > +(defconst custom-icon--texts-sub-type > > + '(list :format "%{%t%}:\n%v\n" > > + :tag "Texts Only" > > + (const :tag "" text) > > + (repeat :tag "Values" > > + (string :tag "Text")) > > + (plist :tag "Text properties"))) > > + > > +(defconst custom-icon--type > > + `(repeat :format ,(concat "%{%t%}" > > + (propertize ":" 'display "") > > + "\n\n%v%i\n") > > + :tag "Icon elements: > > +- Only the first occurrence of a same element counts. > > +- Missing elements will take their default value. > > +- At least one element should be provided with a valid value." > > + (choice :void ,custom-icon--texts-sub-type > > + :extra-offset -3 > > + ,custom-icon--images-sub-type > > + ,custom-icon--emojis-sub-type > > + ,custom-icon--symbols-sub-type > > + ,custom-icon--texts-sub-type))) > > + > > (defun custom-icon-value-create (widget) > > "Here is where you edit the icon's specification." > > (custom-load-widget widget) > > @@ -5535,13 +5582,7 @@ custom-icon-value-create > > (form (widget-get widget :custom-form)) > > (symbol (widget-get widget :value)) > > (tag (widget-get widget :tag)) > > - (type '(repeat > > - (list (choice (const :tag "Images" image) > > - (const :tag "Colorful Emojis" emoji) > > - (const :tag "Monochrome Symbols" symbol) > > - (const :tag "Text Only" text)) > > - (repeat string) > > - plist))) > > + (type custom-icon--type) > > (prefix (widget-get widget :custom-prefix)) > > (last (widget-get widget :custom-last)) > > (style (widget-get widget :custom-style)) > > I think this is an improvement. Thanks David. Thanks for the review. I wanted to install this, but byte-compiler produces a warning: ELC cus-edit.elc In toplevel form: cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget' Is that a typo, and you actually meant custom-icon--texts-sub-type? Also, could you please accompany the patch with the ChangeLog-style commit log message (see CONTRIBUTE for the details)? Otherwise, I will have to write the log message manually when installing your changes. Thanks. From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 09:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , da_vid@orange.fr Cc: 73178@debbugs.gnu.org Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.173641382114088 (code B ref 73178); Thu, 09 Jan 2025 09:11:01 +0000 Received: (at 73178) by debbugs.gnu.org; 9 Jan 2025 09:10:21 +0000 Received: from localhost ([127.0.0.1]:50404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVoYW-0003fA-TC for submit@debbugs.gnu.org; Thu, 09 Jan 2025 04:10:21 -0500 Received: from mail-vs1-xe2f.google.com ([2607:f8b0:4864:20::e2f]:59476) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVoYU-0003aS-7P for 73178@debbugs.gnu.org; Thu, 09 Jan 2025 04:10:19 -0500 Received: by mail-vs1-xe2f.google.com with SMTP id ada2fe7eead31-4aff5b3845eso302134137.2 for <73178@debbugs.gnu.org>; Thu, 09 Jan 2025 01:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736413812; x=1737018612; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PMQr7xRlIE2OLebPVHhewxFqbPPHTJ33rHSIIaeHEpk=; b=XmhB8yCbFhNdflhI+agDXSbTDWS317uJSeJl8OxZ5Bu+gbVyBFPct3ZcqaYQVdesb7 T2fnO2i5Cj+cP+0jFdhNVKio41PfjgvWebJ4uErHYaQrse7WCyt0VXigwbsjq1X81zOe fUlL+sekwOxfSTHcvATagPhFI5eQ3tOTdQNuqHkuxaq+uRqGCr3DI8kKhDzIisq3xY+O aqCOg6gHtRldiHj9rQL3Y/WzhSXI1QqFvdwLN5EfCQnqlgf7FquCSjzugsHesMVY5kMR 58YHzPBuRU6fCn0v10pU1yz3L+gVk9ry7yzDhBDdYHmGStT0qCjeCX7w63dXfXfmtALV qs1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736413812; x=1737018612; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PMQr7xRlIE2OLebPVHhewxFqbPPHTJ33rHSIIaeHEpk=; b=V524Re1ql4ygqzunthFhroh7J22DBo4UQs9M5KVo7hI4i0ApO6liQEt0vqkO/u8d+u cajbDXr7Z8XqQwnpzq6ct3gbYhFJYgn0ZxePvhz2u4l/iQRiFUZkTEpyIhvgbcpbZQog YeqUH0L41EXr4gbi2QwYOLvvoJ4NylXkyJrj+Nl8SaCPA0mpCO2qq6phj4ibhWsj7KHd WVAJ/Q58wFhNL2d03T/yVBt35Cizhc6EF14Kve2zvXRiIFFSp/pmkK/38jr/nOf9HIZT G/KNwFBKEy7Hp0o+QSHGdZuhpQCglcafEfr1GaKc7uBVVHf6Uf8bigqEvsbMQrRRL78P rsFw== X-Gm-Message-State: AOJu0YzsYnKeEtWH2OrT1V87r5n1QC/cwsKBLqAsVwlFT9JRetafKV2H eZZOsg/MfVZdo0v0zVBtkguPjsxWDG3WiK8kqZ4b77lM3EdIMA0W X-Gm-Gg: ASbGncuI9nFb+9KMt+qtiHeqiWeedcV2WiII9oZYnoN143Q+2C4AEKPfiOlfIUbJMPG gtk8EjFCbrN0mUTLJ0uPEclMcU1FWFf+81VOYbBoAoE3Ku3dB/4ZbZjr2V/LFro2lEL+dqJiP6l lHVwV5OtrEfF/lRClzh9RlNPYK6YiDgC2bPQf/Iyy3InU77nwkbjLXTq7OJp4DdZMszGa2GVSbq 0bJr/tY+Jefid5zSCKtCvkk1SKGA8mt8r7JDg9HmJTEF3rH4VF19zlAy+dCS4o= X-Google-Smtp-Source: AGHT+IHmHraYCboIAukZNAaUNGDHyZTSPA122TRcMx7gz1RWil4eSTbEyY+2X8r9lGybS63dh1oawQ== X-Received: by 2002:a05:6102:a4e:b0:4b2:4cb0:91d5 with SMTP id ada2fe7eead31-4b3d0fc4fdbmr4802660137.15.1736413812260; Thu, 09 Jan 2025 01:10:12 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-8623157902esm546356241.32.2025.01.09.01.10.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 01:10:10 -0800 (PST) Message-ID: Date: Thu, 9 Jan 2025 06:10:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> <86ed1c31o6.fsf@gnu.org> Content-Language: en-US From: Mauro Aranda In-Reply-To: <86ed1c31o6.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Wed, 8 Jan 2025 10:59:27 -0300 >> Cc: Eli Zaretskii >> From: Mauro Aranda >> >> David Ponce writes: >> >>  > On 11/09/2024 5:19 PM, David Ponce wrote: >>  >> Attached the correct patch. >>  >> Sorry >>  > Should be the good one this time. >>  > Sorry again. >>  > >>  > diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el >>  > index 3ab5f11532e..fd790b18630 100644 >>  > --- a/lisp/cus-edit.el >>  > +++ b/lisp/cus-edit.el >>  > @@ -5525,6 +5525,53 @@ custom-icon-extended-menu >>  >    "A menu for `custom-icon' widgets. >>  >  Used in `custom-icon-action' to show a menu to the user.") >>  > >>  > +(defconst custom-icon--images-sub-type >>  > +  '(list :format "%{%t%}:\n%v\n" >>  > +         :tag "Images" >>  > +         (const  :tag "" image) >>  > +         (repeat :tag "Values" >>  > +                 (string :tag "Image filename")) >>  > +         (plist  :tag "Image attributes"))) >>  > + >>  > +(defconst custom-icon--emojis-sub-type >>  > +  '(list :format "%{%t%}:\n%v\n" >>  > +         :tag "Colorful Emojis" >>  > +         (const  :tag "" emoji) >>  > +         (repeat :tag "Values" >>  > +                 (string :tag "Emoji text")) >>  > +         (plist  :tag "Emoji text properties"))) >>  > + >>  > +(defconst custom-icon--symbols-sub-type >>  > +  '(list :format "%{%t%}:\n%v\n" >>  > +         :tag "Monochrome Symbols" >>  > +         (const  :tag "" symbol) >>  > +         (repeat :tag "Values" >>  > +                 (string :tag "Symbol text")) >>  > +         (plist  :tag "Symbol text properties"))) >>  > + >>  > +(defconst custom-icon--texts-sub-type >>  > +  '(list :format "%{%t%}:\n%v\n" >>  > +         :tag "Texts Only" >>  > +         (const  :tag "" text) >>  > +         (repeat :tag "Values" >>  > +                 (string :tag "Text")) >>  > +         (plist  :tag "Text properties"))) >>  > + >>  > +(defconst custom-icon--type >>  > +  `(repeat :format ,(concat "%{%t%}" >>  > +                            (propertize ":" 'display "") >>  > +                            "\n\n%v%i\n") >>  > +           :tag "Icon elements: >>  > +- Only the first occurrence of a same element counts. >>  > +- Missing elements will take their default value. >>  > +- At least one element should be provided with a valid value." >>  > +    (choice :void ,custom-icon--texts-sub-type >>  > +            :extra-offset -3 >>  > +            ,custom-icon--images-sub-type >>  > +            ,custom-icon--emojis-sub-type >>  > +            ,custom-icon--symbols-sub-type >>  > +            ,custom-icon--texts-sub-type))) >>  > + >>  >  (defun custom-icon-value-create (widget) >>  >    "Here is where you edit the icon's specification." >>  >    (custom-load-widget widget) >>  > @@ -5535,13 +5582,7 @@ custom-icon-value-create >>  >       (form (widget-get widget :custom-form)) >>  >       (symbol (widget-get widget :value)) >>  >       (tag (widget-get widget :tag)) >>  > -     (type '(repeat >>  > -                 (list (choice (const :tag "Images" image) >>  > -                               (const :tag "Colorful Emojis" emoji) >>  > -                               (const :tag "Monochrome Symbols" symbol) >>  > -                               (const :tag "Text Only" text)) >>  > -                       (repeat string) >>  > -                       plist))) >>  > +     (type custom-icon--type) >>  >       (prefix (widget-get widget :custom-prefix)) >>  >       (last (widget-get widget :custom-last)) >>  >       (style (widget-get widget :custom-style)) >> >> I think this is an improvement.  Thanks David. > > Thanks for the review. > > I wanted to install this, but byte-compiler produces a warning: > >     ELC      cus-edit.elc > >   In toplevel form: >   cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget' > > Is that a typo, and you actually meant custom-icon--texts-sub-type? There were typos in the first 2 patches David sent.  The last patch, the one that ends with -V2, was good.  I think I quoted that one. From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Mauro Aranda Cc: 73178@debbugs.gnu.org Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.173641691123476 (code B ref 73178); Thu, 09 Jan 2025 10:02:01 +0000 Received: (at 73178) by debbugs.gnu.org; 9 Jan 2025 10:01:51 +0000 Received: from localhost ([127.0.0.1]:50493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVpMN-00066a-8L for submit@debbugs.gnu.org; Thu, 09 Jan 2025 05:01:51 -0500 Received: from smtp-81.smtpout.orange.fr ([80.12.242.81]:40809 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVpMK-00066P-2r for 73178@debbugs.gnu.org; Thu, 09 Jan 2025 05:01:50 -0500 Received: from [192.168.1.21] ([90.112.40.65]) by smtp.orange.fr with ESMTPA id VpMDt0ndVgrRVVpMGtrrou; Thu, 09 Jan 2025 11:01:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1736416906; bh=p57XV3i2jfFHotpMBY8l4IfzEZJANC9Z+Fnu1v7ggB8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=aUvBMPSSybw7kmZvFhAxozQEV3xwkQRpbVRZhXaQmYXi/Jrhl8c/DcG9wDvqTs22T g7dA7ihnomiYiv0v8yw/xs10VXKo1bqi8ZgI6237MoovamotdHm/ka4QRsj8q4ICYg 10YtE9Y64Mny5BqO2F8Ygq+xyxWwPViBPdW0OzOTGV2MXCufLEEeGixJlkRrmclyMx jUsZ/p+bbocZ9IfJ8eah3EsNbvlgPxxvNS5bHmPrw5ko0M2YMSGZqkFhj/3yJa2UjM 2ylxb5YilaOAjd8HJEK0p4+MejkS1D2vEPbl2XndEXY5W3UjjG5G/KQMq7Rd/Unloc FffkL/iFKZSoA== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Thu, 09 Jan 2025 11:01:46 +0100 X-ME-IP: 90.112.40.65 Content-Type: multipart/mixed; boundary="------------2v1xAl04xulOinUXJ106pOFF" Message-ID: <822bd2c9-7463-4c55-89c2-2eabd990944d@orange.fr> Date: Thu, 9 Jan 2025 11:01:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> <86ed1c31o6.fsf@gnu.org> Content-Language: fr, en-US From: David Ponce In-Reply-To: <86ed1c31o6.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------2v1xAl04xulOinUXJ106pOFF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-01-09 08:07, Eli Zaretskii wrote: >> Date: Wed, 8 Jan 2025 10:59:27 -0300 >> Cc: Eli Zaretskii >> From: Mauro Aranda >> [...] >> I think this is an improvement. Thanks David. > > Thanks for the review. > > I wanted to install this, but byte-compiler produces a warning: > > ELC cus-edit.elc > > In toplevel form: > cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget' > > Is that a typo, and you actually meant custom-icon--texts-sub-type? > > Also, could you please accompany the patch with the ChangeLog-style > commit log message (see CONTRIBUTE for the details)? Otherwise, I > will have to write the log message manually when installing your > changes. > > Thanks. Hello Eli, Hmm, it seems you didn't install the correct patch? I attached the correct patch (V2) which applies cleanly for me. Also below is my proposed ChangeLog. Thank you, and thanks Mauro for your review. 2025-01-09 David Ponce Improve usability of the widget used to customize icon. * lisp/cus-edit.el (custom-icon--images-sub-type) (custom-icon--emojis-sub-type, custom-icon--symbols-sub-type) (custom-icon--texts-sub-type): New constant. (custom-icon--type): New constant. (custom-icon-value-create): Use it. --------------2v1xAl04xulOinUXJ106pOFF Content-Type: text/x-patch; charset=UTF-8; name="improve-widget-to-customize-icon-V2.patch" Content-Disposition: attachment; filename="improve-widget-to-customize-icon-V2.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4 IDNhYjVmMTE1MzJlLi5mZDc5MGIxODYzMCAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5l bAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC01NTI1LDYgKzU1MjUsNTMgQEAgY3VzdG9t LWljb24tZXh0ZW5kZWQtbWVudQogICAiQSBtZW51IGZvciBgY3VzdG9tLWljb24nIHdpZGdl dHMuCiBVc2VkIGluIGBjdXN0b20taWNvbi1hY3Rpb24nIHRvIHNob3cgYSBtZW51IHRvIHRo ZSB1c2VyLiIpCiAKKyhkZWZjb25zdCBjdXN0b20taWNvbi0taW1hZ2VzLXN1Yi10eXBlCisg ICcobGlzdCA6Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiSW1hZ2Vz IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIGltYWdlKQorICAgICAgICAgKHJlcGVhdCA6 dGFnICJWYWx1ZXMiCisgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiSW1hZ2UgZmls ZW5hbWUiKSkKKyAgICAgICAgIChwbGlzdCAgOnRhZyAiSW1hZ2UgYXR0cmlidXRlcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgJyhsaXN0IDpm b3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJDb2xvcmZ1bCBFbW9qaXMi CisgICAgICAgICAoY29uc3QgIDp0YWcgIiIgZW1vamkpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJFbW9qaSB0ZXh0 IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIkVtb2ppIHRleHQgcHJvcGVydGllcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1zeW1ib2xzLXN1Yi10eXBlCisgICcobGlzdCA6 Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiTW9ub2Nocm9tZSBTeW1i b2xzIgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHN5bWJvbCkKKyAgICAgICAgIChyZXBl YXQgOnRhZyAiVmFsdWVzIgorICAgICAgICAgICAgICAgICAoc3RyaW5nIDp0YWcgIlN5bWJv bCB0ZXh0IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIlN5bWJvbCB0ZXh0IHByb3BlcnRp ZXMiKSkpCisKKyhkZWZjb25zdCBjdXN0b20taWNvbi0tdGV4dHMtc3ViLXR5cGUKKyAgJyhs aXN0IDpmb3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJUZXh0cyBPbmx5 IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHRleHQpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJUZXh0IikpCisg ICAgICAgICAocGxpc3QgIDp0YWcgIlRleHQgcHJvcGVydGllcyIpKSkKKworKGRlZmNvbnN0 IGN1c3RvbS1pY29uLS10eXBlCisgIGAocmVwZWF0IDpmb3JtYXQgLChjb25jYXQgIiV7JXQl fSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvcGVydGl6ZSAiOiIgJ2Rpc3Bs YXkgIiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlxuXG4ldiVpXG4iKQorICAg ICAgICAgICA6dGFnICJJY29uIGVsZW1lbnRzOgorLSBPbmx5IHRoZSBmaXJzdCBvY2N1cnJl bmNlIG9mIGEgc2FtZSBlbGVtZW50IGNvdW50cy4KKy0gTWlzc2luZyBlbGVtZW50cyB3aWxs IHRha2UgdGhlaXIgZGVmYXVsdCB2YWx1ZS4KKy0gQXQgbGVhc3Qgb25lIGVsZW1lbnQgc2hv dWxkIGJlIHByb3ZpZGVkIHdpdGggYSB2YWxpZCB2YWx1ZS4iCisgICAgKGNob2ljZSA6dm9p ZCAsY3VzdG9tLWljb24tLXRleHRzLXN1Yi10eXBlCisgICAgICAgICAgICA6ZXh0cmEtb2Zm c2V0IC0zCisgICAgICAgICAgICAsY3VzdG9tLWljb24tLWltYWdlcy1zdWItdHlwZQorICAg ICAgICAgICAgLGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgICAgICAgICAgICxj dXN0b20taWNvbi0tc3ltYm9scy1zdWItdHlwZQorICAgICAgICAgICAgLGN1c3RvbS1pY29u LS10ZXh0cy1zdWItdHlwZSkpKQorCiAoZGVmdW4gY3VzdG9tLWljb24tdmFsdWUtY3JlYXRl ICh3aWRnZXQpCiAgICJIZXJlIGlzIHdoZXJlIHlvdSBlZGl0IHRoZSBpY29uJ3Mgc3BlY2lm aWNhdGlvbi4iCiAgIChjdXN0b20tbG9hZC13aWRnZXQgd2lkZ2V0KQpAQCAtNTUzNSwxMyAr NTU4Miw3IEBAIGN1c3RvbS1pY29uLXZhbHVlLWNyZWF0ZQogCSAoZm9ybSAod2lkZ2V0LWdl dCB3aWRnZXQgOmN1c3RvbS1mb3JtKSkKIAkgKHN5bWJvbCAod2lkZ2V0LWdldCB3aWRnZXQg OnZhbHVlKSkKIAkgKHRhZyAod2lkZ2V0LWdldCB3aWRnZXQgOnRhZykpCi0JICh0eXBlICco cmVwZWF0Ci0gICAgICAgICAgICAgICAgIChsaXN0IChjaG9pY2UgKGNvbnN0IDp0YWcgIklt YWdlcyIgaW1hZ2UpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnN0IDp0 YWcgIkNvbG9yZnVsIEVtb2ppcyIgZW1vamkpCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGNvbnN0IDp0YWcgIk1vbm9jaHJvbWUgU3ltYm9scyIgc3ltYm9sKQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFnICJUZXh0IE9ubHkiIHRleHQp KQotICAgICAgICAgICAgICAgICAgICAgICAocmVwZWF0IHN0cmluZykKLSAgICAgICAgICAg ICAgICAgICAgICAgcGxpc3QpKSkKKwkgKHR5cGUgY3VzdG9tLWljb24tLXR5cGUpCiAJIChw cmVmaXggKHdpZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tcHJlZml4KSkKIAkgKGxhc3QgKHdp ZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tbGFzdCkpCiAJIChzdHlsZSAod2lkZ2V0LWdldCB3 aWRnZXQgOmN1c3RvbS1zdHlsZSkpCg== --------------2v1xAl04xulOinUXJ106pOFF-- From unknown Sat Jun 21 03:16:11 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: David Ponce Subject: bug#73178: closed (Re: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon) Message-ID: References: <86tta812cz.fsf@gnu.org> <4cd4a62c-6642-49a3-8b2c-5eda13ac79af@orange.fr> X-Gnu-PR-Message: they-closed 73178 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 73178@debbugs.gnu.org Date: Thu, 09 Jan 2025 14:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1736433422-11772-1" This is a multi-part message in MIME format... ------------=_1736433422-11772-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #73178: 31.0.50; [PATCH] Improve the widget to customize icon which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 73178@debbugs.gnu.org. --=20 73178: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73178 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1736433422-11772-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 73178-done) by debbugs.gnu.org; 9 Jan 2025 14:36:08 +0000 Received: from localhost ([127.0.0.1]:51311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVtdn-00032d-UP for submit@debbugs.gnu.org; Thu, 09 Jan 2025 09:36:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45238) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVtdl-00032I-53 for 73178-done@debbugs.gnu.org; Thu, 09 Jan 2025 09:36:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVtdf-0006Ri-2t; Thu, 09 Jan 2025 09:35:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nbDdqwGwxWY6oA4vWaUjrSHxqpWfrFAF9G28JidMauU=; b=I6tAwPdV5aRm MODXbVyLP/9RYzwH7D7NKufeH3DaT26Coea0NxiZS0kVW9Z2YeJtI5HTf0UQQtYGM2xtJaKSrXKZg 6HeqTV7HK9dfivK2q63mIE1pYv3czbP/rRjquM8fR2jCAWHunpUiDJ5kau0ZD2PbmlBYMltQmjbOh AWZnDmczOtJD/KdaaBdfPTvHzHonTXGsPC/zQV8e2U16SFdJDGzcGYklTZF+EGRWZc2EiF2+Sdtr+ DgRUpWc7nBLTynTd2xeIqrVOT/DSSdAJ72TLjfF2bCaS/+XbOHIt4TohZwZ3B4opYcQDyAQPwG6sL Ek7HjCEsKsJBwAIxszDLew==; Date: Thu, 09 Jan 2025 16:35:56 +0200 Message-Id: <86tta812cz.fsf@gnu.org> From: Eli Zaretskii To: David Ponce In-Reply-To: <822bd2c9-7463-4c55-89c2-2eabd990944d@orange.fr> (message from David Ponce on Thu, 9 Jan 2025 11:01:40 +0100) Subject: Re: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> <86ed1c31o6.fsf@gnu.org> <822bd2c9-7463-4c55-89c2-2eabd990944d@orange.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73178-done Cc: maurooaranda@gmail.com, 73178-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 9 Jan 2025 11:01:40 +0100 > Cc: 73178@debbugs.gnu.org > From: David Ponce > > > I wanted to install this, but byte-compiler produces a warning: > > > > ELC cus-edit.elc > > > > In toplevel form: > > cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget' > > > > Is that a typo, and you actually meant custom-icon--texts-sub-type? > > > > Also, could you please accompany the patch with the ChangeLog-style > > commit log message (see CONTRIBUTE for the details)? Otherwise, I > > will have to write the log message manually when installing your > > changes. > > > > Thanks. > > Hello Eli, > > Hmm, it seems you didn't install the correct patch? > I attached the correct patch (V2) which applies cleanly for me. > Also below is my proposed ChangeLog. > > Thank you, and thanks Mauro for your review. Thanks, and sorry for missing the last patch earlier. Now installed on master, and closing the bug. ------------=_1736433422-11772-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Sep 2024 14:28:53 +0000 Received: from localhost ([127.0.0.1]:39319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soOKz-0005Sj-5U for submit@debbugs.gnu.org; Wed, 11 Sep 2024 10:28:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:48280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soOKv-0005SY-RA for submit@debbugs.gnu.org; Wed, 11 Sep 2024 10:28:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soOKi-0003d0-E4 for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 10:28:43 -0400 Received: from smtp-15.smtpout.orange.fr ([80.12.242.15] helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soOKf-0003Yl-CV for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 10:28:36 -0400 Received: from [192.168.1.21] ([2.7.225.247]) by smtp.orange.fr with ESMTPA id oOKWsyzIseJiWoOKWsxi1n; Wed, 11 Sep 2024 16:28:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1726064905; bh=F8tDx2Kmc0qFfqaoqg1RhBmR0qWtJD+JfZ9HcevW2Es=; h=Message-ID:Date:MIME-Version:To:From:Subject; b=q0uB4IIu36E1Rhrqgn1IEGTCHwlLXIpPDNiGL5e2OJsKN7xTwlZSGsKQaM1xaft52 Mj22l0c9iMIVYCPwJEr1ZTTJArXbppW8VKSkl8q/stdgmfRjyRIsoLe9vWrG9bxYOf QBVL2GYYzVSkonp2D76bqogq+Muq9Xt82ozK5xmy3uwtZi2QXa8Cfsn5uolRSHqkYG iAUKMxweywuIUqNk1C8UMLb1GfnFdLdWoV6k9AFTfyZaFymFzOqM1w8SjshZCuKPpE Z8gkV3mxkDB082UhUwOU8BYaEEnNXrKvrGdrDy6koygPeb5lpSM7HJHQVNkixch/sH eGl5M67HrKBeA== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Wed, 11 Sep 2024 16:28:25 +0200 X-ME-IP: 2.7.225.247 Content-Type: multipart/mixed; boundary="------------VpcLuYVgaJwoscLCCTCeyusE" Message-ID: <4cd4a62c-6642-49a3-8b2c-5eda13ac79af@orange.fr> Date: Wed, 11 Sep 2024 16:28:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: fr, en-US To: bug-gnu-emacs@gnu.org From: David Ponce Subject: 31.0.50; [PATCH] Improve the widget to customize icon Received-SPF: pass client-ip=80.12.242.15; envelope-from=da_vid@orange.fr; helo=smtp.smtpout.orange.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------VpcLuYVgaJwoscLCCTCeyusE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello, Whenever I try to use Emacs' built-in icons, I have some difficulty understanding the user interface for customizing an icon. For example, regardless of the type of icon element, all the fields have similar labels, which makes the interface difficult to understand and use. For instance, for Images, it is not clear that the String field is intended to enter the image file name: Choice: Value Menu [Images|Colorful Emojis|Monochrome Symbols|Text only] Repeat: INS DEL String: INS Plist: INS DEL : Key: Value: INS Also, nothing guides you regarding usage of this complex widget. I propose the attached patch that improves the widget used to customize an icon. Possible ChangeLog: 2024-09-11 David Ponce Improve usability of the widget used to customize icon. * lisp/cus-edit.el (custom-icon--images-sub-type) (custom-icon--emojis-sub-type, custom-icon--symbols-sub-type) (custom-icon--texts-sub-type): New constant. (custom-icon--type): New constant. (custom-icon-value-create): Use it. With this patch, a quick help summarizes usage, and the different fields are named according to the kind of icon element. Here is a view of the new UI when customizing the default `button' icon: --------------------------------------------------------------- Hide Button: Icon elements: - Only the first occurrence of a same element counts. - Missing elements will take their default value.: - At least one element should be provided with a valid value. INS DEL Choice: Value Menu Images: Values: INS DEL Image filename: INS Image attributes: INS DEL : Key: :face Value: icon-button INS INS DEL Choice: Value Menu Colorful Emojis: Values: INS DEL Emoji text: 🔵 INS Emoji text properties: INS DEL : Key: :face Value: icon INS INS DEL Choice: Value Menu Monochrome Symbols: Values: INS DEL Symbol text: ● INS Symbol text properties: INS DEL : Key: :face Value: icon-button INS INS DEL Choice: Value Menu Texts Only: Values: INS DEL Text: button INS Text properties: INS DEL : Key: :face Value: icon-button INS INS --------------------------------------------------------------- WDYT? Thanks! In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-09-11 Repository revision: 69e1aca041c57ba425425d31471e1c8f86d3bf04 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 40 (KDE Plasma) Configured using: 'configure --with-x-toolkit=gtk3 --with-cairo-xcb --with-native-compilation=no PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_TIME: fr_FR.utf8 value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix --------------VpcLuYVgaJwoscLCCTCeyusE Content-Type: text/x-patch; charset=UTF-8; name="improve-widget-to-customize-icon-V0.patch" Content-Disposition: attachment; filename="improve-widget-to-customize-icon-V0.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4 IDNhYjVmMTE1MzJlLi5mZDc5MGIxODYzMCAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5l bAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC01NTI1LDYgKzU1MjUsNTMgQEAgY3VzdG9t LWljb24tZXh0ZW5kZWQtbWVudQogICAiQSBtZW51IGZvciBgY3VzdG9tLWljb24nIHdpZGdl dHMuCiBVc2VkIGluIGBjdXN0b20taWNvbi1hY3Rpb24nIHRvIHNob3cgYSBtZW51IHRvIHRo ZSB1c2VyLiIpCiAKKyhkZWZjb25zdCBjdXN0b20taWNvbi0taW1hZ2VzLXN1Yi10eXBlCisg ICcobGlzdCA6Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiSW1hZ2Vz IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIGltYWdlKQorICAgICAgICAgKHJlcGVhdCA6 dGFnICJWYWx1ZXMiCisgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiSW1hZ2UgZmls ZW5hbWUiKSkKKyAgICAgICAgIChwbGlzdCAgOnRhZyAiSW1hZ2UgYXR0cmlidXRlcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgJyhsaXN0IDpm b3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJDb2xvcmZ1bCBFbW9qaXMi CisgICAgICAgICAoY29uc3QgIDp0YWcgIiIgZW1vamkpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJFbW9qaSB0ZXh0 IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIkVtb2ppIHRleHQgcHJvcGVydGllcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1zeW1ib2xzLXN1Yi10eXBlCisgICcobGlzdCA6 Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiTW9ub2Nocm9tZSBTeW1i b2xzIgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHN5bWJvbCkKKyAgICAgICAgIChyZXBl YXQgOnRhZyAiVmFsdWVzIgorICAgICAgICAgICAgICAgICAoc3RyaW5nIDp0YWcgIlN5bWJv bCB0ZXh0IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIlN5bWJvbCB0ZXh0IHByb3BlcnRp ZXMiKSkpCisKKyhkZWZjb25zdCBjdXN0b20taWNvbi0tdGV4dHMtc3ViLXR5cGUKKyAgJyhs aXN0IDpmb3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJUZXh0cyBPbmx5 IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHRleHQpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJUZXh0IikpCisg ICAgICAgICAocGxpc3QgIDp0YWcgIlRleHQgcHJvcGVydGllcyIpKSkKKworKGRlZmNvbnN0 IGN1c3RvbS1pY29uLS10eXBlCisgIGAocmVwZWF0IDpmb3JtYXQgLChjb25jYXQgIiV7JXQl fSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvcGVydGl6ZSAiOiIgJ2Rpc3Bs YXkgIiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlxuXG4ldiVpXG4iKQorICAg ICAgICAgICA6dGFnICJJY29uIGVsZW1lbnRzOgorLSBPbmx5IHRoZSBmaXJzdCBvY2N1cnJl bmNlIG9mIGEgc2FtZSBlbGVtZW50IGNvdW50cy4KKy0gTWlzc2luZyBlbGVtZW50cyB3aWxs IHRha2UgdGhlaXIgZGVmYXVsdCB2YWx1ZS4KKy0gQXQgbGVhc3Qgb25lIGVsZW1lbnQgc2hv dWxkIGJlIHByb3ZpZGVkIHdpdGggYSB2YWxpZCB2YWx1ZS4iCisgICAgKGNob2ljZSA6dm9p ZCAsY3VzdG9tLWljb24tLXRleHRzLXdpZGdldAorICAgICAgICAgICAgOmV4dHJhLW9mZnNl dCAtMworICAgICAgICAgICAgLGN1c3RvbS1pY29uLS1pbWFnZXMtc3ViLXR5cGUKKyAgICAg ICAgICAgICxjdXN0b20taWNvbi0tZW1vamlzLXN1Yi10eXBlCisgICAgICAgICAgICAsY3Vz dG9tLWljb24tLXN5bWJvbHMtc3ViLXR5cGUKKyAgICAgICAgICAgICxjdXN0b20taWNvbi0t dGV4dHMtc3ViLXR5cGUpKSkKKwogKGRlZnVuIGN1c3RvbS1pY29uLXZhbHVlLWNyZWF0ZSAo d2lkZ2V0KQogICAiSGVyZSBpcyB3aGVyZSB5b3UgZWRpdCB0aGUgaWNvbidzIHNwZWNpZmlj YXRpb24uIgogICAoY3VzdG9tLWxvYWQtd2lkZ2V0IHdpZGdldCkKQEAgLTU1MzUsMTMgKzU1 ODIsNyBAQCBjdXN0b20taWNvbi12YWx1ZS1jcmVhdGUKIAkgKGZvcm0gKHdpZGdldC1nZXQg d2lkZ2V0IDpjdXN0b20tZm9ybSkpCiAJIChzeW1ib2wgKHdpZGdldC1nZXQgd2lkZ2V0IDp2 YWx1ZSkpCiAJICh0YWcgKHdpZGdldC1nZXQgd2lkZ2V0IDp0YWcpKQotCSAodHlwZSAnKHJl cGVhdAotICAgICAgICAgICAgICAgICAobGlzdCAoY2hvaWNlIChjb25zdCA6dGFnICJJbWFn ZXMiIGltYWdlKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFn ICJDb2xvcmZ1bCBFbW9qaXMiIGVtb2ppKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChjb25zdCA6dGFnICJNb25vY2hyb21lIFN5bWJvbHMiIHN5bWJvbCkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiVGV4dCBPbmx5IiB0ZXh0KSkK LSAgICAgICAgICAgICAgICAgICAgICAgKHJlcGVhdCBzdHJpbmcpCi0gICAgICAgICAgICAg ICAgICAgICAgIHBsaXN0KSkpCisJICh0eXBlIGN1c3RvbS1pY29uLS13aWRnZXQpCiAJIChw cmVmaXggKHdpZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tcHJlZml4KSkKIAkgKGxhc3QgKHdp ZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tbGFzdCkpCiAJIChzdHlsZSAod2lkZ2V0LWdldCB3 aWRnZXQgOmN1c3RvbS1zdHlsZSkpCg== --------------VpcLuYVgaJwoscLCCTCeyusE-- ------------=_1736433422-11772-1-- From unknown Sat Jun 21 03:16:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: maurooaranda@gmail.com, 73178-done@debbugs.gnu.org Received: via spool by 73178-done@debbugs.gnu.org id=D73178.173643438815437 (code D ref 73178); Thu, 09 Jan 2025 14:54:01 +0000 Received: (at 73178-done) by debbugs.gnu.org; 9 Jan 2025 14:53:08 +0000 Received: from localhost ([127.0.0.1]:51362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVtuF-00040u-Uc for submit@debbugs.gnu.org; Thu, 09 Jan 2025 09:53:08 -0500 Received: from smtp-79.smtpout.orange.fr ([80.12.242.79]:56135 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVtuD-00040k-1Y for 73178-done@debbugs.gnu.org; Thu, 09 Jan 2025 09:53:06 -0500 Received: from [192.168.1.21] ([90.112.40.65]) by smtp.orange.fr with ESMTPA id Vtu5tVJJgTA3oVtu8tHswx; Thu, 09 Jan 2025 15:53:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1736434383; bh=b/u9ztohVvuGm4ks1BNAQpbzOmaw5hrZkO1dcZvpmTI=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=Jajc7VVrNTTDokf6XBXadZ3Nfdmlz6YL4fSglyH7uICh8Qu7lYmLshdycCFdr5doc +U0ejDltXTy7qHsU8cpwkJAijYW/iWqHizJVq1EU8g4fYSyMLPMYyltjBK5stHan+z zNU3WSy8tvnL5snhecCHWjQLe4kQpPwcY01U2Wzo0ynYHTf7Y0h6CY3kmq+C0zWS5Q N7svvr3xBMQ+aWY5Y2dP+EXE/qFjcKREgoyo+5/zdXlEl//ie363Sl2mSGKHzVAX3u gIxb5ImCR8NHtawcQATfysQ7npPRd5vK/n20IeSfQWwOyebURXwtHM2avOGjiyrWHS 1pLRwsePWgnow== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Thu, 09 Jan 2025 15:53:03 +0100 X-ME-IP: 90.112.40.65 Message-ID: <73d3590c-8393-4585-86c1-d6d69a3e42da@orange.fr> Date: Thu, 9 Jan 2025 15:52:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> <86ed1c31o6.fsf@gnu.org> <822bd2c9-7463-4c55-89c2-2eabd990944d@orange.fr> <86tta812cz.fsf@gnu.org> Content-Language: fr, en-US From: David Ponce In-Reply-To: <86tta812cz.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-01-09 15:35, Eli Zaretskii wrote: >> Date: Thu, 9 Jan 2025 11:01:40 +0100 >> Cc: 73178@debbugs.gnu.org >> From: David Ponce >> >>> I wanted to install this, but byte-compiler produces a warning: >>> >>> ELC cus-edit.elc >>> >>> In toplevel form: >>> cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget' >>> >>> Is that a typo, and you actually meant custom-icon--texts-sub-type? >>> >>> Also, could you please accompany the patch with the ChangeLog-style >>> commit log message (see CONTRIBUTE for the details)? Otherwise, I >>> will have to write the log message manually when installing your >>> changes. >>> >>> Thanks. >> >> Hello Eli, >> >> Hmm, it seems you didn't install the correct patch? >> I attached the correct patch (V2) which applies cleanly for me. >> Also below is my proposed ChangeLog. >> >> Thank you, and thanks Mauro for your review. > > Thanks, and sorry for missing the last patch earlier. No worries. I should have double-checked my patch before submitting it ;-) > > Now installed on master, and closing the bug. Thank you very much!