GNU bug report logs - #73176
[PATCH] gnu: go-1.20: Build with gccgo-12 on some systems.

Previous Next

Package: guix-patches;

Reported by: Efraim Flashner <efraim <at> flashner.co.il>

Date: Wed, 11 Sep 2024 10:05:02 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73176: closed ([PATCH] gnu: go-1.20: Build with gccgo-12 on
 some systems.)
Date: Thu, 12 Sep 2024 14:35:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 12 Sep 2024 15:32:56 +0100
with message-id <875xr1lz6v.fsf <at> gmail.com>
and subject line [PATCH] gnu: go-1.20: Build with gccgo-12 on some systems.
has caused the debbugs.gnu.org bug report #73176,
regarding [PATCH] gnu: go-1.20: Build with gccgo-12 on some systems.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73176: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73176
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] gnu: go-1.20: Build with gccgo-12 on some systems.
Date: Wed, 11 Sep 2024 13:04:03 +0300
* gnu/packages/golang.scm (go-1.20)[native-inputs]: Don't replace the
gccgo input on architectures bootstrapping go with it.

Change-Id: I26831b2bcfe623f6eb0ac7c16b463e5e873110e6
---

This should only cause rebuilds on riscv64 and ppc64le.

 gnu/packages/golang.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 9f04b8e4232..95aca837ffc 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2016-2023 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2016-2024 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Matthew Jordan <matthewjordandevops <at> yandex.com>
 ;;; Copyright © 2016 Andy Wingo <wingo <at> igalia.com>
 ;;; Copyright © 2016, 2019, 2021 Ludovic Courtès <ludo <at> gnu.org>
@@ -811,7 +811,10 @@ (define-public go-1.20
      ;; See 'src/cmd/dist/notgo117.go' in the source code distribution,
      ;; as well as the upstream discussion of this topic:
      ;; https://go.dev/issue/44505
-     (alist-replace "go" (list go-1.17) (package-native-inputs go-1.17)))))
+     ;; We continue to use gccgo-12 since it provides go-1.18.
+     (if (member (%current-system) (package-supported-systems go-1.4))
+         (alist-replace "go" (list go-1.17) (package-native-inputs go-1.17))
+         (package-native-inputs go-1.17)))))
 
 (define-public go-1.21
   (package

base-commit: b6d5a7f5836739dab884b49a64ca354794dd845f
-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted



[Message part 3 (message/rfc822, inline)]
From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 73176-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: go-1.20: Build with gccgo-12 on some systems.
Date: Thu, 12 Sep 2024 15:32:56 +0100
[Message part 4 (text/plain, inline)]
Hi,

Pushed as d893d040478f07fbfb08e0ff18549ab4215dcca2 to go-team.

--
Oleg
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 253 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.