From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Sep 2024 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 73175@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172604776428715 (code B ref -1); Wed, 11 Sep 2024 09:43:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Sep 2024 09:42:44 +0000 Received: from localhost ([127.0.0.1]:37793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soJs3-0007T5-Ps for submit@debbugs.gnu.org; Wed, 11 Sep 2024 05:42:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:40960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soJs1-0007Sw-SE for submit@debbugs.gnu.org; Wed, 11 Sep 2024 05:42:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soJrr-0007tz-TI for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:42:31 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soJrq-0006YK-DW for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:42:31 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-42ca4e0299eso39041385e9.2 for ; Wed, 11 Sep 2024 02:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726047748; x=1726652548; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=hG/3jxzigjGv1cWX12TLdw67NxmgTXATmdM22NDkUF0=; b=kp+ud4ZbMNfXQP2vhMzX7PxYLYnmkeU+88pvW5l3MLSU0joR1OiAzy1wh76cDMne+p 1VjnrUDhTa/bXn4S4yFy9jrOm/vHWYuYx3hjNC2J1xSW8yQh1yEEeYzCDsqBYRzKMkZf HK+ShAgVoaYb4EC67CgbSOKHJKkEEwdu4V8mPKWNEm5ae/b/m8XiNArJyw1yC4ZJJHD4 BpQ1mVi7bmj+gwpQxYRvCRNUbSj6cJ1kGiM8y76gB8COo2lEhJ0CsZ7RnhEeCWQDw7Fm rJ7Q2Hi0FG5Rq+3hHH1ukHjeYgT2ywDVzQverApnzh0lyA2zEJ8vjtNfOGVk4tpVlC0I s+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726047748; x=1726652548; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hG/3jxzigjGv1cWX12TLdw67NxmgTXATmdM22NDkUF0=; b=TmM97uqOTqpRVYue94EX2wS2fdL8unI0/PJqDqU1DO30QooXrTWs3y3OB1cG2hLlSL 4nsbKWyr6leYdG3nYznNq4t7GK9/vOwdDRRL4vh/T6VX+u6oBmQfTr3YRn7Gmv/Gm1Un KzMl0HPX7BZk/inWzZJzxma9Qxmqf5jAH+RHBAo+nsOv3YcAsJB/BBh+5O8c886ktnEP JP57LYblNNmQtsswsTPRKXxWmNBy+vBSgrLTSgHT7hRrgU2UQZgxSmGvz83aJJxHFpD/ HfyPq15wdT2bszNcw9EMzJLIUg9Fb98p4y/xs8SqBlD5w10PWiycT+P6AhVGwZ1igjS8 lm6Q== X-Gm-Message-State: AOJu0YxTSwBqFh+NJCTGMjFRhWkaHAlbvKITluMrcXONcv6n6SteXDDF iOLXG2/OVo9xJq/Dw5KoIqpeVFlebtM7edHxd8GGA+SyL2li8CqvKyeMvQ== X-Google-Smtp-Source: AGHT+IHT99hdqrluu4Pe1vd3bOzQJ5jABwqGoT0r7v0UuGsi4lVcwLOHfdfPTyfh+Ow1LsfI2Tt7Mg== X-Received: by 2002:a05:600c:3586:b0:426:50e1:ea6e with SMTP id 5b1f17b1804b1-42cad76a0aamr105215785e9.18.1726047747782; Wed, 11 Sep 2024 02:42:27 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:8061:cf5c:603f:ba35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42caeb81611sm138958695e9.32.2024.09.11.02.42.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2024 02:42:27 -0700 (PDT) From: Robert Pluim Date: Wed, 11 Sep 2024 11:42:26 +0200 Message-ID: <87y13yle65.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) src/emacs -Q etc/NEWS C-x C-q ; buttons appear C-x C-q ; buttons don=CA=BCt disappear (personally I don=CA=BCt mind the buttons, but the intent of faf1f037987c was to make them disappear). I came up with the following, but I can never remember all the details of text property removal (maybe we need a `button-debuttonize-region'?) diff --git a/lisp/textmodes/emacs-news-mode.el b/lisp/textmodes/emacs-news-= mode.el index edeb1540feb..2cca63071b5 100644 --- a/lisp/textmodes/emacs-news-mode.el +++ b/lisp/textmodes/emacs-news-mode.el @@ -112,10 +112,17 @@ emacs-news--mode-common (define-derived-mode emacs-news-mode text-mode "NEWS" "Major mode for editing the Emacs NEWS file." ;; Disable buttons. - (button-mode nil) + (button-mode -1) ;; And make the buffer writable. This is used when toggling ;; emacs-news-mode. (setq buffer-read-only nil) + (save-excursion + (with-silent-modifications + (widen) + (remove-text-properties (point-min) (point-max) + (button--properties nil nil nil)) + (add-face-text-property (point-min) (point-max) + 'button nil))) (setq-local fill-paragraph-function #'emacs-news--fill-paragraph) (emacs-news--mode-common)) =20 In GNU Emacs 30.0.60 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-09-05 built on rltb Repository revision: fc7581ae2ee9db1e3189b76c66be9cd13f72f004 Repository branch: emacs-30 System Description: Debian GNU/Linux 12 (bookworm) Robert --=20 From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2024 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 73175@debbugs.gnu.org Received: via spool by 73175-submit@debbugs.gnu.org id=B73175.172681521822290 (code B ref 73175); Fri, 20 Sep 2024 06:54:02 +0000 Received: (at 73175) by debbugs.gnu.org; 20 Sep 2024 06:53:38 +0000 Received: from localhost ([127.0.0.1]:33915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srXWL-0005nR-CG for submit@debbugs.gnu.org; Fri, 20 Sep 2024 02:53:38 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:58145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srXW7-0005md-0H for 73175@debbugs.gnu.org; Fri, 20 Sep 2024 02:53:36 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id F0FB0240009; Fri, 20 Sep 2024 06:52:56 +0000 (UTC) From: Juri Linkov In-Reply-To: <87y13yle65.fsf@gmail.com> (Robert Pluim's message of "Wed, 11 Sep 2024 11:42:26 +0200") Organization: LINKOV.NET References: <87y13yle65.fsf@gmail.com> Date: Fri, 20 Sep 2024 09:52:25 +0300 Message-ID: <86y13m6esa.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juri@linkov.net X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > src/emacs -Q etc/NEWS > C-x C-q ; buttons appear > C-x C-q ; buttons donʼt disappear > > (personally I donʼt mind the buttons, but the intent of faf1f037987c > was to make them disappear). > > I came up with the following, but I can never remember all the details > of text property removal (maybe we need a `button-debuttonize-region'?) Or `button-unbuttonize-region' (like in `gnus-unbuttonized-mime-types'). > (define-derived-mode emacs-news-mode text-mode "NEWS" > "Major mode for editing the Emacs NEWS file." > ;; Disable buttons. > - (button-mode nil) > + (button-mode -1) > ;; And make the buffer writable. This is used when toggling > ;; emacs-news-mode. > (setq buffer-read-only nil) > + (save-excursion > + (with-silent-modifications > + (widen) > + (remove-text-properties (point-min) (point-max) > + (button--properties nil nil nil)) > + (add-face-text-property (point-min) (point-max) > + 'button nil))) Probably it would be the right thing to move this code to `button-mode' to remove properties when it's disabled. From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2024 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 73175@debbugs.gnu.org Received: via spool by 73175-submit@debbugs.gnu.org id=B73175.172682276216987 (code B ref 73175); Fri, 20 Sep 2024 09:00:02 +0000 Received: (at 73175) by debbugs.gnu.org; 20 Sep 2024 08:59:22 +0000 Received: from localhost ([127.0.0.1]:34055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srZU2-0004Pu-DY for submit@debbugs.gnu.org; Fri, 20 Sep 2024 04:59:22 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:44362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srZU0-0004Pd-5O for 73175@debbugs.gnu.org; Fri, 20 Sep 2024 04:59:21 -0400 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-42cba6cdf32so15029545e9.1 for <73175@debbugs.gnu.org>; Fri, 20 Sep 2024 01:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726822675; x=1727427475; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VVHhyNTXurcWOyOoy1krEf6PbJn/EFDvloU3pOdCQWA=; b=YwEM3fGTEg8aWpnpFLoJFsl5Cn1bxeHkb71R31pB/dlXrs1bCSbRrbL4fSJ63nExEc PKIGPxFGDl8+UMZ1xhnSZBQ6xwUd1W+IkdvNOFoBAVROL1cjm/iyiS72xUdENrAga45M CJzCprDJIYlJl6/E+/yFAuABLdjRXdpVVcR6K4DKAxn0Z/Z6JhlbFsQTZa/fN5MvdHL4 jpIpWVoxxsyVyjnN+DfjIOwxflHNsUA9Za22HS9TPJumPE/xqQGReUVtZIaVtSDyuEFA fnaYr0duwypjL4ceAp+dUTwfibf3jb7I5ZNnE9ICvkyZtuSBHvPH03p9X2dVI15O2YYv CreA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726822675; x=1727427475; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VVHhyNTXurcWOyOoy1krEf6PbJn/EFDvloU3pOdCQWA=; b=sc2bLk5kSv5ap2CqD/KlcuuvJjy7ohK+lX2IcBKAR4C24JSTOCOSV+KWL6d9RNKFvx QqrbwC+AxyiZdP8crfh4R8xXzxMniGFWSJJUxm9NcHV+u1Va4Qr9u20XOs9TNb4grq9K sa12cT8wKjB1WYeyQ6tFJ6cnEjK4lUZ3i29BEt9Ui42NDTBuZlvzz4nBU747XbPFqjlX 0fLQ7teJrWH8dSnIQnauSEWFB7Y1i6f+kpoIVilIJJyMXyizxrdXSc2b/7QgXF0BhKYw cb1TBGcuo4KQt8TzkahXkXTmB7c6dVQy/cnj7yHOMthLO32qEXER3J9v7h1TheetXp93 P5Fg== X-Gm-Message-State: AOJu0Yy69uOckDskSnbmH0ZU5N8twHLpo19fH4KqdywQLa/WZa/pduE3 3PicTfVAc3m+fFW8FM3wjAydcq1f/bUcy0sReFMgzLTOQmQGFgxZL3RAJQ== X-Google-Smtp-Source: AGHT+IEWK8oMh8f2i5yhi4c8j6JVeyQbeDQqY4V+0cFjtul/yZS3nlcFrLTz73ieh3FO/avK/+t+HQ== X-Received: by 2002:a05:600c:310a:b0:42c:a89e:b0e6 with SMTP id 5b1f17b1804b1-42e7abe8e3emr13989155e9.11.1726822674978; Fri, 20 Sep 2024 01:57:54 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:3f8e:9d48:84d3:6a9f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7afbfa1asm16594475e9.21.2024.09.20.01.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 01:57:54 -0700 (PDT) From: Robert Pluim In-Reply-To: <86y13m6esa.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 20 Sep 2024 09:52:25 +0300") References: <87y13yle65.fsf@gmail.com> <86y13m6esa.fsf@mail.linkov.net> Date: Fri, 20 Sep 2024 10:57:53 +0200 Message-ID: <87o74ihfce.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 20 Sep 2024 09:52:25 +0300, Juri Linkov sai= d: >> src/emacs -Q etc/NEWS >> C-x C-q ; buttons appear >> C-x C-q ; buttons don=CA=BCt disappear >>=20 >> (personally I don=CA=BCt mind the buttons, but the intent of faf1f03= 7987c >> was to make them disappear). >>=20 >> I came up with the following, but I can never remember all the detai= ls >> of text property removal (maybe we need a `button-debuttonize-region= '?) Juri> Or `button-unbuttonize-region' (like in `gnus-unbuttonized-mime-t= ypes'). Sure. >> (define-derived-mode emacs-news-mode text-mode "NEWS" >> "Major mode for editing the Emacs NEWS file." >> ;; Disable buttons. >> - (button-mode nil) >> + (button-mode -1) >> ;; And make the buffer writable. This is used when toggling >> ;; emacs-news-mode. >> (setq buffer-read-only nil) >> + (save-excursion >> + (with-silent-modifications >> + (widen) >> + (remove-text-properties (point-min) (point-max) >> + (button--properties nil nil nil)) >> + (add-face-text-property (point-min) (point-max) >> + 'button nil))) Juri> Probably it would be the right thing to move this code to `button= -mode' Juri> to remove properties when it's disabled. That would be best (assuming I=CA=BCve got the incantation right ;-)) Robert --=20 From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2024 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 73175@debbugs.gnu.org Received: via spool by 73175-submit@debbugs.gnu.org id=B73175.17268366531469 (code B ref 73175); Fri, 20 Sep 2024 12:51:01 +0000 Received: (at 73175) by debbugs.gnu.org; 20 Sep 2024 12:50:53 +0000 Received: from localhost ([127.0.0.1]:34335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srd65-0000Nc-E9 for submit@debbugs.gnu.org; Fri, 20 Sep 2024 08:50:53 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:55601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srd63-0000NQ-8S for 73175@debbugs.gnu.org; Fri, 20 Sep 2024 08:50:52 -0400 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-374c180d123so1235035f8f.3 for <73175@debbugs.gnu.org>; Fri, 20 Sep 2024 05:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726836566; x=1727441366; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YIi8iVqmgdQ1+o8rzAAhKH6Wu+SEk4uK3tAY5t8Trjs=; b=O/YEScsyKv/ElH7Pe68rhNXMUbouGkRCbOjr5FZVbpalCacYXMgD99Fkgk2x+cD+80 z+6zd1R/7Svqdp3Wy1ty3EKEnXfuyHAbGs4lRX1iar+n8J+NlEkmIULh48IIvji9exgk mxdYHb3b6y4s47F9nebcT5lLKd7Egi+waIMxCOXo0ncj+vMykBH0PGQU+BnORyz++6oi WaruG4HdYNVhP+Pg1mtH7X6kt4M2zW2cR0V0hAOeHHza1tIr8BIApIBJlIyn9WoAEv7P qKStq5Xna6HzYhTTywWC/RY7thlCrnC1RlvApPa/RdrAMOnlRGvY2g3eA6etysgKGoQy Eq/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726836566; x=1727441366; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YIi8iVqmgdQ1+o8rzAAhKH6Wu+SEk4uK3tAY5t8Trjs=; b=vken24ocM/oeQCIsDLBTqBaQnz7Lg4eWEPgaXx65fCook8KQ/juz1KqGJtFjSqrTWK guw3NegtMmKnWtnIq4MKtVK923dacA7GlK0HjEApNJvy1dJqKgLgRfJwHrYm2PS9bZKg UnTowFtJOVDXtsywKU1tj2Ky4NzoRuzPOOglNrUKHOLzICUjKdJJyM+GsVUN+1jL4jmn tQRQ5jY4alFGg+cW9Tla+L8s2Hus7WzhgtQrM7OXBF3e10m27CgkXajweSliXvy4z120 0I+TFeCAPY1ykE0YqqbuFLvy9RU5q7FKwZ13eQUrTH5g9DsbgWXHjSFbyfBIjS4JoFKB yIgw== X-Gm-Message-State: AOJu0YwZdct6fnBp/+Z3sG10S9UCDVkZHfNC3kDGdgxSTqO8ue/lPTnE FZ0D2/7WQVKpE/b44LIljvxECgZIVuqu69AE81KsQnmOwkehLoSjmX9upg== X-Google-Smtp-Source: AGHT+IEfOhz7cpHfkmsxGGHEfZ01bq1s6aAoEA/PCupU6yov+rlkJuUk+h00phM2IG8grPGi0sDDDA== X-Received: by 2002:adf:e805:0:b0:378:81aa:2662 with SMTP id ffacd0b85a97d-37a4223e13fmr1339862f8f.7.1726836566327; Fri, 20 Sep 2024 05:49:26 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:1578:f437:28:be5f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e780e14fsm17592081f8f.117.2024.09.20.05.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 05:49:26 -0700 (PDT) From: Robert Pluim In-Reply-To: <87o74ihfce.fsf@gmail.com> (Robert Pluim's message of "Fri, 20 Sep 2024 10:57:53 +0200") References: <87y13yle65.fsf@gmail.com> <86y13m6esa.fsf@mail.linkov.net> <87o74ihfce.fsf@gmail.com> Date: Fri, 20 Sep 2024 14:49:25 +0200 Message-ID: <874j6ah4mi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 20 Sep 2024 10:57:53 +0200, Robert Pluim s= aid: Juri> Probably it would be the right thing to move this code to `button= -mode' Juri> to remove properties when it's disabled. Robert> That would be best (assuming I=CA=BCve got the incantation righ= t ;-)) Although `button-mode' is described as a mode for button *navigation*, so changing its behaviour might annoy people. We=CA=BCll let = the maintainers decide that one =E2=98=BA=EF=B8=8F Robert --=20 From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2024 06:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 73175@debbugs.gnu.org Received: via spool by 73175-submit@debbugs.gnu.org id=B73175.172716088018383 (code B ref 73175); Tue, 24 Sep 2024 06:55:02 +0000 Received: (at 73175) by debbugs.gnu.org; 24 Sep 2024 06:54:40 +0000 Received: from localhost ([127.0.0.1]:45131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sszRY-0004mR-1l for submit@debbugs.gnu.org; Tue, 24 Sep 2024 02:54:40 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sszRU-0004lY-Pv for 73175@debbugs.gnu.org; Tue, 24 Sep 2024 02:54:37 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 98ADE1C0004; Tue, 24 Sep 2024 06:54:05 +0000 (UTC) From: Juri Linkov In-Reply-To: <874j6ah4mi.fsf@gmail.com> (Robert Pluim's message of "Fri, 20 Sep 2024 14:49:25 +0200") Organization: LINKOV.NET References: <87y13yle65.fsf@gmail.com> <86y13m6esa.fsf@mail.linkov.net> <87o74ihfce.fsf@gmail.com> <874j6ah4mi.fsf@gmail.com> Date: Tue, 24 Sep 2024 09:39:53 +0300 Message-ID: <86setpd07a.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Juri> Probably it would be the right thing to move this code to `button-mode' > Juri> to remove properties when it's disabled. > > Robert> That would be best (assuming Iʼve got the incantation right ;-)) > > Although `button-mode' is described as a mode for button > *navigation*, so changing its behaviour might annoy people. Weʼll let the > maintainers decide that one ☺️ The change will fix its behaviour only for disabling with (button-mode -1). I don't see how this might annoy people. It's the standard thing for a mode to clean up after itself. From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2024 09:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 73175@debbugs.gnu.org Received: via spool by 73175-submit@debbugs.gnu.org id=B73175.172717027919518 (code B ref 73175); Tue, 24 Sep 2024 09:32:01 +0000 Received: (at 73175) by debbugs.gnu.org; 24 Sep 2024 09:31:19 +0000 Received: from localhost ([127.0.0.1]:45306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1st1t9-00054k-Eg for submit@debbugs.gnu.org; Tue, 24 Sep 2024 05:31:19 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:44113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1st1t7-00054R-7r for 73175@debbugs.gnu.org; Tue, 24 Sep 2024 05:31:18 -0400 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-42cb7a2e4d6so49157195e9.0 for <73175@debbugs.gnu.org>; Tue, 24 Sep 2024 02:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727170187; x=1727774987; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Jb4YBR5W/z3mphSHLYW+JxvbwlwKJArPtizRkkkxEOw=; b=hCVI3kGR+ZeSEZEWvJgqTXfv17OD2Jl4MkwzjkDPFb9dZIghMpjEhUpmWyGSbAsM/v Uouw7e/GFu7FM58UgdE9n42ijESds3DQh96lJ4i0Mf+Jf6thVlCHyQvOv9qM8yLq4BV4 WsD+DXhBJaJeN1WnaBL8tsJcS+2N9GAlNnwUEHnz/L+dV5J84dYJbY7X5FhiMxm1QUPi 7CoGhWDrXATpsAOyoq+E2gdqfgngY3IWS1JowGU2DlHXNU/+FxrCQkMqFewXxshp9sVf x4PtI83o9yHLQJTcCG8AMtBvp6WLH2Skty2H/TMIsXt7rD8q+BDLmkak09aWs/qQYVQm yuAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727170187; x=1727774987; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jb4YBR5W/z3mphSHLYW+JxvbwlwKJArPtizRkkkxEOw=; b=mZf4L7INPzi15gpLsP61X24XaKga9doDDwBvGVAlHRRFCJwWOOXbo+4wU8oYmyPrXk UYtGbjzN/bAtXepl990oHTnx/3r9UJ/7ZksLaVFmZVzQGugQKP9Nsoj4iT8q9AJqUa5A inQMQEHscfN/AnH3wFwxQBT2DJ/+52AbO+zXv9R7XBFFL+gzO8wEXdcmgfkFXNm2aGZK 9z9Bap+WxXDa4IwRyTJNz0S8C6P9K4FcnU2fU/eQNHekU7KguIktM3WMdePuNYkHMqvl km5Gp2Zs8iNhBuTdsMQ6oLx18hfqMG27v7/iHnvoZpeOJFeQGWXcnHPQR0gXNckjGQOb 56OQ== X-Gm-Message-State: AOJu0YzNs2fyYVcYUUUsFzaZV9get0HIizA8I2+stc9ABuTe1Ye5ZcnN ckSU4asdUy6MBUrQNM9NQ0glA7qibNsKp00WFdi96NJyehGDM3dKoy1Cbg== X-Google-Smtp-Source: AGHT+IH9ugqUB0MpAwXN9q2NClKuhGdqZb9hsdmjAbPFG2c2sj+TeCsBDyb/wnpq2PBGJgt3zd4vMg== X-Received: by 2002:a05:6000:154d:b0:374:c481:3f7 with SMTP id ffacd0b85a97d-37a422521b5mr10659938f8f.6.1727170186762; Tue, 24 Sep 2024 02:29:46 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:84a5:f5c1:da9c:5ef]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2c2652sm1087402f8f.46.2024.09.24.02.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 02:29:46 -0700 (PDT) From: Robert Pluim In-Reply-To: <86setpd07a.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 24 Sep 2024 09:39:53 +0300") References: <87y13yle65.fsf@gmail.com> <86y13m6esa.fsf@mail.linkov.net> <87o74ihfce.fsf@gmail.com> <874j6ah4mi.fsf@gmail.com> <86setpd07a.fsf@mail.linkov.net> Date: Tue, 24 Sep 2024 11:29:45 +0200 Message-ID: <87o74de6wm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 24 Sep 2024 09:39:53 +0300, Juri Linkov sai= d: Juri> Probably it would be the right thing to move this code to `button= -mode' Juri> to remove properties when it's disabled. >>=20 Robert> That would be best (assuming I=CA=BCve got the incantation righ= t ;-)) >>=20 >> Although `button-mode' is described as a mode for button >> *navigation*, so changing its behaviour might annoy people. We=CA=BC= ll let the >> maintainers decide that one =E2=98=BA=EF=B8=8F Juri> The change will fix its behaviour only for disabling with Juri> (button-mode -1). I don't see how this might annoy people. Juri> It's the standard thing for a mode to clean up after itself. OK. Are we agreed that `unbuttonize-region' is a good name before I update the manual? (Hmm, `buttonize-region' isn=CA=BCt in the elisp manual. I=CA=BCm assuming emacs-30 is still open for documentation changes, if not I can fix that on master.) Robert --=20 From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2024 12:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 73175@debbugs.gnu.org, juri@linkov.net Received: via spool by 73175-submit@debbugs.gnu.org id=B73175.172718076924085 (code B ref 73175); Tue, 24 Sep 2024 12:27:02 +0000 Received: (at 73175) by debbugs.gnu.org; 24 Sep 2024 12:26:09 +0000 Received: from localhost ([127.0.0.1]:45492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1st4cK-0006GO-6H for submit@debbugs.gnu.org; Tue, 24 Sep 2024 08:26:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1st4cH-0006Fh-HJ for 73175@debbugs.gnu.org; Tue, 24 Sep 2024 08:26:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st4bn-0003e0-SI; Tue, 24 Sep 2024 08:25:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9PHXqbzpWcMrPEoBcQogjkIxDhjViufhp2//6oO3GqA=; b=C4BvxFy9rU2NryVcPz0c 9CZrVuCTCeHYGAmi1EBgrCqSmJZgkT2/xHQUcRLPO8pKII5fZ42xbkxlS4ZHzX39hslMrA/x504+i uV89pg5Zh4Ka5nM/mgR1rNlAkNOT9RskqSXk41SDKCXBISpJ7VKB3yLaDIUV+N3eJA+huCpdmNtz+ M2//kZymCQ1Z4ixicu9YTmdmauPv6to9M4sT1i5/55RbhRciI7NunXPNemIKyMIPlvH+OYme/Gk/Z u6TwKFwg1LuhZ8tXLwG3xk/GhaUKxTnubSli1zuUb4zdHrn72Ppzc5atDSuSb/UWMf8HEfAX0xRNB LCyYTicNCZvV5Q==; Date: Tue, 24 Sep 2024 15:25:14 +0300 Message-Id: <86frppdys5.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87o74de6wm.fsf@gmail.com> (message from Robert Pluim on Tue, 24 Sep 2024 11:29:45 +0200) References: <87y13yle65.fsf@gmail.com> <86y13m6esa.fsf@mail.linkov.net> <87o74ihfce.fsf@gmail.com> <874j6ah4mi.fsf@gmail.com> <86setpd07a.fsf@mail.linkov.net> <87o74de6wm.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 73175@debbugs.gnu.org > From: Robert Pluim > Date: Tue, 24 Sep 2024 11:29:45 +0200 > > Hmm, `buttonize-region' isnʼt in the elisp manual. Iʼm assuming > emacs-30 is still open for documentation changes Yes, thanks. From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2024 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 73175@debbugs.gnu.org, juri@linkov.net Received: via spool by 73175-submit@debbugs.gnu.org id=B73175.172719421914318 (code B ref 73175); Tue, 24 Sep 2024 16:11:01 +0000 Received: (at 73175) by debbugs.gnu.org; 24 Sep 2024 16:10:19 +0000 Received: from localhost ([127.0.0.1]:52187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1st879-0003if-0s for submit@debbugs.gnu.org; Tue, 24 Sep 2024 12:10:19 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:43281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1st7yB-00035p-Ph for 73175@debbugs.gnu.org; Tue, 24 Sep 2024 12:00:57 -0400 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-37a413085cbso3076979f8f.1 for <73175@debbugs.gnu.org>; Tue, 24 Sep 2024 09:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727193565; x=1727798365; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=nq26wywjUxclFr0pUrIg26m58POZYzUq80OjrU0kWqs=; b=bxHx0t1RB9dG6p7k6AwGPf5KcGflPZ9TNHWYicVN7t2M02cH94gLjF+XVrzQP1XBhS ja1YX+8m/M2mtPlWmWy9AZqEmZwDSITGregkv7PcRa9ExMWtJ6Y5Mpyl69lnE0DsMsUa lvqKbc9tvQi7iQti3I522EhPA3yhyjJNLFY5UZQHZaaFS2zAvJOeCe0U3Ev77AmqcPTy B4FjXp0c9Bm+NenuCBuwayTSZVv3NhmsqlEVEHUIlRFbRX16y5uaC2TIH6tTWh9EL7mz Qo+2hTJA4JC9vt69lNU1ytYOmWrz5JOsjz5PUluR2mx9UNWDDLqWanlBKlw35QvU5wKE xtfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727193565; x=1727798365; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nq26wywjUxclFr0pUrIg26m58POZYzUq80OjrU0kWqs=; b=g41UB/2tDUpQzbkpkFVaZ5B+rEZovSkAXQgLapLy9LPnggcgmUSRZrTlnrSGjL+/Wg RoOboRMIwYzstMMDCZ1nXiWA166JyZcVwW83A0j7ebAIkZOzcLM1w5mbnVNJqAXEAWQJ H9uEQA4P0qKh5VmaY34UXpd00u5RdKdFJ4G7fkTOt/hjTGy9tERIeDAyL5AqZlms+LvT STHs2Hkwk1bhJ5gSAjxQS5I4lKsdQw+PGqObQJ7O3mdnI3K4DNcTz9C1Z8x3nctNA+lO tOi9s8AwpYcMwJfE8zo0+rAxLwvORgV5+48bW5ncE29D3AHH5V4WexeRrfidqSmZiNGF C8Jw== X-Gm-Message-State: AOJu0YwhsVz0vY0izwlrfAVpRWhmr1IkrRPJbS9jzm2cEZnVwGmynp3o bQ/gAeYbNamabMoMsUQPj0hpUCK7LDKCtuuDbSCgYtjNBkineWEBByC9fA== X-Google-Smtp-Source: AGHT+IGyPe/wWrBhTVD0WES5gZ1/s0o9OEzdOck4VXuHcZ4Rxn7EfLfaejSkNxhiGzS+hiuMGAr3kg== X-Received: by 2002:adf:fd4b:0:b0:374:cee6:c298 with SMTP id ffacd0b85a97d-37c84e3eef8mr2214035f8f.21.1727193564543; Tue, 24 Sep 2024 08:59:24 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:84a5:f5c1:da9c:5ef]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e754c643csm160842915e9.45.2024.09.24.08.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 08:59:24 -0700 (PDT) From: Robert Pluim In-Reply-To: <86frppdys5.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Sep 2024 15:25:14 +0300") References: <87y13yle65.fsf@gmail.com> <86y13m6esa.fsf@mail.linkov.net> <87o74ihfce.fsf@gmail.com> <874j6ah4mi.fsf@gmail.com> <86setpd07a.fsf@mail.linkov.net> <87o74de6wm.fsf@gmail.com> <86frppdys5.fsf@gnu.org> Date: Tue, 24 Sep 2024 17:59:23 +0200 Message-ID: <877cb1dov8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 24 Sep 2024 15:25:14 +0300, Eli Zaretskii said: >> Cc: 73175@debbugs.gnu.org >> From: Robert Pluim >> Date: Tue, 24 Sep 2024 11:29:45 +0200 >>=20 >> Hmm, `buttonize-region' isn=CA=BCt in the elisp manual. I=CA=BCm ass= uming >> emacs-30 is still open for documentation changes Eli> Yes, thanks. OK. Done. I=CA=BCve just remembered that button.el can use either overlays or text properties to make buttons, so `unbuttonize-region' should look like this: (defun unbuttonize-region (start end) "Remove all the buttons between START and END. This removes both text-property and overlay based buttons." (dolist (o (overlays-in start end)) (when (overlay-get o 'button) (delete-overlay o))) (with-silent-modifications (remove-text-properties start end (button--properties nil nil nil)) (add-face-text-property start end 'button nil))) Robert --=20 From unknown Sat Aug 16 21:02:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Oct 2024 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 73175@debbugs.gnu.org Cc: Eli Zaretskii , juri@linkov.net Received: via spool by 73175-submit@debbugs.gnu.org id=B73175.17286419592634 (code B ref 73175); Fri, 11 Oct 2024 10:20:02 +0000 Received: (at 73175) by debbugs.gnu.org; 11 Oct 2024 10:19:19 +0000 Received: from localhost ([127.0.0.1]:33551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szCjv-0000gO-3L for submit@debbugs.gnu.org; Fri, 11 Oct 2024 06:19:19 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:42008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szCjr-0000g4-J6; Fri, 11 Oct 2024 06:19:17 -0400 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43115887867so12452165e9.0; Fri, 11 Oct 2024 03:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728641882; x=1729246682; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4TNcN5AU+5W2T4/g5zHIfMkYv1H9hvlgWNJFUNqsJIk=; b=mSIWxEJ+096sewnzYsnzAhd2H6LNaAJPxMDNBXUcKZSlu38V1oWO6FG4ZqVxSt5NUp 4FAlL+0KgLUbFPNW/WPlVIQOn7xLso5BySg8xf1sW5T2c74uLS6xpyhDEF8SHJFNLIqG Nlu7C7r28MTGKmcGolyN+IUk4A/Tvs2m47Psb34S5lHlN1ulwFUW9YqQD6FyPGNt9vmn J8eNhprhj6yoPhu4SPxegUgV7XBNgR6CfCkQ3uQkI+O0MhJz1YyJ7sQHhbwHWNyxFyuu f3LFM3xYbifUERtRv4+tkMlU+y38dFSag8SDQvGR0i5PizSV8hglE3jXXflpBIm+cMqR 7AGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728641882; x=1729246682; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4TNcN5AU+5W2T4/g5zHIfMkYv1H9hvlgWNJFUNqsJIk=; b=t19sGMsRbj3Tp4yYCVAMNzK2Xa0KNmaWC1HQsJLVqTQC3BaS0cFuYU/CgIygp8KM0p /XoBVd56WMB0WO84Tq9jKBbyEt52cHS8Yfv8vUtFkrUbZnKyxkMfMGLts+yzuuSZsPKb rqYFHqItLY+IbuhY6wNLhNLyqReNPRcv+pNpTior7ORkzGapUl5QryX46I1am4IfrANb x+n4JKrUOgCYiUkimaIRhqna88hpGE+dSaZsBxI2v2i4BTSaaQFsXqOjVG80cVM5TRsm ns2wPQ+wv/+qj55R9kz4h5ceYHLXvaQm93RhVGFkK3RaePral3omH6bnChQ/ztcxL9xs 94hA== X-Forwarded-Encrypted: i=1; AJvYcCU5j8NsYJNlVPQ6KACdofgfQfTfzdDno+LejMwKsOrrmOhktcnvqVQIB4YAWPQwyq4kqBMmiqdF@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxjua5LnxLAL1mWlaIiDDIJZYqYO8hNiLJuwK9EQrI17sdC10QH k9LyuesXlQFMxxLe5UwYIaHNVkedrSsdnKgy69Nty801UauqkzX2GpinFA== X-Google-Smtp-Source: AGHT+IGSOV+SqxZTBkzHt1mwJbrQNUWuABKIm/zgWE9mjWkvDmh500scrZt6RwtX3p7+u0vtD/iuCg== X-Received: by 2002:a05:600c:1911:b0:424:a7f1:ba2 with SMTP id 5b1f17b1804b1-43115af6051mr54245695e9.17.1728641881573; Fri, 11 Oct 2024 03:18:01 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:c129:aa1a:56de:131f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431182d7c56sm38338865e9.7.2024.10.11.03.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 03:18:00 -0700 (PDT) From: Robert Pluim In-Reply-To: <877cb1dov8.fsf@gmail.com> (Robert Pluim's message of "Tue, 24 Sep 2024 17:59:23 +0200") References: <87y13yle65.fsf@gmail.com> <86y13m6esa.fsf@mail.linkov.net> <87o74ihfce.fsf@gmail.com> <874j6ah4mi.fsf@gmail.com> <86setpd07a.fsf@mail.linkov.net> <87o74de6wm.fsf@gmail.com> <86frppdys5.fsf@gnu.org> <877cb1dov8.fsf@gmail.com> Date: Fri, 11 Oct 2024 12:18:00 +0200 Message-ID: <87wmift02v.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 73175 fixed close 73175 31.1 quit Closing. Committed as e631a3f3067 Robert --