GNU bug report logs - #73172
[PATCH] Move to start of current header in diff-{file,hunk}-prev

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Spencer Baugh <sbaugh <at> janestreet.com>, 73172 <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#73172: [PATCH] Move to start of current header in diff-{file,  hunk}-prev
Date: Fri, 13 Sep 2024 03:28:43 +0300

Hi Spencer and Stefan,

On 10/09/2024 21:40, Spencer Baugh via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:

> (The following change is split across two patches; the first one, "move
> easy-mmode", fixes an unrelated FIXME, which makes the diff in the
> second patch simpler)
> 
> If point was after a file or hunk header, the diff-file-prev and
> diff-hunk-prev commands would move to the start of that header.
> But if point was *within* the header, they would not move, and
> would report "No previous file" or "No previous hunk".  This
> differs from the behavior of most other movement commands,
> e.g. backward-sexp or backward-sentence.
> 
> This commit fixes diff-file-prev and diff-hunk-prev, as well as
> other easy-mmode-define-navigation BASE-prev commands.  Now
> these commands move to the start of the containing "thing" just
> like other movement commands.
> 
> * lisp/emacs-lisp/easy-mmode.el (easy-mmode--prev): Move to
> start of current match first.
> 
> Also discussed here:
> https://lists.gnu.org/archive/html/help-gnu-emacs/2024-08/msg00367.html

Patch#1 seems unequivocally a good thing (easier code iteration) and 
patch#2 seems good on balance.

It does introduce some backward incompatibility in rare cases where I 
have probably internalized the current behavior already -- for example 
in the vc-print-root-log output pressing 'p' while on the first line 
somewhere between the initial '*' and the end of the date dings with "No 
previous log message", and how will move to bol.

But it might be more consistent anyway, given that the there is no ding 
already if you start out inside the summary text.

There aren't many in-tree callers of easy-mmode-define-navigation 
(diff-mode, log-view, smerge and, uh, cvs-status), and few 3rd party 
callers, so this seems low-impact. diff-hl-mode is not affected either 
because it only uses diff-hunk-next, not diff-hunk-prev.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.