GNU bug report logs - #73168
[PATCH] gnu: bash-minimal: Add package description.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73168 in the body.
You can then email your comments to 73168 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Romain GARBAGE <romain.garbage <at> inria.fr>
To: guix-patches <at> gnu.org
Cc: ludovic.courtes <at> inria.fr, Romain GARBAGE <romain.garbage <at> inria.fr>
Subject: [PATCH] gnu: bash-minimal: Add package description.
Date: Tue, 10 Sep 2024 16:13:42 +0200

* gnu/packages/bash.scm (bash-minimal): Add package description.

Change-Id: I37da88d189f3a2d99aa8bcba5de3102909ae4761
---
 gnu/packages/bash.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
index 9ecec0a484..ad94c076bf 100644
--- a/gnu/packages/bash.scm
+++ b/gnu/packages/bash.scm
@@ -258,7 +258,9 @@ (define-public bash-minimal
        ((#:phases phases)
         `(modify-phases ,phases
            ;; No loadable modules.
-           (delete 'move-development-files)))))))
+           (delete 'move-development-files)))))
+    (description "This is a stripped-down version of the @code{bash} package for
+non-interactive use.")))
 
 (define-public static-bash
   ;; Statically-linked Bash that contains nothing but the 'bash' binary and

base-commit: 7f05b73d90f740c6a139f0e706b717d3174f6321
-- 
2.46.0

Message #8 received at 73168 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 73168 <at> debbugs.gnu.org
Cc: Romain GARBAGE <romain.garbage <at> inria.fr>
Subject: Re: [PATCH] gnu: bash-minimal: Add package description.
Date: Tue, 10 Sep 2024 11:22:14 -0500

Hi,

This should go to core-updates.

-- 
all the best,
jgart

Message #11 received at 73168 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
To: Romain GARBAGE <romain.garbage <at> inria.fr>
Cc: 73168 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: bash-minimal: Add package description.
Date: Thu, 12 Sep 2024 12:47:06 +0200

Hi Romain,

Romain GARBAGE <romain.garbage <at> inria.fr> skribis:

> * gnu/packages/bash.scm (bash-minimal): Add package description.
>
> Change-Id: I37da88d189f3a2d99aa8bcba5de3102909ae4761

[...]

> +    (description "This is a stripped-down version of the @code{bash} package for
> +non-interactive use.")))

Good initiative.  I would change the synopsis rather than the
description (this is what’s usually/often done for package variants),
like, say:

  (synopsis "The GNU Bourne-Again SHell, stripped down for non-interactive use")

WDYT?

Ludo’.

Message #14 received at 73168 <at> debbugs.gnu.org (full text, mbox):

From: Romain GARBAGE <romain.garbage <at> inria.fr>
To: 73168 <at> debbugs.gnu.org
Cc: ludovic.courtes <at> inria.fr, Romain GARBAGE <romain.garbage <at> inria.fr>
Subject: [PATCH v2] gnu: bash-minimal: Add package synopsis.
Date: Thu, 12 Sep 2024 12:54:58 +0200

* gnu/packages/bash.scm (bash-minimal): Add package synopsis.

Change-Id: I33f12547fca19d096712786a0c33525aa726b343
---
 gnu/packages/bash.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
index 9ecec0a484..93641a78d5 100644
--- a/gnu/packages/bash.scm
+++ b/gnu/packages/bash.scm
@@ -258,7 +258,8 @@ (define-public bash-minimal
        ((#:phases phases)
         `(modify-phases ,phases
            ;; No loadable modules.
-           (delete 'move-development-files)))))))
+           (delete 'move-development-files)))))
+    (synopsis "The GNU Bourne-Again SHell, stripped down for non-interactive use")))
 
 (define-public static-bash
   ;; Statically-linked Bash that contains nothing but the 'bash' binary and

base-commit: b6d5a7f5836739dab884b49a64ca354794dd845f
-- 
2.46.0

Message #19 received at 73168-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
To: Romain GARBAGE <romain.garbage <at> inria.fr>
Cc: 73168-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: bash-minimal: Add package synopsis.
Date: Thu, 12 Sep 2024 17:10:48 +0200

Romain GARBAGE <romain.garbage <at> inria.fr> skribis:

> * gnu/packages/bash.scm (bash-minimal): Add package synopsis.
>
> Change-Id: I33f12547fca19d096712786a0c33525aa726b343

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.