GNU bug report logs - #73155
ruby-net-smtp-0.3.3 fails to build

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73155 in the body.
You can then email your comments to 73155 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomás Ortín <tomasortin <at> mailbox.org>
To: bug-guix <at> gnu.org
Subject: ruby-net-smtp-0.3.3 fails to build
Date: Mon, 9 Sep 2024 20:49:25 +0200

`ruby-net-smtp` fails to build during the `check` phase, apparently due 
to an expired certificate. The certificate seems to be bundled with the 
package, so I suppose this means the package needs to be updated.

```
Error: test_enable_starttls(Net::TestSSLContext): 
OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 
peeraddr=empty-path-AF_UNIX-sockaddr state=error: certificate verify 
failed (certificate has expired)
```

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Tomás Ortín <tomasortin <at> mailbox.org>,
 Tomás Ortín via Bug reports for GNU Guix
 <bug-guix <at> gnu.org>, 73155 <at> debbugs.gnu.org
Subject: Re: bug#73155: ruby-net-smtp-0.3.3 fails to build
Date: Mon, 09 Sep 2024 19:41:40 +0000

Hi Tomás,

Unfortunately, updating the package to a version with a renewed certificate is not a solution.  It merely resets the same 'time bomb' to explode later down the road.  It's bad enough that nobody will be able to build a tested ruby-net-smtp <at> 0.3.3 again, at least until Linux can virtualise a wall clock.

Fortunately, it appears that upstream has since added the exact commands needed to regenerate the certificates: <https://github.com/ruby/net-smtp/blob/master/test/net/fixtures/Makefile>.  We can generate new ones at build time.

I only wonder whether openssl would stall on build machines with insufficient entropy available, or whether that's not an issue.

Kind regards,

T G-R

Sent on the go.  Excuse or enjoy my brevity.

Message #14 received at 73155 <at> debbugs.gnu.org (full text, mbox):

From: Javier Olaechea <pirata <at> gmail.com>
To: 73155 <at> debbugs.gnu.org
Subject: [PATCH] gnu: ruby-net-smtp: Fix tests
Date: Tue, 10 Sep 2024 22:35:05 +0000

[Message part 1 (text/plain, inline)]

Attached is a patch to fix the build by regenerating the certificates. Note
that a Makefile to update the certificates was introduced in the version
that updated the certificates. In those versions we can simplify the
before-check hook to be:

(with-directory "test/net/fixtures"
  (invoke "make" "regen_certificates"))

Another question, we are packaging a ~2 year old version. When updating the
version, should we drop the before-check lambda? Or should we keep it in
case someone wants to build ruby-net-smtp in the year 2034?

Cheers
-- 
"I object to doing things that computers can do." — Olin Shivers

[Message part 2 (text/html, inline)]

[0001-gnu-ruby-net-smtp-Fix-tests.patch (text/x-patch, attachment)]

Message #17 received at 73155 <at> debbugs.gnu.org (full text, mbox):

From: Javier Olaechea <pirata <at> gmail.com>
To: 73155 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: ruby-net-smtp: Fix tests
Date: Fri, 22 Nov 2024 19:33:38 +0000

[Message part 1 (text/plain, inline)]

Attached is a revised version of the patch following the feedback received
in the november Guix social meetup

-- 
"I object to doing things that computers can do." — Olin Shivers

[Message part 2 (text/html, inline)]

[v2-0001-gnu-ruby-net-smtp-Fix-tests.patch (text/x-patch, attachment)]

Message #22 received at 73155-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Javier Olaechea <pirata <at> gmail.com>
Cc: 73155-done <at> debbugs.gnu.org
Subject: Re: bug#73155: [PATCH v2] gnu: ruby-net-smtp: Fix tests
Date: Fri, 22 Nov 2024 22:00:14 +0000

[Message part 1 (text/plain, inline)]

Javier Olaechea <pirata <at> gmail.com> writes:

> Attached is a revised version of the patch following the feedback received in the november Guix social meetup

Thanks, I've pushed this to master as
eabdad1ad5144487a1606fb35afa11c1bb6dc720.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.