GNU bug report logs - #73135
[PATCH] Enable parallel tests for GTK

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73135 in the body.
You can then email your comments to 73135 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: The Man <squishypinkelephant <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Enable parallel tests for GTK
Date: Sun, 8 Sep 2024 19:55:10 -0500

[Message part 1 (text/plain, inline)]

In the middle of testing a set of patches that caused a large number of
rebuilds, I noticed the gtk package was taking an obscenely long time to
run checks. Upon inspection I found out it was not running tests as
parallel.
For example, https://ci.guix.gnu.org/build/5623913/details took >3000!
seconds.
The fix is obvious and will save time on future rebuilds.

[Message part 2 (text/html, inline)]

[gtk-parallel-test.patch (text/x-patch, attachment)]

Message #8 received at 73135 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: The Man <squishypinkelephant <at> gmail.com>
Cc: 73135 <at> debbugs.gnu.org
Subject: Re: [bug#73135] [PATCH] Enable parallel tests for GTK
Date: Fri, 04 Oct 2024 17:14:51 +0200

Hi,

The Man <squishypinkelephant <at> gmail.com> skribis:

> In the middle of testing a set of patches that caused a large number of
> rebuilds, I noticed the gtk package was taking an obscenely long time to
> run checks. Upon inspection I found out it was not running tests as
> parallel.
> For example, https://ci.guix.gnu.org/build/5623913/details took >3000!
> seconds.
> The fix is obvious and will save time on future rebuilds.
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index 3d4766713d..f0f6a0cd9a 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -1195,6 +1195,7 @@ (define-public gtk
>                                          (string=? (%current-system) "aarch64-linux"))
>                                     "--no-suite=wayland_gles2_failing"
>                                     "--no-suite=wayland_gles_failing"))
> +      #:parallel-tests? #t

I wonder why #:parallel-tests? defaults to #f in ‘meson-build-system’,
contrary to what other build systems do.

I think we should create a branch where we change it to #t, and merge it
once we’re done rebuilding all the packages and fixing any relevant
failure.

Would you like to give that a try?

Thanks,
Ludo’.

Message #11 received at 73135 <at> debbugs.gnu.org (full text, mbox):

From: The Man <squishypinkelephant <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 73135 <at> debbugs.gnu.org
Subject: Re: [bug#73135] [PATCH] Enable parallel tests for GTK
Date: Fri, 4 Oct 2024 11:05:33 -0500

[Message part 1 (text/plain, inline)]

Sounds like a good idea to me.

On Fri, Oct 4, 2024, 10:14 AM Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi,
>
> The Man <squishypinkelephant <at> gmail.com> skribis:
>
> > In the middle of testing a set of patches that caused a large number of
> > rebuilds, I noticed the gtk package was taking an obscenely long time to
> > run checks. Upon inspection I found out it was not running tests as
> > parallel.
> > For example, https://ci.guix.gnu.org/build/5623913/details took >3000!
> > seconds.
> > The fix is obvious and will save time on future rebuilds.
> > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> > index 3d4766713d..f0f6a0cd9a 100644
> > --- a/gnu/packages/gtk.scm
> > +++ b/gnu/packages/gtk.scm
> > @@ -1195,6 +1195,7 @@ (define-public gtk
> >                                          (string=? (%current-system)
> "aarch64-linux"))
> >                                     "--no-suite=wayland_gles2_failing"
> >                                     "--no-suite=wayland_gles_failing"))
> > +      #:parallel-tests? #t
>
> I wonder why #:parallel-tests? defaults to #f in ‘meson-build-system’,
> contrary to what other build systems do.
>
> I think we should create a branch where we change it to #t, and merge it
> once we’re done rebuilding all the packages and fixing any relevant
> failure.
>
> Would you like to give that a try?
>
> Thanks,
> Ludo’.
>

[Message part 2 (text/html, inline)]

Message #14 received at 73135 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: The Man <squishypinkelephant <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 73135 <at> debbugs.gnu.org
Subject: Re: [bug#73135] [PATCH] Enable parallel tests for GTK
Date: Sat, 05 Oct 2024 21:36:54 +0900

Hi,

The Man <squishypinkelephant <at> gmail.com> writes:

> Sounds like a good idea to me.

Implemented!  See: https://ci.guix.gnu.org/jobset/meson-parallel-tests

It hasn't started building anything yet (it's buildin guix at that
revision for now).

There's an RSS feed to keep track of it:
https://ci.guix.gnu.org/events/rss/?specification=meson-parallel-tests

-- 
Thanks,
Maxim

Message #19 received at 73135-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: The Man <squishypinkelephant <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 73135-done <at> debbugs.gnu.org
Subject: Re: [bug#73135] [PATCH] Enable parallel tests for GTK
Date: Sat, 12 Oct 2024 14:34:13 +0900

Hello,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi,
>
> The Man <squishypinkelephant <at> gmail.com> writes:
>
>> Sounds like a good idea to me.
>
> Implemented!  See: https://ci.guix.gnu.org/jobset/meson-parallel-tests
>
> It hasn't started building anything yet (it's buildin guix at that
> revision for now).
>
> There's an RSS feed to keep track of it:
> https://ci.guix.gnu.org/events/rss/?specification=meson-parallel-tests

No issues whatsoever found:
https://ci.guix.gnu.org/jobset/meson-parallel-tests

Will prepare the branch merge request and close this one.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.