GNU bug report logs - #73128
[PATCH gnome-team 00/12] Mini update dump

Previous Next

Full log

Message #47 received at 73128 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: vivien <at> planete-kraus.eu, 73128 <at> debbugs.gnu.org
Subject: Re: [bug#73128] [PATCH gnome-team 07/12] gnu: Add libei.
Date: Wed, 11 Sep 2024 14:47:55 +0900

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/freedesktop.scm (libei): New variable.
>
> Co-authored-by: Vivien Kraus <vivien <at> planete-kraus.eu>

[...]

> +(define-public libei
> +  (package
> +    (name "libei")
> +    (version "1.3.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.freedesktop.org/libinput/libei.git")
> +                    (commit version)))
> +              (sha256
> +               (base32
> +                "0idbl20ax060s7m435rszfv7c0bvpinjvq45qbqwvcvp0hg8r9y8"))
> +              (snippet
> +               #~(begin
> +                   (use-modules (guix build utils))
> +                   (substitute* "test/meson.build"
> +                     (("subproject\\('munit'")
> +                      "# subproject('munit'")
> +                     ((", fallback: \\['munit', 'munit_dep'\\]")
> +                      ""))
> +                   (delete-file-recursively "subprojects")))))

What is the above snippet for?  A comment would be great.

> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:configure-flags #~'("-Ddocumentation=api" ;protocol requires hugo
> +                            "-Dsd-bus-provider=libelogind")))
> +    (inputs
> +     (list elogind libevdev libxkbcommon))
> +    (propagated-inputs
> +     ;; liboeffis-1.0.pc requires.private libelogind
> +     (list elogind))
> +    (native-inputs
> +     (list doxygen libxml2 munit pkg-config python python-attrs python-black python-dbusmock python-jinja2 python-pytest python-structlog valgrind/interactive))

160 chars is a tad long for our 80 columns maximum width convention :-).

> +    (home-page "https://libinput.pages.freedesktop.org/libei/")
> +    (synopsis "Emulated Input protocol implementation")
> +    (description
> +     "Libei provides a client and server implementation of the @acronym{EI,Emulated

I think you can safely add a space after the comma, for extra
readability (and allowing M-q to break tE long line).

Otherwise, LGTM.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.