Subject: [bug#73128] [PATCH gnome-team 06/12] gnu: Add munit.

From: Maxim Cournoyer <[email-masked]>
Date: Wed, 11 Sep 2024 14:33:08 +0900

Hi,

Vivien Kraus <[email-masked]> writes:

> * gnu/packages/check.scm (munit): New variable.
>
> Change-Id: I193e55ef4ceec1d62f595dd779f7b3d76154fad4
> ---
>  gnu/packages/check.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index 248d1c4231..d689bc5abe 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -4206,3 +4206,34 @@ (define-public subunit
>  command line filters to process a subunit stream and language bindings for
>  Python, C, C++ and shell.  Bindings are easy to write for other languages.")
>      (license (list license:asl2.0 license:bsd-3)))) ;user can pick
> +
> +(define-public munit
> +  (package
> +    (name "munit")
> +    ;; No release for years, https://github.com/nemequ/munit/issues/95

Nitpick, but I'd fully punctuate that standalone comment, like:

       ;; No release for years (see:
       ;; https://github.com/nemequ/munit/issues/95).
          
> +    (version "0.2.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/nemequ/munit")
> +                    (commit "fbbdf1467eb0d04a6ee465def2e529e4c87f2118")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "13725v4pps2bpndniksa58nqi9gvx0f0900k0rqvp95bxw5z8vda"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'fix-installability
> +            ;; See https://github.com/nemequ/munit/pull/67

I'd give a bit more context in the comment, and reference the upstream
issue URL as I did above.

> +            (lambda _
> +              (substitute* "meson.build"
> +                (("install: meson.is_subproject\\(\\)")
> +                 "install: not meson.is_subproject()")))))))
> +    (synopsis "Small unit testing framework for C")
> +    (description
> +     "µnit is a small testing framework for C.")

Some extra description would be welcome; right now it doesn't add
anything to the synopsis. What kind of features does it provided, for
example? Hopefully the home page of the project has more to say about
it.

Could you please send a v2?

-- 
Thanks,
Maxim