GNU bug report logs - #731
23.0.60; Varying point position after undo

Previous Next

Package: emacs;

Reported by: Markus Triska <markus.triska <at> gmx.at>

Date: Sat, 16 Aug 2008 17:05:07 UTC

Severity: normal

Done: martin rudalics <rudalics <at> gmx.at>

Bug is archived. No further changes may be made.

Full log

Message #50 received at 731 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 731 <at> debbugs.gnu.org, Markus Triska <markus.triska <at> gmx.at>,
        cyd <at> MIT.EDU
Subject: Re: bug#731: 23.0.60; Varying point position after undo
Date: Mon, 22 Sep 2008 17:59:14 +0200

> Hmm.. the comment seems to say that calling it is just redundant,
> whereas this thread shows that it can actually be harmful.
> Could you improve the comment so as to explain why it's harmful?

I checked it in with a slightly more accurate comment.  IMHO, however,
last_boundary_buffer and last_boundary_position should be documented
better.  In particular, I don't understand the comment near the end of
record_point saying

  /* If we are just after an undo boundary, and
     point wasn't at start of deleted range, record where it was.  */

BTW, why isn't there a separate last_boundary_position for each buffer?

martin
This bug report was last modified 16 years and 323 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.