From triska@gmx.at Sat Aug 16 09:59:17 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.5 required=4.0 tests=AWL,BAYES_00,FOURLA, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 16 Aug 2008 16:59:17 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7GGxDsp029257 for ; Sat, 16 Aug 2008 09:59:15 -0700 Received: from mx10.gnu.org ([199.232.76.166]:39605) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KUP6E-0008Kh-Fu for emacs-pretest-bug@gnu.org; Sat, 16 Aug 2008 12:57:58 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KUP7M-0002HL-H6 for emacs-pretest-bug@gnu.org; Sat, 16 Aug 2008 12:59:12 -0400 Received: from mail.gmx.net ([213.165.64.20]:33377) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KUP7L-0002Gx-R5 for emacs-pretest-bug@gnu.org; Sat, 16 Aug 2008 12:59:08 -0400 Received: (qmail invoked by alias); 16 Aug 2008 16:59:06 -0000 Received: from chello062178240212.3.14.tuwien.teleweb.at (EHLO mt-computer.local) [62.178.240.212] by mail.gmx.net (mp032) with SMTP; 16 Aug 2008 18:59:06 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX190+XZPgXJ0RQTwZhbU+wK7VlAJcQn6WGv9474/oo ZGjXXELfd77xrD Received: by mt-computer.local (Postfix, from userid 502) id 644A7A32727; Sat, 16 Aug 2008 18:59:05 +0200 (CEST) From: Markus Triska To: emacs-pretest-bug@gnu.org Subject: 23.0.60; Varying point position after undo Message-Id: <20080816165905.644A7A32727@mt-computer.local> Date: Sat, 16 Aug 2008 18:59:05 +0200 (CEST) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.54 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) When you put the following two forms in undo1.el: (progn (goto-char (point-max)) (insert "test line\n")) (defun mytest () (message "hi")) then do "$ emacs -Q undo1.el", place point after the first form, press C-x C-e then C-_, point is placed at the original end of buffer. In contrast, every further time you do the same, point is placed at the end of the second form after the insertion is undone. When you then switch to the *scratch* buffer and then switch back and do the same, point is again placed at the original end of the buffer exactly the first time you do it, and placed at the other spot every further time. I find it desirable that point position after undo become more predictable in this case. I have also seen cases where point after undo is completely misplaced (i.e., neither at the place where point originally was, nor where the inserted text started), though I cannot yet reproduce it reliably. In GNU Emacs 23.0.60.1 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9) of 2008-08-15 on mt-computer.local Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en.UTF-8 value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t From cyd@MIT.EDU Thu Sep 18 20:26:58 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.0 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 19 Sep 2008 03:26:58 +0000 Received: from south-station-annex.mit.edu (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8J3QsJN016910 for <731@emacsbugs.donarmstrong.com>; Thu, 18 Sep 2008 20:26:56 -0700 Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id m8J3QnaO000385; Thu, 18 Sep 2008 23:26:49 -0400 (EDT) Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id m8J3QeeR022699; Thu, 18 Sep 2008 23:26:42 -0400 (EDT) Received: from w92-130-webmail-2.mit.edu (WEBMAIL-SNAT.MIT.EDU [18.7.22.108]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id m8J3QbwI001271; Thu, 18 Sep 2008 23:26:37 -0400 (EDT) Received: (from nobody@localhost) by w92-130-webmail-2.mit.edu (8.12.4) id m8J3Qb2r008527; Thu, 18 Sep 2008 23:26:37 -0400 Received: from c-24-63-201-57.hsd1.ma.comcast.net (c-24-63-201-57.hsd1.ma.comcast.net [24.63.201.57]) (User authenticated as cyd@ATHENA.MIT.EDU) by webmail.mit.edu (Horde MIME library) with HTTP; Thu, 18 Sep 2008 23:26:37 -0400 Message-ID: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> Date: Thu, 18 Sep 2008 23:26:37 -0400 From: cyd@MIT.EDU To: Markus Triska Cc: 731@debbugs.gnu.org Subject: Re: 23.0.60; Varying point position after undo MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) X-Scanned-By: MIMEDefang 2.42 > When you put the following two forms in undo1.el: > > (progn > (goto-char (point-max)) > (insert "test line\n")) > > (defun mytest () > (message "hi")) > > then do "$ emacs -Q undo1.el", place point after the first form, press > C-x C-e then C-_, point is placed at the original end of buffer. In > contrast, every further time you do the same, point is placed at the > end of the second form after the insertion is undone. I can't reproduce this with latest CVS. Do you still see this problem? From markus.triska@gmx.at Thu Sep 18 21:31:59 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.6 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 19 Sep 2008 04:31:59 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8J4Vt6v009043 for <731@emacsbugs.donarmstrong.com>; Thu, 18 Sep 2008 21:31:56 -0700 Received: (qmail invoked by alias); 19 Sep 2008 04:31:49 -0000 Received: from chello062178240212.3.14.tuwien.teleweb.at (EHLO mt-computer.local) [62.178.240.212] by mail.gmx.net (mp034) with SMTP; 19 Sep 2008 06:31:49 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX1/tABARWKDt0O9lIkWvTFvpsfLVb07YeO1UXHJXWL ghU5YDMEEsYXup Received: by mt-computer.local (Postfix, from userid 502) id E4359AEAE94; Fri, 19 Sep 2008 06:31:47 +0200 (CEST) From: Markus Triska To: cyd@MIT.EDU Cc: 731@debbugs.gnu.org Subject: Re: 23.0.60; Varying point position after undo References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> Date: Fri, 19 Sep 2008 06:31:47 +0200 In-Reply-To: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> (cyd@mit.edu's message of "Thu, 18 Sep 2008 23:26:37 -0400") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.65 cyd@MIT.EDU writes: > Do you still see this problem? Yes; it also works if I place point anywhere within the first top-level form and then press C-M-x, followed by C-_. The first time I do that, point is moved to the original end of buffer, i.e., after the second form. Every further time, point isn't moved, until I visit a different buffer. I can reproduce this with today's Emacs 23 CVS on OSX 10.4 and Ubuntu Intrepid. Emacs 22.2 never moves point on both systems. undo1.el is also available from: http://www.logic.at/prolog/undo1.el As mentioned, the file must be specified on the command line - opening it with C-x C-f and then doing the above does not move point. However, you can open undo1.el with C-x C-f, then do C-x b, switch to *scratch*, then return to undo1.el. If you then do C-M-x C-_, point should move. From rudalics@gmx.at Fri Sep 19 01:45:36 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 19 Sep 2008 08:45:37 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8J8jXfD001609 for <731@emacsbugs.donarmstrong.com>; Fri, 19 Sep 2008 01:45:34 -0700 Received: (qmail invoked by alias); 19 Sep 2008 08:45:24 -0000 Received: from 62-47-44-24.adsl.highway.telekom.at (EHLO [62.47.44.24]) [62.47.44.24] by mail.gmx.net (mp007) with SMTP; 19 Sep 2008 10:45:24 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/wXQgi0ynwgWpC9ibJEpMDzh0Wo/JGlme7gLyBGg zqe/6ctboVAlDM Message-ID: <48D36604.7020702@gmx.at> Date: Fri, 19 Sep 2008 10:42:44 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Markus Triska , 731@debbugs.gnu.org CC: cyd@MIT.EDU Subject: Re: bug#731: 23.0.60; Varying point position after undo References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.82 > As mentioned, the file must be specified on the command line - opening > it with C-x C-f and then doing the above does not move point. However, > you can open undo1.el with C-x C-f, then do C-x b, switch to *scratch*, > then return to undo1.el. If you then do C-M-x C-_, point should move. So the initial values of `buffer-undo-list' differ wrt when you open the file via the command line or `find-file'. Can you tell us how? martin From markus.triska@gmx.at Fri Sep 19 06:23:38 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 19 Sep 2008 13:23:38 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8JDNYFm002575 for <731@emacsbugs.donarmstrong.com>; Fri, 19 Sep 2008 06:23:35 -0700 Received: (qmail invoked by alias); 19 Sep 2008 13:23:28 -0000 Received: from chello062178240212.3.14.tuwien.teleweb.at (EHLO mt-computer.local) [62.178.240.212] by mail.gmx.net (mp013) with SMTP; 19 Sep 2008 15:23:28 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX192/Awi7412hNMkasgyC814GC2o+xT2vSMI8402aK UGuu9FgdIKpILC Received: by mt-computer.local (Postfix, from userid 502) id 19031AEB20F; Fri, 19 Sep 2008 15:23:25 +0200 (CEST) From: Markus Triska To: martin rudalics Cc: 731@debbugs.gnu.org, cyd@MIT.EDU Subject: Re: bug#731: 23.0.60; Varying point position after undo References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> Date: Fri, 19 Sep 2008 15:23:24 +0200 In-Reply-To: <48D36604.7020702@gmx.at> (martin rudalics's message of "Fri, 19 Sep 2008 10:42:44 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.68 martin rudalics writes: > So the initial values of `buffer-undo-list' differ wrt when you open the > file via the command line or `find-file'. Can you tell us how? buffer-undo-list is initially nil regardless of how I open the file. When I open the file from the command line and then press C-M-x on the first form, `buffer-undo-list' is with CVS trunk: (nil (96 . 106) (t 18643 . 10108)) whereas with Emacs 22.2, it is: (nil (96 . 106) 1 (t 18643 . 10108)) Starting anew with CVS trunk, after I do C-M-x C-_ M-< C-M-x, it is: (nil (96 . 106) 1 (t 18643 . 10108) nil (#("test line\n" 0 10 (fontified t)) . 96) nil (96 . 106) (t 18643 . 10108)) When I do the same with Emacs 22.2, it is: (nil (96 . 106) 1 (t 18643 . 10108) nil (#("test line\n" 0 10 (fontified t)) . 96) nil (96 . 106) 1 (t 18643 . 10108)) With CVS trunk, when I open the file with C-x C-f and do C-M-x, it is: (nil (96 . 106) 1 (t 18643 . 10108)) From rudalics@gmx.at Sun Sep 21 05:01:30 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.4 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MIXEDBDN,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 21 Sep 2008 12:01:31 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8LC1QAF029682 for <731@emacsbugs.donarmstrong.com>; Sun, 21 Sep 2008 05:01:28 -0700 Received: (qmail invoked by alias); 21 Sep 2008 12:01:20 -0000 Received: from 88-117-42-206.adsl.highway.telekom.at (EHLO [88.117.42.206]) [88.117.42.206] by mail.gmx.net (mp019) with SMTP; 21 Sep 2008 14:01:20 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+XFDkYrzCXmAG5Wqhg0WUVbPwfhz8A7ucOWM/3qd rmeYOOpO5ZUjM5 Message-ID: <48D636ED.3020103@gmx.at> Date: Sun, 21 Sep 2008 13:58:37 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Markus Triska CC: 731@debbugs.gnu.org, cyd@MIT.EDU Subject: Re: bug#731: 23.0.60; Varying point position after undo References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> In-Reply-To: Content-Type: multipart/mixed; boundary="------------050006030101010109010606" X-Y-GMX-Trusted: 0 X-FuHaFi: 0.72,0.62 This is a multi-part message in MIME format. --------------050006030101010109010606 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > buffer-undo-list is initially nil regardless of how I open the file. > When I open the file from the command line and then press C-M-x on the > first form, `buffer-undo-list' is with CVS trunk: > > (nil > (96 . 106) > (t 18643 . 10108)) > > whereas with Emacs 22.2, it is: > > (nil > (96 . 106) > 1 > (t 18643 . 10108)) Hmmm... Can you try the attached patch? martin --------------050006030101010109010606 Content-Type: text/plain; name="731.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="731.diff" *** undo.c.~1.85.~ 2008-05-14 09:49:54.000000000 +0200 --- undo.c 2008-09-21 13:44:44.468750000 +0200 *************** *** 79,85 **** if (NILP (pending_boundary)) pending_boundary = Fcons (Qnil, Qnil); ! if (current_buffer != last_undo_buffer) Fundo_boundary (); last_undo_buffer = current_buffer; --- 79,88 ---- if (NILP (pending_boundary)) pending_boundary = Fcons (Qnil, Qnil); ! if ((current_buffer != last_undo_buffer) ! /* Don't make an undo boundary when record_first_change will do it ! anyway. */ ! && (MODIFF > SAVE_MODIFF)) Fundo_boundary (); last_undo_buffer = current_buffer; --------------050006030101010109010606-- From markus.triska@gmx.at Sun Sep 21 05:31:48 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 21 Sep 2008 12:31:49 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8LCViB7008509 for <731@emacsbugs.donarmstrong.com>; Sun, 21 Sep 2008 05:31:46 -0700 Received: (qmail invoked by alias); 21 Sep 2008 12:31:39 -0000 Received: from chello062178240212.3.14.tuwien.teleweb.at (EHLO mt-computer.local) [62.178.240.212] by mail.gmx.net (mp022) with SMTP; 21 Sep 2008 14:31:39 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX18Dki5ZxgoDlh83lPBUOE0P1CyvrMCVLpsFEJ1ev1 nWAERMTmzmAEiJ Received: by mt-computer.local (Postfix, from userid 502) id 1EE3FAF5893; Sun, 21 Sep 2008 14:31:35 +0200 (CEST) From: Markus Triska To: martin rudalics Cc: 731@debbugs.gnu.org, cyd@MIT.EDU Subject: Re: bug#731: 23.0.60; Varying point position after undo References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> <48D636ED.3020103@gmx.at> Date: Sun, 21 Sep 2008 14:31:35 +0200 In-Reply-To: <48D636ED.3020103@gmx.at> (martin rudalics's message of "Sun, 21 Sep 2008 13:58:37 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.8100000000000001 martin rudalics writes: > Hmmm... Can you try the attached patch? It fixes this problem for me, thank you! From monnier@iro.umontreal.ca Sun Sep 21 12:30:17 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 21 Sep 2008 19:30:17 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8LJUB3k031006 for <731@emacsbugs.donarmstrong.com>; Sun, 21 Sep 2008 12:30:15 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjkGAA4+1kjO+KDT/2dsb2JhbACBXbJ3gWaBBA X-IronPort-AV: E=Sophos;i="4.32,441,1217822400"; d="scan'208";a="27198933" Received: from 206-248-160-211.dsl.teksavvy.com (HELO ceviche.home) ([206.248.160.211]) by ironport2-out.teksavvy.com with ESMTP; 21 Sep 2008 15:30:04 -0400 Received: by ceviche.home (Postfix, from userid 20848) id BC86EB40B1; Sun, 21 Sep 2008 15:30:04 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 731@debbugs.gnu.org, Markus Triska , cyd@MIT.EDU Subject: Re: bug#731: 23.0.60; Varying point position after undo Message-ID: References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> <48D636ED.3020103@gmx.at> Date: Sun, 21 Sep 2008 15:30:04 -0400 In-Reply-To: <48D636ED.3020103@gmx.at> (martin rudalics's message of "Sun, 21 Sep 2008 13:58:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > ! if ((current_buffer != last_undo_buffer) > ! /* Don't make an undo boundary when record_first_change will do it > ! anyway. */ > ! && (MODIFF > SAVE_MODIFF)) Hmm.. the comment seems to say that calling it is just redundant, whereas this thread shows that it can actually be harmful. Could you improve the comment so as to explain why it's harmful? Stefan From monnier@IRO.UMontreal.CA Mon Sep 22 21:23:00 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.3 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 23 Sep 2008 04:23:00 +0000 Received: from harpie.CC.UMontreal.CA (harpie.cc.umontreal.ca [132.204.2.134]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8N4Msst009585 for <731@emacsbugs.donarmstrong.com>; Mon, 22 Sep 2008 21:22:58 -0700 Received: from alfajor.home (vpn-132-204-232-65.acd.umontreal.ca [132.204.232.65]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m8MHfBLp020127; Mon, 22 Sep 2008 13:41:11 -0400 Received: by alfajor.home (Postfix, from userid 20848) id B52121C133; Mon, 22 Sep 2008 13:40:40 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 731@debbugs.gnu.org, Markus Triska , cyd@MIT.EDU Subject: Re: bug#731: 23.0.60; Varying point position after undo Message-ID: References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> <48D636ED.3020103@gmx.at> <48D7C0D2.7030804@gmx.at> Date: Mon, 22 Sep 2008 13:40:40 -0400 In-Reply-To: <48D7C0D2.7030804@gmx.at> (martin rudalics's message of "Mon, 22 Sep 2008 17:59:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3109=0 > I checked it in with a slightly more accurate comment. IMHO, however, Thank you. > last_boundary_buffer and last_boundary_position should be documented > better. In particular, I don't understand the comment near the end of > record_point saying > /* If we are just after an undo boundary, and > point wasn't at start of deleted range, record where it was. */ > BTW, why isn't there a separate last_boundary_position for each buffer? Maybe Richard knows a bit more, but I suspect, nobody knows. Stefan From rudalics@gmx.at Mon Sep 22 22:28:51 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731) by emacsbugs.donarmstrong.com; 23 Sep 2008 05:28:51 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8N5Slfk027065 for <731@emacsbugs.donarmstrong.com>; Mon, 22 Sep 2008 22:28:49 -0700 Received: (qmail invoked by alias); 22 Sep 2008 16:02:00 -0000 Received: from 62-47-50-128.adsl.highway.telekom.at (EHLO [62.47.50.128]) [62.47.50.128] by mail.gmx.net (mp015) with SMTP; 22 Sep 2008 18:02:00 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX188sQI6txE8EbA2xBMb6VJgpjHH3oMSURB+CkJmoo PhxzUAKLl7yoEk Message-ID: <48D7C0D2.7030804@gmx.at> Date: Mon, 22 Sep 2008 17:59:14 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Stefan Monnier CC: 731@debbugs.gnu.org, Markus Triska , cyd@MIT.EDU Subject: Re: bug#731: 23.0.60; Varying point position after undo References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> <48D636ED.3020103@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.78 > Hmm.. the comment seems to say that calling it is just redundant, > whereas this thread shows that it can actually be harmful. > Could you improve the comment so as to explain why it's harmful? I checked it in with a slightly more accurate comment. IMHO, however, last_boundary_buffer and last_boundary_position should be documented better. In particular, I don't understand the comment near the end of record_point saying /* If we are just after an undo boundary, and point wasn't at start of deleted range, record where it was. */ BTW, why isn't there a separate last_boundary_position for each buffer? martin From rudalics@gmx.at Mon Sep 22 23:36:26 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 731-done) by emacsbugs.donarmstrong.com; 23 Sep 2008 06:36:26 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8N6aMfU012408 for <731-done@emacsbugs.donarmstrong.com>; Mon, 22 Sep 2008 23:36:24 -0700 Received: (qmail invoked by alias); 23 Sep 2008 06:36:17 -0000 Received: from 62-47-58-101.adsl.highway.telekom.at (EHLO [62.47.58.101]) [62.47.58.101] by mail.gmx.net (mp052) with SMTP; 23 Sep 2008 08:36:17 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18N2sZ5dA4NNvQHSM93ZdLcYyEzbE8WNnxoEO/iR+ c4FiNVYP7wMmQr Message-ID: <48D88DBB.2080905@gmx.at> Date: Tue, 23 Sep 2008 08:33:31 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Stefan Monnier CC: 731-done@debbugs.gnu.org, Markus Triska , cyd@MIT.EDU Subject: Re: bug#731: 23.0.60; Varying point position after undo References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> <48D636ED.3020103@gmx.at> <48D7C0D2.7030804@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.73 Fixed as 2008-09-22 Martin Rudalics * undo.c (record_point): Don't call Fundo_boundary for first change. (Bug#731) martin From unknown Fri Sep 05 14:00:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Tue, 21 Oct 2008 14:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator