GNU bug report logs - #73094
[PATCH 00/10] Add python-safetensors

Previous Next

Full log

Message #40 received at 73094 <at> debbugs.gnu.org (full text, mbox):

From: Herman Rimm <herman <at> rimm.ee>
To: 73094 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 00/10] Add python-safetensors
Date: Sun, 8 Sep 2024 14:46:14 +0200

Hello Nicholas,

python-safetensors builds fine.  Can you reduce the indentation of the
snippet, and remove the (let ((file-path "Cargo.toml")) in arguments?

I think the development-inputs for rust-darling are up to date, so for
patch #3 you could try:

-     `(#:skip-build? #t
+     `(#:cargo-development-inputs
+       (("rust-proc-macro2" ,rust-proc-macro2-1)
+        ("rust-quote" ,rust-quote-1)
+        ("rust-rustversion" ,rust-rustversion-1)
+        ("rust-syn" ,rust-syn-2)
+        ("rust-trybuild" ,rust-trybuild-1))

Also try enabling the build for patches #1 and #2.  The other patches
look OK.

Cheers,
Herman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.