GNU bug report logs - #73094
[PATCH 00/10] Add python-safetensors

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Sat, 7 Sep 2024 09:39:01 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Herman Rimm <herman <at> rimm.ee>
To: 73094 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [bug#73094] [PATCH 00/10] Add python-safetensors
Date: Sun, 8 Sep 2024 14:46:14 +0200

Hello Nicholas,

python-safetensors builds fine.  Can you reduce the indentation of the
snippet, and remove the (let ((file-path "Cargo.toml")) in arguments?

I think the development-inputs for rust-darling are up to date, so for
patch #3 you could try:

-     `(#:skip-build? #t
+     `(#:cargo-development-inputs
+       (("rust-proc-macro2" ,rust-proc-macro2-1)
+        ("rust-quote" ,rust-quote-1)
+        ("rust-rustversion" ,rust-rustversion-1)
+        ("rust-syn" ,rust-syn-2)
+        ("rust-trybuild" ,rust-trybuild-1))

Also try enabling the build for patches #1 and #2.  The other patches
look OK.

Cheers,
Herman
This bug report was last modified 136 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.