GNU bug report logs - #73073
[PATCH 0/6] Allow origin with label as inputs.

Previous Next

Full log

View this message in rfc822 format

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, Vivien Kraus <vivien <at> planete-kraus.eu>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 73073 <at> debbugs.gnu.org
Subject: [bug#73073] [PATCH v3 2/8] gnu: gnome-recipes: Move libgd origin from phases to native-inputs.
Date: Thu, 12 Dec 2024 23:34:22 +0100

Hi,

On Thu, 12 Dec 2024 at 23:18, Liliana Marie Prikler <liliana.prikler <at> gmail.com> wrote:

>> > > +                           (file-name (git-file-name "libgd" version))
>> >
>> > Not sure what the state of this is here, but again noting that
>> > "version" has no meaning in the libgd input and "checkout" would be
>> > more honest.
>>
>> You’re right, though packages do have a ‘version’ field; use of
>> ‘git-file-name’ here follows established convention in Guix.
>
> Does it?  Assume libfoo 3.0 and libbar 0.1.0 pull in the same libgd.
> What happens?

Not sure it really matter since it’s a fixed output.  The item reads:

    /gnu/store/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-libgd-YYYY

where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is determined by the SHA256
checksum.  Therefore, YYYY can be anything, it does not really matter.

At worse, the item is downloaded several times, say by libfoo 3.0 and
libbar 0.1.0.

All in all, I agree that the best solution here is simply:

    (file-name "libgd-checkout")

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.