Subject: Re: [bug#73073] [PATCH v3 2/8] gnu: gnome-recipes: Move libgd origin from phases to native-inputs.

From: Ludovic Courtès <[email-masked]>
Date: Thu, 12 Dec 2024 12:27:37 +0100

Hi Liliana,

Liliana Marie Prikler <[email-masked]> skribis:

> Am Mittwoch, dem 04.12.2024 um 18:54 +0100 schrieb Ludovic Courtès:
>> From: Simon Tournier <[email-masked]>
>> 
>> * gnu/packages/dlang.scm (gnome-recipes)[arguments]<phases>: Move
>> libgd
>> origin from here...
>> [native-inputs]: ...to here.

[...]

>> +               #$(this-package-native-input (git-file-name "libgd"
>> version))
>>                 "subprojects/libgd"))))))
>>      (inputs (list glib
>>                    gnome-autoar
>> @@ -821,6 +813,15 @@ (define-public gnome-recipes
>>      (native-inputs (list desktop-file-utils ;for update-desktop-
>> database
>>                           gettext-minimal
>>                           `(,glib "bin")
>> +                         (origin
>> +                           (method git-fetch)
>> +                           (uri (git-reference
>> +                                 (url
>> "https://gitlab.gnome.org/GNOME/libgd")
>> +                                 (commit
>> "c7c7ff4e05d3fe82854219091cf116cce6b19de0")))
>> +                           (file-name (git-file-name "libgd"
>> version))
>> +                           (sha256
>> +                            (base32
>> +                            
> Not sure what the state of this is here, but again noting that
> "version" has no meaning in the libgd input and "checkout" would be
> more honest.

You’re right, though packages do have a ‘version’ field; use of
‘git-file-name’ here follows established convention in Guix.

Thanks,
Ludo’.