Subject: bug#73066: closed (Re: [bug#73066] [PATCH] gnu: kwin: Disable failing test on aarch64.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 06 Sep 2024 14:52:02 +0000

Your bug report

#73066: [PATCH] gnu: kwin: Disable failing test on aarch64.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
73066: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73066
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#73066] [PATCH] gnu: kwin: Disable failing test on aarch64.
From: Zheng Junjie <[email-masked]>
To: Roman Scherer <[email-masked]>
Cc: [email-masked]
Date: Fri, 06 Sep 2024 22:50:44 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Roman Scherer <[email-masked]> writes:

> * gnu/packages/kde-plasma.scm (kwin): Disable failing test on aarch64.
>
> Change-Id: Iecd9edbacca5805a54bcaf84bcec205367b96a05
> ---
>  gnu/packages/kde-plasma.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm
> index 5e9b9688d1..7294a7555c 100644
> --- a/gnu/packages/kde-plasma.scm
> +++ b/gnu/packages/kde-plasma.scm
> @@ -29,6 +29,7 @@ (define-module (gnu packages kde-plasma)
>    #:use-module (guix git-download)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix gexp)
> +  #:use-module (guix utils)
>    #:use-module (guix build-system cmake)
>    #:use-module (guix build-system trivial)
>    #:use-module (guix build-system qt)
> @@ -1429,6 +1430,9 @@ (define-public kwin
>                          "-E"
>                          (string-join
>                           (list
> +                          ;; Fails on an Apple M1 (aarch64) with the following error:
> +                          ;; TestColorspaces::roundtripConversion fails
> +                          #$(if (target-aarch64?) "kwin-testColorspaces" "")

adjust it to use  #$@(if (target-aarch64?)
                       #~("kwin-testColorspaces")
                       #~())
                    
only change it on aarch64.

>                            "kwin-testDrm" ;; require Drm
>                            "kwin-testInputMethod"
>                            "kwin-testPlasmaWindow" ;; require plasma-workspace qml module.
>
> base-commit: 7d2ced8d6d9c38327592d312376d59a8c37fc160

Subject: [PATCH] gnu: kwin: Disable failing test on aarch64.
From: Roman Scherer <[email-masked]>
To: [email-masked]
Cc: Roman Scherer <[email-masked]>, [email-masked]
Date: Fri, 6 Sep 2024 12:23:35 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/kde-plasma.scm (kwin): Disable failing test on aarch64.

Change-Id: Iecd9edbacca5805a54bcaf84bcec205367b96a05
---
 gnu/packages/kde-plasma.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm
index 5e9b9688d1..7294a7555c 100644
--- a/gnu/packages/kde-plasma.scm
+++ b/gnu/packages/kde-plasma.scm
@@ -29,6 +29,7 @@ (define-module (gnu packages kde-plasma)
   #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix gexp)
+  #:use-module (guix utils)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system trivial)
   #:use-module (guix build-system qt)
@@ -1429,6 +1430,9 @@ (define-public kwin
                         "-E"
                         (string-join
                          (list
+                          ;; Fails on an Apple M1 (aarch64) with the following error:
+                          ;; TestColorspaces::roundtripConversion fails
+                          #$(if (target-aarch64?) "kwin-testColorspaces" "")
                           "kwin-testDrm" ;; require Drm
                           "kwin-testInputMethod"
                           "kwin-testPlasmaWindow" ;; require plasma-workspace qml module.

base-commit: 7d2ced8d6d9c38327592d312376d59a8c37fc160
-- 
2.45.2