GNU bug report logs - #73064
[PATCH 0/1] gnu: oksh: Update to 7.5.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73064 in the body.
You can then email your comments to 73064 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Luis Henriques <henrix <at> camandro.org>
To: guix-patches <at> gnu.org
Cc: Luís Henriques <henrix <at> camandro.org>
Subject: [PATCH 0/1] gnu: oksh: Update to 7.5.
Date: Thu,  5 Sep 2024 22:56:03 +0100

From: Luís Henriques <henrix <at> camandro.org>

Hi!

I'm sending an update (my first patch!) to the oksh shell.  To be honest,
this package confuses me because it's not what I would expect it to be.  I
_think_ this should be the OpenBSD portable oksh, but the information in the
package definition isn't correct (not even the license).  So, I may be
missing something.

Luís Henriques (1):
  gnu: oksh: Update to 7.5.

 gnu/packages/shells.scm | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)


base-commit: 993d6d2e7be4dac738629c76a51058f4dc5bc449
-- 
2.45.2

Message #8 received at 73064 <at> debbugs.gnu.org (full text, mbox):

From: Luis Henriques <henrix <at> camandro.org>
To: 73064 <at> debbugs.gnu.org
Cc: Luís Henriques <henrix <at> camandro.org>
Subject: [PATCH 1/1] gnu: oksh: Update to 7.5.
Date: Thu,  5 Sep 2024 22:58:25 +0100

From: Luís Henriques <henrix <at> camandro.org>

* gnu/packages/shells.scm (oksh): Update to 7.5.
[source]: Download from github official portable oksh project.
[home-page]: Updated to maintaners url.
[synopsis, description]: Improved with text from oksh README.
[license]: Fixed license.

Change-Id: I06f7b6210b6d725678452c5130b09c3fb382ebca
---
 gnu/packages/shells.scm | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index ec15f9d21f..b44756ffa4 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -25,6 +25,7 @@
 ;;; Copyright © 2023 Jaeme Sifat <jaeme <at> runbox.com>
 ;;; Copyright © 2024 Tanguy Le Carrour <tanguy <at> bioneland.org>
 ;;; Copyright © 2024 Vinicius Monego <monego <at> posteo.net>
+;;; Copyright © 2024 Luís Henriques <henrix <at> camandro.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -820,25 +821,32 @@ (define-public s-shell
 (define-public oksh
   (package
     (name "oksh")
-    (version "0.5.9")
+    (version "7.5")
     (source
      (origin
        (method url-fetch)
-       (uri (string-append "https://connochaetos.org/oksh/oksh-"
-                           version ".tar.gz"))
+       (uri (string-append
+             "https://github.com/ibara/oksh/releases/download/oksh-"
+             version "/oksh-" version ".tar.gz"))
        (sha256
         (base32
-         "0ln9yf6pxngsviqszv8klnnvn8vcpplvj1njdn8xr2y8frkbw8r3"))))
+         "0pgdxvy8jgydsyzk7vcc93pm09bihqvrn3i35gz1ncg9z31rbf20"))))
     (build-system gnu-build-system)
     (arguments
-     `(; The test files are not part of the distributed tarball.
-       #:tests? #f))
-    (home-page "https://connochaetos.org/oksh")
-    (synopsis "Port of OpenBSD Korn Shell")
+     `(#:tests? #f)) ; there are no tests available
+    (home-page "https://github.com/ibara/oksh")
+    (synopsis "Portable OpenBSD Korn Shell")
     (description
-     "Oksh is a port of the OpenBSD Korn Shell.
-The OpenBSD Korn Shell is a cleaned up and enhanced ksh.")
-    (license license:gpl3+)))
+     "Oksh is a portable OpenBSD ksh.  Not an official OpenBSD project.
+Unlike other ports of OpenBSD ksh, this port is entirely self-contained
+and aims to be maximally portable across operating systems and C compilers.")
+    (license (list license:public-domain
+                   ;; asprintf.c, issetugid.c, reallocarray.c, sh.1,
+                   ;; strlcat.c, strlcpy.c, strtonum.c
+                   license:isc
+                   ;; confstr.c, siglist.c, signame.c, sys-queue.h, unvis.c,
+                   ;; vis.c, vis.h
+                   license:bsd-3))))
 
 (define-public loksh
   (package
-- 
2.45.2

Message #13 received at 73064-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Luis Henriques <henrix <at> camandro.org>
Cc: 73064-done <at> debbugs.gnu.org
Subject: Re: [bug#73064] [PATCH 1/1] gnu: oksh: Update to 7.5.
Date: Mon, 16 Sep 2024 10:19:17 +0200

Hi Luis,

Luis Henriques <henrix <at> camandro.org> skribis:

> From: Luís Henriques <henrix <at> camandro.org>
>
> * gnu/packages/shells.scm (oksh): Update to 7.5.
> [source]: Download from github official portable oksh project.
> [home-page]: Updated to maintaners url.
> [synopsis, description]: Improved with text from oksh README.
> [license]: Fixed license.
>
> Change-Id: I06f7b6210b6d725678452c5130b09c3fb382ebca

Applied, thank you, and welcome! :-)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.