GNU bug report logs - #73047
30.0.90; feature request - add recency column to ibuffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73047 in the body.
You can then email your comments to 73047 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.90; feature request - add recency column to ibuffer
Date: Thu, 05 Sep 2024 17:28:09 +0200

Dear Emacs maintainers,

I want to propose the addition of an optional recency column to Ibuffer,
which shows the last buffer display time. Sorting by recency is already
supported by Ibuffer (ibuffer-do-sort-by-recency). I use the following
code in my configuration:

(defvar-keymap ibuffer-recency-header-map
  "<mouse-1>" #'ibuffer-do-sort-by-recency)
  
(define-ibuffer-column recency
  (:inline t :summarizer ignore :header-mouse-map ibuffer-recency-header-map)
  (if-let ((time (buffer-local-value 'buffer-display-time buffer)))
      (progn
        (require 'marginalia)
        (marginalia--time (buffer-local-value 'buffer-display-time buffer)))
    "never"))

The time string is formatted in a human readable form, relative to to
the current time, e.g., "2 mins ago", "30 secs ago" or "never". I use
the function from the Marginalia package from GNU ELPA for formatting
right now. As far as I know Emacs does not yet provide a relative time
formatting function? Maybe there is interest in adding marginalia--time
to Emacs, e.g., with the name format-time-relative? As far as I know,
multiple packages define a similar formatting function, such that we
could potentially get some code reuse. The function could be ported
back via Compat to make it available to ELPA packages.

Thank you!

Message #8 received at 73047 <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 73047 <at> debbugs.gnu.org
Subject: Re: bug#73047: 30.0.90; feature request - add recency column to
 ibuffer
Date: Thu, 5 Sep 2024 12:36:11 -0400

[Message part 1 (text/plain, inline)]

> On Sep 5, 2024, at 11:28 AM, Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
> 
> As far as I know, multiple packages define a similar formatting function, such that we
> could potentially get some code reuse. 

Definitely agree.  See bug#71572 <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71572#72>, which includes such a formatting function, heavily discussed, but not yet merged.

[Message part 2 (text/html, inline)]

Message #11 received at 73047 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: JD Smith <jdtsmith <at> gmail.com>
Cc: 73047 <at> debbugs.gnu.org
Subject: Re: bug#73047: 30.0.90; feature request - add recency column to
 ibuffer
Date: Thu, 05 Sep 2024 19:00:35 +0200

JD Smith <jdtsmith <at> gmail.com> writes:

>> On Sep 5, 2024, at 11:28 AM, Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
>> 
>> As far as I know, multiple packages define a similar formatting function, such that we
>> could potentially get some code reuse. 
>
> Definitely agree.  See bug#71572 <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71572#72>, which includes such a formatting function, heavily discussed, but not yet merged.

That's great! Thank you for working on this function.

Message #14 received at 73047 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: 73047 <at> debbugs.gnu.org
Cc: JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#73047: 31; [PATCH] - add recency column to ibuffer
Date: Sat, 28 Dec 2024 13:27:58 +0100

[Message part 1 (text/plain, inline)]

I've attached a patch to this mail which adds a recency column to
Ibuffer. It uses the `seconds-to-string' function with the READABLE
argument.

[0001-ibuffer-Define-recency-column.patch (text/x-diff, attachment)]

Message #17 received at 73047 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: 73047 <at> debbugs.gnu.org
Cc: JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#73047: 31; [PATCH] - add recency column to ibuffer
Date: Sat, 28 Dec 2024 13:50:20 +0100

[Message part 1 (text/plain, inline)]

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> I've attached a patch to this mail which adds a recency column to
> Ibuffer. It uses the `seconds-to-string' function with the READABLE
> argument.

Please disregard the earlier patch, which was a wrong version.  I've
attached a better patch to this mail.  Thanks.

Daniel

[0001-ibuffer-Define-recency-column.patch (text/x-diff, attachment)]

Message #20 received at 73047 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: jdtsmith <at> gmail.com, 73047 <at> debbugs.gnu.org
Subject: Re: bug#73047: 31; [PATCH] - add recency column to ibuffer
Date: Sat, 11 Jan 2025 14:09:21 +0200

> Cc: JD Smith <jdtsmith <at> gmail.com>
> Date: Sat, 28 Dec 2024 13:50:20 +0100
> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Daniel Mendler <mail <at> daniel-mendler.de> writes:
> 
> > I've attached a patch to this mail which adds a recency column to
> > Ibuffer. It uses the `seconds-to-string' function with the READABLE
> > argument.
> 
> Please disregard the earlier patch, which was a wrong version.  I've
> attached a better patch to this mail.  Thanks.

Thanks.  Should this be called out in NEWS?

Message #23 received at 73047 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jdtsmith <at> gmail.com, 73047 <at> debbugs.gnu.org
Subject: Re: bug#73047: 31; [PATCH] - add recency column to ibuffer
Date: Sat, 11 Jan 2025 13:24:05 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: JD Smith <jdtsmith <at> gmail.com>
>> Date: Sat, 28 Dec 2024 13:50:20 +0100
>> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>> 
>> > I've attached a patch to this mail which adds a recency column to
>> > Ibuffer. It uses the `seconds-to-string' function with the READABLE
>> > argument.
>> 
>> Please disregard the earlier patch, which was a wrong version.  I've
>> attached a better patch to this mail.  Thanks.
>
> Thanks.  Should this be called out in NEWS?

Yes. I've added an entry to the NEWS file. See the updated patch
attached to this mail. Thanks.

Daniel

[0001-ibuffer-Define-recency-column.patch (text/x-diff, attachment)]

Message #28 received at 73047-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: jdtsmith <at> gmail.com, 73047-done <at> debbugs.gnu.org
Subject: Re: bug#73047: 31; [PATCH] - add recency column to ibuffer
Date: Sat, 11 Jan 2025 15:06:38 +0200

> From: Daniel Mendler <mail <at> daniel-mendler.de>
> Cc: 73047 <at> debbugs.gnu.org,  jdtsmith <at> gmail.com
> Date: Sat, 11 Jan 2025 13:24:05 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Cc: JD Smith <jdtsmith <at> gmail.com>
> >> Date: Sat, 28 Dec 2024 13:50:20 +0100
> >> From:  Daniel Mendler via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> 
> >> Daniel Mendler <mail <at> daniel-mendler.de> writes:
> >> 
> >> > I've attached a patch to this mail which adds a recency column to
> >> > Ibuffer. It uses the `seconds-to-string' function with the READABLE
> >> > argument.
> >> 
> >> Please disregard the earlier patch, which was a wrong version.  I've
> >> attached a better patch to this mail.  Thanks.
> >
> > Thanks.  Should this be called out in NEWS?
> 
> Yes. I've added an entry to the NEWS file. See the updated patch
> attached to this mail. Thanks.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.