GNU bug report logs - #73044
[PATCH] Add project-find-file-in-root

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Spencer Baugh <sbaugh <at> janestreet.com>
Subject: bug#73044: closed (Re: bug#73044: [PATCH] Add project-find-file-in-root)
Date: Fri, 06 Sep 2024 16:21:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#73044: [PATCH] Add project-find-file-in-root

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73044 <at> debbugs.gnu.org.

-- 
73044: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73044
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Spencer Baugh <sbaugh <at> janestreet.com>, 73044-done <at> debbugs.gnu.org
Subject: Re: bug#73044: [PATCH] Add project-find-file-in-root
Date: Fri, 6 Sep 2024 19:20:16 +0300

Version: 31.1

Hi Spencer,

On 05/09/2024 17:01, Spencer Baugh via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Several users have asked me for a command which is just
> find-file, but starting from the project root.  In large
> projects, where project-files is expensive, this will have
> substantially better performance than project-find-file.
> 
> Also, it allows opening files which aren't included in
> project-files without paying the further cost of running
> project--files-in-directory (which is what happens when passing
> INCLUDE-ALL=t to project-find-file).
> 
> Also, it may help with user confusion about why
> project-find-file doesn't behave like find-file.  (which I've
> encountered a few times)
> 
> This command is equivalent to C-x p o C-x C-f, but it's nice to
> be able to bind it to a specific key.
> 
> Overall, this is easy enough to provide, so let's just do that.

Makes sense, thanks, pushed to master (adding the 'interactive' form and 
a NEWS entry).

The name is a little verbose - if anybody has a better idea later, 
they're welcome to suggest it, there is some time to do a change.

[Message part 3 (message/rfc822, inline)]

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Cc: dmitry <at> gutov.dev
Subject: [PATCH] Add project-find-file-in-root
Date: Thu, 05 Sep 2024 10:01:46 -0400

[Message part 4 (text/plain, inline)]

Tags: patch


Several users have asked me for a command which is just
find-file, but starting from the project root.  In large
projects, where project-files is expensive, this will have
substantially better performance than project-find-file.

Also, it allows opening files which aren't included in
project-files without paying the further cost of running
project--files-in-directory (which is what happens when passing
INCLUDE-ALL=t to project-find-file).

Also, it may help with user confusion about why
project-find-file doesn't behave like find-file.  (which I've
encountered a few times)

This command is equivalent to C-x p o C-x C-f, but it's nice to
be able to bind it to a specific key.

Overall, this is easy enough to provide, so let's just do that.

In GNU Emacs 29.2.50 (build 16, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2024-08-26 built on
 igm-qws-u22796a
Repository revision: e6d04c06a7eb6ce932b52a346368d02b7a811a00
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.10 (Green Obsidian)

Configured using:
 'configure --with-x-toolkit=lucid --without-gpm --without-gconf
 --without-selinux --without-imagemagick --with-modules --with-gif=no
 --with-cairo --with-rsvg --without-compress-install
 --with-native-compilation=aot --with-tree-sitter
 PKG_CONFIG_PATH=/usr/local/home/garnish/libtree-sitter/0.22.6-1/lib/pkgconfig/'

[0001-Add-project-find-file-in-root.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.