From unknown Fri Aug 15 16:18:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73036 <73036@debbugs.gnu.org> To: bug#73036 <73036@debbugs.gnu.org> Subject: Status: 29.4; Test failure in erc-networks--id-sort-buffers Reply-To: bug#73036 <73036@debbugs.gnu.org> Date: Fri, 15 Aug 2025 23:18:53 +0000 retitle 73036 29.4; Test failure in erc-networks--id-sort-buffers reassign 73036 emacs submitter 73036 Ulrich Mueller severity 73036 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 02:00:36 2024 Received: (at submit) by debbugs.gnu.org; 5 Sep 2024 06:00:36 +0000 Received: from localhost ([127.0.0.1]:35907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm5Xn-0000Au-Q1 for submit@debbugs.gnu.org; Thu, 05 Sep 2024 02:00:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:50520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm5Xj-0000Ai-V9 for submit@debbugs.gnu.org; Thu, 05 Sep 2024 02:00:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sm5Wh-00030f-3z for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 01:59:27 -0400 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1sm5We-0005VL-VE for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 01:59:26 -0400 From: Ulrich Mueller To: bug-gnu-emacs@gnu.org Subject: 29.4; Test failure in erc-networks--id-sort-buffers Date: Thu, 05 Sep 2024 07:59:14 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=140.211.166.183; envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Forwarding Gentoo bug 920696 . We see the following test failure on an hppa2.0-unknown-linux-gnu (Linux-6.9.8-gentoo-parisc64-parisc64-PA8900_-Shortfin-with-glibc2.39) system: Test erc-networks--id-sort-buffers condition: (ert-test-failed ((should (equal (erc-networks--id-sort-buffers ...) (list newest middle oldest))) :form (equal (# # #) (# # #)) :value nil :explanation (list-elt 0 (different-atoms # #)))) FAILED 6/41 erc-networks--id-sort-buffers (0.000000 sec) at lisp/erc/erc-networks-tests.el:133 [...] Ran 41 tests, 40 results as expected, 1 unexpected (2024-09-03 20:09:01+0000, 14 .712021 sec) 1 unexpected results: FAILED erc-networks--id-sort-buffers ((should (equal (erc-networks--id-sort -buffers (list oldest newest middle)) (list newest middle oldest))) :form (equal (# # #) (# # #)) :value nil :explanation (list-elt 0 (different-atoms # #))) [...] SUMMARY OF TEST RESULTS ----------------------- Files examined: 465 Ran 6939 tests, 6675 results as expected, 1 unexpected, 263 skipped 1 files contained unexpected results: lisp/erc/erc-networks-tests.log Looking at the code, the test creates three buffers, then sorts them by time. Clock resolution on HPPA appears to be 4 milliseconds, so it is not unlikely that the buffers end up with exactly the same timestamp and sorting fails. Attached patch fixes the problem. Is it OK to install it on the emacs-30 branch? --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=0001-Fix-test-failure-in-erc-networks-tests.patch >From bf42248be8e795d591ce97c1d161d73d98038db6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Wed, 4 Sep 2024 13:35:51 +0200 Subject: [PATCH] Fix test failure in erc-networks-tests * test/lisp/erc/erc-networks-tests.el (erc-networks--id-sort-buffers): Make sure that buffers have different timestamps. --- test/lisp/erc/erc-networks-tests.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/lisp/erc/erc-networks-tests.el b/test/lisp/erc/erc-networks-tests.el index f0a7c37ddf2..e84cca68cdd 100644 --- a/test/lisp/erc/erc-networks-tests.el +++ b/test/lisp/erc/erc-networks-tests.el @@ -133,10 +133,12 @@ erc-networks--id-sort-buffers (with-temp-buffer (setq erc-networks--id (erc-networks--id-fixed-create 'oldest) oldest (current-buffer)) + (sleep-for 0.02) (with-temp-buffer (setq erc-networks--id (erc-networks--id-fixed-create 'middle) middle (current-buffer)) + (sleep-for 0.02) (with-temp-buffer (setq erc-networks--id (erc-networks--id-fixed-create 'newest) -- 2.46.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 02:50:18 2024 Received: (at 73036) by debbugs.gnu.org; 5 Sep 2024 06:50:18 +0000 Received: from localhost ([127.0.0.1]:35983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm6Jt-0003yA-Sv for submit@debbugs.gnu.org; Thu, 05 Sep 2024 02:50:18 -0400 Received: from mail-108-mta38.mxroute.com ([136.175.108.38]:36145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm6Js-0003y0-3W for 73036@debbugs.gnu.org; Thu, 05 Sep 2024 02:50:16 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta38.mxroute.com (ZoneMTA) with ESMTPSA id 191c0ed0ae90003e01.001 for <73036@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 05 Sep 2024 06:44:05 +0000 X-Zone-Loop: 546fd13c7d50fb0dd98871ed0de286147a2ff214677f X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9RHZWVAQd0fED/Ghj37gn4Y1qecV9T7u2fV0+TM1CHk=; b=cltnHwInnCrkD0zWA3e1al75qy fE+z30wzWu9ApjAlLp9QmhnkUcJiOwQsXw7fbhxFw9uG8EGrxlCSsIsmz9sYJnx0LTkZKvvD7KEa4 hXB1ZTVa0Cgz6YOyLvbltBhsV0i0O8pGNFhIUibaM6i9b0iIR/aPLAOXefEF0mUUONdzR9bO/0dpx RcMK/Ta6Lc1blIenYFDgdiJ8gHG4Ql0JmOULJ7juZTeCuck5Lt8YU3ZaR3rVCVFFa5lvZyHiDUYdK D8gFAZdKOVLnz1BpHHB4XNVgMQGuEcqufLsTXhdDfFXwR7FaE0VXEIJSyWbU564BzUTpq5mPXtFdQ xkoRaIag==; From: "J.P." To: Ulrich Mueller Subject: Re: bug#73036: 29.4; Test failure in erc-networks--id-sort-buffers In-Reply-To: (Ulrich Mueller's message of "Thu, 05 Sep 2024 07:59:14 +0200") References: Date: Wed, 04 Sep 2024 23:44:02 -0700 Message-ID: <87bk1261n1.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73036 Cc: Eli Zaretskii , emacs-erc@gnu.org, 73036@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ulrich, Author of shoddy test here. Apologies for the annoyance. Ulrich Mueller writes: > Looking at the code, the test creates three buffers, then sorts them by > time. Clock resolution on HPPA appears to be 4 milliseconds, so it is > not unlikely that the buffers end up with exactly the same timestamp and > sorting fails. Makes sense to me. > Attached patch fixes the problem. Is it OK to install it on the emacs-30 > branch? I guess that's up to the Emacs maintainers (Eli Cc'd). Thanks, J.P. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 04:25:35 2024 Received: (at control) by debbugs.gnu.org; 5 Sep 2024 08:25:35 +0000 Received: from localhost ([127.0.0.1]:36089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm7o7-0002xo-8w for submit@debbugs.gnu.org; Thu, 05 Sep 2024 04:25:35 -0400 Received: from woodpecker.gentoo.org ([140.211.166.183]:48678 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm7o4-0002xX-NN for control@debbugs.gnu.org; Thu, 05 Sep 2024 04:25:33 -0400 From: Ulrich Mueller To: control@debbugs.gnu.org Subject: Re: bug#73036: 29.4; Test failure in erc-networks--id-sort-buffers In-Reply-To: <86le064jbi.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Sep 2024 11:05:05 +0300") References: <87bk1261n1.fsf@neverwas.me> <86le064jbi.fsf@gnu.org> Date: Thu, 05 Sep 2024 10:23:39 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 73036 30.1 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 04:55:19 2024 Received: (at 73036) by debbugs.gnu.org; 5 Sep 2024 08:55:19 +0000 Received: from localhost ([127.0.0.1]:36132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm8Gt-0005JY-1r for submit@debbugs.gnu.org; Thu, 05 Sep 2024 04:55:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm8BD-0004sv-Au for 73036@debbugs.gnu.org; Thu, 05 Sep 2024 04:49:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sm7UO-0007jg-56; Thu, 05 Sep 2024 04:05:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cGiMSHWl9SThBlxW6nQ0cL6T80LdEgKzrjWcqZOUYAY=; b=mPNP481AgNYz fhs41hsYaiCx03URfoom9LogmMbe3RolN2us9MWuUV75lqcsfdvUbAobloT3GoxExvezuvynt6K3w +loPRCUiHbNvGoCkaqtfJDG4pbUJ1fberHJ4EeLLjzfQ5WhViu30OzrwDcWWa4iS7V768uyPkwy2W 35CukFGvloCrYC1L5/gqlOolzgfTenBO3bYhm3ZyJDAQyh6kM29JDCFJwasDano4MWnsHyeTPQSKi TEcjxS+mj+30VpiCggoEvL09zOl3ZknNjW9c3RfYyFR+MKaHcT+4JV5JUY8G4l79dpZdSP45DwF+T CosBX4Td/44tPuQLDdGmxg==; Date: Thu, 05 Sep 2024 11:05:05 +0300 Message-Id: <86le064jbi.fsf@gnu.org> From: Eli Zaretskii To: "J.P." In-Reply-To: <87bk1261n1.fsf@neverwas.me> (jp@neverwas.me) Subject: Re: bug#73036: 29.4; Test failure in erc-networks--id-sort-buffers References: <87bk1261n1.fsf@neverwas.me> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73036 Cc: ulm@gentoo.org, emacs-erc@gnu.org, 73036@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "J.P." > Cc: 73036@debbugs.gnu.org, emacs-erc@gnu.org, Eli Zaretskii > Date: Wed, 04 Sep 2024 23:44:02 -0700 > > Hi Ulrich, > > Author of shoddy test here. Apologies for the annoyance. > > Ulrich Mueller writes: > > > Looking at the code, the test creates three buffers, then sorts them by > > time. Clock resolution on HPPA appears to be 4 milliseconds, so it is > > not unlikely that the buffers end up with exactly the same timestamp and > > sorting fails. > > Makes sense to me. > > > Attached patch fixes the problem. Is it OK to install it on the emacs-30 > > branch? > > I guess that's up to the Emacs maintainers (Eli Cc'd). It's okay to install these test fixes on the emacs-30 release branch. Thanks. From unknown Fri Aug 15 16:18:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 03 Oct 2024 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator